Eduardo has posted comments on this change.
Change subject: BZ#788640 - Add [block|file]SD.getAllVolumes
......................................................................
Patch Set 7: (7 inline comments)
....................................................
Commit Message
Line 7: BZ#788640 - Add [block|file]SD.getAllVolumes
Towards an image manipulation without recursive SD _> image -> volume produces.
Without MD readings!
....................................................
File vdsm/storage/blockSD.py
Line 142: raise se.IncorrectFormat("Volume %s lacks minimal tag
set"
We can decipher the image.
Can't take risks.
Line 147: def getAllVolumes(sdUUID):
Should be an analogous static method for fileSD. Not done yet, but comming soon.
Really the class method is redundant.
Towards a vdsm free of SD produces, weak references, proxies and caches.
Line 153: lvs = lvm.getLV(sdUUID)
makeBlockSDVols is only for easier manipulation of the tags.
Still not sure if lvm should be called here or in an upper level.
Line 157: res[vName] = {'imgs': [], 'parent': None}
These are in memory loops and no so long, irrelevant compared to IO and the
actual flows.
Want ummutables and not dicts, and the code is simpler this way IMHO.
I will consider the change proposed.
....................................................
File vdsm/storage/fileSD.py
Line 272: if len(tuple(vPath for vPath in volMetaPaths
lists are copied as references to the same object. This can lead to nasty bugs.
Want constants (ummutables) in the response.
Line 273: if imgUUID in vPath)) > 1:
For a template in use the volUUID will appear twice.
But the template self image will have only one entry (the template itself) in
it's dir.
--
To view, visit http://gerrit.ovirt.org/3462
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7eccf5ca100bd354aa09208ca60bb112fb697063
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://fedorahosted.org/mailman/listinfo/vdsm-patches
