Dan Kenigsberg has submitted this change and it was merged.
Change subject: MOM Integration
..
MOM Integration
This patch integrates MOM into vdsm. For the descprition of
how it works, please see Adam's mail:
https://fedorahost
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 17:
Congrats
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-Message
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 17: Verified
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: co
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 17: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.org/setting
Doron Fediuck has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 17: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerr
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 15: Looks good to me, but someone else must approve
(2 inline comments)
this patch has waited long enough.
..
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 14: (1 inline comment)
File vdsm/clientIF.py
Line 112: if self.mom:
Yes,
Xu He Jie has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 14: I would prefer that you didn't submit this
(1 inline comment)
minor issue
Fil
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 14:
Ayal,
All problems you pointed out has been fixed in the new patch.
Many thanks for the review!
--
To view, visit http://gerrit.ovirt
Ayal Baron has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 13: I would prefer that you didn't submit this
(5 inline comments)
Minor issues
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 12:
Other questions except the file name(MOM.py) has been answered.
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 11: (2 inline comments)
File vdsm/MOM.py
Line 30: class momThread(threading.Thread):
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 11: (1 inline comment)
File vdsm/MOM.py
Line 44: ret['ksmState'] = sta
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 11: I would prefer that you didn't submit this
(2 inline comments)
thanks, Mark, for the update. I have very few stylistic comment
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 10: I would prefer that you didn't submit this
(4 inline comments)
File vdsm/
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9:
Adam,
The MOM patch is already done in my local repo. I wrote it to test this patch.
I will submit later.
--
To view, visit http://ge
Xu He Jie has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9: (2 inline comments)
File vdsm/Makefile.am
Line 241:
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9:
One additional comment. You will need to submit a patch to MOM to change the
initialization sequence since you no longer need to r
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9: I would prefer that you didn't submit this
(10 inline comments)
File Makefile.
Xu He Jie has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 9: I would prefer that you didn't submit this
(5 inline comments)
File vdsm/ksm.py
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7: I would prefer that you didn't submit this
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerrit.ovirt.
Adam Litke has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7:
I would also like to request that a set of tests be added to the functional
test suite to check the MOM integration code.
--
To vi
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7:
How about moving MOM development to gerrit.ovirt.org? ;-)
I think that mom should receive an API object (even API.Global()!) th
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7:
Hi Dan,
Thanks a lot for the review. I am going to revise the patch as per your
comments. And the unittest will be included in next ve
Dan Kenigsberg has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7: I would prefer that you didn't submit this
(14 inline comments)
Thanks for pursuing this integration, particularly when ksmtune
Doron Fediuck has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/2367
To unsubscribe, visit http://gerri
Mark Wu has posted comments on this change.
Change subject: MOM Integration
..
Patch Set 7:
Change from patch set 6:
- fix file list sorting problem in Makefile.am and vdsm.spec.in according to
Ayal's comments
- fix mom.conf
27 matches
Mail list logo
