Dan Kenigsberg has submitted this change and it was merged.
Change subject: Normalize lvm._buildFilter().
..
Normalize lvm._buildFilter().
Change-Id: I2c0a5c61ba6754db996b2c88b32bedee852df22f
Signed-off-by: Eduardo
Dan Kenigsberg has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 2: Code-Review+2
Acking despite Ayal comment, since he has acked the dependent short filters
patch.
--
To view,
Ayal Baron has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 2:
(1 comment)
File vdsm/storage/lvm.py
Line 131: strippeds =
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/4487/ : SUCCESS
Eduardo has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 2: Verified+1
Following CLI (only) commands tested.
Tested from CLI only with:
connectStorageServer getStorageDomainsList
Dan Kenigsberg has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1:
(1 comment)
File vdsm/storage/lvm.py
Line 128:
Line 129:
Dan Kenigsberg has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1:
(anyway, you have to rebase this patch for the unit tests)
--
To view, visit http://gerrit.ovirt.org/17966
To
Dan Kenigsberg has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1: Code-Review+2
Eduardo tells me that he is not sure that the multipath-generated list of
devices is free of
Ayal Baron has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1:
(1 comment)
File vdsm/storage/lvm.py
Line 133: dmPaths = []
Eduardo has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1:
(1 comment)
File vdsm/storage/lvm.py
Line 128:
Line 129:
Line
Dan Kenigsberg has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1: Code-Review-1
(1 comment)
I like the idea, but I think it can become even better.
Eduardo has uploaded a new change for review.
Change subject: Normalize lvm._buildFilter().
..
Normalize lvm._buildFilter().
Change-Id: I2c0a5c61ba6754db996b2c88b32bedee852df22f
Signed-off-by: Eduardo ewars...@redhat.com
---
M
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Normalize lvm._buildFilter().
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/3861/ : FAILURE
13 matches
Mail list logo