oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 18:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sani
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Unified network persistence [4.1/4.*] - Upgrade mechanism
Unified network persistence feat
Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 17: Code-Review+2
(1 comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 17: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5854
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 17: Verified+1
All outstanding comments handled.
--
To view, visit http://gerrit.ovirt.or
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(6 comments)
File lib/vdsm/tool/u
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 16:
There's still outstanding comments by Yaniv (I haven't forgotten them).
--
To view, v
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 16: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5849
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(1 comment)
File lib/vdsm/tool/up
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(1 comment)
File lib/vdsm/tool/up
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15:
(6 comments)
File lib/vdsm/tool
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 15: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/5843
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 14:
(3 comments)
File lib/vdsm/utils.
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 14: Code-Review-1
(3 comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/47
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 14: Code-Review-1
For some reason logging output is going to vdsm.log and not to upgrade.lo
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13:
(9 comments)
Pushing new patch set in a second...
I had an offline session with Yaniv
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13:
I thought about it more and I prefer no to have logger at all. if you want, you
can
Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13:
(3 comments)
Assaf, Yaniv Bronhaim wrote on Oct 24 15:44 (UTC+1)
"""
Patch Set 10: C
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13:
(1 comment)
File lib/vdsm/tool/
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13: Code-Review-1
(5 comments)
Looks like all (or at least most) of this patch is about
Dan Kenigsberg has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13: Code-Review-1
(2 comments)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/44
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 12:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/44
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 11:
Jenkins failure unrelated to patch's code.
--
To view, visit http://gerrit.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 11: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerri
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 11: Verified+1
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit http:
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10:
(1 comment)
File lib/vdsm/tool/up
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10:
(1 comment)
File lib/vdsm/tool/
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10:
(1 comment)
Will do.
File lib/vd
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10:
(1 comment)
File lib/vdsm/tool/
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10: Code-Review-1
I like the vdsm-tool logger idea, but do it separately to your feature
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 10: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4740
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 9: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/4734/
Saggi Mizrahi has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
*leaf classes
--
To view, visit http://gerrit.ovirt.org/17726
To unsubscribe, visit h
Saggi Mizrahi has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
I never said to squash the upgrade class in.
I said it upgrade() should be converted t
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
@Saggi:
On a more meta-programming note: "Python is not Java. We avoid creating
needle
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
@Saggi:
Even *if* the Upgrade class isn't reusable, there's an advantage to keeping it
Saggi Mizrahi has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8: Code-Review-1
(3 comments)
You probably don't want to design this that way.
You want
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
What if the running version is newer than the version written in the upgrade
file? How
Antoni Segura Puimedon has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8: Code-Review-1
(2 comments)
NOTE: The following is a proposal, @Assaf, @Dan, @
Yaniv Bronhaim has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
(2 comments)
Commit Message
Line
Assaf Muller has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8:
Yaniv, Saggi: Updated the commit message to give some context.
--
To view, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Unified network persistence [4.1/4.*] - Upgrade mechanism
..
Patch Set 8: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit
44 matches
Mail list logo
