Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(3 comments)
Adding Piotr to review the schema changes.
https://gerrit.ovirt.org/#/c/56805/2/lib/api/
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(3 comments)
https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmap
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-sche
Francesco Romani has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2: Code-Review-1
(2 comments)
-1 for visibility, but IMHO you are on the right track
https://gerri
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmap
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-sche
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Line
Francesco Romani has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS2, Lin
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3816:
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 3864:
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 3:
(2 comments)
I like the idea of single extensible parameter like the DriveSpecCdrom, even if
it is no
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/56805/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Line
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 3:
(4 comments)
https://gerrit.ovirt.org/#/c/56805/3/lib/api/vdsm-api.yml
File lib/api/vdsm-api.yml:
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 5: Verified+1
Verified by (ab)using virt functional tests with new api.
--
To view, visit https://g
gerrit-hooks has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 6: Code-Review+1
waiting for Nir's approval
--
To view, visit https://gerrit.ovirt.org/56805
To un
gerrit-hooks has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7:
The code is nice, I still don't understand why engine needs to set the index,
while vdsm set the index
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7:
The index must be sent to indicate which cdrom is the target of the action. We
could theoreticall
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7:
Adding engine maintainers to get their blessing for this api.
--
To view, visit https://gerrit.ovirt.
Dan Kenigsberg has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7:
Only opinion, a much cleaner option is to add a new argument for the guest
location of the CD devi
Shahar Havivi has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://gerrit
Piotr Kliczewski has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://ger
Dan Kenigsberg has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 7: Code-Review-1
(1 comment)
also, .json should be dropped from patch.
https://gerrit.ovirt.org/#/c/
gerrit-hooks has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Dan Kenigsberg has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 8: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://gerri
Martin Polednik has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 8: Verified+1
Verified that BC works with 4.0 engine (same args sent as 3.6), hacked
functional test
Arik Hadas has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://gerrit.ov
Nir Soffer has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/56805
To unsubscribe, visit https://gerrit.ov
gerrit-hooks has posted comments on this change.
Change subject: cdrom: API change: require interface & index
..
Patch Set 9:
* Update tracker: IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To view, vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: cdrom: API change: require interface & index
..
cdrom: API change: require interface & index
Previously, changeCD call did not require anything but pat
31 matches
Mail list logo
