Francesco Romani has posted comments on this change. Change subject: cdrom: API change: require interface & index ......................................................................
Patch Set 2: Code-Review-1 (2 comments) -1 for visibility, but IMHO you are on the right track https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 6506: # Line 6507: # Since: 4.10.0 Line 6508: ## Line 6509: {'command': {'class': 'VM', 'name': 'changeCD'}, Line 6510: 'data': {'vmID': 'UUID', 'driveSpec': 'CdromSpec'}, > We need to fix the engine, not the schema. This *is* the correct approach, and I'm fine with it as long as we keep BC with old Engines (as AFAIK you already do in the code) Line 6511: 'returns': 'VmDefinition'} Line 6512: Line 6513: ## Line 6514: # @VM.changeFloppy: https://gerrit.ovirt.org/#/c/56805/2/vdsm/virt/vm.py File vdsm/virt/vm.py: PS2, Line 3820: TypeError Please narrow down this block as much as you can. I believe only line 3817 could raise this, right? -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
