Nir Soffer has posted comments on this change. Change subject: cdrom: API change: require interface & index ......................................................................
Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/56805/2/lib/api/vdsmapi-schema.json File lib/api/vdsmapi-schema.json: Line 6473 Line 6474 Line 6475 Line 6476 Line 6477 > That is wrong and we don't want to support that. We cannot fix old engines, they will continue to access vdsm with a string. Once we enable type verification, you will get warnings when working with old engine, and we are not allowed to warn user about valid request from old engine. So adapting the schema to fit reality is a must. We can define that this usage is deprecated, and provide a new type that handle stuff in the correct way. Once we stop supporting old engines (> 4.1?) we can drop the ugly 'str' type. -- To view, visit https://gerrit.ovirt.org/56805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I178c1a02bbad962f9dc9b67bed7691cf170ee896 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: gerrit-hooks <automat...@ovirt.org> Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
