Federico Simoncelli has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 16: Code-Review+1
I am not a fan of using path for passing the ceph volume path from engine to
vdsm.
Dan Kenigsberg has submitted this change and it was merged.
Change subject: ceph: Initial support for network disk
..
ceph: Initial support for network disk
The previous code supported network disk by abusing Drive.volumeInfo
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 17:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To
Adam Litke has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/15/vdsm/rpc/vdsmapi-schema.json
File
Adam Litke has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15:
After discussing with Nir I realize the VmDiskDevice is already polluted with
'connection' information
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/15/vdsm/rpc/vdsmapi-schema.json
File
Adam Litke has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15: Code-Review+2
After talking with Nir I agree that the VmDiskDevice is already polluted with
'connection'
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Francesco Romani has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/14/vdsm/rpc/vdsmapi-schema.json
File
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 15: Verified+1
This version refine the documentation of the diskType parameter and unneeded
empty line that
Daniel Erez has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 14: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/14/vdsm/rpc/vdsmapi-schema.json
File
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/14/vdsm/rpc/vdsmapi-schema.json
File
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 10: Verified+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 6:
Federico, I believe that the next patch https://gerrit.ovirt.org/40477 is
addressing your concern about
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Piotr Kliczewski has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 5: Code-Review+1
schema change looks good.
--
To view, visit https://gerrit.ovirt.org/38766
To
Francesco Romani has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Federico Simoncelli has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/virt/vmdevices/storage.py
File
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/virt/vmdevices/storage.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json
File
Sahina Bose has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/virt/vmdevices/storage.py
File
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json
File
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/virt/vmdevices/storage.py
File
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json
File
Francesco Romani has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4: Code-Review+1
(3 comments)
nice improvement, added inline comments about possible further
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
Francesco, engine never used volumeInfo for passing network drive to vdsm. This
was an undocumented hack
Piotr Kliczewski has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4: Code-Review+1
Schema change looks good
--
To view, visit https://gerrit.ovirt.org/38766
To
Francesco Romani has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
I'm not familiar with the support of network drives in Engine, so I wonder:
this change is nicer and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16748/ : SUCCESS
Daniel Erez has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4: Verified+1 Code-Review+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 2:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 1:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
Nir Soffer has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4: Verified+1
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
automat...@ovirt.org has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 3:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16720/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16767/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16735/ : SUCCESS
49 matches
Mail list logo
