Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.o
Dan Kenigsberg has submitted this change and it was merged.
Change subject: clientIF: prepareVolumePath payload cleanup
..
clientIF: prepareVolumePath payload cleanup
the prepareVolumePath code path for cdrom/floppy
images is c
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Verified+1
Re-verified manually:
* creation being tested during (still in progress) benchmarks
* r
Vinzenz Feenstra has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
will do some testing again before to re-tick verified, even though changes in
last revision where
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6889/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
patch set 7: Dan kindly pointed me to a solution which should make everyone
happy
--
To view, v
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/24636/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 282:
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6: Code-Review+1
The pep8 error seems like issue in the slave.
--
To view, visit http://gerrit.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
(2 comments)
http://gerrit.ovirt.org/#/c/24636/5/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 28
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
(2 comments)
Looks good, but another comment can be removed, and temporary variable for pep8
is not re
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6783/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
Patch set 5:
remove the ugliness introduced in the previous commit;
tried to satisfy all the remar
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
(6 comments)
http://gerrit.ovirt.org/#/c/24636/4/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 28
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
(1 comment)
Nir, a big thank you for the very detailed and in-depth review. You raised very
vali
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
(1 comment)
Meta comment.
http://gerrit.ovirt.org/#/c/24636/4/vdsm/clientIF.py
File vdsm/clientIF.py:
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
(4 comments)
Puting some code in the final else makes the code more clear and allow dropping
some comm
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
(1 comment)
And the helper function name got worse.
http://gerrit.ovirt.org/#/c/24636/4/vdsm/clientIF.
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4: Code-Review-1
(1 comment)
Some parts became worse then the original code in latest patches.
http://ger
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6717/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 3:
patch set 4:
addressed reviewers comments.
_prepareVolumeFromPayload -> _makePayloadVolume renamed
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/24636/3/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 28
Antoni Segura Puimedon has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 3:
(2 comments)
Some minor nits.
http://gerrit.ovirt.org/#/c/24636/3/vdsm/clientIF.py
File vd
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6697/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
(4 comments)
http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 29
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 297:
Dan Kenigsberg has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py
File vdsm/clientIF.
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
no code change except the removal of an additional check not present in the
original code.
Re-ver
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2: Verified+1
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ov
Vinzenz Feenstra has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/24636/2/vdsm/clientIF.py
File vdsm/clientIF
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 1:
(1 comment)
http://gerrit.ovirt.org/#/c/24636/1/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 327:
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
patch set 2 pass the tests.
patch set 1 had a check which raised a different exception (VolumeErr
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
Does it pass the tests?
--
To view, visit http://gerrit.ovirt.org/24636
To unsubscribe, visit http://g
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7306/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 1: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7305/ : FAILU
Francesco Romani has abandoned this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Abandoned
Patch fully splitted. refactoring: http://gerrit.ovirt.org/24636
tests: http://gerrit.ovirt.org/#/c/24614/
--
Francesco Romani has uploaded a new change for review.
Change subject: clientIF: prepareVolumePath payload cleanup
..
clientIF: prepareVolumePath payload cleanup
the prepareVolumePath code path for cdrom/floppy
images is complic
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8: -Verified
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit http://gerrit.ovi
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8:
(6 comments)
Followed Nir's advice and split the tests in a separate change here:
http://gerrit.
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8:
Finally, I think it would be best to separate this to two patches. First a
patch that add the tests, wo
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8:
(1 comment)
Another test that would be nice to have.
http://gerrit.ovirt.org/#/c/22928/8/tests/clienti
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8:
(5 comments)
Tests are better now, but the fake objects can be more generic and easier to
use when we
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/7285/ : SUCCESS
htt
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 8: Verified+1
Patch set 8:
* improved the commit message, which was indeed confused as Nir pointed o
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
- The new code looks clean and good
- The commit message is confusing, as this is a refactoring and it d
Martin Polednik has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit http://gerrit.
Antoni Segura Puimedon has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, visit http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit_el/6277/ : SUCCESS
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(3 comments)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 28
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 7: Verified+1
Patch Set 7:
addressed reviewers comment. No code changes.
--
To view, visit http://g
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 334
Antoni Segura Puimedon has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(2 comments)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
L
Michal Skrivanek has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/22928/6/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 284
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6: Verified+1
Tested using the same tests of: http://gerrit.ovirt.org/#/c/22925/
Marking as verified;
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6: -Verified
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6731/ : SU
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
Jenkins failure is unrelated (and quite strange to me)
Fetching upstream changes from origin
Comm
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6: Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6707/ : SUCCE
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 6:
Patch set 6: address comments.
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe, v
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
(5 comments)
http://gerrit.ovirt.org/#/c/22928/5/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 24
Nir Soffer has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
(5 comments)
Partial review, I'll get to it later.
...
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_unit_tests_gerrit/6579/ : SUCCESS
htt
Francesco Romani has posted comments on this change.
Change subject: clientIF: prepareVolumePath payload cleanup
..
Patch Set 5:
Changes: addressed Nir comments.
--
To view, visit http://gerrit.ovirt.org/22928
To unsubscribe,
65 matches
Mail list logo
