automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 16:
* Update tracker::IGNORE, no Bug-Url found
* Set MODIFIED::IGNORE, no Bug-Url found.
--
To vi
Dan Kenigsberg has submitted this change and it was merged.
Change subject: qemuimg: add support for convert progress
..
qemuimg: add support for convert progress
This patch adds the support for QemuImgProcess, a class designed
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 15: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovir
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 15: Verified+1
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovirt.o
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 15:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 14: Code-Review+2
Adam, is this rebased on current master? That error in the ci should be fixed
now.
--
To
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 14:
Ahh, love the spurious CI failures always happening at the perfect time.
--
To view, visit https://gerr
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 14:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 13:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 12: Code-Review-1
Adam, please check my comments from version 11.
--
To view, visit https://gerrit.ovirt.or
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 12:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 11: Code-Review+1
(2 comments)
Just minor commit message cleanup.
https://gerrit.ovirt.org/#/c/33910/11//CO
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 11: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/33910
To unsubscribe, visit https://gerrit.ovir
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 11:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 9:
(4 comments)
https://gerrit.ovirt.org/#/c/33910/9/vdsm/storage/image.py
File vdsm/storage/image.py:
Line
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 10:
(3 comments)
https://gerrit.ovirt.org/#/c/33910/10/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 2
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 10: Code-Review-1
(3 comments)
Also see my comments in version 9 in image.py
https://gerrit.ovirt.org/#/c/3
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/33910/7/tests/qemuimgTests.py
File tests/qemuimgTests.py:
Line
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 9:
(10 comments)
https://gerrit.ovirt.org/#/c/33910/9/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 22
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(6 comments)
https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 241
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 10:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure h
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 9: Code-Review-1
(14 comments)
https://gerrit.ovirt.org/#/c/33910/9/lib/vdsm/qemuimg.py
File lib/vdsm/qemuim
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 9:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 8: Verified+1
Tested with the following engine flows:
* Offline move disk
* Clone disk
* Create template fro
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 8:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 269:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 269:
Adam Litke has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/33910/7/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 269:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(3 comments)
https://gerrit.ovirt.org/#/c/33910/7/tests/qemuimgTests.py
File tests/qemuimgTests.py:
Line
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
(4 comments)
Added some comments on the code, will review the tests later.
https://gerrit.ovirt.org/#/c/
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 7:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 6:
(9 comments)
Reviewed everything, suggested some cleanups.
https://gerrit.ovirt.org/#/c/33910/6/lib/vdsm
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/33910/6//COMMIT_MSG
Commit Message:
Line 13: command = qemuimg
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 6:
(2 comments)
Nice, but I think we should simplify and clarify the code receiving data.
Looked only at th
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 6:
Build Started (2/2)
0 -> http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1494/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 6:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/18264/
--
To v
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 6:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16902/ : SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 5:
Build Started (2/2) ->
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/17074/
-
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 5:
Build Started (1/2) ->
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16902/
--
To v
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 5:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/16806/ : SUCCESS
http://
automat...@ovirt.org has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 4:
* Update tracker::IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure he
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 3:
(2 comments)
http://gerrit.ovirt.org/#/c/33910/3/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
Line 257:
Nir Soffer has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/33910/3/vdsm/storage/image.py
File vdsm/storage/image.py:
Line 1
Dan Kenigsberg has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/33910/3/vdsm/storage/image.py
File vdsm/storage/image.py:
Li
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/13567/ : FAILURE
Federico Simoncelli has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/33910/2/lib/vdsm/qemuimg.py
File lib/vdsm/qemuimg.py:
L
Francesco Romani has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 2:
(5 comments)
more initial comments
http://gerrit.ovirt.org/#/c/33910/2/lib/vdsm/qemuimg.py
File li
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/13387/ : SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemuimg: add support for convert progress
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/12828/ : FAILURE
Federico Simoncelli has uploaded a new change for review.
Change subject: qemuimg: add support for convert progress
..
qemuimg: add support for convert progress
Change-Id: Id0b53e418c62bb2e91444ba5f351c916ca417299
Signed-off-by:
53 matches
Mail list logo
