mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 29: Verified+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 29: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 31:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_install_rpm_sanity_gerrit/7
Dan Kenigsberg has submitted this change and it was merged.
Change subject: replace configure_libvirt.py with python code.
..
replace configure_libvirt.py with python code.
The port is to behave as similar as possible to the ol
Dan Kenigsberg has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 30: Code-Review+2
Let's break stuff!
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscrib
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 30: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerr
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 30: Verified+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovi
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 28: Verified+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovi
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 28:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/28/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 28:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9155/
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 27: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/27298/27/lib/vdsm/tool/passwd.py
File lib
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 27: Verified+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 27:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9097/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 26:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/9062/ : SU
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 25:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit_el/8910/
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 24:
(3 comments)
http://gerrit.ovirt.org/#/c/27298/24/lib/vdsm/tool/configurator.py
File lib/vdsm/tool
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 24:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9801/ : S
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 23:
(8 comments)
http://gerrit.ovirt.org/#/c/27298/23//COMMIT_MSG
Commit Message:
Line 6:
Line 7: re
Saggi Mizrahi has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 23:
(8 comments)
http://gerrit.ovirt.org/#/c/27298/23//COMMIT_MSG
Commit Message:
Line 6:
Line 7:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 23:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9776/ : FAILU
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 23:
(4 comments)
http://gerrit.ovirt.org/#/c/27298/23/lib/vdsm/tool/configurator.py
File lib/vdsm/tool
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 23: Code-Review+1
(1 comment)
hope i haven't miss more changes . but expect the naming, it seems a
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 22:
just verify again. the code looks complete from my prospective
--
To view, visit http://gerrit
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 21:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/21/lib/vdsm/tool/configurator.py
File lib/vdsm/to
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 22: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerr
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 22:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9650/ : FAILU
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 21:
(3 comments)
http://gerrit.ovirt.org/#/c/27298/21/lib/vdsm/tool/configurator.py
File lib/vdsm/tool
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 21:
(2 comments)
http://gerrit.ovirt.org/#/c/27298/21/lib/vdsm/tool/configurator.py
File lib/vdsm/t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 21:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9630/ : SUCCE
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 20:
(4 comments)
that looks complete. only nits and the verification with node after restart (to
s
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 20: Verified-1
Removing until ovirt-node verification can be done.
--
To view, visit http://gerrit.ov
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 20:
(15 comments)
http://gerrit.ovirt.org/#/c/27298/20/lib/vdsm/tool/configurator.py
File lib/vdsm/too
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 20: Code-Review-1
(15 comments)
http://gerrit.ovirt.org/#/c/27298/20/lib/vdsm/tool/configurator.py
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 20:
Mooli, as we are testing in ovirt-node, please click in verified just after the
val
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 20:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9608/ : S
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 20: Verified+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovi
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 19: Verified+1
--
To view, visit http://gerrit.ovirt.org/27298
To unsubscribe, visit http://gerrit.ovi
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 19:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9601/ : SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 18:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit_tests_gerrit/9594/ : FAILU
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 17:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/17/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 17:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9286/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 16:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/9241/ : SUCCESS
ht
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 14:
(11 comments)
http://gerrit.ovirt.org/#/c/27298/14//COMMIT_MSG
Commit Message:
Line 5: CommitDate
Douglas Schilling Landgraf has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 14:
(11 comments)
http://gerrit.ovirt.org/#/c/27298/14//COMMIT_MSG
Commit Message:
Lin
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8995/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8991/ : SUCCESS
ht
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 12:
(3 comments)
http://gerrit.ovirt.org/#/c/27298/12/lib/vdsm/tool/configurator.py
File lib/vdsm/tool
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 12: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/27298/12/lib/vdsm/tool/configurator.py
F
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 12:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8963/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 11:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8952/ : SUCCESS
ht
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8922/ : SUCCESS
ht
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(5 comments)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(2 comments)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/co
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
(5 comments)
http://gerrit.ovirt.org/#/c/27298/9/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/co
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 9:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8893/ : SUCCESS
htt
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 8:
(1 comment)
>ok, than I would suggest to:
>1. Rename allTrue to needsUpdate - because it seems that
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8816/ : SUCCESS
htt
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 8:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/8//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 201
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/7/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/con
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 7:
(5 comments)
http://gerrit.ovirt.org/#/c/27298/7/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 7:
(4 comments)
http://gerrit.ovirt.org/#/c/27298/7/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/co
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 7:
(1 comment)
ok, I am done, looks ok, I am sure there are more cleanups that can be done,
but I do
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8781/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8729/ : SUCCESS
htt
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(7 comments)
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Nir Soffer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(6 comments)
Partial review.
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
File
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/6/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/co
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 6:
(1 comment)
nice! I think it is much better than what we had.
http://gerrit.ovirt.org/#/c/27298/6
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5: Verified+1
(1 comment)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File lib/v
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(13 comments)
The way I see things now, I think 'type' belongs on file and not on
a config section
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(10 comments)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File lib/vdsm/tool
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 5:
(5 comments)
http://gerrit.ovirt.org/#/c/27298/5/lib/vdsm/tool/configurator.py
File lib/vdsm/too
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/4/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/co
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/4/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 4:
(6 comments)
http://gerrit.ovirt.org/#/c/27298/4/lib/vdsm/tool/configurator.py
File lib/vdsm/tool/c
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/4/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vds
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 4:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/4/lib/vdsm/tool/libvirt_configure.sh.in
File lib/vdsm
Alon Bar-Lev has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 4:
(6 comments)
these tend to be a mess... I think it can be simpler, however it is not that
importa
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8630/ : SUCCESS
htt
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/27298/3/tests/toolTests.py
File tests/toolTests.py:
Line 1
mooli tayer has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 3:
(9 comments)
http://gerrit.ovirt.org/#/c/27298/3/lib/vdsm/tool/Makefile.am
File lib/vdsm/tool/Makef
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/27298/3/tests/toolTests.py
File tests/tool
Yaniv Bronhaim has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 3:
(8 comments)
love it ! thanks!! just few comments. please have more reviews now. i think its
al
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/8473/ : SUCCESS
htt
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 2: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_ge
oVirt Jenkins CI Server has posted comments on this change.
Change subject: replace configure_libvirt.py with python code.
..
Patch Set 1: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_pep8_ge
mooli tayer has uploaded a new change for review.
Change subject: replace configure_libvirt.py with python code.
..
replace configure_libvirt.py with python code.
Change-Id: I74bfe05bb4b5f5d09021f21b324f9b7d5d0fdaab
Signed-off-b
92 matches
Mail list logo
