Petr Horáček has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 8: Verified+1
common/contextlib_test.py passed OK.
[root@centos7-vdsmbox ~]# python2
Python 2.7.5 (default, Nov 20 2015, 02:00:19)
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Piotr Kliczewski has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 6: Code-Review-1
Please fix issue that Edward mentioned.
--
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe,
Edward Haas has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/6/lib/vdsm/compat.py
File lib/vdsm/compat.py:
Line 42: try:
Line
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Edward Haas has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe, visit https://gerrit.ovirt.org/settings
Piotr Kliczewski has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55065
To unsubscribe, visit https://gerrit.ovirt.org/settings
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 5:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Edward Haas has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4:
(1 comment)
https://gerrit.ovirt.org/#/c/55065/4/vdsm_hooks/ovs/ovs_before_network_setup.py
File
Piotr Kliczewski has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/4/vdsm_hooks/ovs/ovs_before_network_setup.py
File
Edward Haas has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/4/vdsm_hooks/ovs/ovs_before_network_setup.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4: Code-Review+1
looks alright. please verify both over python3 and 2
--
To view, visit https://gerrit.ovirt.org/55065
To
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 4:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Petr Horáček has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 3:
(1 comment)
https://gerrit.ovirt.org/#/c/55065/3/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/3/vdsm_hooks/ovs/ovs_before_network_setup_ip.py
File
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Yaniv Bronhaim has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: Code-Review-1
I don't agree - please use same api and import python3 suppress when available.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: -Code-Review
none of my comments merit a -1. they can be fixed in a follow up.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55065/2/lib/vdsm/utils.py
File lib/vdsm/utils.py:
Line 918: return
Petr Horáček has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: Verified+1
Passed utilsTests.py and OVS tests without a regression.
--
To view, visit https://gerrit.ovirt.org/55065
To
Edward Haas has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2: Code-Review+1
Note that vdsm/utils.py is a common cross vertical module, other maintainers
may need to review it.
You may need tp
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 2:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
Petr Horáček has uploaded a new change for review.
Change subject: utils: suppress
..
utils: suppress
Since suppress() function is available only in Python 3, add our own
implementation to vdsm/utils.py.
Change-Id:
gerrit-hooks has posted comments on this change.
Change subject: utils: suppress
..
Patch Set 1:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header matches 'Bug-Url: '
and is
25 matches
Mail list logo
