From Dan Kenigsberg :
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vdsm: virt: add optional container support
..
vdsm: virt: add optional container support
We add an
From Dan Kenigsberg :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 64: Code-Review+2
copying score
--
To view, visit
From Dan Kenigsberg :
Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 63: Code-Review+2
(1 comment)
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 58:
(11 comments)
I believe the code is ready, just leaving some food for thought in comments.
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 58:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 57:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 56:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 55:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 54:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py
File
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
(1 comment)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containerslib.py
File
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 53:
* Update Tracker::IGNORE, no bug url/s found
* Check Bug-Url::IGNORE, not relevant for branch: master
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
(9 comments)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containersconnection.py
File
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 52:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51: Code-Review-1
(9 comments)
https://gerrit.ovirt.org/#/c/53820/51/lib/vdsm/containersconnection.py
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 51:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 50:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 49:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 48:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 47:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 46:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 45:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 44:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 43: Code-Review-1
(15 comments)
Martin's comments needs to be addressed.
Martin Polednik has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 43:
(15 comments)
Basic review, I still haven't wrapped my head around the bigger picture.
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 43:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 42:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 41:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 40:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 39:
(1 comment)
https://gerrit.ovirt.org/#/c/53820/39/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 39:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 38:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 37:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 36:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 35:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 34:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 33:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 32:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 31:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 30:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: vdsm: virt: add optional container support
..
Patch Set 29:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
41 matches
Mail list logo