Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
Any other suggestion besides renaming export_xml for the upcoming rebase?
--
To view, visit
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/9/vdsm/virt/domain_descriptor.py
File
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9: Code-Review+1
let's not hide other score.
--
To view, visit https://gerrit.ovirt.org/55769
To
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/9/vdsm/virt/domain_descriptor.py
File
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(1 comment)
Very partial review, will look at it again next week.
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9: Code-Review+2
*Really* nice improvements. I like this.
--
To view, visit
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 9:
(10 comments)
I tried to address all the suggestions for improvements, so hopefully we can
move
Milan Zamazal has uploaded a new change for review.
Change subject: virt: Make DomainDescriptor use XML helpers
..
virt: Make DomainDescriptor use XML helpers
We are going to stop using xml.dom.minidom and to use xml.etree
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(7 comments)
Thank you all for the comments and suggestions, I hope things get clarified and
we
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(9 comments)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
> Not having a value is an exceptional situation,
No, it's not an exceptional situation when we
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 78:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line 78:
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/8/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
Line
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/8//COMMIT_MSG
Commit Message:
Line 33:
Nir Soffer has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
(7 comments)
https://gerrit.ovirt.org/#/c/55769/8//COMMIT_MSG
Commit Message:
Line 33:
Martin Polednik has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
Something makes me feel uneasy about this particular patch (not series as a
whole) and it's that
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py
File tests/vmXmlTests.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/55769
To unsubscribe, visit
gerrit-hooks has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 8:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Milan Zamazal has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7:
(2 comments)
https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py
File tests/vmXmlTests.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/55769/7/tests/vmXmlTests.py
File tests/vmXmlTests.py:
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7: Code-Review+1
(1 comment)
https://gerrit.ovirt.org/#/c/55769/7/vdsm/virt/vmxml.py
File
gerrit-hooks has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 7:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
gerrit-hooks has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 6:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
Francesco Romani has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 3:
(1 comment)
I'm convinced that adding a (thin) wrapper layer is a good direction, probably
our
gerrit-hooks has posted comments on this change.
Change subject: virt: Make DomainDescriptor use XML helpers
..
Patch Set 3:
* Update tracker: IGNORE, no Bug-Url found
* Check Bug-Url::WARN, no bug url found, make sure header
32 matches
Mail list logo
