Change in vdsm[master]: virt: introduce "Async" helper

2015-11-30 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found -- To view, visit https://gerrit.ovirt.org/49114 To unsubscribe,

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-30 Thread fromani
Francesco Romani has abandoned this change. Change subject: virt: introduce "Async" helper .. Abandoned we like https://gerrit.ovirt.org/49318 more. -- To view, visit https://gerrit.ovirt.org/49114 To unsubscribe, visit

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-27 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: (11 comments) The issue I'm trying the address is the split logic introduced in

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-27 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 3: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-26 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: Martin, I think we can go with Async if we can simplify it. E.g. how about something like the following in do():

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-25 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: Code-Review-1 (11 comments) I can't get rid of feeling that the implementation is too complicated for the

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-25 Thread mbetak
Martin Betak has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: I'm going to have to agree with Milan. We need to ask ourselves, what we are getting in exchange for all this

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-24 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 2: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-24 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: virt: introduce "Async" helper .. virt: introduce "Async" helper Introduce the "Async" class, to run one-shot long operations in background. It comes on two

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-24 Thread automation
gerrit-hooks has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure header matches

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-24 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/49114/1//COMMIT_MSG Commit Message: Line 12: - Async: a thin

Change in vdsm[master]: virt: introduce "Async" helper

2015-11-24 Thread fromani
Francesco Romani has posted comments on this change. Change subject: virt: introduce "Async" helper .. Patch Set 1: Code-Review-1 add docstrings -- To view, visit https://gerrit.ovirt.org/49114 To unsubscribe, visit