Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-05-17 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/54440/2//COMMIT_MSG Commit Message: Line 5:

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-05-17 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 2: * #1335840::Update tracker: OK * Check Bug-Url::OK * Check Public Bug::#1335840::OK, public

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-05-13 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: We've got a bug for this now: https://bugzilla.redhat.com/1335840 -- To view, visit

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-05-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: To clarify: We must be careful about balloon devices because if libvirt doesn't find one in

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-05-12 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: I'm not completely sure what's going on here (disclaimer: I haven't spent much time

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-05-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: Couldn't we simply ignore balloon devices with model='none'? -- To view, visit

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-05-12 Thread mzamazal
Milan Zamazal has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: For me, the balloon alias gets lost after libvirtd restart. Just restarting Vdsm doesn't

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-03-11 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: Code-Review-1 let's investigate the libvirt side first. -- To view, visit

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-03-08 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: yes, this seems more libvirt issue. I'll investigate this further on libvirt side. --

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-03-07 Thread mpolednik
Martin Polednik has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: That seems dangerous as alias is generated by libvirt - why is it missing in this case?

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-03-07 Thread fromani
Francesco Romani has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: Right after the start, the balloon has the alias. The very first investigation suggests

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-03-07 Thread fromani
Francesco Romani has uploaded a new change for review. Change subject: vm: devices: fix behaviour with balloon model=none .. vm: devices: fix behaviour with balloon model=none In the recovery flow, should Vdsm recover a VM

Change in vdsm[master]: vm: devices: fix behaviour with balloon model=none

2016-03-07 Thread automation
gerrit-hooks has posted comments on this change. Change subject: vm: devices: fix behaviour with balloon model=none .. Patch Set 1: * Update tracker: IGNORE, no Bug-Url found * Check Bug-Url::WARN, no bug url found, make sure