On Thu, 2017-02-09 at 14:22 +0100, Christophe de Dinechin wrote:
> > >
> > > If the message is NULL, we should still display something like
> > > “unknown error”. If we think it’s worth testing for error-
> > > >message
> > > != NULL, then I suggest another patch just for that, that fixes
> > >
>>
>> If the message is NULL, we should still display something like
>> “unknown error”. If we think it’s worth testing for error->message
>> != NULL, then I suggest another patch just for that, that fixes all
>> places and not just this one.
> I agree
Separate patch sent.
>> BTW, I did not
On Thu, 2017-02-09 at 12:10 +0100, Christophe de Dinechin wrote:
> Thanks for the comments.
>
> > On 9 Feb 2017, at 11:23, Pavel Grunt wrote:
> >
> > Hello Christophe,
> >
> > On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote:
> > > When running 'remote-viewer'
Thanks for the comments.
> On 9 Feb 2017, at 11:23, Pavel Grunt wrote:
>
> Hello Christophe,
>
> On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote:
>> When running 'remote-viewer' without arguments,
>> and selecting a non-supported protocol, e.g. ssh://foo,
>>
Hello Christophe,
On Wed, 2017-02-08 at 17:48 +0100, Christophe de Dinechin wrote:
> When running 'remote-viewer' without arguments,
> and selecting a non-supported protocol, e.g. ssh://foo,
> the generated error was silently swallowed by the retry loop.
> This was introduced in
> On 8 Feb 2017, at 20:34, Eduardo Lima (Etrunko) wrote:
>
> Patch looks good, I personally also like to check for error->message
> before dereferencing it, but I don't really know what others think about it.
I had wondered about that, but I checked, and apparently, all
On 08/02/17 14:48, Christophe de Dinechin wrote:
> When running 'remote-viewer' without arguments,
> and selecting a non-supported protocol, e.g. ssh://foo,
> the generated error was silently swallowed by the retry loop.
> This was introduced in 06b2c382468876a19600374bd59475e66d488af8.
> ---
>
When running 'remote-viewer' without arguments,
and selecting a non-supported protocol, e.g. ssh://foo,
the generated error was silently swallowed by the retry loop.
This was introduced in 06b2c382468876a19600374bd59475e66d488af8.
---
src/remote-viewer.c | 3 +++
1 file changed, 3 insertions(+)