RE: [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler

2016-09-13 Thread Gonglei (Arei)
Hi Ola, > -Original Message- > From: Ola Liljedahl [mailto:ola.liljed...@arm.com] > Sent: Tuesday, September 13, 2016 7:53 PM > To: Paolo Bonzini; Daniel P. Berrange; Gonglei (Arei) > Cc: qemu-de...@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng > (Peter); Luonengjun;

RE: [virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler

2016-09-13 Thread Gonglei (Arei)
Hi Paolo, > -Original Message- > From: virtio-dev@lists.oasis-open.org [mailto:virtio-dev@lists.oasis-open.org] > On Behalf Of Paolo Bonzini > Sent: Tuesday, September 13, 2016 6:58 PM > To: Daniel P. Berrange; Gonglei (Arei) > Cc: qemu-de...@nongnu.org; virtio-dev@lists.oasis-open.org;

[virtio-dev] Re: [PATCH 1/3] virtio: Basic implementation of virtio pstore driver

2016-09-13 Thread Michael S. Tsirkin
On Sat, Aug 20, 2016 at 05:07:42PM +0900, Namhyung Kim wrote: > The virtio pstore driver provides interface to the pstore subsystem so > that the guest kernel's log/dump message can be saved on the host > machine. Users can access the log file directly on the host, or on the > guest at the next

[virtio-dev] [PATCH v10] virtio-net: add Max MTU configuration field

2016-09-13 Thread Aaron Conole
It is helpful for a host to indicate it's MTU to be set on guest NICs other than the assumed 1500 byte value. This helps in situations where the host network is using Jumbo Frames, or aiding in PMTU discovery by configuring a homogenous network. It is also helpful for sizing receive buffers

[virtio-dev] Re: [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 11:54, Daniel P. Berrange wrote: > > OK, I agree with you :) But if we support multiple backends, can > > we keep cryptodev-linux module as one option? > > I'm personally against any support for out of tree kernel modules > in QEMU, regardless of whether QEMU also implements

[virtio-dev] Re: [PATCH v2 02/15] crypto: introduce crypto queue handler

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 11:20, Daniel P. Berrange wrote: >> > +typedef struct CryptoPacket CryptoPacket; >> > +typedef struct CryptoQueue CryptoQueue; >> > +typedef struct CryptoPacketBuf CryptoPacketBuf; >> > + >> > +typedef void (CryptoPacketSent) (CryptoClientState *, int); > As previously, I'd expect

[virtio-dev] Re: [PATCH v2 01/15] crypto: introduce cryptodev backend and crypto legacy hardware

2016-09-13 Thread Paolo Bonzini
On 13/09/2016 11:13, Daniel P. Berrange wrote: > > + * Permission is hereby granted, free of charge, to any person obtaining a > > copy > > + * of this software and associated documentation files (the "Software"), > > to deal > > + * in the Software without restriction, including without

[virtio-dev] RE: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff

2016-09-13 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 6:09 PM > To: Gonglei (Arei) > Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff > > On Tue, Sep 13, 2016 at 10:05:01AM +, Gonglei (Arei) wrote: > > > > > > >

[virtio-dev] RE: [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 5:54 PM > To: Gonglei (Arei) > Cc: qemu-de...@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng > (Peter); Luonengjun; m...@redhat.com; stefa...@redhat.com; >

[virtio-dev] RE: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff

2016-09-13 Thread Gonglei (Arei)
> -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 5:23 PM > To: Gonglei (Arei) > Cc: qemu-de...@nongnu.org; virtio-dev@lists.oasis-open.org; Huangpeng > (Peter); Luonengjun; m...@redhat.com; stefa...@redhat.com; >

[virtio-dev] RE: [PATCH v2 01/15] crypto: introduce cryptodev backend and crypto legacy hardware

2016-09-13 Thread Gonglei (Arei)
> > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 5:14 PM > Subject: Re: [PATCH v2 01/15] crypto: introduce cryptodev backend and crypto > legacy hardware > > On Tue, Sep 13, 2016 at 11:52:07AM +0800, Gonglei wrote: > > cryptodev backend is used to

[virtio-dev] RE: [PATCH v2 00/15] virtio-crypto: introduce framework and device emulation

2016-09-13 Thread Gonglei (Arei)
Hi Daniel, Thanks for your comments fristly, please see my embedded reply. Regards, -Gonglei > -Original Message- > From: Daniel P. Berrange [mailto:berra...@redhat.com] > Sent: Tuesday, September 13, 2016 4:58 PM > To: Gonglei (Arei) > Cc: qemu-de...@nongnu.org;