Re: [virtio-dev] Re: [Qemu-devel] [v23 1/2] virtio-crypto: Add virtio crypto device specification

2018-06-19 Thread Michael S. Tsirkin
On Wed, Jan 10, 2018 at 01:53:09PM +0800, Longpeng (Mike) wrote: > Hi Halil, > > We are fixing the Intel BUG these days, so I will go through your comments > after > we're done. Thanks. All right - are you guys done with meltdown/spectre? I'd like us to start finally getting parts of this in the

Re: [virtio-dev] [PATCH v3] VIRTIO_F_IO_BARRIER: use I/O barriers in driver

2018-06-19 Thread Michael S. Tsirkin
On Thu, May 10, 2018 at 11:41:26PM +0800, Tiwei Bie wrote: > There will be hardware virtio devices in the future, which > require drivers to use the barriers suitable for I/O devices, > compared with software virtio devices which just require > drivers to use the barriers suitable for CPU cores. >

Re: [virtio-dev] [PATCH v7] vsock: add vsock device

2018-06-19 Thread Michael S. Tsirkin
On Thu, Aug 04, 2016 at 04:24:37PM +0100, Stefan Hajnoczi wrote: > The virtio vsock device is a zero-configuration socket communications > device. It is designed as a guest<->host management channel suitable > for communicating with guest agents. > > vsock is designed with the sockets API in mind

Re: [virtio-dev] [PATCH] Add virtio gpu device specification.

2018-06-19 Thread Michael S. Tsirkin
On Tue, May 10, 2016 at 01:25:37PM +0200, Gerd Hoffmann wrote: > Hi, > > > > > Rendered versions are available here: > > > > https://www.kraxel.org/virtio/virtio-v1.0-cs03-virtio-gpu.pdf > > > > > > > > https://www.kraxel.org/virtio/virtio-v1.0-cs03-virtio-gpu.html#x1-287 > > > > I gue

Re: [virtio-dev] Re: [PATCH] Update virtio input device specification

2018-06-19 Thread Michael S. Tsirkin
On Thu, Apr 06, 2017 at 03:21:26PM +0200, Gerd Hoffmann wrote: > Hi, > > > The downside is that this is hard to specify formally, the same way we > > do other devices. Say we do that and point to a fixed version of the > > relevant Linux headers and the headers evolve and add or change > > somet

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 05:14:18PM +0800, Tiwei Bie wrote: > On Mon, Jun 18, 2018 at 07:28:33PM +0300, Michael S. Tsirkin wrote: > > On Mon, Jun 18, 2018 at 05:08:32PM +0200, Halil Pasic wrote: > > > > > > > > > On 06/15/2018 05:37 PM, Michael S. Tsirkin wrote: > > > > On Fri, Jun 15, 2018 at 05:

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 12:54:53PM +0200, Cornelia Huck wrote: > Sorry about dragging mainframes into this, but this will only work for > homogenous device coupling, not for heterogenous. Consider my vfio-pci > + virtio-net-ccw example again: The guest cannot find out that the two > belong together

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Siwei Liu
On Tue, Jun 19, 2018 at 3:54 AM, Cornelia Huck wrote: > On Fri, 15 Jun 2018 10:06:07 -0700 > Siwei Liu wrote: > >> On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: >> > On Thu, 14 Jun 2018 18:57:11 -0700 >> > Siwei Liu wrote: >> > >> >> Thank you for sharing your thoughts, Cornelia. With q

Re: [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 02:02:10PM -0500, Venu Busireddy wrote: > On 2018-06-19 21:53:01 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 01:36:17PM -0500, Venu Busireddy wrote: > > > On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jun 19, 2018 at 01:14:06PM -050

Re: [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 21:53:01 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 01:36:17PM -0500, Venu Busireddy wrote: > > On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > > > > On 2018-06-19 20:24:12 +0300, Michael S

Re: [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 01:36:17PM -0500, Venu Busireddy wrote: > On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > > > On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote: > > > > On Tue, Jun 19, 2018 at 11:32:26AM -050

Re: [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 21:21:23 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > > On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote: > > > > Add a "Vendor-Specific" capability to t

Re: [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 01:14:06PM -0500, Venu Busireddy wrote: > On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote: > > > Add a "Vendor-Specific" capability to the PCIe bridge, to contain the > > > "Group Identifier" (UUID) t

Re: [virtio-dev] Re: [PATCH virtio 1/1] Add "Group Identifier" support to virtio PCI capabilities.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 21:12:17 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 12:54:06PM -0500, Venu Busireddy wrote: > > On 2018-06-19 20:30:06 +0300, Michael S. Tsirkin wrote: > > > On Tue, Jun 19, 2018 at 11:32:28AM -0500, Venu Busireddy wrote: > > > > Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group

Re: [virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 20:24:12 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote: > > Add a "Vendor-Specific" capability to the PCIe bridge, to contain the > > "Group Identifier" (UUID) that will be used to pair a virtio device with > > the passthrough device

Re: [virtio-dev] Re: [PATCH virtio 1/1] Add "Group Identifier" support to virtio PCI capabilities.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 12:54:06PM -0500, Venu Busireddy wrote: > On 2018-06-19 20:30:06 +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 11:32:28AM -0500, Venu Busireddy wrote: > > > Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the > > > virtio PCI capabilities to a

Re: [virtio-dev] Re: [PATCH virtio 1/1] Add "Group Identifier" support to virtio PCI capabilities.

2018-06-19 Thread Venu Busireddy
On 2018-06-19 20:30:06 +0300, Michael S. Tsirkin wrote: > On Tue, Jun 19, 2018 at 11:32:28AM -0500, Venu Busireddy wrote: > > Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the > > virtio PCI capabilities to allow for the grouping of devices. > > > > Signed-off-by: Venu Busireddy

[virtio-dev] Re: [PATCH virtio 1/1] Add "Group Identifier" support to virtio PCI capabilities.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 11:32:28AM -0500, Venu Busireddy wrote: > Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the > virtio PCI capabilities to allow for the grouping of devices. > > Signed-off-by: Venu Busireddy > --- > content.tex | 43 ++

[virtio-dev] Re: [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 11:32:26AM -0500, Venu Busireddy wrote: > Add a "Vendor-Specific" capability to the PCIe bridge, to contain the > "Group Identifier" (UUID) that will be used to pair a virtio device with > the passthrough device attached to that bridge. > > This capability is added to the b

[virtio-dev] [PATCH 3/3] Add "Group Identifier" support to virtio devices.

2018-06-19 Thread Venu Busireddy
Use the virtio PCI capability "VIRTIO_PCI_CAP_GROUP_ID_CFG" to store the "Group Identifier" (UUID) specified via the command line option "uuid" for the virtio device. The capability will be present in the virtio device's configuration space iff the "uuid" option is specified. Group Identifier is u

[virtio-dev] [PATCH 2/3] Add "Group Identifier" support to PCIe bridges.

2018-06-19 Thread Venu Busireddy
Add a "Vendor-Specific" capability to the PCIe bridge, to contain the "Group Identifier" (UUID) that will be used to pair a virtio device with the passthrough device attached to that bridge. This capability is added to the bridge iff the "uuid" option is specified for the bridge device, via the qe

[virtio-dev] [PATCH virtio 1/1] Add "Group Identifier" support to virtio PCI capabilities.

2018-06-19 Thread Venu Busireddy
Add VIRTIO_PCI_CAP_GROUP_ID_CFG (Group Identifier) capability to the virtio PCI capabilities to allow for the grouping of devices. Signed-off-by: Venu Busireddy --- content.tex | 43 +++ 1 file changed, 43 insertions(+) diff --git a/content.tex b/content.

[virtio-dev] [PATCH 1/3] Add a true or false option to the DEFINE_PROP_UUID macro.

2018-06-19 Thread Venu Busireddy
It may not always be desirable to have a random UUID stuffed into the '_field' member. Add a new option '_default' to the macro, that will allow the caller to specify if a random UUID needs be generated or not. Also modified the instance where this macro is used. Signed-off-by: Venu Busireddy --

[virtio-dev] [PATCH 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-19 Thread Venu Busireddy
The patch set "Enable virtio_net to act as a standby for a passthru device" [1] deals with live migration of guests that use passthrough devices. However, that scheme uses the MAC address for pairing the virtio device and the passthrough device. The thread "netvsc: refactor notifier/event handling

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-19 Thread Tiwei Bie
On Tue, Jun 19, 2018 at 12:46:45PM +0200, Halil Pasic wrote: > On 06/19/2018 11:14 AM, Tiwei Bie wrote: > > On Mon, Jun 18, 2018 at 07:28:33PM +0300, Michael S. Tsirkin wrote: [...] > > > > If it would be better to drop this patch, > > I'm fine with dropping it. Thanks! > > > > @Tiwei Bie > Than

Re: [virtio-dev] Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-19 Thread Michael S. Tsirkin
On Tue, Jun 19, 2018 at 08:13:37PM +0800, Wei Wang wrote: > On 06/19/2018 11:05 AM, Michael S. Tsirkin wrote: > > On Tue, Jun 19, 2018 at 01:06:48AM +, Wang, Wei W wrote: > > > On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: > > > > On Sat, Jun 16, 2018 at 01:09:44AM +, Wang, W

Re: [virtio-dev] Re: [PATCH v33 2/4] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_HINT

2018-06-19 Thread Wei Wang
On 06/19/2018 11:05 AM, Michael S. Tsirkin wrote: On Tue, Jun 19, 2018 at 01:06:48AM +, Wang, Wei W wrote: On Monday, June 18, 2018 10:29 AM, Michael S. Tsirkin wrote: On Sat, Jun 16, 2018 at 01:09:44AM +, Wang, Wei W wrote: Not necessarily, I think. We have min(4m_page_blocks / 512, 1

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Cornelia Huck
On Fri, 15 Jun 2018 10:06:07 -0700 Siwei Liu wrote: > On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > > On Thu, 14 Jun 2018 18:57:11 -0700 > > Siwei Liu wrote: > > > >> Thank you for sharing your thoughts, Cornelia. With questions below, I > >> think you raised really good points, som

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-19 Thread Halil Pasic
On 06/19/2018 11:14 AM, Tiwei Bie wrote: On Mon, Jun 18, 2018 at 07:28:33PM +0300, Michael S. Tsirkin wrote: [..] (11) The VIRTIO specification is a bit vague about how a reset is supposed to be handled by the guest, but it certainly does not prohibit the negotiated features from changing a

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-19 Thread Tiwei Bie
On Mon, Jun 18, 2018 at 07:28:33PM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 18, 2018 at 05:08:32PM +0200, Halil Pasic wrote: > > > > > > On 06/15/2018 05:37 PM, Michael S. Tsirkin wrote: > > > On Fri, Jun 15, 2018 at 05:16:10PM +0200, Halil Pasic wrote: > > > > > > > > > > > > On 06/15/20