[virtio-dev] Re: [PATCH v11 00/10] Introduce device group and device management

2023-04-04 Thread Cornelia Huck
On Mon, Apr 03 2023, "Michael S. Tsirkin" wrote: > On Mon, Apr 03, 2023 at 06:39:12PM +0200, Cornelia Huck wrote: >> On Mon, Apr 03 2023, "Michael S. Tsirkin" wrote: >> >> > Change log: >> > >> > since v10: >> >addresse

[virtio-dev] Re: [PATCH 08/11] transport-pci: Introduce virtio extended capability

2023-04-04 Thread Cornelia Huck
On Tue, Apr 04 2023, "Michael S. Tsirkin" wrote: > On Fri, Mar 31, 2023 at 01:58:31AM +0300, Parav Pandit wrote: >> PCI device configuration space for capabilities is limited to only 192 >> bytes shared by many PCI capabilities of generic PCI device and virtio >> specific. >> >> Hence,

Re: [virtio-dev] [PATCH v10 0/8] Rename queue index to queue number

2023-03-31 Thread Cornelia Huck
On Thu, Mar 30 2023, Halil Pasic wrote: > On Thu, 30 Mar 2023 00:23:33 +0300 > Parav Pandit wrote: > >> 1. Currently, virtqueue is identified between driver and device >> interchangeably using either number or index terminology. >> >> 2. Between PCI and MMIO transport the queue size (depth) is

[virtio-dev] Re: [PATCH v10 8/8] virtio-net: Describe RSS using rss rq id

2023-03-30 Thread Cornelia Huck
On Thu, Mar 30 2023, Parav Pandit wrote: > The content of indirection table and unclassified_queue which are > based on math calculation historically. To better describe this, to > avoid intermixing array index with virtqueue index and to use virtqueue > number > > introduce a field rq_handle

[virtio-dev] Re: [PATCH v10 7/8] virtio-net: Avoid duplicate receive queue example

2023-03-30 Thread Cornelia Huck
"the 0-based number"? > \item If the destination receive queue is being reset (See \ref{sec:Basic > Facilities of a Virtio Device / Virtqueues / Virtqueue Reset}), the device > MUST drop the packet. > \end{itemize} > Otherwise, Reviewed-by: Cornelia Huck

[virtio-dev] Re: [PATCH v10 6/8] transport-ccw: Refer to the vq by its number

2023-03-30 Thread Cornelia Huck
mment > v2->v3: > - added comment note for queue_select similar to max_queue_size > v0->v1: > - new patch > --- > transport-ccw.tex | 14 ++++-- > 1 file changed, 8 insertions(+), 6 deletions(-) Reviewed-by: Cornelia Huck ---

[virtio-dev] Re: [PATCH v10 1/8] content: Add vq number text

2023-03-30 Thread Cornelia Huck
moved description close to introduction, it was in middle of > queue data transfer description > v2->v3: > - new patch > --- > content.tex | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Cornelia Huck ---

[virtio-dev] RE: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
On Wed, Mar 29 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Wednesday, March 29, 2023 5:30 AM >> >> Same comment regarding s/Previously/previously/ as for the last patch. >> > Will change. > >> Also, I'm not that happy with the name &q

[virtio-dev] RE: [PATCH v9 3/8] transport-mmio: Rename QueueNum register

2023-03-29 Thread Cornelia Huck
On Wed, Mar 29 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Wednesday, March 29, 2023 5:16 AM >> >> I'm not sure it is worthwile keeping the lines short so aggressively (after >> all, it >> does not affect the generated html/pdf), espec

[virtio-dev] Re: [PATCH v9 6/8] transport-ccw: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
On Tue, Mar 28 2023, Parav Pandit wrote: > Currently specification uses virtqueue index and > number interchangeably to refer to the virtqueue. > > Instead refer to it by its number. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit > > --- >

[virtio-dev] Re: [PATCH v9 5/8] transport-ccw: Rename queue depth/size to other transports

2023-03-29 Thread Cornelia Huck
ct vq_config_block { > be16 index; > -be16 max_num; > +be16 max_queue_size; /* Previously known as max_num */ Nit: the comment should probably start with a lower-case 'p', as it is not a complete sentence (further instances of this below). Otherwise, Reviewed-by: Cornelia Hu

[virtio-dev] Re: [PATCH v9 4/8] transport-mmio: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
-- > transport-mmio.tex | 23 +-- > 1 file changed, 9 insertions(+), 14 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v9 3/8] transport-mmio: Rename QueueNum register

2023-03-29 Thread Cornelia Huck
}, \field{QueueNum}, > \field{QueueReady}, > +following operations on \field{QueueSizeMax}, > +\field{QueueSize}, \field{QueueReady}, I'm not sure it is worthwile keeping the lines short so aggressively (after all, it does not affect the generated html/pdf), e

[virtio-dev] Re: [PATCH v9 2/8] transport-pci: Refer to the vq by its number

2023-03-29 Thread Cornelia Huck
virtqueue number in the Note > - refer to vqn field instead of virtqueue number > --- > transport-pci.tex | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) Reviewed-by: Cornelia Huck - To

[virtio-dev] Re: [PATCH v9 1/8] content: Add vq number text

2023-03-29 Thread Cornelia Huck
On Tue, Mar 28 2023, Parav Pandit wrote: > Introduce vq number and its range so that subsequent patches can refer > to it. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/163 > Signed-off-by: Parav Pandit > --- > changelog: > v8->v9: > - added inclusive when describing the vq number

[virtio-dev] Re: [PATCH] virtio-spi: add the device specification

2023-03-27 Thread Cornelia Huck
On Fri, Mar 24 2023, Haixu Cui wrote: > virtio-spi is a virtual SPI master and it allows a guset to operate and > use the physical SPI master controlled by the host. Please spell out what SPI is the first time you use it. Also, please remember to post the separate patch that reserves the ID

[virtio-dev] Re: [virtio-comment] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation

2023-03-22 Thread Cornelia Huck
On Wed, Mar 22 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Wednesday, March 22, 2023 12:37 PM >> >> On Wed, Mar 22 2023, Parav Pandit wrote: >> >> >> From: Cornelia Huck >> >> Sent: Wednesday, March 22, 2023 11

[virtio-dev] RE: [PATCH v13] virtio-net: support the virtqueue coalescing moderation

2023-03-22 Thread Cornelia Huck
On Wed, Mar 22 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Wednesday, March 22, 2023 11:21 AM >> >> On Wed, Mar 22 2023, Heng Qi wrote: >> >> > +The driver MUST NOT set \field{vqn} to any value other than an enabled >> transmit

[virtio-dev] Re: [PATCH v13] virtio-net: support the virtqueue coalescing moderation

2023-03-22 Thread Cornelia Huck
On Wed, Mar 22 2023, Heng Qi wrote: > +The driver MUST NOT set \field{vqn} to any value other than an enabled > transmit or receive virtqueue number. "than the virtqueue number of an enabled transmit or receive virtqueue" might be better -- what do others think? Otherwise, LGTM.

[virtio-dev] Re: [virtio-comment] [PATCH v12] virtio-net: support the virtqueue coalescing moderation

2023-03-21 Thread Cornelia Huck
On Tue, Mar 21 2023, Heng Qi wrote: > May I bother you please to withdraw the vote, I will modify it according > to your opinion and release a new version!:) Sure, done. - To unsubscribe, e-mail:

[virtio-dev] Re: [virtio-comment] [PATCH v12] virtio-net: support the virtqueue coalescing moderation

2023-03-21 Thread Cornelia Huck
On Tue, Mar 21 2023, Heng Qi wrote: > 在 2023/3/21 上午12:35, Cornelia Huck 写道: >> On Sun, Mar 12 2023, Heng Qi wrote: >>> \item \field{max_usecs} for RX: Maximum number of microseconds to delay a >>> RX notification. >>> \item \field{max_usecs} for TX: Max

[virtio-dev] Re: [virtio-comment] [PATCH v12] virtio-net: support the virtqueue coalescing moderation

2023-03-20 Thread Cornelia Huck
On Sun, Mar 12 2023, Heng Qi wrote: > Currently, coalescing parameters are grouped for all transmit and receive > virtqueues. This patch supports setting or getting the parameters for a > specified virtqueue, and a typical application of this function is netdim[1]. > > When the traffic between

[virtio-dev] Re: [virtio-comment] [PATCH 1/1] RFC: virtio-bt: add virtio BT device specification

2023-03-15 Thread Cornelia Huck
On Wed, Mar 15 2023, "Michael S. Tsirkin" wrote: > On Wed, Mar 15, 2023 at 04:55:59PM +0100, Cornelia Huck wrote: >> On Fri, Mar 10 2023, Igor Skalkin wrote: >> > +\subsection{Feature bits}\label{sec:Device Types / BT Device / Feature >> > bits} >>

[virtio-dev] Re: [virtio-comment] [PATCH 1/1] RFC: virtio-bt: add virtio BT device specification

2023-03-15 Thread Cornelia Huck
On Fri, Mar 10 2023, Igor Skalkin wrote: > This PR is aimed as review for comments(RFC) purpose. > > * Initial draft version. > > Signed-off-by: Igor Skalkin > --- > conformance.tex| 12 ++- > content.tex| 1 + >

Re: [virtio-dev] [PATCH] virtio-spi: add the device specification

2023-03-15 Thread Cornelia Huck
On Mon, Feb 27 2023, Haixu Cui wrote: > virtio-spi is a virtual SPI master and it allows a guset to operate and > use the physical SPI master controlled by the host. > > Signed-off-by: Haixu Cui > --- > content.tex | 2 + > device-types/spi/description.tex

[virtio-dev] Re: [PATCH] transport-pci: Remove duplicate word structure

2023-03-15 Thread Cornelia Huck
On Fri, Mar 10 2023, Parav Pandit wrote: > Remove duplicate word structure. > > Signed-off-by: Parav Pandit > --- > transport-pci.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, pushed as an editorial update.

[virtio-dev] Re: [PATCH] virtio-net: Fix virtqueues spelling error

2023-03-15 Thread Cornelia Huck
On Fri, Mar 10 2023, Parav Pandit wrote: > Correct spelling from virtqueus to virtqueues. > > Signed-off-by: Parav Pandit > --- > device-types/net/description.tex | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Thanks, pushed as editorial update.

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-03-10 Thread Cornelia Huck
On Fri, Mar 10 2023, Alexandre Courbot wrote: > Hi Cornelia, > > On Fri, Mar 10, 2023 at 7:51 PM Cornelia Huck wrote: >> >> On Tue, Feb 07 2023, Cornelia Huck wrote: >> >> > On Tue, Feb 07 2023, Alexandre Courbot wrote: >> > >> >> On Mo

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-03-10 Thread Cornelia Huck
On Tue, Feb 07 2023, Cornelia Huck wrote: > On Tue, Feb 07 2023, Alexandre Courbot wrote: > >> On Mon, Feb 6, 2023 at 11:13 PM Cornelia Huck wrote: >>> I hope we can sort this out soon -- I guess I'm not the only one who is >>> anxious about this spec moving forw

[virtio-dev] Re: [virtio-comment] [PATCH v10 00/10] Introduce device group and device management

2023-03-08 Thread Cornelia Huck
On Mon, Mar 06 2023, "Michael S. Tsirkin" wrote: > On Mon, Mar 06, 2023 at 01:29:30PM +0100, Jiri Pirko wrote: >> Thu, Mar 02, 2023 at 02:04:48PM CET, m...@redhat.com wrote: >> >> [...] >> >> > >> >TODO (maybe?) - probably ok to defer until this part is upstream: >> > >> >Add "all members"

[virtio-dev] Re: [virtio-comment] RE: [PATCH v10 06/10] mmio: document ADMIN_VQ as reserved

2023-03-08 Thread Cornelia Huck
On Tue, Mar 07 2023, Parav Pandit wrote: >> From: Michael S. Tsirkin >> Sent: Friday, March 3, 2023 3:34 AM >> >> On Thu, Mar 02, 2023 at 06:40:55PM +, Parav Pandit wrote: >> > Did you miss reviewed-by from [1] or this is an old series reposted? >> > [1] >> >

[virtio-dev] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-03-08 Thread Cornelia Huck
On Wed, Mar 08 2023, Max Gurtovoy wrote: > On 08/03/2023 14:07, Michael S. Tsirkin wrote: >> On Wed, Mar 08, 2023 at 12:55:37PM +0200, Max Gurtovoy wrote: > 5. VIRTIO_ADMIN_STATUS_COMMAND_SPECIFIC_ERR (for more info read the > command_specific_error field). I don't think it's a

[virtio-dev] Re: [virtio] [PATCH v10 01/10] virtio: document forward compatibility guarantees

2023-03-08 Thread Cornelia Huck
On Tue, Mar 07 2023, David Edmondson wrote: > "Michael S. Tsirkin" writes: > >> On Mon, Mar 06, 2023 at 01:53:50PM +, David Edmondson wrote: >>> "Michael S. Tsirkin" writes: >>> >>> > Feature negotiation forms the basis of forward compatibility >>> > guarantees of virtio but has never

[virtio-dev] Re: [virtio-comment] RE: [PATCH v3 0/2] virtio-net: Improve dev config layout

2023-03-08 Thread Cornelia Huck
On Tue, Mar 07 2023, Parav Pandit wrote: > Hi Cornelia, > >> -Original Message----- >> From: Cornelia Huck >> Sent: Monday, March 6, 2023 9:32 AM >> To: Parav Pandit ; m...@redhat.com; virtio-dev@lists.oasis- >> open.org >> Cc: virtio-comm...@lists

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [PATCH v5 0/6] Split transport specific files

2023-03-06 Thread Cornelia Huck
On Mon, Mar 06 2023, Cornelia Huck wrote: > On Mon, Mar 06 2023, Jan Kiszka wrote: > >> On 03.03.23 08:45, Michael S. Tsirkin wrote: >>> On Thu, Mar 02, 2023 at 03:10:45PM +, Parav Pandit wrote: >>>> >>>> >>>>> From:

[virtio-dev] RE: [PATCH v3 0/2] virtio-net: Improve dev config layout

2023-03-06 Thread Cornelia Huck
On Tue, Feb 21 2023, Parav Pandit wrote: >> From: Parav Pandit >> Sent: Friday, February 17, 2023 10:45 AM > >> Patch summary: >> patch-1: consolidate read only field at one place in driver requirements >> patch-2: define device configuration layout before describing its fields. >> >>

Re: [virtio-dev] Re: [PATCH v5 0/6] Split transport specific files

2023-03-06 Thread Cornelia Huck
On Mon, Mar 06 2023, Jan Kiszka wrote: > On 03.03.23 08:45, Michael S. Tsirkin wrote: >> On Thu, Mar 02, 2023 at 03:10:45PM +, Parav Pandit wrote: >>> >>> From: Parav Pandit Sent: Friday, February 24, 2023 5:22 PM Problem statement: Currently several tens of pages

[virtio-dev] Re: [virtio-comment] Re: [PATCH 0/3] Rename queue index to queue number

2023-03-02 Thread Cornelia Huck
On Wed, Mar 01 2023, "Michael S. Tsirkin" wrote: > On Wed, Mar 01, 2023 at 06:22:07PM +0100, Halil Pasic wrote: >> On Mon, 27 Feb 2023 09:45:31 +0100 >> Cornelia Huck wrote: >> >> > For the vq index/number, I'm not that sure that "virtqueue

[virtio-dev] Re: [virtio-comment] [PATCH] makediff: make it work for fresh checkout

2023-03-02 Thread Cornelia Huck
in > --- > makediff.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH 0/3] Cleanup for PCI transitional common cfg

2023-02-27 Thread Cornelia Huck
On Sat, Feb 25 2023, "Michael S. Tsirkin" wrote: > On Sun, Feb 26, 2023 at 12:29:58AM +0200, Parav Pandit wrote: >> Legacy interface PCI Device layout description has following issues. >> >> 1. repeated 'structure' word >> 2. virtio header was defined the 0.9.5 spec. It is referred with >>

[virtio-dev] Re: [PATCH 0/3] Rename queue index to queue number

2023-02-27 Thread Cornelia Huck
On Thu, Feb 23 2023, Parav Pandit wrote: > 1. Currently, virtqueue is identified between driver and device > interchangeably using either number of index terminology. > > 2. Between PCI and MMIO transport the queue size (depth) is > defined as queue_size and QueueNum respectively. > > To avoid

[virtio-dev] Re: [PATCH v3 1/2] virtio-net: Describe dev cfg fields read only

2023-02-22 Thread Cornelia Huck
On Wed, Feb 22 2023, "Michael S. Tsirkin" wrote: > On Wed, Feb 22, 2023 at 01:07:07PM +0100, Cornelia Huck wrote: >> On Wed, Feb 22 2023, "Michael S. Tsirkin" wrote: >> >> > On Wed, Feb 22, 2023 at 10:01:24AM +0100, Cornelia Huck wrote: >> &

[virtio-dev] Re: [PATCH v3 1/2] virtio-net: Describe dev cfg fields read only

2023-02-22 Thread Cornelia Huck
On Wed, Feb 22 2023, "Michael S. Tsirkin" wrote: > On Wed, Feb 22, 2023 at 10:01:24AM +0100, Cornelia Huck wrote: >> On Tue, Feb 21 2023, "Michael S. Tsirkin" wrote: >> >> > On Tue, Feb 21, 2023 at 05:59:52PM +, Parav Pandit wrote: >>

[virtio-dev] Re: [PATCH v3 1/2] virtio-net: Describe dev cfg fields read only

2023-02-22 Thread Cornelia Huck
On Tue, Feb 21 2023, "Michael S. Tsirkin" wrote: > On Tue, Feb 21, 2023 at 05:59:52PM +, Parav Pandit wrote: >> >> > From: Michael S. Tsirkin >> > Sent: Tuesday, February 21, 2023 12:52 PM >> > >> > On Tue, Feb 21, 2023 at 05:50:09PM +, Parav Pandit wrote: >> > > Hence, it should be

[virtio-dev] Re: [PATCH v3 1/2] virtio-net: Describe dev cfg fields read only

2023-02-21 Thread Cornelia Huck
On Fri, Feb 17 2023, Parav Pandit wrote: > Device configuration fields are read only. Avoid duplicating this > description for multiple fields. > > Instead describe it one time and do it in the driver requirements > section. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/161 >

Re: [virtio-dev] [PATCH v3] virtio-net: Mention VIRTIO_NET_F_HASH_REPORT dependency on VIRTIO_NET_F_CTRL_VQ

2023-02-20 Thread Cornelia Huck
On Mon, Feb 06 2023, Alvaro Karsz wrote: > If the VIRTIO_NET_F_HASH_REPORT feature is negotiated, the driver may > send VIRTIO_NET_CTRL_MQ_HASH_CONFIG commands, thus, the control VQ > feature should be negotiated. > > --- > v2: Use SHOULD instead of Feature bit requirement, version 1.2 is

RE: [virtio-dev] Re: [virtio-comment] RE: [PATCH v6] virtio-net: Improve introductory description

2023-02-20 Thread Cornelia Huck
On Fri, Feb 17 2023, Parav Pandit wrote: > Yes, can you please withdraw the ballot [1] as it contains stale reference to > the patch? > > [1] https://www.oasis-open.org/apps/org/workgroup/virtio/ballot.php?id=3758 > > Also please create new ballot as the github link is now updated for the issue

Re: [virtio-dev] Re: [PATCH] virtio-net: define the VIRTIO_NET_F_CTRL_RX_EXTRA feature bit

2023-02-20 Thread Cornelia Huck
On Mon, Feb 20 2023, Alvaro Karsz wrote: > I didn't add the control vq feature as a feature bit requirement for > the same reason as [1]. > > If you think that we can add a feature bit requirement instead of > "SHOULD NOT offer" and "SHOULD NOT negotiate", I can add it in v2. > > [1]

[virtio-dev] Re: [PATCH v6] virtio-net: Improve introductory description

2023-02-16 Thread Cornelia Huck
On Thu, Feb 16 2023, "Michael S. Tsirkin" wrote: > On Thu, Feb 16, 2023 at 02:30:03PM +, Parav Pandit wrote: >> >> > From: Cornelia Huck >> > Sent: Thursday, February 16, 2023 9:10 AM >> > >> > On Tue, Feb 14 2023, Parav Pandit w

[virtio-dev] Re: [PATCH 5/6] transport-mmio: Correct spelling errors

2023-02-16 Thread Cornelia Huck
On Fri, Feb 03 2023, Parav Pandit wrote: > Now that we have individual files, fix reported spelling errors. > > While at it, remove extra white space at end of line. > > Signed-off-by: Parav Pandit > --- > transport-mmio.tex | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-)

[virtio-dev] Re: [PATCH v6] virtio-net: Improve introductory description

2023-02-16 Thread Cornelia Huck
On Tue, Feb 14 2023, Parav Pandit wrote: > The control VQ of the virtio network device is used beyond advance > steering control. The control VQ dynamically changes multiple features > of the initialized device. > > Hence, update this area of control VQ introductory description at few > places

[virtio-dev] Re: [PATCH] changelog: Fix missing reference to driver notifications

2023-02-16 Thread Cornelia Huck
On Thu, Feb 16 2023, Parav Pandit wrote: > Cited commit in fixes tag missed to update the reference to drivers > notifications section in past change log. > Fix the reference. > > Fixes: be2ce1ee17e0 ("content.tex Fix Driver notifications label") > Signed-off-by: Parav Pandit > --- > cl-os.tex

[virtio-dev] Re: [PATCH] content.tex Fix Driver notifications label

2023-02-15 Thread Cornelia Huck
On Wed, Feb 15 2023, "Michael S. Tsirkin" wrote: > On Wed, Feb 15, 2023 at 01:19:25PM +0100, Cornelia Huck wrote: >> On Wed, Feb 15 2023, "Michael S. Tsirkin" wrote: >> >> > On Fri, Feb 10, 2023 at 12:23:14PM +0100, Cornelia Huck wrote: &g

[virtio-dev] Re: [PATCH] content.tex Fix Driver notifications label

2023-02-15 Thread Cornelia Huck
On Wed, Feb 15 2023, "Michael S. Tsirkin" wrote: > On Fri, Feb 10, 2023 at 12:23:14PM +0100, Cornelia Huck wrote: >> On Fri, Feb 03 2023, Parav Pandit wrote: >> >> > Driver notifications section is under "Basic Facilities of a Virtio >> > Device&

[virtio-dev] Re: [virtio] Re: [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-02-14 Thread Cornelia Huck
On Mon, Feb 13 2023, "Michael S. Tsirkin" wrote: > On Mon, Feb 13, 2023 at 02:13:43PM +0100, Cornelia Huck wrote: >> On Mon, Feb 13 2023, Max Gurtovoy wrote: >> >> > On 13/02/2023 14:42, Cornelia Huck wrote: >> >> On Mon, Feb 13 2023, Max Gurt

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-02-13 Thread Cornelia Huck
On Mon, Feb 13 2023, Max Gurtovoy wrote: > On 13/02/2023 15:13, Cornelia Huck wrote: >> On Mon, Feb 13 2023, Max Gurtovoy wrote: >> >>> On 13/02/2023 14:42, Cornelia Huck wrote: >>>> On Mon, Feb 13 2023, Max Gurtovoy wrote: >>>> >

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-02-13 Thread Cornelia Huck
On Mon, Feb 13 2023, Max Gurtovoy wrote: > On 13/02/2023 14:42, Cornelia Huck wrote: >> On Mon, Feb 13 2023, Max Gurtovoy wrote: >> >>> On 13/02/2023 10:16, Michael S. Tsirkin wrote: >>>> On Mon, Feb 13, 2023 at 02:54:47AM +0200, Max Gurtovoy wrote: >

[virtio-dev] Re: [virtio] Re: [PATCH v10 10/10] ccw: document more reserved features

2023-02-13 Thread Cornelia Huck
On Mon, Feb 13 2023, Cornelia Huck wrote: > On Thu, Feb 09 2023, "Michael S. Tsirkin" wrote: > >> vq reset and shared memory are unsupported, too. >> >> Signed-off-by: Michael S. Tsirkin >> --- >> >> >> This is not strictly part of thi

[virtio-dev] Re: [PATCH v10 10/10] ccw: document more reserved features

2023-02-13 Thread Cornelia Huck
On Thu, Feb 09 2023, "Michael S. Tsirkin" wrote: > vq reset and shared memory are unsupported, too. > > Signed-off-by: Michael S. Tsirkin > --- > > > This is not strictly part of this patchset, but just to > give you the idea of how we can expand this down the road. We could split this out to

[virtio-dev] Re: [PATCH v10 07/10] ccw: document ADMIN_VQ as reserved

2023-02-13 Thread Cornelia Huck
tral place, but it > does not hurt to remind implementers to mask it. > > Note: there are more features to add to this list. > Will be done later with a patch on top. > > Signed-off-by: Michael S. Tsirkin > --- > content.tex | 12 > 1 file c

[virtio-dev] Re: [virtio-comment] Re: [PATCH v10 03/10] admin: introduce group administration commands

2023-02-13 Thread Cornelia Huck
On Mon, Feb 13 2023, Max Gurtovoy wrote: > On 13/02/2023 10:16, Michael S. Tsirkin wrote: >> On Mon, Feb 13, 2023 at 02:54:47AM +0200, Max Gurtovoy wrote: For some system calls and library functions (e.g., getpriority(2)), -1 is a valid return on success. In such cases,

[virtio-dev] Re: [PATCH v10 02/10] admin: introduce device group and related concepts

2023-02-13 Thread Cornelia Huck
On Thu, Feb 09 2023, "Michael S. Tsirkin" wrote: > +A member identifier for this group can have a value 0x1 to 0x > +and equals the SR-IOV VF number of the member device (see > +\hyperref[intro:PCIe]{[PCIe]}). Maybe "a value from 0x1 to 0x" or "a value between 0x1 and 0x

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] [PATCH v10 01/10] virtio: document forward compatibility guarantees

2023-02-13 Thread Cornelia Huck
On Thu, Feb 09 2023, David Edmondson wrote: > On Thursday, 2023-02-09 at 07:13:32 -05, Michael S. Tsirkin wrote: >> +In particular, this is >> +especially important for features limited to specific transports, >> +as enabling these for more transports in future versions of the >> +specification

[virtio-dev] Re: [PATCH] content.tex Fix Driver notifications label

2023-02-10 Thread Cornelia Huck
On Fri, Feb 03 2023, Parav Pandit wrote: > Driver notifications section is under "Basic Facilities of a Virtio > Device". However, the label is placed under "Virtqueues" section. > > Fix the label references. > > Signed-off-by: Parav Pandit > --- > content.tex | 14 +++--- > 1 file

[virtio-dev] Re: [PATCH v3] virtio-net: Improve introductory description

2023-02-09 Thread Cornelia Huck
On Thu, Feb 09 2023, "Michael S. Tsirkin" wrote: > On Thu, Feb 09, 2023 at 03:41:08AM +0200, Parav Pandit wrote: >> @@ -389,8 +392,8 @@ \subsection{Device Operation}\label{sec:Device Types / >> Network Device / Device O >> }; >> \end{lstlisting} >> >> -The controlq is used to control device

[virtio-dev] Re: [PATCH v3] virtio-net: Improve introductory description

2023-02-09 Thread Cornelia Huck
On Thu, Feb 09 2023, Parav Pandit wrote: > The control VQ of the virtio network device is used beyond advance > steering control. The control VQ dynamically changes multiple features > of the initialized device. > > Hence, update this area of control VQ introductory description at few > places

[virtio-dev] RE: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Cornelia Huck
On Tue, Feb 07 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Tuesday, February 7, 2023 8:49 AM >> >> On Fri, Feb 03 2023, Parav Pandit wrote: >> >> > Currently some fields of the virtio_net_config structure are defined >> > befor

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-02-07 Thread Cornelia Huck
On Tue, Feb 07 2023, Alexandre Courbot wrote: > On Mon, Feb 6, 2023 at 11:13 PM Cornelia Huck wrote: >> >> On Thu, Jan 19 2023, Alexander Gordeev >> wrote: >> >> > Hi Alexandre, >> > >> > On 12.01.23 07:39, Alexandre Courbot wrote: &

[virtio-dev] Re: [PATCH] virtio-net: Define configuration field layout before its description

2023-02-07 Thread Cornelia Huck
On Fri, Feb 03 2023, Parav Pandit wrote: > Currently some fields of the virtio_net_config structure are defined > before introducing the structure and some are defined after > introducing virtio_net_config. > Better to define the configuration layout first followed by > description of all the

[virtio-dev] Re: [PATCH v2] virtio-net: Improve introductory description

2023-02-07 Thread Cornelia Huck
On Thu, Feb 02 2023, Parav Pandit wrote: > The control VQ of the virtio network device is used beyond advance > steering control. The control VQ dynamically changes multiple features > of the initialized device. > > Hence, update this area of control VQ introductory description at few > places

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-02-06 Thread Cornelia Huck
On Thu, Jan 19 2023, Alexander Gordeev wrote: > Hi Alexandre, > > On 12.01.23 07:39, Alexandre Courbot wrote: >> On Thu, Jan 12, 2023 at 3:42 AM Alexander Gordeev >> wrote: >>> Well, on the one hand mimicking v4l2 looks like an easy solution from >>> virtio-video spec writing perspective.

[virtio-dev] Re: [PATCH v1] virtio-net: Improve introductory description

2023-02-01 Thread Cornelia Huck
On Mon, Jan 23 2023, Parav Pandit wrote: > The control VQ of the virtio network device is used beyond advance > steering control. The control VQ dynamically changes multiple features > of the initialized device. > > Hence, update this area of control VQ introductory description at few > places

[virtio-dev] Re: [PATCH] virtio-net: Avoid confusing device configuration text

2023-01-30 Thread Cornelia Huck
On Thu, Jan 26 2023, Parav Pandit wrote: > The added text in commit of Fixes tag was redundant and > confusing in context of VLAN filtering description. > > Hence remove it as discussed in [1] and [2]. > > [1] https://lists.oasis-open.org/archives/virtio-dev/202301/msg00282.html > [2]

[virtio-dev] Re: [PATCH] virtio-net: Improve control vq introductory description

2023-01-23 Thread Cornelia Huck
On Mon, Jan 23 2023, Parav Pandit wrote: > The control VQ of the virtio network device is used for controlling > multiple features, not just advanced steering control. The control VQ > dynamically changes multiple features of the initialized device. > > Hence, update this area of control VQ

[virtio-dev] Re: [virtio-comment] Re: [PATCH v7] virtio-net: support inner header hash

2023-01-16 Thread Cornelia Huck
On Mon, Jan 16 2023, Heng Qi wrote: > On Wed, Jan 11, 2023 at 04:45:12AM -0500, Michael S. Tsirkin wrote: >> On Wed, Jan 04, 2023 at 03:14:01PM +0800, Heng Qi wrote: >> > @@ -3386,7 +3391,8 @@ \subsection{Device Operation}\label{sec:Device Types >> > / Network Device / Device O >> >

[virtio-dev] Re: [virtio-comment] [PATCH v4 00/20] Split device spec to its individual files

2023-01-13 Thread Cornelia Huck
On Thu, Jan 12 2023, Parav Pandit wrote: > Relatively several of the recent device specifications are maintained > in their own specification file. Such separate files enables better > maintenance of the specification overall. > However, several of the initial virtio device specifications > are

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-12 Thread Cornelia Huck
On Thu, Jan 12 2023, Halil Pasic wrote: > On Thu, 12 Jan 2023 15:30:58 +0100 > Cornelia Huck wrote: > >> >> >> >> I like that: we don't want to talk about hosts/VMMs/etc. as we >> >> fundamentally deal with devices and drivers, but sharing between g

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-12 Thread Cornelia Huck
On Thu, Jan 12 2023, Alexandre Courbot wrote: > Hi Cornelia, > > On Wed, Jan 11, 2023 at 5:45 PM Cornelia Huck wrote: >> >> > + >> >> > +The device MUST set the \field{caps_length} field to a value equal to >> >> > +the response size of VIRT

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-12 Thread Cornelia Huck
On Thu, Jan 12 2023, Xuan Zhuo wrote: > On Thu, 12 Jan 2023 09:42:05 +0100, Cornelia Huck wrote: >> On Thu, Jan 12 2023, "Michael S. Tsirkin" wrote: >> >> > On Thu, Jan 12, 2023 at 10:01:25AM +0800, Jason Wang wrote: >> >> On We

Re: [virtio-dev] [PATCH v2 1/1] virtio-ism: introduce new device virtio-ism

2023-01-12 Thread Cornelia Huck
roduce a catchy name for the >> > > > "entity that launched the VMs" and prevent oversimplification by >> > > > explaining any shortcomings of the name if any in one place. Host would >> > > > be one candidate, VMM another. &g

Re: [virtio-dev] [PATCH v3 06/20] virtio-mem-balloon: Maintain mem balloon device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, David Hildenbrand wrote: > On 11.01.23 16:01, Parav Pandit wrote: >> Hi David, > > Hi Parav, > >> >>> From: David Hildenbrand >>> Sent: Wednesday, January 11, 2023 9:14 AM >>> To: Parav Pandit ; m...@redhat.com; >>> virtio-dev@lists.oasis- >>> open.org; coh...@redhat.com

[virtio-dev] Re: [PATCH v3 11/20] virtio-vsock: Maintain socket device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [PATCH v3 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-11 Thread Cornelia Huck
On Wed, Jan 11 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2023-01-11 Thread Cornelia Huck
On Tue, Dec 27 2022, Alexandre Courbot wrote: > Hi Cornelia, thanks for the feedback! I have directly reported the > comments snipped from this answer to the source document. > > On Fri, Dec 9, 2022 at 12:01 AM Cornelia Huck wrote: >> >> On Thu, Dec 08 2022,

RE: [virtio-dev] Re: [PATCH v2 00/20] Split device spec to its individual files

2023-01-10 Thread Cornelia Huck
On Tue, Jan 10 2023, Parav Pandit wrote: >> From: Cornelia Huck >> Sent: Tuesday, January 10, 2023 10:21 AM >> >> On Tue, Jan 10 2023, Parav Pandit wrote: >> >> >> From: virtio-dev@lists.oasis-open.org >> >> On Behalf Of Cornelia Huc

RE: [virtio-dev] Re: [PATCH v2 00/20] Split device spec to its individual files

2023-01-10 Thread Cornelia Huck
On Tue, Jan 10 2023, Parav Pandit wrote: >> From: virtio-dev@lists.oasis-open.org On >> Behalf Of Cornelia Huck >> >> On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: >> > Does makediff still work? Documentation says latexpand does not >&g

[virtio-dev] Re: [PATCH v2 00/20] Split device spec to its individual files

2023-01-10 Thread Cornelia Huck
On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > On Mon, Jan 09, 2023 at 06:28:29PM +0200, Parav Pandit wrote: >> Relatively several of the recent device specifications are maintained >> in their own specification file. Such separate files enables better >> maintenance of the specification

Re: [virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Mon, Jan 09 2023, Cornelia Huck wrote: > On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > >> On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: >>> On Sun, Jan 01 2023, Parav Pandit wrote: >>> >>> > Place device specificati

[virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Mon, Jan 09 2023, "Michael S. Tsirkin" wrote: > On Mon, Jan 09, 2023 at 01:48:27PM +0100, Cornelia Huck wrote: >> On Sun, Jan 01 2023, Parav Pandit wrote: >> >> > Place device specification, its driver and device >> > conformance into its

[virtio-dev] Re: [virtio-comment] [PATCH v1 19/20] virtio-gpio: Maintain gpio device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 17/20] virtio-i2c: Maintain i2c device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 15/20] virtio-sound: Maintain sound device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [virtio-comment] [PATCH v1 13/20] virtio-rpmb: Maintain rpmb device spec in separate directory

2023-01-09 Thread Cornelia Huck
On Sun, Jan 01 2023, Parav Pandit wrote: > Place device specification, its driver and device > conformance into its own directory to have self contained device > specification. > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/153 > Signed-off-by: Parav Pandit > --- > changelog: >

[virtio-dev] Re: [PATCH v4] virtio_net: support inner header hash

2022-12-22 Thread Cornelia Huck
On Wed, Dec 21 2022, Heng Qi wrote: > If the tunnel is used to encapsulate the packets, the hash calculated > using the outer header of the receive packets is always fixed for the > same flow packets, i.e. they will be steered to the same receive queue. > > We add a tunnel feature bit

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2022-12-20 Thread Cornelia Huck
On Tue, Dec 20 2022, Alexander Gordeev wrote: > Hello Cornelia, > > On 20.12.22 10:51, Cornelia Huck wrote: >> On Mon, Dec 19 2022, Alexander Gordeev >> wrote: >> >>> Hello Alexandre, >>> >>> Thanks for the update. Please check m

Re: [virtio-dev] Re: [RFC PATCH v6] virtio-video: Add virtio video device specification

2022-12-20 Thread Cornelia Huck
On Mon, Dec 19 2022, Alexander Gordeev wrote: > Hello Alexandre, > > Thanks for the update. Please check my comments below. > I'm new to the virtio video spec development, so I may lack some > historic perspective. I would gladly appreciate pointing me to some > older emails explaining

Re: [virtio-dev] Re: [PATCH v3] virtio_net: support inner header hash

2022-12-14 Thread Cornelia Huck
If the reviewers do not have more comments on >> I plan to review this no later than the end of this week. > > Okay, I see. > > @Cornelia Huck, Although I have submitted the voting issue, please wait > for a while for @Jason Wang to review, thank you. Ack, will do. (I'm not

Re: [virtio-dev] [RFC PATCH v6] virtio-video: Add virtio video device specification

2022-12-08 Thread Cornelia Huck
On Thu, Dec 08 2022, Alexandre Courbot wrote: > Add the specification of the video decoder and encoder devices, which > can be used to provide host-accelerated video operations to the guest. > > Signed-off-by: Keiichi Watanabe > Signed-off-by: Alexandre Courbot > -- > Here is the long-overdue

[virtio-dev] Re: [PATCH v9 09/10] admin: conformance clauses

2022-11-25 Thread Cornelia Huck
On Fri, Nov 25 2022, "Michael S. Tsirkin" wrote: > On Fri, Nov 25, 2022 at 12:42:23PM +0100, Cornelia Huck wrote: >> On Fri, Nov 25 2022, Jason Wang wrote: >> >> > 在 2022/11/24 16:36, Michael S. Tsirkin 写道: >> >> On Thu, Nov 24, 2022 at 02:51:21PM

[virtio-dev] Re: [PATCH v9 09/10] admin: conformance clauses

2022-11-25 Thread Cornelia Huck
On Fri, Nov 25 2022, Jason Wang wrote: > 在 2022/11/24 16:36, Michael S. Tsirkin 写道: >> On Thu, Nov 24, 2022 at 02:51:21PM +0800, Jason Wang wrote: >>> On Thu, Nov 24, 2022 at 5:08 AM Michael S. Tsirkin wrote: +The device MUST NOT fail a command solely because the buffers +provided are

<    1   2   3   4   5   6   7   >