Re: [virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Heng Qi
在 2023/2/8 下午11:04, Parav Pandit 写道: From: Michael S. Tsirkin Sent: Wednesday, February 8, 2023 9:48 AM On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, February 8, 2023 9:43 AM On Wed, Feb 08, 2023 at 02:37:55PM +, Parav

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Heng Qi
在 2023/2/9 上午4:52, Michael S. Tsirkin 写道: On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote: > > From: Michael S. Tsirkin Sent: Wednesday, February 8, 2023 9:48 AM On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday,

Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Heng Qi
在 2023/2/9 上午6:35, Alvaro Karsz 写道: From: Alvaro Karsz Sent: Wednesday, February 8, 2023 4:56 PM Alvaro, Do you know if any software used it? Can you get some real data? I implemented this feature in our DPU, so at least 1 vendor is using this feature But which software (virtio net

Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Heng Qi
在 2023/2/9 上午1:53, Alvaro Karsz 写道: > > From: Michael S. Tsirkin Sent: Wednesday, February 8, 2023 9:48 AM On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: From: Michael S. Tsirkin Sent: Wednesday, February 8, 2023 9:43 AM On Wed, Feb 08, 2023 at 02:37:55PM +, Parav

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Alvaro Karsz > Sent: Wednesday, February 8, 2023 5:36 PM > > > > From: Alvaro Karsz > > > Sent: Wednesday, February 8, 2023 4:56 PM > > > > > > Alvaro, > > > > Do you know if any software used it? Can you get some real data? > > > > > > I implemented this feature in our DPU, so at

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Thu, Feb 09, 2023 at 12:35:42AM +0200, Alvaro Karsz wrote: > > > From: Alvaro Karsz > > > Sent: Wednesday, February 8, 2023 4:56 PM > > > > > > Alvaro, > > > > Do you know if any software used it? Can you get some real data? > > > > > > I implemented this feature in our DPU, so at least 1

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Thu, Feb 09, 2023 at 12:45:42AM +0200, Alvaro Karsz wrote: > Maybe we should do something more future friendly. > We may want to add more coalescing related features in the future. > * Maybe max/min sets? > * Maybe to offload the adaptive algo to the DPU? > > It will require more feature

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Alvaro Karsz
Maybe we should do something more future friendly. We may want to add more coalescing related features in the future. * Maybe max/min sets? * Maybe to offload the adaptive algo to the DPU? It will require more feature bits.. We could rename this new feature from VIRTIO_NET_F_PERQUEUE_NOTF_COAL

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Alvaro Karsz
> > From: Alvaro Karsz > > Sent: Wednesday, February 8, 2023 4:56 PM > > > > Alvaro, > > > Do you know if any software used it? Can you get some real data? > > > > I implemented this feature in our DPU, so at least 1 vendor is using this > > feature > > But which software (virtio net driver) in

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 5:29 PM > > On Wed, Feb 08, 2023 at 10:23:00PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > > Sent: Wednesday, February 8, 2023 5:16 PM > > > > > Not having this feature/command even complicates things now that >

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 10:23:00PM +, Parav Pandit wrote: > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 5:16 PM > > > > Not having this feature/command even complicates things now that we > > > > are talking about removing the RX and TX from the per vq command, > > > >

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 5:16 PM > > > Not having this feature/command even complicates things now that we > > > are talking about removing the RX and TX from the per vq command, > > > how do you change parameters to all TX queues? to all RX queues? > > >

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 10:08:41PM +, Parav Pandit wrote: > > > From: Alvaro Karsz > > Sent: Wednesday, February 8, 2023 4:56 PM > > > > Alvaro, > > > Do you know if any software used it? Can you get some real data? > > > > I implemented this feature in our DPU, so at least 1 vendor is

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 09:05:47PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 3:52 PM > > > > On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote: > > > > > From: Michael S. Tsirkin > > > > > Sent: Wednesday, February 8, 2023 9:48

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Alvaro Karsz > Sent: Wednesday, February 8, 2023 4:56 PM > > Alvaro, > > Do you know if any software used it? Can you get some real data? > > I implemented this feature in our DPU, so at least 1 vendor is using this > feature But which software (virtio net driver) in which OS is

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Alvaro Karsz
> > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 3:52 PM > > > > On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote: > > > > > From: Michael S. Tsirkin > > > > > Sent: Wednesday, February 8, 2023 9:48 AM > > > > > > > > > > On Wed, Feb 08, 2023 at 02:44:37PM +,

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Alvaro Karsz
> On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, February 8, 2023 9:48 AM > > > > > > > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: > > > > > > > > > > > From: Michael S. Tsirkin > > > > > > Sent:

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 3:52 PM > > On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote: > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, February 8, 2023 9:48 AM > > > > > > > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 07:53:09PM +0200, Alvaro Karsz wrote: > > > From: Michael S. Tsirkin > > > Sent: Wednesday, February 8, 2023 9:48 AM > > > > > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: > > > > > > > > > From: Michael S. Tsirkin > > > > > Sent: Wednesday, February

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 07:23:12PM +, Parav Pandit wrote: > You are right. Two commands are there. > Regardless the ambiguity remains > ━━━ > From: Parav Pandit > Sent: Wednesday, February 8, 2023 8:57 PM > To: Michael

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
You are right. Two commands are there. Regardless the ambiguity remains From: Parav Pandit Sent: Wednesday, February 8, 2023 8:57 PM To: Michael S. Tsirkin Cc: Heng Qi ; Xuan Zhuo ; virtio-comment @ lists . oasis-open . org ; virtio-dev @ lists . oasis-open .

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Alvaro Karsz
> > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 9:48 AM > > > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, February 8, 2023 9:43 AM > > > > > > > > On Wed, Feb 08, 2023 at 02:37:55PM +,

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 10:20 AM [..] > > > > Most performant data path wouldn't implement and read the extra mode. > > It is always fw that is going to program same value, or per queue valued or > disable value in each Q regardless whichever way we

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 03:04:03PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 9:48 AM > > > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, February 8, 2023

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 9:48 AM > > On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > > Sent: Wednesday, February 8, 2023 9:43 AM > > > > > > On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 02:44:37PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 9:43 AM > > > > On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote: > > > > > > > From: Michael S. Tsirkin > > > > Sent: Wednesday, February 8, 2023 9:18

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 9:43 AM > > On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote: > > > > > From: Michael S. Tsirkin > > > Sent: Wednesday, February 8, 2023 9:18 AM > > > > > > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote: > >

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 9:18 AM > > > > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote: > > > > I see two options. > > > > 1. Just have per VQ params. Software has the full

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 02:37:55PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Wednesday, February 8, 2023 9:18 AM > > > > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote: > > > > I see two options. > > > > 1. Just have per VQ params. Software has the full

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, February 8, 2023 9:18 AM > > On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote: > > > I see two options. > > > 1. Just have per VQ params. Software has the full knowledge of in which > > > it is > operating, and state remains at software

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 07:30:34PM +0800, Heng Qi wrote: > > I see two options. > > 1. Just have per VQ params. Software has the full knowledge of in which it > > is operating, and state remains at software level. > > This effectively achieves both the mode. > > > > 2. Have a mode cmd, > > Mode

[virtio-dev] Re: [virtio-comment] Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 07:23:10PM +0800, Heng Qi wrote: > > > 在 2023/2/8 下午6:04, Michael S. Tsirkin 写道: > > On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote: > > > > > > 在 2023/2/7 下午10:06, Michael S. Tsirkin 写道: > > > > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > > > > >

Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Heng Qi
在 2023/2/8 下午6:10, Michael S. Tsirkin 写道: On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote: I think it's a good idea to do this on top of Alvaro's patch unifying these two structures. I saw Alvaro's patch, but it doesn't seem to be stable yet, is there a good way for me to unify the

Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote: > > I think it's a good idea to do this on top of Alvaro's patch > > unifying these two structures. > > I saw Alvaro's patch, but it doesn't seem to be stable yet, is there a good > way for me to > unify the two structures, since a patch

Re: [virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-08 Thread Michael S. Tsirkin
On Wed, Feb 08, 2023 at 09:57:54AM +0800, Heng Qi wrote: > > > 在 2023/2/7 下午10:06, Michael S. Tsirkin 写道: > > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > > > Currently, the coalescing profile is directly applied to all queues. > > > This patch supports configuring the parameters

RE: [virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Heng Qi > Sent: Tuesday, February 7, 2023 9:36 PM > > > 在 2023/2/8 上午10:20, Parav Pandit 写道: > >> From: Xuan Zhuo > >> Sent: Tuesday, February 7, 2023 8:46 PM > >> > >> On Tue, 7 Feb 2023 09:06:19 -0500, "Michael S. Tsirkin" > >> > >> wrote: > >>> On Tue, Feb 07, 2023 at 07:16:34PM

[virtio-dev] RE: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Parav Pandit
> From: Xuan Zhuo > Sent: Tuesday, February 7, 2023 8:46 PM > > On Tue, 7 Feb 2023 09:06:19 -0500, "Michael S. Tsirkin" > wrote: > > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > > > Currently, the coalescing profile is directly applied to all queues. > > > This patch supports

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 09:06:24AM -0500, Michael S. Tsirkin wrote: > On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > > Currently, the coalescing profile is directly applied to all queues. > > This patch supports configuring the parameters for a specified queue. > > > > When the

[virtio-dev] Re: [virtio-comment] [PATCH] virtio-net: support per-queue coalescing moderation

2023-02-07 Thread Michael S. Tsirkin
On Tue, Feb 07, 2023 at 07:16:34PM +0800, Heng Qi wrote: > Currently, the coalescing profile is directly applied to all queues. > This patch supports configuring the parameters for a specified queue. > > When the traffic between queues is unbalanced, for example, one queue > is busy and another