[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-21 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Wednesday, June 21, 2023 11:56 AM > Not like v3 please. If you want to re-open this: > > > First I think we need multiple offsets just like notification capaiblity, > sorted by > priority. Second I think we need ability to report offset within owner not >

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-21 Thread Michael S. Tsirkin
On Wed, Jun 21, 2023 at 03:50:00PM +, Parav Pandit wrote: > > > > From: Parav Pandit > > Sent: Tuesday, June 20, 2023 10:12 AM > > > > Michael, > > > > > From: Parav Pandit > > > Sent: Monday, June 19, 2023 2:07 PM > > > We don't need to do it now. > > > > > > > Current VF capability is ki

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-21 Thread Parav Pandit
> From: Parav Pandit > Sent: Tuesday, June 20, 2023 10:12 AM > > Michael, > > > From: Parav Pandit > > Sent: Monday, June 19, 2023 2:07 PM > > We don't need to do it now. > > > > > Current VF capability is kind of ok I guess ... > > > > > Already proposed one? > > > > > If you want admin comm

Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Michael S. Tsirkin
On Wed, Jun 21, 2023 at 01:09:40AM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Tuesday, June 20, 2023 6:22 AM > > > > On Tue, Jun 20, 2023 at 12:14:16AM +, Parav Pandit wrote: > > > > > > > > > > From: virtio-dev@lists.oasis-open.org > > > > On Behalf Of Michael S

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Tuesday, June 20, 2023 6:22 AM > > On Tue, Jun 20, 2023 at 12:14:16AM +, Parav Pandit wrote: > > > > > > > From: virtio-dev@lists.oasis-open.org > > > On Behalf Of Michael S. Tsirkin > > > Sent: Monday, June 19, 2023 1:46 PM > > > > > These devices have

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Parav Pandit
Michael, > From: Parav Pandit > Sent: Monday, June 19, 2023 2:07 PM > We don't need to do it now. > > > Current VF capability is kind of ok I guess ... > > > Already proposed one? > > > If you want admin command to query then it would need to map in PF > memory. > No need. > It is similar to

Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-20 Thread Michael S. Tsirkin
On Tue, Jun 20, 2023 at 12:14:16AM +, Parav Pandit wrote: > > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:46 PM > > > These devices have a legacy interface yes? > Yes. partially. > > > So they should be transitional to avo

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:46 PM > These devices have a legacy interface yes? Yes. partially. > So they should be transitional to avoid breaking assumption. > > > But they are not *exactly* > in that they don't h

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 12:17 PM > I'd love to just put this stuff in a separate tex document and just link > there from > the generic thing. > Or if it's too hard, please create new sections for this stuff. But in this > case each > of these sections has to s

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 2:01 PM > > That flexibility is better gained via AQ instead of introducing new extended > capability on the VF. > > To be frank for e.g. transport vq we'll need to do it with admin command (can > we stop saying AQ please? it's a habit t

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:58 PM > > AQ command on the PF is self-contained and extendible without baking things > in very low level hw centric pci capabilities, which are hard to get rid of > it. > > I worry about systems where there's value in having VF drive

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:45:17PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:38 PM > > > > > If we can't just make it come for free then maybe > > > > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the > > > > number in the commo

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:45:17PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:38 PM > > > > > If we can't just make it come for free then maybe > > > > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the > > > > number in the commo

Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:35:04PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:26 PM > > > > > Also these devices will use non-transitional ID but they in fact do > > > > have a legacy interface so using this definition they are > > > > transiti

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:38 PM > > > If we can't just make it come for free then maybe > > > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG is better, we can just list the > > > number in the common section and then link to the description in the new > section. > > > > > Ho

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:26:22PM +, Parav Pandit wrote: > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:20 PM > > > > It is reused, but it doesnt come for free. > > > Do you want to re-consider AQ notify query command? > > > Or continue as proposed in v6? > > > > > > If

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:26 PM > > > Also these devices will use non-transitional ID but they in fact do > > > have a legacy interface so using this definition they are > > > transitional devices. Maybe we need to add when we describe the > > > device ID text

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:20 PM > > It is reused, but it doesnt come for free. > > Do you want to re-consider AQ notify query command? > > Or continue as proposed in v6? > > > If we can't just make it come for free then maybe > VIRTIO_PCI_CAP_LEGACY_NOTIFY_CFG

Re: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 05:11:19PM +, Parav Pandit wrote: > > > > From: virtio-dev@lists.oasis-open.org On > > Behalf Of Michael S. Tsirkin > > Sent: Monday, June 19, 2023 1:04 PM > > > On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > > > +Even though virtqueue driver notific

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Mon, Jun 19, 2023 at 04:39:16PM +, Parav Pandit wrote: > > > > From: Michael S. Tsirkin > > Sent: Monday, June 19, 2023 12:38 PM > > > > > > > +\field{legacy_q_notify_supported} when set to 1, indicates that the > > > +device supports legacy queue notifications at this notification > > >

RE: [virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: virtio-dev@lists.oasis-open.org On > Behalf Of Michael S. Tsirkin > Sent: Monday, June 19, 2023 1:04 PM > On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > > +Even though virtqueue driver notifications can be communicated > > +through administration virtqueue, if the grou

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > +Even though virtqueue driver notifications can be communicated through > +administration virtqueue, if the group member device support such > +notifications using a memory-mapped operation, such driver notifications > +are sent using

[virtio-dev] RE: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Parav Pandit
> From: Michael S. Tsirkin > Sent: Monday, June 19, 2023 12:38 PM > > > > +\field{legacy_q_notify_supported} when set to 1, indicates that the > > +device supports legacy queue notifications at this notification > > +location. Legacy Queue Notification address is derived within a BAR for a > v

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > --- a/transport-pci.tex > +++ b/transport-pci.tex > @@ -541,6 +541,8 @@ \subsubsection{Notification structure > layout}\label{sec:Virtio Transport Options > struct virtio_pci_notify_cap { > struct virtio_pci_cap cap; >

[virtio-dev] Re: [PATCH v6 4/4] transport-pci: Introduce group legacy group member config region access

2023-06-19 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 08:30:15PM +0300, Parav Pandit wrote: > This patch links how in a PCI transport a group owner can access group > member (PCI VFs) legacy registers using a legacy registers access > commands using administration virtqueue infrastructure. > > Additionally it extend the PCI no