Re: [virtio-dev] Re: queue_reset register polarity to improve

2022-04-25 Thread Cornelia Huck
On Sun, Apr 24 2022, "Michael S. Tsirkin" wrote: > On Sun, Apr 24, 2022 at 12:49:19AM +, Parav Pandit wrote: >> Hi, >> >> A recently defined queue_reset register has a little weird definition that >> we should improve. >> When driver initiate queue reset, it writes queue_reset = 1. >> When

[virtio-dev] Re: [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-27 Thread Cornelia Huck
On Wed, Apr 27 2022, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to return 1 when qu

RE: [virtio-dev] [PATCH v2] virtio: Improve queue_reset polarity to match to default reset state

2022-04-28 Thread Cornelia Huck
On Thu, Apr 28 2022, Parav Pandit wrote: > All above comments are taken care now with Cornelia's wording for your input > and by correctly updating device side section now. > Sending v3. Honestly, I think it's a bit early for sending a v3 already, since it seems we've not reached complete agree

[virtio-dev] Re: [PATCH v4] virtio: Improve queue_reset polarity to match to default reset state

2022-04-29 Thread Cornelia Huck
On Fri, Apr 29 2022, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to return 1 when qu

[virtio-dev] Re: [virtio] [PATCH] acknowledgements: update for 1.2

2022-05-02 Thread Cornelia Huck
pecification and are gratefully acknowledged: > > +\subsection*{Participants} > +Alexander Duyck, Intel \newline > +Alex Bennée, Linaro \newline > +Anton Yakovlev, OpenSynergy \newline > +Arseny Krasnov, Kaspersky Lab \newline > +Cornelia Huck, Red Hat \newline > +David Hildenbrand,

[virtio-dev] Re: [PATCH v5] virtio: Improve queue_reset polarity to match to default reset state

2022-05-02 Thread Cornelia Huck
On Fri, Apr 29 2022, Parav Pandit wrote: > Currently when driver initiates a queue reset, device is expected > to communicate reset status to the driver by changing the value of the > queue_reset register twice. First to return value other than 1 when > reset is ongoing, later to return 1 when qu

Re: [virtio-dev] [PATCH] changelog editorial fixes

2022-05-10 Thread Cornelia Huck
gt; > Reported-by: Paul Knight > Signed-off-by: Michael S. Tsirkin > --- > cl-os.tex | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Anyway, Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: v

Re: [virtio-dev] [PATCH] editorial: use bold for title and headings

2022-05-10 Thread Cornelia Huck
in makehtml.sh for the future. > > Reported-by: Paul Knight > Signed-off-by: Michael S. Tsirkin > --- > makehtml.sh | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) I'm not familiar with .css, but Acked-by: Cornelia Huck -

Re: [virtio-dev] [PATCH] editorial: update S390 Common I/O link

2022-05-10 Thread Cornelia Huck
On Tue, May 10 2022, "Michael S. Tsirkin" wrote: > Paul Knight wrote: > > In running a link check, I noted several issues, none significant for this > initial public review publication: > - broken link in Normative references: > -- [S390 Common I/O] ESA/390 Common I/O-Device and Self-Description,

[virtio-dev] Re: [PATCH v2] editorial: update S390 Common I/O link

2022-05-10 Thread Cornelia Huck
fication. > > Reported-by: Paul Knight > Suggested-by: Halil Pasic > Signed-off-by: Michael S. Tsirkin > --- > > changes from v1: > do not tweak description just the url > > introductio

[virtio-dev] Re: [virtio-comment] RE: [PATCH v5 2/7] Introduce admin command set

2022-05-17 Thread Cornelia Huck
On Mon, May 16 2022, Parav Pandit wrote: > Hi Michael, > >> From: Michael S. Tsirkin >> Sent: Sunday, May 15, 2022 11:24 AM > > [..] > >> > +\subsection{VIRTIO ADMIN DEVICE CAPS ACCEPT >> command}\label{sec:Basic >> > +Facilities of a Virtio Device / Admin command set / VIRTIO ADMIN >> > +DEVICE

[virtio-dev] Re: [PATCH v5 5/7] Add miscellaneous configuration structure for PCI

2022-05-17 Thread Cornelia Huck
On Sun, May 15 2022, "Michael S. Tsirkin" wrote: > On Wed, Apr 27, 2022 at 01:58:22AM +0300, Max Gurtovoy wrote: >> This new structure will be used for adding new miscellaneous registers >> for a virtio device configuration layout. >> >> For now, only admin_queue_index register is added. Admin v

[virtio-dev] Re: [virtio-comment] Re: [PATCH v5 1/7] Introduce device group

2022-05-18 Thread Cornelia Huck
On Wed, May 18 2022, Max Gurtovoy wrote: > Hi MST, > > On 5/15/2022 6:25 PM, Michael S. Tsirkin wrote: >> On Wed, Apr 27, 2022 at 01:58:18AM +0300, Max Gurtovoy wrote: >>> +\subsection{Device group}\label{sec:Introduction / Terminology / Device >>> group} >>> + >>> +A device group includes one o

[virtio-dev] Re: [virtio-comment] Re: [PATCH v5 2/7] Introduce admin command set

2022-05-18 Thread Cornelia Huck
On Wed, May 18 2022, Max Gurtovoy wrote: > On 5/15/2022 6:23 PM, Michael S. Tsirkin wrote: >> On Wed, Apr 27, 2022 at 01:58:19AM +0300, Max Gurtovoy wrote: >>> This command set is used for essential administrative and management >>> operations. >>> >>> Admin commands should be submitted to a well

[virtio-dev] Re: [virtio-comment] RE: [PATCH v5 2/7] Introduce admin command set

2022-05-18 Thread Cornelia Huck
On Wed, May 18 2022, Max Gurtovoy wrote: > On 5/17/2022 2:48 PM, Michael S. Tsirkin wrote: >> On Mon, May 16, 2022 at 09:08:34PM +, Parav Pandit wrote: >>> Hi Michael, >>> From: Michael S. Tsirkin Sent: Sunday, May 15, 2022 11:24 AM >>> [..] >>> > +\subsection{VIRTIO ADMIN DEVI

Re: [virtio-dev] [PATCH v3] virtio_net: support split header

2022-06-07 Thread Cornelia Huck
On Mon, Jun 06 2022, Xuan Zhuo wrote: > The purpose of this feature is to split the header and the payload of > the packet. > > |receive buffer| > | 0th descriptor | 1th descriptor| > | virtnet hdr | mac

Re: [virtio-dev] [PATCH v5] virtio_net: support split header

2022-07-25 Thread Cornelia Huck
f used lenght if the first descriptor is skipped > in the case of merge > > v4: > 1. fix typo @Cornelia Huck @Jason Wang > 2. do not split header for IP fragmentation packet. @Jason Wang > > v3: > 1. Fix some syntax issues > 2. Fix some terminology issue

Re: [virtio-dev] Re: [PATCH] virtio_net: support split header

2022-08-04 Thread Cornelia Huck
On Thu, Aug 04 2022, Heng Qi wrote: > 在 2022/8/4 下午2:27, Jason Wang 写道: >> On Mon, Aug 1, 2022 at 2:59 PM Heng Qi wrote: >>> @@ -3820,9 +3826,13 @@ \subsubsection{Processing of Incoming >>> Packets}\label{sec:Device Types / Network >>> driver MUST NOT use the \field{csum_start} and \field{csu

Re: [virtio-dev] Re: [PATCH] virtio_net: support split header

2022-08-09 Thread Cornelia Huck
On Fri, Aug 05 2022, Heng Qi wrote: > 在 2022/8/4 下午9:50, Cornelia Huck 写道: >> On Thu, Aug 04 2022, Heng Qi wrote: >> >>> 在 2022/8/4 下午2:27, Jason Wang 写道: >>>> On Mon, Aug 1, 2022 at 2:59 PM Heng Qi wrote: >>>>> @@ -3820,9 +3826,13 @@ \

[virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-10 Thread Cornelia Huck
On Tue, Aug 09 2022, "Michael S. Tsirkin" wrote: > On Wed, Mar 30, 2022 at 04:21:02PM +0100, Usama Arif wrote: >> Driver auxiliary notifications allow the device to send notifications >> other than configuration changes and used buffer notifications to the >> driver, these are optional and their

[virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-10 Thread Cornelia Huck
On Wed, Aug 10 2022, "Michael S. Tsirkin" wrote: > On Wed, Aug 10, 2022 at 11:54:35AM +0200, Cornelia Huck wrote: >> On Tue, Aug 09 2022, "Michael S. Tsirkin" wrote: >> >> > On Wed, Mar 30, 2022 at 04:21:02PM +0100, Usama Arif wrote: >> >

Re: [virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-11 Thread Cornelia Huck
On Wed, Aug 10 2022, Halil Pasic wrote: > On Wed, 10 Aug 2022 11:54:35 +0200 > Cornelia Huck wrote: > >> >> These device-specific notifications are needed later when adding support >> >> for virtio-vhost-user device. >> >> >> >> Signed

Re: [virtio-dev] Re: [PATCH 1/4] content: Introduce driver/device auxiliary notifications

2022-08-11 Thread Cornelia Huck
On Wed, Aug 10 2022, "Michael S. Tsirkin" wrote: > On Wed, Aug 10, 2022 at 07:41:08PM +0200, Halil Pasic wrote: >> On Wed, 10 Aug 2022 11:54:35 +0200 >> Cornelia Huck wrote: >> > This highlights another problem, however: When we introduce new features >

Re: [virtio-dev] [PATCH v7] virtio_net: support split header

2022-08-25 Thread Cornelia Huck
cial for the zerocopy > implemented by the upper layer. > > Signed-off-by: Xuan Zhuo > Signed-off-by: Heng Qi > Reviewed-by: Kangjie Xu > --- > v7: > 1. Fix some presentation issues. > 2. Use "split transport header". @Jason Wang > 3. Clarif

Re: [virtio-dev] [PATCH v5] virtio-blk: add zoned block device specification

2022-08-29 Thread Cornelia Huck
On Sun, Aug 28 2022, Dmitry Fomichev wrote: > Introduce support for Zoned Block Devices to virtio. > > Zoned Block Devices (ZBDs) aim to achieve a better capacity, latency > and/or cost characteristics compared to commonly available block > devices by getting the entire LBA space of the device di

[virtio-dev] Re: [virtio] [PATCH RFC v7 6/8] ccw: disallow ADMIN_VQ

2022-08-30 Thread Cornelia Huck
[finally got around to looking at this thread] On Tue, Aug 30 2022, Halil Pasic wrote: > On Mon, 29 Aug 2022 14:28:05 -0400 > "Michael S. Tsirkin" wrote: > >> On Thu, Aug 18, 2022 at 03:39:58PM +0200, Halil Pasic wrote: > [..] >> > Fair point! >> > >> > I would prefer a driver normative which

Re: [virtio-dev] [PATCH] audio->sound

2022-09-08 Thread Cornelia Huck
ce \\ > +25 & Sound device \\ > \hline > 26 & file system device \\ > \hline Reviewed-by: Cornelia Huck Actually, under the title "Sound device", the spec says "The virtio sound card is a virtual audio device..." -- should it be &

[virtio-dev] Re: [PATCH v6] virtio-blk: add zoned block device specification

2022-09-30 Thread Cornelia Huck
e following people for their useful feedback >> and suggestions while working on the initial iterations of this patch. >> >> Damien Le Moal >> Matias Bjørling >> Niklas Cassel >> Hans Holmberg >> >> Fixes: https://github.com/oasis-tcs/virtio-spec

Re: [virtio-dev] [PATCH v3 1/4] content: Introduce driver/device auxiliary notifications

2022-10-11 Thread Cornelia Huck
On Fri, Oct 07 2022, Usama Arif wrote: > Driver auxiliary notifications allow the device to send notifications > other than configuration changes and used buffer notifications to the > driver, these are optional and their meaning is device-specific. > > Device auxiliary notifications allow the dr

Re: [virtio-dev] [PATCH] content: reserve device ID 43 for Camera device

2022-10-21 Thread Cornelia Huck
On Fri, Oct 14 2022, hrishivarya.bhageerad...@opensynergy.com wrote: > From: Hrishivarya Bhageeradhan > > The virtio-camera device allows to stream a camera video with > ability to change controls, formats and get camera captures. > This patch is to reserve the next available device ID for > virt

[virtio-dev] Re: [PATCH v11] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-03-27 Thread Cornelia Huck
On Tue, 27 Mar 2018 05:59:27 +0300 "Michael S. Tsirkin" wrote: > Some devices benefit from ability to find out the number of available > descriptors in the ring: for efficiency or as a debugging aid. > > To help with these optimizations, add a new feature: > VIRTIO_F_NOTIFICATION_DATA. When nego

[virtio-dev] Re: [PATCH v11] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-03-27 Thread Cornelia Huck
On Tue, 27 Mar 2018 16:51:18 +0300 "Michael S. Tsirkin" wrote: > On Tue, Mar 27, 2018 at 11:31:16AM +0200, Cornelia Huck wrote: > > On Tue, 27 Mar 2018 05:59:27 +0300 > > "Michael S. Tsirkin" wrote: > > > > > Some devices benefi

[virtio-dev] Re: [virtio] [PATCH v12] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-03-29 Thread Cornelia Huck
On Wed, 28 Mar 2018 20:21:47 +0300 "Michael S. Tsirkin" wrote: > On Wed, Mar 28, 2018 at 06:56:13PM +0200, Halil Pasic wrote: > > > > > > On 03/27/2018 06:37 PM, Michael S. Tsirkin wrote: > > > Some devices benefit from ability to find out the number of available > > > descriptors in the ring

[virtio-dev] Re: [virtio] [PATCH v12] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-03-29 Thread Cornelia Huck
On Thu, 29 Mar 2018 15:52:34 +0300 "Michael S. Tsirkin" wrote: > On Thu, Mar 29, 2018 at 11:05:55AM +0200, Cornelia Huck wrote: > > On Wed, 28 Mar 2018 20:21:47 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Wed, Mar 28, 2018 at 0

Re: [virtio-dev] Re: [virtio] [PATCH v12] VIRTIO_F_NOTIFICATION_DATA: extra data to devices

2018-04-03 Thread Cornelia Huck
On Mon, 2 Apr 2018 17:34:50 +0200 Halil Pasic wrote: > On 03/29/2018 04:30 PM, Michael S. Tsirkin wrote: > > On Thu, Mar 29, 2018 at 04:15:19PM +0200, Halil Pasic wrote: > >> > [..] > >> > >> I don't have a good solution, otherwise I would have proposed already. > >> Maybe something like 'ava

[virtio-dev] Re: [PATCH 2/5] consistency: clean up stale wording for v1.1 terms

2018-04-10 Thread Cornelia Huck
On Mon, 9 Apr 2018 20:58:39 +0200 Halil Pasic wrote: > Occasionally we still use used and available ring instead of Device and > Driver Area respectively. Same goes for descriptor table with the > difference that depending on the context we need either Descriptor Area > or descriptor ring. > >

[virtio-dev] Re: [PATCH 2/5] consistency: clean up stale wording for v1.1 terms

2018-04-10 Thread Cornelia Huck
On Tue, 10 Apr 2018 12:04:51 +0200 Halil Pasic wrote: > On 04/10/2018 11:30 AM, Cornelia Huck wrote: > > On Mon, 9 Apr 2018 20:58:39 +0200 > > Halil Pasic wrote: > > > >> Occasionally we still use used and available ring instead of Device and > >>

[virtio-dev] Re: [RFC PATCH 3/3] ccw: map common notifications terminology to ccw

2018-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2018 00:11:27 +0200 Halil Pasic wrote: [Have not yet looked at your other patches, on my list.] > The various notifications are introduced and specified in the common > (i.e. transport agnostic) portion of this specification. How > notifications are realised for a given transport

[virtio-dev] Re: [virtio] [RFC PATCH 1/3] notifications: unify notifications wording in core

2018-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2018 12:58:37 +0200 Halil Pasic wrote: > On 04/11/2018 04:19 AM, Stefan Hajnoczi wrote: > > On Wed, Apr 11, 2018 at 12:11:25AM +0200, Halil Pasic wrote: > >> \begin{lstlisting} > >> -virtq_disable_interrupts(vq); > >> +virtq_disable_notifications(vq); > > > > This name is am

Re: [virtio-dev] Re: [virtio] [RFC PATCH 1/3] notifications: unify notifications wording in core

2018-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2018 14:35:23 +0200 Paolo Bonzini wrote: > On 11/04/2018 04:19, Stefan Hajnoczi wrote: > > On Wed, Apr 11, 2018 at 12:11:25AM +0200, Halil Pasic wrote: > >> Let us unify the wording when talking about notifications. This change > >> establishes the terms available buffer notifica

[virtio-dev] Re: [RFC PATCH 2/3] notifications:notifications as basic virtio facility

2018-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2018 00:11:26 +0200 Halil Pasic wrote: > Let's introduce notifications as basic virtio facility early on. This > shall not only increase the cohesion between core and transport > description by having a well-defined place where notifications are > introduced, but also give us the

Re: [virtio-dev] Re: [RFC PATCH 3/3] ccw: map common notifications terminology to ccw

2018-04-11 Thread Cornelia Huck
On Wed, 11 Apr 2018 15:42:34 +0200 Halil Pasic wrote: > On 04/11/2018 09:50 AM, Cornelia Huck wrote: > > On Wed, 11 Apr 2018 00:11:27 +0200 > > Halil Pasic wrote: > >> +\item Notifications (via hypercall and virtual interrupts). > > > > Why 'v

[virtio-dev] Re: [virtio] Re: [virtio-dev] Re: [RFC PATCH 3/3] ccw: map common notifications terminology to ccw

2018-04-13 Thread Cornelia Huck
On Thu, 12 Apr 2018 13:12:09 +0200 Halil Pasic wrote: > On 04/11/2018 06:00 PM, Cornelia Huck wrote: > > On Wed, 11 Apr 2018 15:42:34 +0200 > > Halil Pasic wrote: > > > >> On 04/11/2018 09:50 AM, Cornelia Huck wrote: > >>> On Wed, 11 Apr 20

[virtio-dev] Re: [PATCH v1] content: reserve virtio device ID for memory devices

2018-04-27 Thread Cornelia Huck
cb1..bf63be8 100644 > --- a/content.tex > +++ b/content.tex > @@ -2432,6 +2432,8 @@ Device ID & Virtio Device\\ > \hline > 23 & IOMMU device \\ > \hline > +24 & Memory device \\ > +\hline > \end{tabular} > > Some of the

Re: [virtio-dev] [RFC] content: support SR-IOV

2018-05-18 Thread Cornelia Huck
On Fri, 18 May 2018 15:38:55 +0800 Tiwei Bie wrote: > Reserve a feature bit for virtio devices which support SR-IOV. Reserving a feature bit for this makes sense, but... > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > --- > More details can be found from this thread: > http

Re: [virtio-dev] [RFC] content: support SR-IOV

2018-05-18 Thread Cornelia Huck
On Fri, 18 May 2018 16:43:09 +0800 Tiwei Bie wrote: > On Fri, May 18, 2018 at 10:14:38AM +0200, Cornelia Huck wrote: > > On Fri, 18 May 2018 15:38:55 +0800 > > Tiwei Bie wrote: > > > > > Reserve a feature bit for virtio devices which support SR-IOV. > &

[virtio-dev] Re: [PATCH v2] content: support SR-IOV

2018-05-22 Thread Cornelia Huck
On Tue, 22 May 2018 12:56:23 +0800 Tiwei Bie wrote: > Allocate a feature bit for virtio devices which support SR-IOV. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/11 > --- > More details can be found from this thread:

[virtio-dev] Re: [PATCH v3] content: support SR-IOV

2018-05-22 Thread Cornelia Huck
On Tue, 22 May 2018 18:26:15 +0800 Tiwei Bie wrote: > Allocate a feature bit for virtio devices which support SR-IOV. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/11 Reviewed-by

[virtio-dev] Re: [PATCH v4] content: support SR-IOV

2018-05-29 Thread Cornelia Huck
ixes tag (MST); > - Be more explicit in driver requirement (MST); > - Remove the "device MAY fail" description (MST); > - Rebase on IO_BARRIER patch; > > RFC -> v1: > - Mention PCI in the description (Cornelia); > > content.tex | 2

Re: [virtio-dev] [PATCH] virtio: update the comments for transport features

2018-06-01 Thread Cornelia Huck
On Fri, 1 Jun 2018 18:22:17 +0800 Tiwei Bie wrote: > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > --- > This patch is generated on top of below patch: > https://lists.oasis-open.org/archives/virtio-dev/201805/msg00212.html > > include/uapi/linux/virtio_config.h | 9 ++---

[virtio-dev] Re: [PATCH v2] virtio: update the comments for transport features

2018-06-01 Thread Cornelia Huck
+/* > + * Virtio feature bits VIRTIO_TRANSPORT_F_START through > + * VIRTIO_TRANSPORT_F_END are reserved for the transport > + * being used (e.g. virtio_ring, virtio_pci etc.), the > + * rest are per-device feature bits. > + */ > #define V

[virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 14:59:28 +0800 Tiwei Bie wrote: > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > --- > content.tex | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/content.tex b/content.tex > index f

[virtio-dev] Re: [PATCH v2] content: enhance device requirements for feature bits

2018-06-08 Thread Cornelia Huck
SHOULD NOT fail re-negotiation of the same set of features > +after a device or system reset. Failure to do so would > +interfere with resuming from suspend and error recovery. > + > \subsection{Legacy Interface: A Note on Feature > Bits}\label{sec:Basic Facilities of a Virtio Device

[virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 10:07:01 +0800 Tiwei Bie wrote: > Document the driver requirements for the VIRTIO_F_SR_IOV > feature bit. > > Suggested-by: Michael S. Tsirkin > Signed-off-by: Tiwei Bie > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/13 > --- > v2: > - Fix the commit message (MST)

[virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 15:13:11 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 08, 2018 at 11:12:31AM +0200, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 10:07:01 +0800 > > Tiwei Bie wrote: > > > > > Document the driver requirements f

[virtio-dev] Re: [PATCH v2] content: document SR-IOV driver requirements

2018-06-08 Thread Cornelia Huck
On Fri, 8 Jun 2018 19:14:49 +0800 Tiwei Bie wrote: > On Fri, Jun 08, 2018 at 11:12:31AM +0200, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 10:07:01 +0800 > > Tiwei Bie wrote: > > > > > Document the driver requirements for the VIRTIO_F_SR_IOV > > >

[virtio-dev] Re: [PATCH] content: enhance device requirements for feature bits

2018-06-11 Thread Cornelia Huck
On Fri, 8 Jun 2018 19:05:30 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 08, 2018 at 09:36:17AM +0200, Cornelia Huck wrote: > > On Fri, 8 Jun 2018 14:59:28 +0800 > > Tiwei Bie wrote: > > > > > Suggested-by: Michael S. Tsirkin > >

[virtio-dev] Re: [PATCH v3] content: enhance device requirements for feature bits

2018-06-11 Thread Cornelia Huck
label{sec:Basic Facilities of a Virtio Device / Feature > Bits / Legacy Interface: A Note on Feature Bits} Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3] content: enhance device requirements for feature bits

2018-06-11 Thread Cornelia Huck
On Mon, 11 Jun 2018 16:24:51 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 11, 2018 at 03:56:40PM +0800, Tiwei Bie wrote: > > Suggested-by: Michael S. Tsirkin > > Signed-off-by: Tiwei Bie > > Fixes: https://github.com/oasis-tcs/virtio-spec/issues/14 > > --- > > v2: > > - Refine the wording (C

[virtio-dev] Re: [PATCH v3] content: document SR-IOV driver requirements

2018-06-12 Thread Cornelia Huck
ection}{Reserved Feature Bits}{Reserved Feature Bits} > > A device MUST offer VIRTIO_F_VERSION_1. A device MAY fail to operate further I still think we should mention somewhere that this "enable just once" mechanism is useful for e.g. resuming; but this is fine as-is. Reviewe

[virtio-dev] Re: [RFC] content: use a consistent wording for device status

2018-06-13 Thread Cornelia Huck
lds, which makes things confusing. > > content.tex | 21 - > 1 file changed, 12 insertions(+), 9 deletions(-) Patch looks good. Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...

[virtio-dev] Re: [PATCH v2 1/6] notifications: unify notifications wording in core

2018-06-13 Thread Cornelia Huck
On Mon, 11 Jun 2018 18:11:53 +0200 Halil Pasic wrote: > Let us unify the wording when talking about notifications. This change > establishes the terms available buffer notification for what was usually > simply called notification or virtqueue notification in v1.0 and used > buffer notification f

[virtio-dev] Re: [PATCH v2 2/6] notifications: notifications as basic virtio facility

2018-06-13 Thread Cornelia Huck
On Mon, 11 Jun 2018 18:11:54 +0200 Halil Pasic wrote: > Let's introduce notifications as basic virtio facility early on. This > shall not only increase the cohesion between core and transport > description by having a well-defined place where notifications are > introduced, but also give us the

[virtio-dev] Re: [PATCH v2 3/6] ccw: map common notifications terminology to ccw

2018-06-13 Thread Cornelia Huck
. > > Let's make the relationship between the virtio-ccw terms and the common > terms more obvious. > > Signed-off-by: Halil Pasic > Reviewed-by: Stefan Hajnoczi > --- > content.tex | 42 ++ > 1 files changed, 42 insertio

[virtio-dev] Re: [PATCH v2 4/6] pci: map common notifications terminology to PCI

2018-06-13 Thread Cornelia Huck
. > > Let's make the relationship between the PCI terms and the common > terms more obvious. > > Signed-off-by: Halil Pasic > --- > conformance.tex |2 +- > content.tex | 13 +++-- > 2 files changed, 8 insertions(+)

[virtio-dev] Re: [PATCH v2 5/6] mmio: map common notifications terminology to MMIO

2018-06-13 Thread Cornelia Huck
On Mon, 11 Jun 2018 18:11:57 +0200 Halil Pasic wrote: > The various notifications are introduced and specified in the common > (i.e. transport agnostic) portion of this specification. How > notifications are realised for a given transport is something each > transport has to specify. > > Let's m

[virtio-dev] Re: [PATCH v2 6/6] notifications: update notifications terminology for devices

2018-06-13 Thread Cornelia Huck
d-off-by: Halil Pasic > --- > content.tex | 22 +++--- > 1 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-14 Thread Cornelia Huck
I've been pointed to this discussion (which I had missed previously) and I'm getting a headache. Let me first summarize how I understand how this feature is supposed to work, then I'll respond to some individual points. The basic idea is to enable guests to migrate seamlessly, while still making i

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Fri, 15 Jun 2018 05:34:24 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 14, 2018 at 12:02:31PM +0200, Cornelia Huck wrote: > > > > I am not all that familiar with how Qemu manages network devices. If we > > > > can > > > > do all the &

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-15 Thread Cornelia Huck
On Thu, 14 Jun 2018 18:57:11 -0700 Siwei Liu wrote: > Thank you for sharing your thoughts, Cornelia. With questions below, I > think you raised really good points, some of which I don't have answer > yet and would also like to explore here. > > First off, I don't want to push the discussion to t

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-18 Thread Cornelia Huck
On Fri, 15 Jun 2018 15:31:43 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 15, 2018 at 11:32:42AM +0200, Cornelia Huck wrote: > > On Fri, 15 Jun 2018 05:34:24 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-19 Thread Cornelia Huck
On Fri, 15 Jun 2018 10:06:07 -0700 Siwei Liu wrote: > On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > > On Thu, 14 Jun 2018 18:57:11 -0700 > > Siwei Liu wrote: > > > >> Thank you for sharing your thoughts, Cornelia. With questions below, I > >&

Re: [virtio-dev] [PATCH v3] content: enhance device requirements for feature bits

2018-06-20 Thread Cornelia Huck
On Wed, 20 Jun 2018 00:30:59 +0800 Tiwei Bie wrote: > On Tue, Jun 19, 2018 at 12:46:45PM +0200, Halil Pasic wrote: > > On 06/19/2018 11:14 AM, Tiwei Bie wrote: > > > On Mon, Jun 18, 2018 at 07:28:33PM +0300, Michael S. Tsirkin wrote: > [...] > > > > > > If it would be better to drop this pat

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-20 Thread Cornelia Huck
On Tue, 19 Jun 2018 23:32:06 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 19, 2018 at 12:54:53PM +0200, Cornelia Huck wrote: > > Sorry about dragging mainframes into this, but this will only work for > > homogenous device coupling, not for heterogenous. Consider my

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-20 Thread Cornelia Huck
On Tue, 19 Jun 2018 13:09:14 -0700 Siwei Liu wrote: > On Tue, Jun 19, 2018 at 3:54 AM, Cornelia Huck wrote: > > On Fri, 15 Jun 2018 10:06:07 -0700 > > Siwei Liu wrote: > > > >> On Fri, Jun 15, 2018 at 4:48 AM, Cornelia Huck wrote: > >> > On Thu, 1

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-20 Thread Cornelia Huck
On Wed, 20 Jun 2018 17:11:59 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 20, 2018 at 11:53:59AM +0200, Cornelia Huck wrote: > > On Tue, 19 Jun 2018 23:32:06 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Jun 19, 2018 at 12:5

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-21 Thread Cornelia Huck
On Wed, 20 Jun 2018 22:48:58 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 20, 2018 at 06:06:19PM +0200, Cornelia Huck wrote: > > In any case, I'm not sure anymore why we'd want the extra uuid. > > It's mostly so we can have e.g. multiple devices wi

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-22 Thread Cornelia Huck
On Thu, 21 Jun 2018 21:20:13 +0300 "Michael S. Tsirkin" wrote: > On Thu, Jun 21, 2018 at 04:59:13PM +0200, Cornelia Huck wrote: > > OK, so what about the following: > > > > - introduce a new feature bit, VIRTIO_NET_F_STANDBY_UUID that indicates > > that w

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-25 Thread Cornelia Huck
On Fri, 22 Jun 2018 22:05:50 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > On Thu, 21 Jun 2018 21:20:13 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Thu, Jun 21, 2018 at 04:59

[virtio-dev] Re: [PATCH v3 5/6] mmio: map common notifications terminology to MMIO

2018-06-25 Thread Cornelia Huck
1 files changed, 13 insertions(+), 12 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3 2/6] notifications: notifications as basic virtio facility

2018-06-25 Thread Cornelia Huck
++++ > 1 files changed, 36 insertions(+), 0 deletions(-) Reviewed-by: Cornelia Huck - To unsubscribe, e-mail: virtio-dev-unsubscr...@lists.oasis-open.org For additional commands, e-mail: virtio-dev-h...@lists.oasis-open.org

[virtio-dev] Re: [PATCH v3 1/6] notifications: unify notifications wording in core

2018-06-25 Thread Cornelia Huck
er as used. Device can then trigger > -a device event - i.e. send an interrupt to the driver. > +a device event - i.e. send a used buffer notification to the driver. > > Device reports the number of bytes it has written to memory for > each buffer it uses. This is referred t

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 04:46:03 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 25, 2018 at 11:55:12AM +0200, Cornelia Huck wrote: > > On Fri, 22 Jun 2018 22:05:50 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Fri, Jun 22, 2018 at 05:09:55P

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Fri, 22 Jun 2018 17:05:04 -0700 Siwei Liu wrote: > On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirkin wrote: > > I suspect the diveregence will be lost on most users though > > simply because they don't even care about vfio. They just > > want things to go fast. > > Like Jason said, VF is

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 04:50:25 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 25, 2018 at 10:54:09AM -0700, Samudrala, Sridhar wrote: > > > > > > Might not neccessarily be something wrong, but it's very limited to > > > > > > prohibit the MAC of VF from changing when enslaved by failover. > > >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-26 Thread Cornelia Huck
On Tue, 26 Jun 2018 18:38:51 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 05:17:32PM +0200, Cornelia Huck wrote: > > On Tue, 26 Jun 2018 04:50:25 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Mon, Jun 25,

Re: [virtio-dev] Re: [PATCH v2 0/4] Use of unique identifier for pairing virtio and passthrough devices...

2018-06-27 Thread Cornelia Huck
On Wed, 27 Jun 2018 07:06:42 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 10:49:30PM -0500, Venu Busireddy wrote: > > The patch set "Enable virtio_net to act as a standby for a passthru > > device" [1] deals with live migration of guests that use passthrough > > devices. However, t

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-27 Thread Cornelia Huck
On Tue, 26 Jun 2018 20:50:20 +0300 "Michael S. Tsirkin" wrote: > On Tue, Jun 26, 2018 at 05:08:13PM +0200, Cornelia Huck wrote: > > On Fri, 22 Jun 2018 17:05:04 -0700 > > Siwei Liu wrote: > > > > > On Fri, Jun 22, 2018 at 3:33 PM, Michael S. Tsirki

Re: [virtio-dev] Re: [Qemu-devel] [PATCH] qemu: Introduce VIRTIO_NET_F_STANDBY feature bit to virtio_net

2018-06-27 Thread Cornelia Huck
On Sat, 23 Jun 2018 00:43:24 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jun 22, 2018 at 05:09:55PM +0200, Cornelia Huck wrote: > > Would it be more helpful to focus on generic > > migration support for vfio instead of going about it device by device? > >

Re: [virtio-dev] Re: [RFC] content: tweak VIRTIO_F_IO_BARRIER

2018-06-27 Thread Cornelia Huck
On Tue, 26 Jun 2018 21:39:22 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 27, 2018 at 02:19:22AM +0800, Tiwei Bie wrote: > > On Tue, Jun 26, 2018 at 03:47:28PM +0200, Halil Pasic wrote: > > > On 06/25/2018 09:19 PM, Michael S. Tsirkin wrote: > > > > On Mon, Jun 25, 2018 at 08:24:42PM +0800

[virtio-dev] Retrieving configuration metadata from hypervisor (was: Re: [Qemu-devel] [PATCH v2 3/4] Add "Group Identifier" support to Red Hat PCI bridge.)

2018-06-28 Thread Cornelia Huck
On Thu, 28 Jun 2018 09:25:32 +0100 Daniel P. Berrangé wrote: > On Wed, Jun 27, 2018 at 07:02:36AM +0300, Michael S. Tsirkin wrote: > > On Tue, Jun 26, 2018 at 10:49:33PM -0500, Venu Busireddy wrote: > > > Add the "Vendor-Specific" capability to the Red Hat PCI bridge device > > > "pci-bridge",

Re: [virtio-dev] [PATCH v3 0/6] rework notifications terminology

2018-07-03 Thread Cornelia Huck
On Tue, 3 Jul 2018 03:01:56 +0300 "Michael S. Tsirkin" wrote: > On Mon, Jun 25, 2018 at 02:21:26PM +0200, Halil Pasic wrote: > > Abstract > > > > The terminology around notifications is currently somewhat > > fragmented. Unify notifications terminology using available and used > > buffe

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-03 Thread Cornelia Huck
On Tue, 3 Jul 2018 09:28:17 -0500 Venu Busireddy wrote: > On 2018-07-03 12:58:25 +0300, Roman Kagan wrote: > > On Mon, Jul 02, 2018 at 02:14:52PM -0700, si-wei liu wrote: > > > On 7/2/2018 9:14 AM, Roman Kagan wrote: > > > > Is the scheme going to be applied/extended to other transports (vmbu

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-04 Thread Cornelia Huck
On Tue, 3 Jul 2018 16:31:03 -0700 Siwei Liu wrote: > On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: > > From my point of view, there are several concerns: > > - This approach assumes a homogeneous pairing (same transport), and > > even more, it assumes that

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-06 Thread Cornelia Huck
On Thu, 5 Jul 2018 17:49:10 -0700 Siwei Liu wrote: > On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: > > On Tue, 3 Jul 2018 16:31:03 -0700 > > Siwei Liu wrote: > > > >> On Tue, Jul 3, 2018 at 7:52 AM, Cornelia Huck wrote: > >> > From my

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Cornelia Huck
On Mon, 9 Jul 2018 16:14:19 +0300 Roman Kagan wrote: > On Fri, Jul 06, 2018 at 03:54:06PM +0200, Cornelia Huck wrote: > > If we want to extend that to other device types, we can add the field > > in their config space; but I'd rather prefer a more generic "host > >

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Cornelia Huck
On Fri, 6 Jul 2018 18:07:00 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jul 06, 2018 at 03:54:06PM +0200, Cornelia Huck wrote: > > On Thu, 5 Jul 2018 17:49:10 -0700 > > Siwei Liu wrote: > > > > > On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrot

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-09 Thread Cornelia Huck
On Fri, 6 Jul 2018 16:37:10 -0700 Siwei Liu wrote: > On Fri, Jul 6, 2018 at 6:54 AM, Cornelia Huck wrote: > > On Thu, 5 Jul 2018 17:49:10 -0700 > > Siwei Liu wrote: > > > >> On Wed, Jul 4, 2018 at 5:15 AM, Cornelia Huck wrote: > >> > On Tue,

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-11 Thread Cornelia Huck
On Tue, 10 Jul 2018 17:07:37 -0700 Siwei Liu wrote: > On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin wrote: > > On Mon, Jul 09, 2018 at 06:11:53PM -0700, si-wei liu wrote: > >> The plan is to enable group ID based matching in the first place rather > >> than > >> match by MAC, the latter

Re: [virtio-dev] Re: [Qemu-devel] [PATCH v3 0/3] Use of unique identifier for pairing virtio and passthrough devices...

2018-07-12 Thread Cornelia Huck
On Thu, 12 Jul 2018 02:37:03 -0700 Siwei Liu wrote: > On Wed, Jul 11, 2018 at 2:53 AM, Cornelia Huck wrote: > > On Tue, 10 Jul 2018 17:07:37 -0700 > > Siwei Liu wrote: > > > >> On Mon, Jul 9, 2018 at 6:54 PM, Michael S. Tsirkin > >> wrote: > >

<    1   2   3   4   5   6   7   8   >