[vpp-dev] make: yamllint: Command not found

2019-11-13 Thread Pei, Yulong
Hello vpp-dev & csit-dev, https://jenkins.fd.io/job/vpp-checkstyle-verify-master/12407/console 16:56:10 *** 16:56:10 * VPP CHECKSTYLE SUCCESSFULLY COMPLETED 16:56:10

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

2019-11-13 Thread Satya Murthy
Thanks a lot Dave for offering the help. The change would be of great help for us. Please let us know, once you have a patch, so that we can selectively take that patch and import. -- Thanks & Regards, Murthy -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group.

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Paul Vinciguerra
How do people feel about managing the CI where possible via the Makefile by testing for JENKINS_URL? On Wed, Nov 13, 2019 at 10:11 AM Dave Wallace wrote: > Status update: > > Florin fixed 'make checkstyle' with [1] (Thanks Florin! :) > > Ed Kern has added 'make install-dep' to the checkstyle

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Dave Wallace
Status update: Florin fixed 'make checkstyle' with [1]  (Thanks Florin! :) Ed Kern has added 'make install-dep' to the checkstyle verify build executors. The revert of my ci-management patch [2] will be abandoned. Florin's patch will be reverted once the new build executors are available

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

2019-11-13 Thread Dave Barach via Lists.Fd.Io
If you use an rx pthread to tickle your main thread [via eventfd if you like] – and to do nothing else – I don’t see why you’d need to lock anything. We’d want to make a couple of very simple changes to .../src/vlibmemory/memory_client.c so folks can use any rx pthread function they like,

[vpp-dev] Two potential bugs in nat/out2in

2019-11-13 Thread Raj
Hello All, I want to share two observations I had while chasing a crash in VPP. To the best of my knowledge, this is what happens in src/plugins/nat/nat_det_out2in.c:icmp_match_out2in_det() - First it will lookup the destination addr and get the snat_det_map if found. - If no mapping found,

[vpp-dev] Coverity run FAILED as of 2019-11-13 14:07:31 UTC

2019-11-13 Thread Noreply Jenkins
Coverity run failed today. Current number of outstanding issues are 5 Newly detected: 0 Eliminated: 0 More details can be found at https://scan.coverity.com/projects/fd-io-vpp/view_defects -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14586):

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

2019-11-13 Thread Satya Murthy
Thanks Ole for the response. We will weigh between performance of "unix domain sockets" vs "lock contention with rx thread" approached and go accordingly. -- Thanks & Regards, Murthy -=-=-=-=-=-=-=-=-=-=-=- Links: You receive all messages sent to this group. View/Reply Online (#14585):

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Paul Vinciguerra
Can you leave it? The change in the makefile was backed out. Can we work on automating new containers when the makefile is updated? On Wed, Nov 13, 2019 at 8:58 AM Dave Wallace wrote: > Dave, > > My bad. I had Vanessa merge a patch to ci-management [0] which I tested > locally, but forgot

Re: [vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Dave Wallace
Dave, My bad.  I had Vanessa merge a patch to ci-management [0] which I tested locally, but forgot that the build executors don't run 'make install-dep'. Unfortunately the ci-management verify jobs don't actually run any of the CI jobs to ensure that the system still works with the patch

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

2019-11-13 Thread Ole Troan
Satya, > Main problem we are seeing with having RX thread is: > > 1) Our application sends VPP-API-request in main thread and stores the > Request and context information in a list > 2) If the response comes in the RX thread, we need to access the context > information list in this thread

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

2019-11-13 Thread Satya Murthy
Thanks Dave for the quick reply. Main problem we are seeing with having RX thread is: 1) Our application sends VPP-API-request in main thread and stores the Request and context information in a list 2) If the response comes in the RX thread, we need to access the context information list in

Re: [vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

2019-11-13 Thread Dave Barach via Lists.Fd.Io
Wouldn’t be hard given that all of the relevant mechanisms are present in the underlying svm_queue code. The question becomes one of performance. Mutex/condvar signaling is lightweight, and the vpp graph dispatcher is perfectly set up to poll vpp’s main input queue. What’s the argument

[vpp-dev] Multiple patch validation failures: yamllint AWOL

2019-11-13 Thread Dave Barach via Lists.Fd.Io
I wonder where "yamllint" went? Multiple patches affected... 07:28:23 clang-format version 6.0.0-1ubuntu2 (tags/RELEASE_600/final) 07:28:24 HEAD detached at dce8b380a 07:28:24 nothing to commit, working tree clean 07:28:24 ***

Re: [vpp-dev] TAP interface rx strange behavior #vpp

2019-11-13 Thread Dimitar Ivanov
Thank You. Now mactime node is visited in both cases - before and after set bridge-domain. W/o bridge-domain: root@ucpe-vpp:~# vppctl show trace --- Start of thread 0 vpp_main --- Packet 1 00:03:50:074475: virtio-input virtio: hw_if_index 16 next-index 7 vring

[vpp-dev] fd to poll in VPP-API-CLIENT with no RX thread

2019-11-13 Thread Satya Murthy
Hi, We are trying to come up with VPP-API-CLIENT module that has no special RX thread. As we dont have no RX thread, we are planning to read messages from shared memory from our main dispatcher. To do this, we want to poll on an FD to check if any message arrived in the SHM queue. I was

Re: [vpp-dev] TAP interface rx strange behavior #vpp

2019-11-13 Thread Damjan Marion via Lists.Fd.Io
Good finding, this may help you: https://gerrit.fd.io/r/c/vpp/+/23396 — Damjan > On 12 Nov 2019, at 17:02, Dimitar Ivanov wrote: > > All this happen in case where tap interface is set to some bridge-domain ! If > i create tap interface and set mactime on it, >