nciguerra
Sent: Wednesday, November 20, 2019 7:33 PM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] Change to Gerrit
How would the group feel about implementing something like [0], so that changes
to the commit message don't trigger rebuilds?
To enforce the commit message structure, we could skip
Hi Andrew.
That used to be the case, not anymore. See:
https://gerrit.fd.io/r/c/vpp/+/23521 . Changing just the commit via the UI,
triggers everything.
Paul
On Wed, Nov 20, 2019 at 6:56 PM Andrew Yourtchenko
wrote:
> Does this idea keep in mind a corner case of editing the commit message
>
Does this idea keep in mind a corner case of editing the commit message over
the gerrit UI?
That operation currently doesn’t trigger the rebuilds... (Though i tend to use
it for a quick edit to recover a checkstyle error, so I would rather have it
trigger the checkstyle :-)
If these things
+1
> On 20 Nov 2019, at 19:32, Paul Vinciguerra wrote:
>
> How would the group feel about implementing something like [0], so that
> changes to the commit message don't trigger rebuilds?
>
> To enforce the commit message structure, we could skip the jobs and set
> verify label after the
+1
From: vpp-dev@lists.fd.io On Behalf Of Paul Vinciguerra
Sent: Wednesday, November 20, 2019 1:33 PM
To: vpp-dev@lists.fd.io
Subject: [EXTERNAL] [vpp-dev] Change to Gerrit
How would the group feel about implementing something like [0], so that changes
to the commit message don't trigger
+1
From: vpp-dev@lists.fd.io On Behalf Of Paul Vinciguerra
Sent: Wednesday, November 20, 2019 1:33 PM
To: vpp-dev@lists.fd.io
Subject: [vpp-dev] Change to Gerrit
How would the group feel about implementing something like [0], so that changes
to the commit message don't trigger rebuilds
+1
Florin
> On Nov 20, 2019, at 10:32 AM, Paul Vinciguerra
> wrote:
>
> How would the group feel about implementing something like [0], so that
> changes to the commit message don't trigger rebuilds?
>
> To enforce the commit message structure, we could skip the jobs and set
> verify
How would the group feel about implementing something like [0], so that changes
to the commit message don't trigger rebuilds?
To enforce the commit message structure, we could skip the jobs and set verify
label after the codestyle checks if no files were changed.
Maybe others don't care, but I
