Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-19 Thread Zarel
2009/2/19 Per Inge Mathisen : > No problem. I agree we should branch for 2.2 now. Anyone see any > reasons why not? Now that I've figured out how to commit to branches other than trunk, I'm fine with this, too. It seems everyone's in support of branching immediately? (I count me, Buggy, Gerard, P

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-19 Thread Dennis Schridde
Am Donnerstag, 19. Februar 2009 15:03:59 schrieb Per Inge Mathisen: > What is the state of the lua branch, though? I got the impression it > still had a way to go before it was playable. Last time I tried, the AI was just sitting there on Rush. Console spammed something about nils. (I tested that

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-19 Thread Per Inge Mathisen
On Thu, Feb 19, 2009 at 12:47 PM, Gerard Krol wrote: > Per Inge Mathisen wrote: >> I would like to suggest that we start refactoring the Warzone codebase >> so that it can more easily be unit tested aggressively. >> > Would it be an idea to wait for the merge from the terrain and the lua > branch?

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-19 Thread Gerard Krol
Per Inge Mathisen wrote: > I would like to suggest that we start refactoring the Warzone codebase > so that it can more easily be unit tested aggressively. > Would it be an idea to wait for the merge from the terrain and the lua branch? That's going to be one hell of a job after we refactor th

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-18 Thread Dennis Schridde
Am Mittwoch, 18. Februar 2009 17:15:45 schrieb Kamaze: > This might be a good time to bump the major version number? I do not think someone said something about a major rewrite. Additionaly the version number should represent user visible changes, and so far I see no proposal for even on in this t

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-18 Thread Kamaze
This might be a good time to bump the major version number? Per Inge Mathisen schrieb: > Hello devs, > > We all know that the current and past state of the Warzone codebase is > a rather sorry excuse for something. There are so many globals all > over the place, that it is almost impossible to se

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-18 Thread Per Inge Mathisen
On Wed, Feb 18, 2009 at 11:03 AM, Dennis Schridde wrote: > Am Mittwoch, 18. Februar 2009 09:54:59 schrieb Giel van Schijndel: >> On Tue, Feb 17, 2009 at 07:10:22PM +0100, Per Inge Mathisen wrote: >> > 2) has *at least* one unit test, >> > 3) uses *no* globals, > BTW: libtagfile violates this. > I

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-18 Thread Dennis Schridde
Am Mittwoch, 18. Februar 2009 09:54:59 schrieb Giel van Schijndel: > On Tue, Feb 17, 2009 at 07:10:22PM +0100, Per Inge Mathisen wrote: > > 2) has *at least* one unit test, > > 3) uses *no* globals, BTW: libtagfile violates this. I have a branch here were I fixed that, but I do not remember whether

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-18 Thread Dennis Schridde
Am Mittwoch, 18. Februar 2009 09:30:54 schrieb Giel van Schijndel: > On Tue, Feb 17, 2009 at 11:17:58PM +0100, Dennis Schridde wrote: > > Maybe I may still propose something: > > Move the current code into /dirty/ and selectively pick cleaned files > > from there and move them into a sensible locat

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-18 Thread Giel van Schijndel
On Tue, Feb 17, 2009 at 07:10:22PM +0100, Per Inge Mathisen wrote: > The code is buggy, and we do not have a process in place to ensure > that it gets better. I dare say that if the only thing that keeps > Warzone from sliding from bad to worse in terms of bugs is hard work, > there is no chance th

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-18 Thread Giel van Schijndel
On Tue, Feb 17, 2009 at 11:17:58PM +0100, Dennis Schridde wrote: > Maybe I may still propose something: > Move the current code into /dirty/ and selectively pick cleaned files > from there and move them into a sensible location / directory-layout > in the main tree. I propose src/dirty/ instead ;-

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-17 Thread Dennis Schridde
Hello! Sounds like a good idea, though I will not have enough time to actively participate in the near future. Maybe I may still propose something: Move the current code into /dirty/ and selectively pick cleaned files from there and move them into a sensible location / directory-layout in the

Re: [Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-17 Thread Kreuvf
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Per Inge Mathisen wrote: > I would like to start porting the map loading code there. If you like > the idea. Then hopefully we could all pitch in and port the functions > you are more familiar with and soon we will have a new, shiny and > improved Warz

[Warzone-dev] A plan to refactor and clean up the warzone code base

2009-02-17 Thread Per Inge Mathisen
Hello devs, We all know that the current and past state of the Warzone codebase is a rather sorry excuse for something. There are so many globals all over the place, that it is almost impossible to separate out code for proper unit testing or reuse. The code is buggy, and we do not have a process