>-Original Message-
>From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of
>Kristian Høgsberg
>Sent: Friday, March 02, 2012 5:17 PM
>
>Yeah, a few good points came up in this thread: process separation so
>if one test corrupts memory it doesn't affect others, being able to
>ru
On Fri, Mar 2, 2012 at 5:28 PM, Daniel Stone wrote:
> Hi,
>
> On 2 March 2012 21:53, Andreas Ericsson wrote:
>> I've written a few in my days. Normally, I keep them ridiculously
>> simple, so the testing code looks something like this (sorry for the
>> sucky indentation; coding in a mua is always
Hi,
On 2 March 2012 21:53, Andreas Ericsson wrote:
> I've written a few in my days. Normally, I keep them ridiculously
> simple, so the testing code looks something like this (sorry for the
> sucky indentation; coding in a mua is always crap):
>
> some_test_func(args)
> {
> test_suite t;
>
On 03/02/2012 07:07 PM, Eoff, Ullysses A wrote:
>> -Original Message-
>> From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of
>> Kristian Høgsberg
>> Sent: Friday, March 02, 2012 7:33 AM
>> To: Michael Hasselmann
>> Cc: Eoff, Ullysses A; wayland-devel@lists.freedesktop.org
>>
>-Original Message-
>From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of
>Kristian Høgsberg
>Sent: Friday, March 02, 2012 7:33 AM
>To: Michael Hasselmann
>Cc: Eoff, Ullysses A; wayland-devel@lists.freedesktop.org
>Subject: Re: [PATCH 0/3] Resubmit - Unit test framework for W
>-Original Message-
>From: Chris Morgan [mailto:chmor...@gmail.com]
>Sent: Friday, March 02, 2012 7:50 AM
>To: Kristian Høgsberg
>Cc: Michael Hasselmann; wayland-devel@lists.freedesktop.org; Eoff, Ullysses
>A
>Subject: Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland
>
>2012/3/2 K
Hi,
On 2 March 2012 12:13, Pekka Paalanen wrote:
> Does this make the code easier to read or not?
> I cannot judge it, since I wrote the macros.
To be honest, I don't think so. I don't think there's any benefit to
grepability and it does kinda obscure what it's doing somewhat. The
guard object
On Fri, Mar 02, 2012 at 03:45:56PM +0200, Ander Conselvan de Oliveira wrote:
> ---
> src/data-device.c| 56 +++--
> src/wayland-server.h |1 +
> 2 files changed, 41 insertions(+), 16 deletions(-)
Thanks Ander, that looks good.
Kristian
> diff
On 03/02/2012 05:52 PM, Pekka Paalanen wrote:
On Fri, 02 Mar 2012 17:37:53 +0200
Tiago Vignatti wrote:
On 03/02/2012 05:33 PM, Pekka Paalanen wrote:
Bad inclusion of DRM headers, missing some system headers.
thanks, Pekka. I had that in my branch already. Will be sending all
together to Kr
On Fri, 02 Mar 2012 17:37:53 +0200
Tiago Vignatti wrote:
> On 03/02/2012 05:33 PM, Pekka Paalanen wrote:
> > Bad inclusion of DRM headers, missing some system headers.
> >
>
> thanks, Pekka. I had that in my branch already. Will be sending all
> together to Kristian next:
>
> http://cgit.freed
2012/3/2 Kristian Høgsberg :
> On Fri, Mar 2, 2012 at 9:30 AM, Chris Morgan wrote:
>>> I found that a good testing framework can lower the barrier of writing
>>> useful tests. Nice logging and status reports are important I feel. And
>>> if for example you can easily write data driven tests, then
On 03/02/2012 05:33 PM, Pekka Paalanen wrote:
Bad inclusion of DRM headers, missing some system headers.
thanks, Pekka. I had that in my branch already. Will be sending all
together to Kristian next:
http://cgit.freedesktop.org/~vignatti/weston/commit/?h=light-misc&id=9045af0933673b989c0f7a
Bad inclusion of DRM headers, missing some system headers.
Signed-off-by: Pekka Paalanen
---
src/libbacklight.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/src/libbacklight.c b/src/libbacklight.c
index b2e19bf..7ff0b86 100644
--- a/src/libbacklight.c
+++ b/src/l
On Fri, Mar 2, 2012 at 4:36 AM, Michael Hasselmann
wrote:
> On Thu, 2012-03-01 at 22:34 -0500, Kristian Høgsberg wrote:
>> Hi Artie,
>>
>> Thanks for starting this. Looks good and certainly when we start
>> adding tests for some of the more complex objects and data structures
>> in the library (w
On Fri, Mar 2, 2012 at 9:30 AM, Chris Morgan wrote:
>> I found that a good testing framework can lower the barrier of writing
>> useful tests. Nice logging and status reports are important I feel. And
>> if for example you can easily write data driven tests, then testing all
>> possible code paths
> I found that a good testing framework can lower the barrier of writing
> useful tests. Nice logging and status reports are important I feel. And
> if for example you can easily write data driven tests, then testing all
> possible code paths in a critical area becomes straight-forward and the
> te
Fix compositor crashes when the clients die before the grab ends.
---
src/shell.c | 13 +
1 files changed, 9 insertions(+), 4 deletions(-)
diff --git a/src/shell.c b/src/shell.c
index 5abfdb5..8a82ad1 100644
--- a/src/shell.c
+++ b/src/shell.c
@@ -224,7 +224,8 @@ weston_surface_move
Add a client parameter to wl_input_device_start_pointer_focus(). If
it is non-nil, if that client terminates while the grab is still
active, the grab is ended and the current focus is set to NULL.
---
src/data-device.c|3 ++-
src/wayland-server.c | 28 +++-
src/wa
---
src/data-device.c| 56 +++--
src/wayland-server.h |1 +
2 files changed, 41 insertions(+), 16 deletions(-)
diff --git a/src/data-device.c b/src/data-device.c
index f0f6baa..be2360c 100644
--- a/src/data-device.c
+++ b/src/data-device.c
@@
Hi,
A few more grab/drag related fixes.
The first patch makes a drag grab terminate if the data source for it
goes away.
The other two (one for wayland core and one for weston), change the
start_pointer_grab interface to take a client parameter. If this
parameter in not NULL, the grab will be te
Em 01-03-2012 06:57, zhiwen...@linux.intel.com escreveu:
From: Alex Wu
@@ -1290,14 +1426,23 @@ activate(struct weston_shell *base, struct
weston_surface *es,
static void
click_to_activate_binding(struct wl_input_device *device,
- uint32_t time, uint32_t key,
+
From: Pekka Paalanen
---
Does this make the code easier to read or not?
I cannot judge it, since I wrote the macros.
src/data-device.c|5 ++---
src/wayland-server.h | 15 +--
2 files changed, 15 insertions(+), 5 deletions(-)
diff --git a/src/data-device.c b/src/data-devi
From: Pekka Paalanen
In wayland and weston code bases we have roughly a dozen destroy
listeners whose only job is to set a pointer to NULL, if a wl_resource
object gets destroyed.
Introduce struct wl_guard as a shorthand for replacing all these trivial
callbacks.
One case in data-device.c is co
From: Alex Wu
If configure() is triggered by a change of buffer size, and the
fullscreen surface has alreay switched from non-fullscreen. An
unnecessary shell_stack_fullscreen() will be called.
---
src/shell.c | 17 +++--
1 files changed, 11 insertions(+), 6 deletions(-)
diff --gi
From: Alex Wu
When the configure() is triggered by a change of buffer size,
a toplevel surface which has not ever been switched to maximazied
or fullscreen will set a random position.
Modified the position restoring logic for toplevel surface. Store
the surface position when it switches from top
From: Alex Wu
Fix a positioning issues caused by change of buffer size and refine the
fullscreen
logic in configure().
---
weston:
The following changes since commit
b9747d02c61adb28261c03ffdb584ce8fbed22b5 :
shell: Add implementation of fullscreen.
On Thu, 2012-03-01 at 22:34 -0500, Kristian Høgsberg wrote:
> Hi Artie,
>
> Thanks for starting this. Looks good and certainly when we start
> adding tests for some of the more complex objects and data structures
> in the library (wl_map would be a good next step), it will be a good
> way to avoi
27 matches
Mail list logo
