Re: [Weston] More discussion about weston output relative motion algorithm

On Wed, 7 May 2014 03:26:56 + Wang, Quanxian quanxian.w...@intel.com wrote: Thanks Pq's comment. Before you continue my comment, I mentioned one point. This is output movement algorithm and it is completely different with pre-configuration of output in weston.ini. For output, no alive,

RE: [Weston] More discussion about weston output relative motion algorithm

-Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Wednesday, May 7, 2014 2:17 PM To: Wang, Quanxian Cc: Hardening (rdp.eff...@gmail.com); Bryce W. Harrington (b.harring...@samsung.com); wayland-devel@lists.freedesktop.org; Jason Ekstrand

Re: [Weston] More discussion about weston output relative motion algorithm

On Wed, 7 May 2014 07:03:32 + Wang, Quanxian quanxian.w...@intel.com wrote: -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Wednesday, May 7, 2014 2:17 PM To: Wang, Quanxian Cc: Hardening (rdp.eff...@gmail.com); Bryce W. Harrington

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

On Tue, 6 May 2014 14:40:53 -0700 Kristian Høgsberg hoegsb...@gmail.com wrote: On Mon, May 05, 2014 at 05:02:15PM +0300, Ander Conselvan de Oliveira wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Otherwise it might receive touch events. I think a

RE: [Weston] More discussion about weston output relative motion algorithm

-Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Wednesday, May 7, 2014 3:41 PM To: Wang, Quanxian Cc: Hardening (rdp.eff...@gmail.com); Bryce W. Harrington (b.harring...@samsung.com); wayland-devel@lists.freedesktop.org; Jason Ekstrand

[PATCH weston 1/3] shell: Fix artifacts caused by workspace change animation

From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Views that extend past the bottom of the output are still visible after the workspace animation ends but before its layer is hidden. When the layer was hidden, nothing would cause those regions to be repainted, leading to

[PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com The check to avoid calling weston_keyboard_set_focus() for a seat that didn't have a keyboard in restore_focus_state() was cheking the wrong seat (the one from the previous loop). That caused a crash when switching workspaces

[PATCH weston 2/3] simple-touch: Handle multiple seats properly

From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com If simple-touch ran on a compositor with multiple seats, and the first one happened to have the touch capability while the second one didn't, the handler for seat capabilities would destroy the wl_touch device it created on

Re: [Weston] More discussion about weston output relative motion algorithm

On Wed, 7 May 2014 08:49:47 + Wang, Quanxian quanxian.w...@intel.com wrote: -Original Message- From: Pekka Paalanen [mailto:ppaala...@gmail.com] Sent: Wednesday, May 7, 2014 3:41 PM To: Wang, Quanxian Subject: Re: [Weston] More discussion about weston output relative

Bug 78372 - create multiple windows with offset

Please go through this NOTABUG bug. https://bugs.freedesktop.org/show_bug.cgi?id=78372 Rohit Nandan ___ wayland-devel mailing list wayland-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/wayland-devel

Re: [PATCH] clients: Initialize label in keyboard handling code

On Wed, 07 May 2014 01:11:07 + Bryce W. Harrington b.harring...@samsung.com wrote: Quells warning: clients/keyboard.c: In function ‘keyboard_handle_key.isra.5’: clients/keyboard.c:556:11: warning: ‘label’ may be used uninitialized in this function [-Wuninitialized] Signed-off-by:

Re: [PATCH 0/5] clients: Use the x*alloc routines

On Wed, 07 May 2014 02:13:10 + Bryce W. Harrington b.harring...@samsung.com wrote: As per our discussion last week, here's patches to convert client code to using xmalloc, xzalloc, xcalloc, and xstrdup where appropriate. I opted not to change nested.c, because it looked like errors were

Re: More build problems: dri2proto

On Tue, 06 May 2014 19:36:59 -0700 Bill Spitzak spit...@gmail.com wrote: Okay, I am trying to build wayland again, from instructions, on a new machine. I am stuck trying to compile mesa: ./autogen.sh --prefix=$WLD --enable-gles2 --disable-gallium-egl

Re: [PATCH v2] doc: Added API documentation for wl_display_create function.

On Wed, 07 May 2014 09:37:45 +0530 Srivardhan Hebbar sri.heb...@samsung.com wrote: Signed-off-by: Srivardhan Hebbar sri.heb...@samsung.com --- src/wayland-server.c |9 + 1 file changed, 9 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index

Re: [PATCH] gitignore log files, now in root directory

On Tue, 11 Mar 2014 18:11:43 + Bryce W. Harrington b.harring...@samsung.com wrote: Signed-off-by: Bryce Harrington b.harring...@samsung.com --- .gitignore |2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index e0a73c0..d3044a2 100644 --- a/.gitignore

[PATCH weston] shell: Don't allow maximized surfaces to be moved with touch

From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com Moving a maximized surface with the pointer is already not possible, so make the behavior with touch consistent. https://bugs.freedesktop.org/show_bug.cgi?id=78208 --- desktop-shell/shell.c | 2 +- 1 file changed, 1

RE: [Weston] More discussion about weston output relative motion algorithm

Hi, Pq I meant this very simple example: There is only one output A. A Then I add output B to the left of A. B-A The position of A must not change. This means that B must get negative coordinates, and A's position stays at 0,0. In Weston, window positions are stored in global

[PATCH] Do not distribute generated headers

From: Thierry Reding tred...@nvidia.com The wayland-server-protocol.h and wayland-client-protocol.h headers are currently being shipped in tarballs created using make dist. This causes out-of-tree builds to fail since make will detect that the headers exist by looking at the source directory (via

[PATCH wayland 0/3] Automatically find a good WAYLAND_SOCKET for compositors

This patch series implements a better fallback than a hardcoded wayland-0 when a server socket has already been taken. This way, the code for searching for an appropriate socket is shared between all compositors. The option to open an explicit socket still exists, if the client specifies it.

[PATCH wayland 3/3] server: Find an open wayland-* socket by default

Rather than just trying wayland-0 and bailing out if it's in use. --- src/wayland-server.c | 29 ++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index 3390171..ba13168 100644 --- a/src/wayland-server.c +++

[PATCH wayland 1/3] server: Create the socket FD after taking the lock

This removes a small cleanup path. --- src/wayland-server.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index e850d48..d299000 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1061,12 +1061,6 @@

[PATCH wayland 2/3] server: Split out code to open sockets for a specific name

We'll use this to autodetect a good socket to open on. --- src/wayland-server.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index d299000..3390171 100644 --- a/src/wayland-server.c +++

[PATCH 1/2] compositor: Add a comment around the WAYLAND_DISPLAY envvar setting

This took me a few minutes to figure out, so document it for the next person who stumbles in here. --- src/compositor.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 3d65e4c..120818f 100644 --- a/src/compositor.c +++

Re: [PATCH wayland 0/3] Automatically find a good WAYLAND_SOCKET for compositors

Of course I mean WAYLAND_DISPLAY, not WAYLAND_SOCKET. Whoops. On Wed, May 7, 2014 at 9:05 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: This patch series implements a better fallback than a hardcoded wayland-0 when a server socket has already been taken. This way, the code for searching

Re: [PATCH weston 1/3] shell: Fix artifacts caused by workspace change animation

Hm, it seems to me that hiding a layer should cause all the regions it occupied to be marked as needing repaint. Fixing the scene graph is better than a one-off at the end of an animation. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira conselv...@gmail.com wrote: From: Ander

Re: [PATCH weston 3/3] shell: Fix crash when restoring focus state during workspace change

Yep, looks good. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira conselv...@gmail.com wrote: From: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com The check to avoid calling weston_keyboard_set_focus() for a seat that didn't have a keyboard in

Re: [PATCH weston 2/3] simple-touch: Handle multiple seats properly

I was wondering why you didn't move the pointer / keyboard fields to the seat, before noticing that they were unused. It might make sense to have a prereq patch that removes those unused fields. This patch looks good, though. On Wed, May 7, 2014 at 4:57 AM, Ander Conselvan de Oliveira

Re: Bug 78372 - create multiple windows with offset

The rationale explained in the bug by Pekka and Emilio sounds OK to me. Explaining a bit more about your use case with your data visualization app might be helpful. What kinds of systems do you want your app to be run on? Generic desktop systems? If so, then you can't guarantee anything about

[PATCH weston 3/5] tests: load the right xwayland plugin

From: Pekka Paalanen pekka.paala...@collabora.co.uk If we do not specify the full path to xwayland.so, Weston can find an old one installed in a $prefix and use that instead of the freshly built one. Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk --- tests/weston-tests-env | 6

[PATCH weston 2/5] tests: use --no-config

From: Pekka Paalanen pekka.paala...@collabora.co.uk Use --no-config to avoid loading arbitrary weston.ini files from unit tests. It may affect the unit test results. I actually hit the following case: [13:34:04.636] Using config file '/home/pq/local/etc/weston.ini' [13:34:04.636] Loading module

[PATCH weston 0/5] test suite fixes

From: Pekka Paalanen pekka.paala...@collabora.co.uk Hi, random little things here. I mostly wanted to make the Xwayland unit test work again. This patch series at least makes it run the right thing, but it still fails. Is the Xwayland test supposed to even work at all now? Are there some

[PATCH weston 5/5] tests: rename xwayland test

From: Pekka Paalanen pekka.paala...@collabora.co.uk If the test is named xwayland.weston, then the automake test harness keys it off xwayland.log. Making xwayland.log runs the test. The test harness has implicit rules to create a %.log from all of %$TEST_EXTENSIONS. So we have implicit rules to

[PATCH weston 1/5] compositor: add --no-config command line option

From: Pekka Paalanen pekka.paala...@collabora.co.uk Useful for unit tests. If Weston finds a weston.ini during unit tests, it will load it and all the modules it asks for. We need a way to prevent loading arbitrary modules from the command line. Signed-off-by: Pekka Paalanen

[PATCH weston 4/5] tests: load the right shell plugin

From: Pekka Paalanen pekka.paala...@collabora.co.uk Again, load the shell plugin with full path, rather than possibly find an old version from a previous installation. Signed-off-by: Pekka Paalanen pekka.paala...@collabora.co.uk --- tests/weston-tests-env | 3 +++ 1 file changed, 3

Re: [PATCH weston 2/3] compositor-wayland: assign the correct mode

I love the simple typos like this. LGTM. On Tue, May 6, 2014 at 5:50 PM, U. Artie Eoff ullysses.a.e...@intel.comwrote: Signed-off-by: U. Artie Eoff ullysses.a.e...@intel.com --- src/compositor-wayland.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 1/2] compositor: Add a comment around the WAYLAND_DISPLAY envvar setting

On Wed, 7 May 2014 09:07:26 -0400 Jasper St. Pierre jstpie...@mecheye.net wrote: This took me a few minutes to figure out, so document it for the next person who stumbles in here. --- src/compositor.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git

Re: [PATCH 2/2] compositor: Use libwayland to find a good default socket name for us

On Wed, 7 May 2014 09:07:27 -0400 Jasper St. Pierre jstpie...@mecheye.net wrote: --- src/compositor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 120818f..85a75bf 100644 --- a/src/compositor.c +++ b/src/compositor.c @@

[PATCH weston] simple-touch: Handle multiple seats

Previously simple-touch would only handle one seat. If there were multiple seats it would lose track of whether there is a touch device available depending on what order the capability events arrive in. This makes it keep a linked list of seats and to track a separate touch device for each seat so

Re: [PATCH weston] simple-touch: Handle multiple seats

Looks mostly the same as Ander's patch here: http://lists.freedesktop.org/archives/wayland-devel/2014-May/014658.html Same review applies :) On Wed, May 7, 2014 at 10:00 AM, Neil Roberts n...@linux.intel.com wrote: Previously simple-touch would only handle one seat. If there were multiple

[PATCH v3] client: extend error handling

When an error occurs, wl_display_get_error() does not provide any way of getting know if it was a local error or if it was an error event, respectively what object caused the error and what the error was. This patch introduces a new function wl_display_get_protocol_error() which will return error

Re: [PATCH v3] client: extend error handling

On 5 May 2014 15:02, Pekka Paalanen ppaala...@gmail.com wrote: On Wed, 30 Apr 2014 10:11:01 +0200 Marek Chalupa mchqwe...@gmail.com wrote: When an error occurs, wl_display_get_error() does not provide any way of getting know if it was a local error or if it was an error event,

[PATCH wayland 0/3] Add API to automatically select a display name

v2 of my patch series. v1 was broken because I didn't test it properly. This one should actually work. First patch also had a resource leak fixed. Second patch is the same. Third patch takes a new approach. Jasper St. Pierre (3): server: Create the socket FD after taking the lock server:

[PATCH wayland 2/3] server: Split out code to open sockets for a specific display name

We'll use this to autodetect a good socket to open on. --- src/wayland-server.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index d0fd280..6bc8dc3 100644 --- a/src/wayland-server.c +++

[PATCH wayland 1/3] server: Create the socket FD after taking the lock

--- src/wayland-server.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/src/wayland-server.c b/src/wayland-server.c index e850d48..d0fd280 100644 --- a/src/wayland-server.c +++ b/src/wayland-server.c @@ -1061,12 +1061,6 @@ wl_display_add_socket(struct

[PATCH wayland 3/3] server: Add a simple API to find a good default display

This allows compositors to easily select a good display to listen on. --- src/wayland-server.c | 23 +++ src/wayland-server.h | 2 ++ 2 files changed, 25 insertions(+) diff --git a/src/wayland-server.c b/src/wayland-server.c index 6bc8dc3..5624199 100644 ---

[PATCH] compositor: Use libwayland to find a good default display for us

--- src/compositor.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/compositor.c b/src/compositor.c index 3d65e4c..1906441 100644 --- a/src/compositor.c +++ b/src/compositor.c @@ -4150,7 +4150,7 @@ int main(int argc, char *argv[]) char *server_socket = NULL,

Re: [PATCH weston 2/3] simple-touch: Handle multiple seats properly

Oh no, I didn't notice this patch buried in the patch series and implemented the same thing: http://lists.freedesktop.org/archives/wayland-devel/2014-May/014690.html Ander, it would be really helpful if you could leave a little note on the bug report if you post a patch to reduce that chance

Re: Bug 78372 - create multiple windows with offset

Yes i'm working for embedded platform where with current desktop shell we cant debug two overlays visually running same apps with same size. Thanks You . Rohit Nandan On Wed, May 7, 2014 at 6:49 PM, Jasper St. Pierre jstpie...@mecheye.netwrote: The rationale explained in the bug by Pekka

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

On 05/07/2014 01:47 AM, Pekka Paalanen wrote: It is for normal windows like registered with xdg_shell where sub-surfaces are not suitable for tooltips. A sub-surface is a part of the window, not another window. A tooltip is not expected to change the window geometry, but a sub-surface does

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

Events aren't delivered to surfaces. They're delivered to clients. On Wed, May 7, 2014 at 2:02 PM, Bill Spitzak spit...@gmail.com wrote: On 05/07/2014 01:47 AM, Pekka Paalanen wrote: It is for normal windows like registered with xdg_shell where sub-surfaces are not suitable for tooltips. A

Re: More build problems: dri2proto

On 05/07/2014 03:04 AM, Pekka Paalanen wrote: Maybe you forgot to set some of the environment variables from here: http://wayland.freedesktop.org/building.html Don't play with the foofoo_CFLAGS and foofoo_LIBS variables, it is much better to fix pkg-config to find the right .pc files. Thank

[PATCH weston] compositor-wayland: fix leak in create_cursor when theme load fails

Free the theme configuration string right after wl_cursor_load_theme since we're done using it. This fixes a leak when the cursor theme could not be loaded. Signed-off-by: U. Artie Eoff ullysses.a.e...@intel.com --- src/compositor-wayland.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

Sorry, what I meant was the surface id and xy location in events. If a subsurface belongs to a different client than the parent surface, though, does this mean the child client will get events that have an xy position relative to the parent surface? On 05/07/2014 11:05 AM, Jasper St. Pierre

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

On 7 May 2014 20:23, Bill Spitzak spit...@gmail.com wrote: If a subsurface belongs to a different client than the parent surface, though, does this mean the child client will get events that have an xy position relative to the parent surface? As a fundamental design point of the Wayland

RE: [PATCH 2/5] clients: Use x*alloc routines for memory allocation

This fixes a few possible NULL deref's, too... not that it matters much once you're in an OOM situation. LGTM -- U. Artie -Original Message- From: wayland-devel [mailto:wayland-devel-boun...@lists.freedesktop.org] On Behalf Of Bryce W. Harrington Sent: Tuesday, May 06, 2014 7:13 PM

weston logind and display managers

Hi, I'm porting sddm (QtQuick based display manager) to Wayland, it's still work in progress but close to be in a usable state and you can find it here: https://github.com/plfiorini/sddm/tree/wayland There are some multiple screen issues specific to how sddm work compared to wl_fullscreen_shell

Re: [PATCH wayland 1/3] server: Create the socket FD after taking the lock

Yeah, this looks good to me. It does change the order of a couple of system calls, but it looks ok to me. Reviewed-by: Jason Ekstrand ja...@jlekstrand.net On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: --- src/wayland-server.c | 15 +++ 1 file

Re: [PATCH wayland 2/3] server: Split out code to open sockets for a specific display name

Comments below, --Jason Ekstrand On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: We'll use this to autodetect a good socket to open on. --- src/wayland-server.c | 40 +--- 1 file changed, 25 insertions(+), 15 deletions(-)

Re: [PATCH wayland 3/3] server: Add a simple API to find a good default display

On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: This allows compositors to easily select a good display to listen on. --- src/wayland-server.c | 23 +++ src/wayland-server.h | 2 ++ 2 files changed, 25 insertions(+) diff --git

Re: [PATCH 1/2] cairo-util: Add frame_touch_motion support

On Tue, May 6, 2014 at 9:46 PM, Boyan Ding stu_...@126.com wrote: --- shared/cairo-util.h | 3 +++ shared/frame.c | 24 2 files changed, 27 insertions(+) diff --git a/shared/cairo-util.h b/shared/cairo-util.h index 4493b0d..7aebb65 100644 ---

Re: [PATCH 0/2] weston: Add touch support to nested wayland backend

Boyan, Thanks for picking this up! I'm making some comments on the patches themselves. Unfortunately, I don't have touch hardware to test it with, but I hope my comments are helpful none the less. --Jason Ekstrand On Tue, May 6, 2014 at 9:46 PM, Boyan Ding stu_...@126.com wrote: The

Re: [PATCH 2/2] compositor-wayland: Add touch support

Boyan, By and large, this looks really good! I have just a few comments below. As I said in another e-mail, I don't have any touch hardware I can test this on, so I wasn't able to actually test it. On Tue, May 6, 2014 at 9:46 PM, Boyan Ding stu_...@126.com wrote: Adding touch support to

Re: [PATCH] Do not distribute generated headers

I won't claim to be an autotools expert, but this looks sane to me. Probably something we want to take care of for 1.5. Reviewed-by: Jason Ekstrand ja...@jlekstrand.net On Wed, May 7, 2014 at 7:09 AM, Thierry Reding thierry.red...@gmail.comwrote: From: Thierry Reding tred...@nvidia.com The

Re: [PATCH wayland 3/3] server: Add a simple API to find a good default display

On Wed, May 7, 2014 at 9:31 PM, Jason Ekstrand ja...@jlekstrand.net wrote: On Wed, May 7, 2014 at 9:25 AM, Jasper St. Pierre jstpie...@mecheye.netwrote: This allows compositors to easily select a good display to listen on. --- src/wayland-server.c | 23 +++

Re: [PATCH v3] client: extend error handling

On Wed, 7 May 2014 16:21:24 +0200 Marek Chalupa mchqwe...@gmail.com wrote: When an error occurs, wl_display_get_error() does not provide any way of getting know if it was a local error or if it was an error event, respectively what object caused the error and what the error was. This

Re: [PATCH weston] window.c: Set the input region of the tooltip to empty

Please always use reply-to-all, you have dropped a lot people from CC. On Wed, 07 May 2014 11:02:56 -0700 Bill Spitzak spit...@gmail.com wrote: On 05/07/2014 01:47 AM, Pekka Paalanen wrote: It is for normal windows like registered with xdg_shell where sub-surfaces are not suitable for

Re: Bug 78372 - create multiple windows with offset

On Wed, 07 May 2014 13:10:31 -0700 Bill Spitzak spit...@gmail.com wrote: Good to see there is an actual bug on this, but I need to ask for our exact case: No, there is not. The bug report was not a valid bug, and is now closed. Our app can be configured to have 2 (well actually any number)