Re: black surface in desktop shell fullscreen mode

2015-10-01 Thread Pekka Paalanen
On Thu, 1 Oct 2015 12:27:21 -0700 Bill Spitzak wrote: > On Thu, Oct 1, 2015 at 12:50 AM, Pekka Paalanen wrote: > > > The black blanket surface behind the window OTOH allows for direct > > scanout. If black bars are not visible and the client buffer is > > completely opaque, it is possible to s

Re: [PATCH weston 1/6] xdg-shell: define the present/present_from_event() requests

2015-10-01 Thread Jonas Ådahl
On Thu, Apr 09, 2015 at 06:22:53PM +0200, Manuel Bachmann wrote: > xdg_surface_present() and xdg_surface_present_from_event() > are new requests supposed to be called on an existing > xdg_surface. They tell the compositor that the surface > has new content which may be of interest to the user. > Th

Re: [PATCH wayland v2] scanner: Close input resource when done to prevent leak

2015-10-01 Thread Jonas Ådahl
On Thu, Oct 01, 2015 at 06:13:29PM -0700, Bryce Harrington wrote: > Addresses this error reported by Denis Denisov: > > [src/scanner.c:1415]: (error) Resource leak: input > > Signed-off-by: Bryce Harrington > > v2: Also close input for other exit points in main. > Signed-off-by: Bryce Harring

Re: [RFC 1/2] Introduce wl_probe_visible protocol

2015-10-01 Thread Jonas Ådahl
On Thu, Oct 01, 2015 at 01:04:34PM +0200, Carlos Garnacho wrote: > Hey Jonas!, > > On Thu, Oct 1, 2015 at 8:51 AM, Jonas Ådahl wrote: > > wl_probe_visible (for now _wl_probe_visible) is a reintroduction of > > the "wl_probe" method of making it possible to position a surface so > > that it is com

[PATCH wayland v2] scanner: Close input resource when done to prevent leak

2015-10-01 Thread Bryce Harrington
Addresses this error reported by Denis Denisov: [src/scanner.c:1415]: (error) Resource leak: input Signed-off-by: Bryce Harrington v2: Also close input for other exit points in main. Signed-off-by: Bryce Harrington --- src/scanner.c | 5 + 1 file changed, 5 insertions(+) diff --git a/s

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-01 Thread Carlos Garnacho
On Thu, Oct 1, 2015 at 9:47 PM, Bill Spitzak wrote: > I really do not like the idea that the compositor is responsible for > matching up modifiers with actions. > > Still trying to figure out why the destination cannot pick one of the > actions, rather than the compositor doing this. If the modifi

Re: Enums, bitfields and wl_arrays

2015-10-01 Thread Bill Spitzak
On Thu, Oct 1, 2015 at 12:00 PM, Nils Chr. Brause wrote: > > There are some enum attributes missing, namely: > - wl_shm_pool::create_buffer::format (it's wl_shm::format) > - wl_shell_surface::set_fullscreen::method (it's > wl_shell_surface::fullscreen_method) > - wl_surface::set_buffer_transform:

Re: [PATCH 1/2] Clarify the enum argument type

2015-10-01 Thread Bill Spitzak
On Thu, Oct 1, 2015 at 12:09 PM, Nils Chr. Brause wrote: > On Thu, Oct 1, 2015 at 9:00 PM, Bill Spitzak wrote: > > > > > > On Thu, Oct 1, 2015 at 8:09 AM, Nils Chr. Brause < > nilschrbra...@gmail.com> > > wrote: > >> > >> Hi, > >> > >> I would recommend to also include the name of the interface,

Re: [PATCH wayland] server: Make serial number 0 mean invalid

2015-10-01 Thread Bill Spitzak
On Thu, Oct 1, 2015 at 12:59 PM, Jasper St. Pierre wrote: > For the present case, present_with_event will support focus-stealing > prevention if the serial is garbage or not up to date, whereas present > should always steal focus. > > The garbage serial and don't-have-a-serial cases are different

Re: [PATCH wayland] server: Make serial number 0 mean invalid

2015-10-01 Thread Jasper St. Pierre
For the present case, present_with_event will support focus-stealing prevention if the serial is garbage or not up to date, whereas present should always steal focus. The garbage serial and don't-have-a-serial cases are different, so I believe we should have two different methods in that case for

Re: [PATCH wayland] protocol: Improve data source notification around DnD progress

2015-10-01 Thread Carlos Garnacho
On Thu, Oct 1, 2015 at 8:48 PM, Bill Spitzak wrote: > > > On Wed, Sep 30, 2015 at 1:45 PM, Carlos Garnacho wrote: >> >> >> - wl_data_source.drop_performed: Happens when the operation has been >> physically finished (eg. the button is released), it could be the right >> place to reset the poin

Re: [PATCH wayland] server: Make serial number 0 mean invalid

2015-10-01 Thread Bill Spitzak
The no-serial value really really really needs to be zero. Otherwise you get all kinds of annoyances with many language wrappers which map zero to false and all other values to true. I think most will have to resort to xor'ing the value with the no-serial value, meaning the numerical values are all

Re: [PATCH wayland v4] protocol: Add DnD actions

2015-10-01 Thread Bill Spitzak
I really do not like the idea that the compositor is responsible for matching up modifiers with actions. Still trying to figure out why the destination cannot pick one of the actions, rather than the compositor doing this. If the modifiers are needed then either the destination gets the modifiers,

Re: [PATCH wayland] protocol: Improve data source notification around DnD progress

2015-10-01 Thread Carlos Garnacho
Hey Michael, On Thu, Oct 1, 2015 at 6:46 PM, Michael Catanzaro wrote: > One problem with this model is that a broken or malicious client could > force the drag source to be leaked by [sending accept and] never > destroying its data offer... but only once per user-initiated drag, so > we can proba

Re: black surface in desktop shell fullscreen mode

2015-10-01 Thread Bill Spitzak
On Thu, Oct 1, 2015 at 12:50 AM, Pekka Paalanen wrote: > > A fullscreen window with show-through parts is kind of an odd concept, > IMHO. For maximized I might understand. > It seems partially-transparent fullscreen terminals are really popular. Pad repeat? That requires application awareness t

Re: [RFC 1/2] Introduce wl_probe_visible protocol

2015-10-01 Thread Bill Spitzak
I don't see anything wrong with the compositor selecting the position for popups, and really don't see any way this "probe" idea can do better. This will avoid round trips, and also allow the compositor to move the popups if other obscuring objects appear after they are created. There are a few req

Re: [PATCH 1/2] Clarify the enum argument type

2015-10-01 Thread Nils Chr. Brause
On Thu, Oct 1, 2015 at 9:00 PM, Bill Spitzak wrote: > > > On Thu, Oct 1, 2015 at 8:09 AM, Nils Chr. Brause > wrote: >> >> Hi, >> >> I would recommend to also include the name of the interface, where the >> enum is defined, in the enum attribute, e.g: >> > > > I believe popular opinion was that a

Re: Enums, bitfields and wl_arrays

2015-10-01 Thread Nils Chr. Brause
Hi, On Thu, Oct 1, 2015 at 7:49 PM, Bryce Harrington wrote: > The topic of adding better enum/bitfield support to the protocol has > come up a few[0] times[1] in the past, and again more recently[2]. We > also have several proposed patches in patchwork, but I'm not sure they > reflect consensus

Re: [PATCH 1/2] Clarify the enum argument type

2015-10-01 Thread Bill Spitzak
On Thu, Oct 1, 2015 at 8:09 AM, Nils Chr. Brause wrote: > Hi, > > I would recommend to also include the name of the interface, where the > enum is defined, in the enum attribute, e.g: > > I believe popular opinion was that a "local" enum, belonging to the same object as the message or event, sh

Re: [PATCH wayland] protocol: Improve data source notification around DnD progress

2015-10-01 Thread Bill Spitzak
On Wed, Sep 30, 2015 at 1:45 PM, Carlos Garnacho wrote: > > - wl_data_source.drop_performed: Happens when the operation has been > physically finished (eg. the button is released), it could be the right > place to reset the pointer cursor back and undo any other state resulting > from the i

Re: Enums, bitfields and wl_arrays

2015-10-01 Thread Bill Spitzak
I'm not sure why one of the large patches seems to be attributed to me, it is actually Auke's. My only contribution was a small patch (number 4) to use the enum/bitfield information in the generated docs. My patch is slightly different that Auke's proposal and he liked it better, I was just holdin

Re: Can I enable mode switching from wayland/weston?

2015-10-01 Thread Jasper St. Pierre
As I mentioned on your post on Reddit [0], SDL2's video mode hooks are no-ops, which explains why SDL isn't changing the resolution. You could change SDL's code to use a different fullscreen mode. I am still struggling why you need to change the resolution with a modeset. [0] https://www.reddit.c

Re: Enums, bitfields and wl_arrays

2015-10-01 Thread Jasper St. Pierre
We have a few constraints. First off, not all enums are closed. Some are intentionally open, like xdg_shell.state. So we definitely need a distinction between a closed enum and an open enum. I'm not familiar enough with Rust to be able to apply something to that. Second, I think we need to make a

Enums, bitfields and wl_arrays

2015-10-01 Thread Bryce Harrington
The topic of adding better enum/bitfield support to the protocol has come up a few[0] times[1] in the past, and again more recently[2]. We also have several proposed patches in patchwork, but I'm not sure they reflect consensus and none have Reviewed-by's on them yet [3,4,5,6,7]. From what I gath

Re: [PATCH 1/4] ivi-shell: Add missing '\n' in weston_log function usage

2015-10-01 Thread Bryce Harrington
On Thu, Oct 01, 2015 at 10:51:29AM -0400, Chris Michael wrote: > Signed-off-by: Chris Michael > --- > ivi-shell/hmi-controller.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Pretty straightforward, I pushed the set: remote: Updating patchwork state for http://patchwork.freedesktop.o

Re: [PATCH wayland] protocol: Improve data source notification around DnD progress

2015-10-01 Thread Michael Catanzaro
One problem with this model is that a broken or malicious client could force the drag source to be leaked by [sending accept and] never destroying its data offer... but only once per user-initiated drag, so we can probably ignore that issue On Thu, 2015-10-01 at 12:00 +0200, Carlos Garnacho wr

Re: Can I enable mode switching from wayland/weston?

2015-10-01 Thread Robert Folland
> On 01 Oct 2015, at 17:08, Giulio Camuffo wrote: > > 2015-10-01 18:03 GMT+03:00 Robert Folland : >> On 01 Oct 2015, at 16:47, Giulio Camuffo wrote: >>> >>> 2015-10-01 16:40 GMT+03:00 Robert Folland : Hi, I need to display video in different resolutions (the resolution of the

Re: [PATCH 1/2] Clarify the enum argument type

2015-10-01 Thread Nils Chr. Brause
Hi, I would recommend to also include the name of the interface, where the enum is defined, in the enum attribute, e.g: Also, I think you forgot some enum attributes, e.g. wl_shm_pool:: create_buffer::format is the wl_shm::format enum, but I can't find it in your patch (I can't seem to find the

Re: Can I enable mode switching from wayland/weston?

2015-10-01 Thread Giulio Camuffo
2015-10-01 18:03 GMT+03:00 Robert Folland : > On 01 Oct 2015, at 16:47, Giulio Camuffo wrote: >> >> 2015-10-01 16:40 GMT+03:00 Robert Folland : >>> Hi, >>> >>> I need to display video in different resolutions (the resolution of the >>> recording), but with weston/wayland I always end up with the

Re: Can I enable mode switching from wayland/weston?

2015-10-01 Thread Robert Folland
On 01 Oct 2015, at 16:47, Giulio Camuffo wrote: > > 2015-10-01 16:40 GMT+03:00 Robert Folland : >> Hi, >> >> I need to display video in different resolutions (the resolution of the >> recording), but with weston/wayland I always end up with the resolution >> preferred by the monitor (1920x1080

[PATCH 4/4] compositor-rdp: Add missing '\n' in weston_log usage

2015-10-01 Thread Chris Michael
Signed-off-by: Chris Michael --- src/compositor-rdp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/compositor-rdp.c b/src/compositor-rdp.c index c221eb9..7272f41 100644 --- a/src/compositor-rdp.c +++ b/src/compositor-rdp.c @@ -1241,7 +1241,7 @@ rdp_backend_create(struct

[PATCH 3/4] cms-colord: Add missing '\n' in weston_log usage

2015-10-01 Thread Chris Michael
Signed-off-by: Chris Michael --- src/cms-colord.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cms-colord.c b/src/cms-colord.c index 1e61feb..c88eb11 100644 --- a/src/cms-colord.c +++ b/src/cms-colord.c @@ -145,7 +145,7 @@ update_device_with_profile_in_idle(struct c

[PATCH 2/4] screen-share: Add missing '\n' in weston_log usage

2015-10-01 Thread Chris Michael
Signed-off-by: Chris Michael --- src/screen-share.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/screen-share.c b/src/screen-share.c index e5f91ea..d961c89 100644 --- a/src/screen-share.c +++ b/src/screen-share.c @@ -438,13 +438,13 @@ shared_output_get_shm_bu

[PATCH 1/4] ivi-shell: Add missing '\n' in weston_log function usage

2015-10-01 Thread Chris Michael
Signed-off-by: Chris Michael --- ivi-shell/hmi-controller.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ivi-shell/hmi-controller.c b/ivi-shell/hmi-controller.c index c388164..5cc76d3 100644 --- a/ivi-shell/hmi-controller.c +++ b/ivi-shell/hmi-controller.c @@ -1780,7 +1780,

Re: Can I enable mode switching from wayland/weston?

2015-10-01 Thread Giulio Camuffo
2015-10-01 16:40 GMT+03:00 Robert Folland : > Hi, > > I need to display video in different resolutions (the resolution of the > recording), but with weston/wayland I always end up with the resolution > preferred by the monitor (1920x1080 in my current setup). > > SDL2 thinks it is producing e.g.

Can I enable mode switching from wayland/weston?

2015-10-01 Thread Robert Folland
Hi, I need to display video in different resolutions (the resolution of the recording), but with weston/wayland I always end up with the resolution preferred by the monitor (1920x1080 in my current setup). SDL2 thinks it is producing e.g. 1280x720, but that is not the real output to screen. Th

Re: [PATCH 1/2] Clarify the enum argument type

2015-10-01 Thread Pekka Paalanen
On Wed, 22 Apr 2015 19:40:44 -0700 Bill Spitzak wrote: > This improvement to the protocol allows you to refer to the kind of enum you > are expecting. > It also introduces a distinction between enums that are bitfields, ie > that can be OR'ed together. > --- > protocol/wayland.dtd |2 ++ >

Re: Multiple views for the same IVI surface

2015-10-01 Thread Pekka Paalanen
On Thu, 1 Oct 2015 13:27:45 +0200 Frederico Cadete wrote: > On Thu, Oct 1, 2015 at 12:23 PM Pekka Paalanen wrote: > > > > On Thu, 01 Oct 2015 17:13:47 +0900 > > Nobuhiko Tanibata wrote: > > > > > Hi, > > > > > > Tested-by: Nobuhiko Tanibata > > > Reviewed-by: Nobuhiko Tanibata > > > > > > The

Multiple views for the same IVI surface

2015-10-01 Thread Frederico Cadete
On Thu, Oct 1, 2015 at 12:23 PM Pekka Paalanen wrote: > > On Thu, 01 Oct 2015 17:13:47 +0900 > Nobuhiko Tanibata wrote: > > > Hi, > > > > Tested-by: Nobuhiko Tanibata > > Reviewed-by: Nobuhiko Tanibata > > > > These constructors are reserved for a feature of 'a ivi-surface to > > several layers

Re: [RFC 1/2] Introduce wl_probe_visible protocol

2015-10-01 Thread Carlos Garnacho
Hey Jonas!, On Thu, Oct 1, 2015 at 8:51 AM, Jonas Ådahl wrote: > wl_probe_visible (for now _wl_probe_visible) is a reintroduction of > the "wl_probe" method of making it possible to position a surface so > that it is completely visible, when positioning it relative to some > other already mapped

RE: [Wayland1.5]CPU occupancy rate of Weston is 99%

2015-10-01 Thread 박성진
Dear Yang Andy, You can trace the status of Weston with the following ways: - Trace with WAYLAND_DEBUG environment variable export WAYLAND_DEBUG=1 Run Weston Watch what's going on... - Trace with wchan : you can see which system call is called by a process ps -aux | grep weston cat

Re: [Wayland1.5]CPU occupancy rate of Weston is 99%

2015-10-01 Thread Pekka Paalanen
On Thu, 1 Oct 2015 08:54:47 + Yang Andy wrote: > Hi everyone > When i run QT-Application on wayland/weston,sometimes there is NG > issue that CPU occupancy rate of Weston is 99%. The probability of > this NG issue is very low,but if the NG issue occur,CPU occupancy > rate of Weston retains 99

Re: [PATCH 1/5] ivi-shell: remove struct link_screen

2015-10-01 Thread Pekka Paalanen
On Thu, 01 Oct 2015 17:13:47 +0900 Nobuhiko Tanibata wrote: > Hi, > > Tested-by: Nobuhiko Tanibata > Reviewed-by: Nobuhiko Tanibata > > These constructors are reserved for a feature of 'a ivi-surface to > several layers' and 'a ivi-layer to several screens'. This feature is > required for >

Re: [PATCH wayland] protocol: Improve data source notification around DnD progress

2015-10-01 Thread Carlos Garnacho
Hey Michael :), On Thu, Oct 1, 2015 at 12:43 AM, Michael Catanzaro wrote: > Reviewed-by: Michael Catanzaro > > These are important fixes for the protocol that will allow drags to > work between GTK+ and Chrome. Thanks for working on this, Carlos! Thanks for the review! > > Nit #1: the existing

[Wayland1.5]CPU occupancy rate of Weston is 99%

2015-10-01 Thread Yang Andy
Hi everyone When i run QT-Application on wayland/weston,sometimes there is NG issue that CPU occupancy rate of Weston is 99%. The probability of this NG issue is very low,but if the NG issue occur,CPU occupancy rate of Weston retains 99%. Could anyone give me some advice on how to track the NG is

Re: [PATCH 3/5] ivi-shell: remove is_layer_in_screen API

2015-10-01 Thread Nobuhiko Tanibata
Hi, Tested-by: Nobuhiko Tanibata Reviewed-by: Nobuhiko Tanibata Best Regards, Nobuhiko Tanibata 2015-08-28 21:59 に Ucan, Emre (ADITG/SW1) さんは書きました: This internal API is redundant, because a layer is allowed to be only on one screen. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c |

Re: [PATCH 4/5] ivi-shell: remove is_surface_in_layer API

2015-10-01 Thread Nobuhiko Tanibata
Hi, Tested-by: Nobuhiko Tanibata Reviewed-by: Nobuhiko Tanibata BR, Nobuhiko Tanibata 2015-08-28 21:59 に Ucan, Emre (ADITG/SW1) さんは書きました: This internal API is redundant, because a surface is allowed to be only on one layer. Signed-off-by: Emre Ucan --- ivi-shell/ivi-layout.c | 23 +-

Re: [PATCH 5/5] ivi-shell: introduce get_weston_view

2015-10-01 Thread Nobuhiko Tanibata
Hi, Tested-by: Nobuhiko Tanibata Reviewed-by: Nobuhiko Tanibata Best Regards, Nobuhiko Tanibata 2015-08-28 21:59 に Ucan, Emre (ADITG/SW1) さんは書きました: The internal API "get_weston_view" is introduced, which returns the weston_view of the given ivi_layout_surface. The API returns a NULL pointer

Re: [PATCH 2/5] ivi-shell: remove struct link_layer

2015-10-01 Thread Nobuhiko Tanibata
Hi, Tested-by: Nobuhiko Tanibata Reviewed-by: Nobuhiko Tanibata BR, Nobuhiko Tanibata 2015-08-28 21:58 に Ucan, Emre (ADITG/SW1) さんは書きました: link_layer's sole purpose is to link a surface to multiple layers, if the surface should be shown in multiple layers. This can be only achieved, if the su

Re: [PATCH 1/5] ivi-shell: remove struct link_screen

2015-10-01 Thread Nobuhiko Tanibata
Hi, Tested-by: Nobuhiko Tanibata Reviewed-by: Nobuhiko Tanibata These constructors are reserved for a feature of 'a ivi-surface to several layers' and 'a ivi-layer to several screens'. This feature is required for - for example, car navigation application prepares junction guide on a surfac

Re: black surface in desktop shell fullscreen mode

2015-10-01 Thread Pekka Paalanen
On Wed, 30 Sep 2015 09:50:09 -0700 Bill Spitzak wrote: > If you are actually destroying the fullscreen surface, then this sounds > like a bug. Yes. It all depends on what "hide" means in Wayland protocol terms with the applications in question. > The inability to make a fullscreen surface parti

Re: [PATCH] wayland: add a release request on wl_seat

2015-10-01 Thread Jonas Ådahl
On Wed, Sep 30, 2015 at 10:17:49PM +0200, David FORT wrote: > This is required if we want to correctly remove a wl_seat compositor-side. A > wl_seat is announced as a global object, then it is bound by the client. When > the compositor wants to remove the seat, it shall announce the global removal