Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-02 Thread Michael Hasselmann
On Thu, 2012-03-01 at 22:34 -0500, Kristian Høgsberg wrote: Hi Artie, Thanks for starting this. Looks good and certainly when we start adding tests for some of the more complex objects and data structures in the library (wl_map would be a good next step), it will be a good way to avoid

Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-02 Thread Kristian Høgsberg
On Fri, Mar 2, 2012 at 9:30 AM, Chris Morgan chmor...@gmail.com wrote: I found that a good testing framework can lower the barrier of writing useful tests. Nice logging and status reports are important I feel. And if for example you can easily write data driven tests, then testing all possible

RE: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-02 Thread Eoff, Ullysses A
-Original Message- From: Chris Morgan [mailto:chmor...@gmail.com] Sent: Friday, March 02, 2012 7:50 AM To: Kristian Høgsberg Cc: Michael Hasselmann; wayland-devel@lists.freedesktop.org; Eoff, Ullysses A Subject: Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland 2012/3/2 Kristian

RE: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-02 Thread Eoff, Ullysses A
-Original Message- From: hoegsb...@gmail.com [mailto:hoegsb...@gmail.com] On Behalf Of Kristian Høgsberg Sent: Friday, March 02, 2012 7:33 AM To: Michael Hasselmann Cc: Eoff, Ullysses A; wayland-devel@lists.freedesktop.org Subject: Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland

Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-02 Thread Daniel Stone
Hi, On 2 March 2012 21:53, Andreas Ericsson a...@op5.se wrote: I've written a few in my days. Normally, I keep them ridiculously simple, so the testing code looks something like this (sorry for the sucky indentation; coding in a mua is always crap): some_test_func(args) {        test_suite

Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-02 Thread Kristian Høgsberg
On Fri, Mar 2, 2012 at 5:28 PM, Daniel Stone dan...@fooishbar.org wrote: Hi, On 2 March 2012 21:53, Andreas Ericsson a...@op5.se wrote: I've written a few in my days. Normally, I keep them ridiculously simple, so the testing code looks something like this (sorry for the sucky indentation;

Re: [PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-03-01 Thread Kristian Høgsberg
Hi Artie, Thanks for starting this. Looks good and certainly when we start adding tests for some of the more complex objects and data structures in the library (wl_map would be a good next step), it will be a good way to avoid regressing functionality. I'm not convinced that we really need an

[PATCH 0/3] Resubmit - Unit test framework for Wayland

2012-02-29 Thread U. Artie Eoff
From: U. Artie Eoff ullysses.a.e...@intel.com Resubmitting since some recent tip commits cause previous patches to not apply properly. The following patches should apply to today's tip. I've included the contents of my original cover-letter for convenience... Unit testing is a very powerful