wayland-client.h and wayland-server.h include the protocol headers generated
at build time. This means that a libwayland user cannot generate and use
protocol code created from a wayland.xml newer than the installed libwayand,
because it is not possible to only include the API header.
This commit a
On 04/26/2015 11:48 PM, Marek Chalupa wrote:
Is the --include-core-headers option necessary? Until now the scanner
included wayland-client/server.h
which included the %-protocol.h, but since there are inclusion guards,
the protocol header was not
included again - so including wayland-client/ser
2015-04-27 21:53 GMT+03:00 Bill Spitzak :
> On 04/26/2015 11:48 PM, Marek Chalupa wrote:
>
>>
>> Is the --include-core-headers option necessary? Until now the scanner
>> included wayland-client/server.h
>> which included the %-protocol.h, but since there are inclusion guards,
>> the protocol header
On 04/27/2015 01:06 PM, Giulio Camuffo wrote:
2015-04-27 21:53 GMT+03:00 Bill Spitzak :
On 04/26/2015 11:48 PM, Marek Chalupa wrote:
Is the --include-core-headers option necessary? Until now the scanner
included wayland-client/server.h
which included the %-protocol.h, but since there are in
2015-04-28 3:34 GMT+03:00 Bill Spitzak :
>
>
> On 04/27/2015 01:06 PM, Giulio Camuffo wrote:
>>
>> 2015-04-27 21:53 GMT+03:00 Bill Spitzak :
>>>
>>> On 04/26/2015 11:48 PM, Marek Chalupa wrote:
>>>
Is the --include-core-headers option necessary? Until now the scanner
included wayland
On Mon, Apr 27, 2015 at 4:06 PM, Giulio Camuffo
wrote:
> 2015-04-27 21:53 GMT+03:00 Bill Spitzak :
> > On 04/26/2015 11:48 PM, Marek Chalupa wrote:
> >
> >>
> >> Is the --include-core-headers option necessary? Until now the scanner
> >> included wayland-client/server.h
> >> which included the %-p
2015-04-28 9:29 GMT+03:00 Marek Chalupa :
>
>
> On Mon, Apr 27, 2015 at 4:06 PM, Giulio Camuffo
> wrote:
>>
>> 2015-04-27 21:53 GMT+03:00 Bill Spitzak :
>> > On 04/26/2015 11:48 PM, Marek Chalupa wrote:
>> >
>> >>
>> >> Is the --include-core-headers option necessary? Until now the scanner
>> >> in
On Tue, 28 Apr 2015 09:40:39 +0300
Giulio Camuffo wrote:
> 2015-04-28 9:29 GMT+03:00 Marek Chalupa :
> >
> >
> > On Mon, Apr 27, 2015 at 4:06 PM, Giulio Camuffo
> > wrote:
> >>
> >> 2015-04-27 21:53 GMT+03:00 Bill Spitzak :
> >> > On 04/26/2015 11:48 PM, Marek Chalupa wrote:
> >> >
> >> >>
> >>
2015-04-28 12:48 GMT+03:00 Pekka Paalanen :
> On Tue, 28 Apr 2015 09:40:39 +0300
> Giulio Camuffo wrote:
>
>> 2015-04-28 9:29 GMT+03:00 Marek Chalupa :
>> >
>> >
>> > On Mon, Apr 27, 2015 at 4:06 PM, Giulio Camuffo
>> > wrote:
>> >>
>> >> 2015-04-27 21:53 GMT+03:00 Bill Spitzak :
>> >> > On 04/26
Pekka,
Thanks for adding me to the CC. I have one general comment that I
would have made inline with the code had it lasted this far. Please
take this opportunity to remove the deprecated stuff by *not* putting
anything deprecated into wayland-*-core.h. We have to keep it to keep
old apps buildi
The problem is when you have an extension.xml, and generate
extension-client-protocol.h. Then you have some preexisting code
including that and relying on it including wayland-client.h and then
wayland-client-protocol.h, and if you use something from that it will
not build anymore, because wayland
2015-04-29 2:17 GMT+03:00 Bill Spitzak :
>> The problem is when you have an extension.xml, and generate
>> extension-client-protocol.h. Then you have some preexisting code
>> including that and relying on it including wayland-client.h and then
>> wayland-client-protocol.h, and if yo
On 04/29/2015 12:21 AM, Giulio Camuffo wrote:
2015-04-29 2:17 GMT+03:00 Bill Spitzak :
The problem is when you have an extension.xml, and generate
extension-client-protocol.h. Then you have some preexisting code
including that and relying on it including wayland-client.h and then
wayland-client-
2015-04-29 19:06 GMT+03:00 Bill Spitzak :
> On 04/29/2015 12:21 AM, Giulio Camuffo wrote:
>>
>> 2015-04-29 2:17 GMT+03:00 Bill Spitzak :
The problem is when you have an extension.xml, and generate
extension-client-protocol.h. Then you have some preexisting code
i
On 04/29/2015 09:18 AM, Giulio Camuffo wrote:
You commented it out from the wrong file. Comment it in iirc
desktop-shell-client-protocol.h instead, or some other file generated
from a protocol in weston.
Okay I did this in weston:
make clean
make protocol/desktop-shell-client-
On Wed, 29 Apr 2015 09:06:13 -0700
Bill Spitzak wrote:
> On 04/29/2015 12:21 AM, Giulio Camuffo wrote:
> > Just to be clear, are you suggesting the scanner should generate two
> > headers for an xml, one including the old headers and one including
> > the core ones? I'm not sure i see the advanta
On 04/30/2015 03:34 AM, Pekka Paalanen wrote:
Just to be clear, my proposal is:
wayland-client.h : hand-written, includes:
wayland-client-core.h
wayland-client-protocol.h
deprecated api
wayland-client-core.h : hand-written, includes
wl_event_queue, wl_pr
2015-04-30 20:41 GMT+03:00 Bill Spitzak :
> On 04/30/2015 03:34 AM, Pekka Paalanen wrote:
>
>>> Just to be clear, my proposal is:
>>>
>>> wayland-client.h : hand-written, includes:
>>> wayland-client-core.h
>>> wayland-client-protocol.h
>>> deprecated api
>>>
>>> way
On 04/30/2015 11:03 AM, Giulio Camuffo wrote:
Functionally the initial patch and the latest ones are exactly the
same, so not sure what you're talking about
No they are not. The original patch and my proposal has
*-client-protocol.h file including wayland-client-core.h. The latest one
ha
2015-04-30 21:18 GMT+03:00 Bill Spitzak :
> On 04/30/2015 11:03 AM, Giulio Camuffo wrote:
>
>> Functionally the initial patch and the latest ones are exactly the
>> same, so not sure what you're talking about
>
>
> No they are not. The original patch and my proposal has *-client-protocol.h
> fi
20 matches
Mail list logo
