Re: [webkit-dev] Cleaning up Document

2010-08-17 Thread Darin Adler
On Aug 17, 2010, at 12:11 PM, Eric Seidel wrote: Window at least used to have its API spread across many classes (including frame, and at least 2 window classes). That is a historical anomaly. Some classes like Window used to be implemented in the bindings layer. That was a bad idea, mixing

Re: [webkit-dev] On IDL files, events and writing DOM bindings

2010-08-11 Thread Darin Adler
On Aug 10, 2010, at 11:39 PM, Xan Lopez wrote: For the GObject bindings I'm actually exposing the events directly. This is a new feature, no other binding has this, and you will have to build everything yourself. There’s nothing in IDL files, or in fact anywhere in the project, that lists all

Re: [webkit-dev] PtrT

2010-08-11 Thread Darin Adler
On Aug 7, 2010, at 8:59 PM, Eric Seidel wrote: How about we add a PtrT (or WeakPtrT or AutoNullT or whatever) I worked on another project years ago where they had a template like this. The issue is with a variety of built-in data types, not specific to pointers. Any built-in data type such as

Re: [webkit-dev] On IDL files, events and writing DOM bindings

2010-08-10 Thread Darin Adler
The bindings do not expose events directly, thus the IDL files don’t show the events. The IDL files only show functions and attributes on the various objects. Events are neither functions nor attributes. For the bindings I am familiar with, there is no list of events and so nothing to be

[webkit-dev] How can I stop getting buildbot ChromeOS failure mails?

2010-08-04 Thread Darin Adler
I got a large mail that started with this: http://build.chromium.org/buildbot/chromiumos/ Automatically closing tree for build image on x86 slab full I don’t want to receive these mails. I don’t understand them. They are full of hex numbers that probably relate to git and check-ins in Chromium

Re: [webkit-dev] Some new coding style rules

2010-08-04 Thread Darin Adler
On Aug 4, 2010, at 1:29 AM, Nikolas Zimmermann wrote: 1. namespace closing brace It was discussed in http://article.gmane.org/gmane.os.opendarwin.webkit.devel/10563, but with no real result. When writing headers, do we need the // namespace Foo comment after the namespace closing

Re: [webkit-dev] Fwd: webkit editing rewrite?

2010-08-04 Thread Darin Adler
On Aug 4, 2010, at 3:48 PM, Ryosuke Niwa wrote: I think the kind of crashes Ojan is talking about are ones caused by DOM mutation events. When we're in a middle of a composite event and fire a DOMModified or whatever appropriate mutation event is, JavaScript can come in and remove node,

Re: [webkit-dev] Name nitpick: layout tests

2010-08-03 Thread Darin Adler
I don’t buy in to this at all. We have done many successful renaming projects in the past. The future is bigger than the past and it’s worthwhile to do maintenance like this. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] webkit editing rewrite?

2010-08-03 Thread Darin Adler
On Aug 3, 2010, at 4:32 PM, Ojan Vafai wrote: Pros: -Ensures that the APIs we expose to the web are at least good enough for our own editing code -Ensures that editing code never crashes (outside of JSC/V8 bugs) -Gives a clean slate for starting the editing code anew -Moves code out of

Re: [webkit-dev] Printer font is different from screen font

2010-07-30 Thread Darin Adler
On Jul 30, 2010, at 2:10 AM, Shinichiro Hamaji wrote: I've noticed WebKit uses slightly different font size for printing on Mac. We should discuss specifics instead of this broad issue. There’s a good chance this is something that has been misdiagnosed. My colleague told me Mac's font API

[webkit-dev] Patches saying “Unreviewed”

2010-07-30 Thread Darin Adler
Hi folks. It’s come to my attention that some webkit-patch or some other script requires that patches without review contain the string “Unreviewed” somewhere in their change log message. I personally think this is not helpful. In my opinion patches that are don’t need review, such as some

Re: [webkit-dev] Patches saying “Unreviewed”

2010-07-30 Thread Darin Adler
It’s totally reasonable for the bot to require a reviewer line, because the bot requires a reviewer on the bug too. It’s in non-bot contexts that I think it’s not good. I think that means I agree with you both who said that running webkit-patch on the command line shouldn't require it. We can

[webkit-dev] Name nitpick: layout tests

2010-07-29 Thread Darin Adler
Hi folks. WebKit regression tests are in a directory named LayoutTests. The object the tests uses to do special test-specific operations is layoutTestController. Both of these names are unwanted baggage, left over from when the test machinery was only good for testing layout. The directory

Re: [webkit-dev] Name nitpick: layout tests

2010-07-29 Thread Darin Adler
On Jul 29, 2010, at 11:09 AM, Ryosuke Niwa wrote: But I'm not sure if converting all the existing tests is feasible or worth the effort. Is there any practical problem other than being semantically wrong? This is not something we have to decide up front. Converting the existing tests is

Re: [webkit-dev] focusin/focusout events

2010-07-27 Thread Darin Adler
On Jul 26, 2010, at 6:32 PM, Ojan Vafai wrote: On Mon, Jul 26, 2010 at 12:06 AM, Darin Adler da...@apple.com wrote: You mention activeElementId, but there must be other side effects that matter. The only other side effects I can think of are the focus outline (which could probably

Re: [webkit-dev] focusin/focusout events

2010-07-26 Thread Darin Adler
On Jul 21, 2010, at 5:24 PM, Ojan Vafai wrote: Opera 10.6: blur, domfocusout, focus, domfocusin Moves activeElement immediately before firing any events. WebKit nightly: blur, (dom)focusout, focus, (dom)focusin Clears activeElement before blur/focusout, sets active element before

Re: [webkit-dev] Does any port implements Navigator.registerProtocolHandler and Navigator.registerContentHandler?

2010-07-23 Thread Darin Adler
This is a matter for the networking layer in your particular port rather than for WebKit itself. It does not require changes to WebKit. The Mac OS X WebKit networking layer, NSURLConnection, has this feature. It’s done by creating a custom NSURLProtocol object. -- Darin

Re: [webkit-dev] How to register another protocol handler

2010-07-23 Thread Darin Adler
On Jul 23, 2010, at 9:46 AM, Flávio Ceolin wrote: First of all, is this a task for WebCore or the port ? If I understand your question correctly, the answer is that it’s a task for the networking layer, which is port-specific. The Mac OS X WebKit networking layer, NSURLConnection, has this

Re: [webkit-dev] Does any port implements Navigator.registerProtocolHandler and Navigator.registerContentHandler?

2010-07-22 Thread Darin Adler
On Jul 22, 2010, at 2:12 PM, Gustavo Sverzut Barbieri wrote: Sorry to disturb this already dead thread, but we're (webkit-efl) thinking of letting applications/browsers register new protocol handlers to provide contents themselves. A co-worker, Flávio Ceolin, will send more details in

Re: [webkit-dev] Clients and the Page constructor

2010-07-21 Thread Darin Adler
On Jul 21, 2010, at 8:47 AM, Steve Block wrote: Currently, nine clients are passed to the Page constructor and the number is growing. Recently, clients have been added for Geolocation, DeviceOrientation and BackForwardController. This approach doesn't seem scalable. What exactly does not

Re: [webkit-dev] SIL Open Font License and WebKit

2010-07-20 Thread Darin Adler
On Jul 20, 2010, at 4:39 AM, Alex Milowski wrote: We can't really download them from stixfonts.org. Why? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] SIL Open Font License and WebKit

2010-07-20 Thread Darin Adler
On Jul 20, 2010, at 8:24 AM, Alex Milowski wrote: some organization should accept the terms of the license and the responsibility for distributing this font to test systems (or developers running tests). Some organization? You lost me there. Isn’t the STI Pub Companies an organization?

Re: [webkit-dev] SIL Open Font License and WebKit

2010-07-20 Thread Darin Adler
On Jul 20, 2010, at 8:45 AM, Alex Milowski wrote: On Tue, Jul 20, 2010 at 4:35 PM, Darin Adler da...@apple.com wrote: On Jul 20, 2010, at 8:24 AM, Alex Milowski wrote: some organization should accept the terms of the license and the responsibility for distributing this font to test systems

Re: [webkit-dev] Trees on fire, how commit-bot does and does not help

2010-07-08 Thread Darin Adler
On Jul 8, 2010, at 10:58 AM, Xan Lopez wrote: Oh, and might this serve as a ping for whoever set the trees on fire... at least some of it seems related to the refPtr work that's been going on (see https://bugs.webkit.org/show_bug.cgi?id=41823) Yes, I’ll be working on this more today. I

Re: [webkit-dev] Trees on fire

2010-07-08 Thread Darin Adler
On Jul 8, 2010, at 11:05 AM, Darin Adler wrote: Yes, I’ll be working on this more today. I could use some help diagnosing what’s going wrong on various platforms. Most of the problems caused by the adoptRef change should be fixed now. Just need to wait for the bots to catch up and see

[webkit-dev] Chromium bots red; does someone know how to fix it?

2010-07-07 Thread Darin Adler
Who has the knowledge and access needed to fix problems like this? svn: Working copy '/Users/cltbld/Desktop/BuildSlaveData/WebKit-BuildSlave/chromium-mac-release/build/WebKit/chromium/sdch/open-vcdiff' locked svn: run 'svn cleanup' to remove locks (type 'svn help cleanup' for details) svn:

Re: [webkit-dev] Closing MathML Bugs?

2010-07-05 Thread Darin Adler
On Jul 5, 2010, at 5:52 AM, Alex Milowski wrote: What's the process for closing out a MathML related bug? Generally someone can change the state of any bug if that person is in a position to know it should change. So you could move these to resolved as long as you have sufficient permissions

Re: [webkit-dev] DefaultMarkViolation assertion failure

2010-07-02 Thread Darin Adler
On Jul 2, 2010, at 7:24 AM, dan.podw...@nokia.com wrote: Can anyone provide some background on the MarkStack::m_isCheckingForDefaultMarkViolation member and what it means when asserts on it fail? There’s a flag in the structure that indicates whether a particular type of JSCell needs to

Re: [webkit-dev] SVG cloneNode?

2010-06-30 Thread Darin Adler
As I see it, the issue shown in your test case is that cloning animated attributes does not clone the animation parameters. That’s something we will need to solve. We should not solve it by overriding copyNonAttributeProperties and hand-writing it in each class. I don’t know enough about the

[webkit-dev] Tightening up smart pointer usage rules

2010-06-28 Thread Darin Adler
Hi folks. I’d like to use our smart pointers more consistently to decrease the chances of memory leaks or other similar problems. My proposal is that we have a rule that all calls to new are immediately followed by putting the object into a smart pointer. The main types of smart pointer that

Re: [webkit-dev] Tightening up smart pointer usage rules

2010-06-28 Thread Darin Adler
On Jun 28, 2010, at 2:14 PM, Adam Barth wrote: Do we need an exception for statics that we intend to leak at shutdown? Maybe leakPtr(new Foo)? Maybe. My first thought for such things is that I’d prefer to write them as: adoptPtr(new Foo).releasePtr() At first that may look strange, but

Re: [webkit-dev] Tightening up smart pointer usage rules

2010-06-28 Thread Darin Adler
On Jun 28, 2010, at 2:55 PM, Antti Koivisto wrote: Is the plan also to banish the std::auto_ptr? It seems pointless and confusing to allow both the OwnPtr and the auto_ptr. Yes, that would be my preference. PassOwnPtr is intended as a replacement for std::auto_ptr. Before PassOwnPtr

Re: [webkit-dev] Interpreting LEAK: on Shutdown

2010-06-22 Thread Darin Adler
On Jun 22, 2010, at 1:30 PM, Alex Milowski wrote: But how do you avoid this: No leak checking done: At least one WebView is still open. There’s no real need to avoid that one. It’s just advisory. If you quit all the windows you still get it. If you get it even after closing all windows,

Re: [webkit-dev] MathML Component in bugs.webkit.org?

2010-06-22 Thread Darin Adler
On Jun 22, 2010, at 8:28 AM, Alex Milowski wrote: Could someone create a MathML component for bug reports in Bugzilla? Sure, I added it. I hope it’s helpful to have a separate component for this. I’m not entirely sure we get a lot of value out of the separate bugs.webkit.org components we

Re: [webkit-dev] Faster bot cycle times on Windows (Re: Bots temporarily red)

2010-06-18 Thread Darin Adler
On Jun 18, 2010, at 1:28 PM, Adam Barth wrote: On Fri, Jun 18, 2010 at 1:22 PM, Adam Roben aro...@apple.com wrote: I've been looking into these. I got the Windows bots down from 11 failures to 3 failures on Wednesday. The main difficulty I have with the windows bots is that they get really

Re: [webkit-dev] Initialization of Attribute Map

2010-06-18 Thread Darin Adler
This is the kind of discussion we usually have in bug reports. First step would be to put the bug report into bugs.webkit.org. To answer your question, it’s not legal to call StyledElement::classNames without first checking hasClass. And if hasClass is true, then there will already be an

Re: [webkit-dev] A proposal for Platform Mechanisms

2010-06-16 Thread Darin Adler
Sounds reasonable to me. We already follow pointers and use virtual functions for all these things, so I don’t see them adding a lot of overhead. Would these Mechanism classes replace all the current Client classes? Would the mechanism objects be obtained once and cached globally? How is the

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Adler
For what it’s worth, this kind of pattern was quite common in the Mac OS X WebKit API, with public enums in the Objective-C API that exactly matched private enums inside WebCore and had to be kept in sync. Over the years, working towards the goal of making WebKit better cross-platform, we’ve

Re: [webkit-dev] WebAccessibilityRole must match AccessiblityRole enums?

2010-06-04 Thread Darin Adler
If the two enum types are identical except for their names, then this doesn’t firewall the types at all. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Making changes to our copy of the W3C CSS1 test suite

2010-06-03 Thread Darin Adler
On Jun 3, 2010, at 2:30 PM, Ojan Vafai wrote: On Wed, Jun 2, 2010 at 6:20 PM, Darin Adler da...@apple.com wrote: 1) There’s one directory with a pristine copy of the W3C test suite, with no WebKit changes. 2) If there are some tests that need to be fixed, fixed copies of those

Re: [webkit-dev] Style question: static, protected, or public members

2010-06-02 Thread Darin Adler
On Jun 1, 2010, at 10:09 PM, Eric Seidel wrote: Let me summarize to see if I understand what should be updated in the style guide/check-webkit-style: Class static member variables should have an s_ prefix. Protected and public member variables should be disallowed. Private member

Re: [webkit-dev] How to handle a new protocol for Blob.url support?

2010-06-02 Thread Darin Adler
On Jun 1, 2010, at 5:14 PM, Jian Li wrote: I am working on Blob.url support as defined in the latest version of File API (http://dev.w3.org/2006/webapi/FileAPI/). The Blob.url will return a URL that can be used to refer to the blob object in a resource request, like

Re: [webkit-dev] Making changes to our copy of the W3C CSS1 test suite

2010-06-02 Thread Darin Adler
On Jun 2, 2010, at 11:29 AM, Eric Seidel wrote: What's the process for making changes to those files? Here’s how I think we should do it: 1) There’s one directory with a pristine copy of the W3C test suite, with no WebKit changes. 2) If there are some tests that need to be fixed,

Re: [webkit-dev] question about download vs. display for text/* MIME types

2010-05-27 Thread Darin Adler
On May 27, 2010, at 12:49 AM, allstars.chh wrote: such as JAD of the midlet http://en.wikipedia.org/wiki/JAD_(file_format) mime type:text/vnd.sun.j2me.app-descriptor but in this case , the JAD will be threated as a DOM and loaded by webkit instead of triggering download procedure The

Re: [webkit-dev] question about download vs. display for text/* MIME types

2010-05-27 Thread Darin Adler
What does Firefox do with files of this MIME type? What does Internet Explorer do? Please add that information to the bug. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Building WebKit on windows for the first time

2010-05-26 Thread Darin Adler
On May 26, 2010, at 9:30 AM, Ojan Vafai wrote: Isn't this a development of WebKit question? It’s a “how to build WebKit” question, which is one of the main purposes of webkit-help. See the details on http://webkit.org/contact.html. I thought webkit-help was for web development questions

Re: [webkit-dev] Style question: static, protected, or public members

2010-05-25 Thread Darin Adler
On May 25, 2010, at 3:05 AM, TAMURA, Kent wrote: Generally speaking I suggest we do not use the m_ prefix for the members of structs. And I suggest that classes with public data members be structs instead of classes. Classes that have public data members only for historical reasons should

Re: [webkit-dev] free functions

2010-05-25 Thread Darin Adler
On May 25, 2010, at 7:54 AM, Chris Jerdonek wrote: I sometimes come across public member functions whose implementations do not depend on private data. There is a school of thought that such functions are better non-member because it reduces the number of functions coupled to private

Re: [webkit-dev] Support for showModalDialog in WebKit

2010-05-21 Thread Darin Adler
On May 21, 2010, at 6:40 PM, Prasad Tammana wrote: 2) Added code to invoke abortModal from NSWindowWillCloseNotification notification. I didn’t tell you do do that, and I don’t know why you’re calling abortModal. -- Darin ___ webkit-dev

[webkit-dev] More webkit-patch requests

2010-05-21 Thread Darin Adler
I’d like webkit-patch to assign new bugs it creates to me. It’s hard for me to find these machine-filed bugs when they aren’t assigned. It would also be nice if I could grab assignment of existing bugs when uploading a patch to them. This hasn’t come up for me yet in practice but used to be

[webkit-dev] webkit-patch requests

2010-05-19 Thread Darin Adler
Not sure where to put these. A while ago people were talking about changes needed to webkit-patch. Here are some of the basics for me for one command, webkit-patch upload. When I use webkit-patch upload to create a patch in a tree where I have not yet written anything for change log,

[webkit-dev] What is the webkit-patch version of svn-unapply?

2010-05-19 Thread Darin Adler
Lets say I just did webkit-patch upload and I am Subversion user and I now want the patch out of my tree. Does webkit-patch have a command to help me do it? I can’t just use svn revert because that doesn’t handle things like added, removed, and moved files. -- Darin

Re: [webkit-dev] webkit-patch requests

2010-05-19 Thread Darin Adler
On May 19, 2010, at 10:52 AM, Adam Barth wrote: Thanks for the feedback. Webkit-patch already respects the EDITOR environment variable. It should be a simple change to support the CHANGE_LOG_EDIT_APPLICATION environment variable also. The function that needs to change is:

Re: [webkit-dev] What is the webkit-patch version of svn-unapply?

2010-05-19 Thread Darin Adler
On May 19, 2010, at 10:56 AM, Adam Barth wrote: On Wed, May 19, 2010 at 10:41 AM, Darin Adler da...@apple.com wrote: Lets say I just did webkit-patch upload and I am Subversion user and I now want the patch out of my tree. Does webkit-patch have a command to help me do it? I can’t just use

Re: [webkit-dev] What is the webkit-patch version of svn-unapply?

2010-05-19 Thread Darin Adler
On May 19, 2010, at 11:15 AM, Adam Barth wrote: Personally, I don't have multiple patches in my tree at the same time, so I don't understand what would be the most convenient for you. Removing the update step is easy, but I'm not sure how you would like to specify the changes to remove from

Re: [webkit-dev] What is the webkit-patch version of svn-unapply?

2010-05-19 Thread Darin Adler
On May 19, 2010, at 11:22 AM, Jeremy Orlow wrote: What if we added an option to webkit-patch upload that unapplies the patch at the end? In fact, for the first iteration, it could simply save the patch in some temporary location and then run 'svn-unapply'. In other words, do what you

Re: [webkit-dev] What is the webkit-patch version of svn-unapply?

2010-05-19 Thread Darin Adler
On May 19, 2010, at 2:05 PM, Chris Jerdonek wrote: I've always wondered the extent to which svn-unapply works for people. It works well for me most of the time. I have some vague memories of recent problems with removed and added files. I’ll try to pay closer attention now. -- Darin

Re: [webkit-dev] Support for showModalDialog in WebKit

2010-05-19 Thread Darin Adler
On May 19, 2010, at 3:00 PM, Prasad Tammana wrote: I'm trying to add support for testing scenarios in the presence of modal dialogs to DumpRenderTree (DRT) and I'm running into an apparent limitation of WebKit support for showModalDialog JavaScript function. Here is what I'm trying to do:

Re: [webkit-dev] webkit build error

2010-05-18 Thread Darin Adler
The mailing list for questions about how to build WebKit is webkit-help, not webkit-dev. Please see http://webkit.org/contact.html. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] converting by constructor

2010-05-17 Thread Darin Adler
I think the Google guideline is pretty close to what a WebKit guideline would be. The explicit keyword should almost always be used when a constructor is creating an object and not just converting type from one to another. Leaving out the explicit keyword should be thought of as equivalent to

Re: [webkit-dev] HitTest'ing scrollbars

2010-05-09 Thread Darin Adler
I think your analysis is right, but I’m not sure. Hyatt did a lot of the scrollbar work for Windows that was later imitated on the other platforms. Maybe he can comment on this? -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] JS event listener

2010-04-30 Thread Darin Adler
This is a question for webkit-help, not webkit-dev. See http://webkit.org/contact.html. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

[webkit-dev] Trouble reviewing patches since the experimental commenting support went into bugs.webkit.org's action=review page

2010-04-22 Thread Darin Adler
I’m having trouble reviewing patches with the action=review patch since the experimental commenting support was added. I now have to do a lot of editing and copying and pasting when reviewing that was not necessary before. - The action=review JavaScript code now deletes the copy of the patch,

Re: [webkit-dev] CMake vs. Apple's build farm

2010-04-21 Thread Darin Adler
On Apr 21, 2010, at 9:45 AM, Adam Treat wrote: Can someone from Apple comment on whether it is possible to include the sources to CMake and then the CMake could bootstrap itself with only dependency on the compiler? This would seem an acceptable solution, no? Hard to comment on something

Re: [webkit-dev] CMake vs. Apple's build farm

2010-04-20 Thread Darin Adler
On Apr 20, 2010, at 10:06 AM, Bradley Nelson wrote: Would prebuilt checked-in binaries be an option? No. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Implementing the sizes attribute of the link tag from HTML5

2010-04-19 Thread Darin Adler
On Apr 15, 2010, at 3:41 PM, Aaron Boodman wrote: On Thu, Apr 15, 2010 at 3:25 PM, Maciej Stachowiak m...@apple.com wrote: Well, it's hard to truly have consensus on adding feature without knowing what it is. That being said, I at least would love to see a more specific proposal for what we

Re: [webkit-dev] currentTime() and UTC time

2010-04-19 Thread Darin Adler
On Apr 19, 2010, at 7:11 PM, Holger Freyther wrote: I once had a patch to use clock_gettime but I discarded it as the call is slower than gettimeofday. I have a micro benchmark for that here[1]. Also tangentially related, I found an article about the lack of clock_gettime on Mac OS X.

Re: [webkit-dev] multi-process always

2010-04-09 Thread Darin Adler
The prototype works with both a threaded model and a multiple process model, chosen at runtime. It seems worthwhile to keep this feature. Anders told me he often turns on the threaded model to debug since the development tools we have work better with a single process and multiple threads than

Re: [webkit-dev] A Range question

2010-04-09 Thread Darin Adler
On Apr 9, 2010, at 10:52 AM, Finnur Thorarinsson wrote: I need a WebKit Ranger for this question: Imagine I have the word Foo inside an edit field (input type=text value=Foo) and the word bar outside of it, like so: [Foo]bar If I try to create a Range of the text Foobar, the range will

Re: [webkit-dev] A Range question

2010-04-09 Thread Darin Adler
On Apr 9, 2010, at 11:06 AM, Finnur Thorarinsson wrote: Fair enough. I can see why it should ignore those matches, but if you look at the details for the bug (https://bugs.webkit.org/show_bug.cgi?id=25868) it states that the markAllMatchesForText function not only ignores the match but it

Re: [webkit-dev] Announcing WebKit2

2010-04-08 Thread Darin Adler
On Apr 8, 2010, at 5:47 PM, Xan Lopez wrote: - In the wiki you mention that one goal of the new framework is to provide a stable C-based API. Is this meant as a public API for WebKit, the same in all platforms (like JSC), or a stable internal API for embedders to use in order to implement

Re: [webkit-dev] Rich Text Editing Questions, Refactoring of Position Classes

2010-04-06 Thread Darin Adler
On Apr 6, 2010, at 9:29 AM, Alexey Proskuryakov wrote: 05.04.2010, в 22:46, Maciej Stachowiak написал(а): The current implementation allows for (and operates on) positions such as [img, 0] - [img, 1] or [br,0] - [br, 1]. Is there a fundamental reason to keep such positions within the

Re: [webkit-dev] The green tree era

2010-04-04 Thread Darin Adler
On Apr 3, 2010, at 10:36 AM, Adam Barth wrote: Keeping the tree green will require a cultural shift in the project, but I think the near term costs of changing the culture are outweighed by the long term gains in productivity. Typically a cultural shift would come after some sort of group

Re: [webkit-dev] To start meter element implementation

2010-04-04 Thread Darin Adler
On Apr 4, 2010, at 7:31 PM, Maciej Stachowiak wrote: I believe progress is only currently enabled for the Qt port, in part because no one has implemented the other themes. This was true on Friday, but on Saturday http://trac.webkit.org/changeset/57051 enabled it for the Mac OS X port. I

Re: [webkit-dev] Directly Destroy webview widget

2010-04-02 Thread Darin Adler
See http://webkit.org/contact.html for information about mailing lists. This mailing list, webkit-dev, is for discussion of the development of WebKit. For questions like yours about the use of WebKit, webkit-help is the appropriate list. And there’s also a list called webkit-gtk that might be

Re: [webkit-dev] Audio directory layout

2010-03-30 Thread Darin Adler
On Mar 30, 2010, at 5:19 PM, Adam Barth wrote: The platform directory contains a lot more than just platform-specific files. It's the platform upon which WebCore is built. For example, KURL is in platform even though it's shared by all the ports. I think the main consideration for whether

Re: [webkit-dev] DEFINE_STATIC_LOCAL

2010-03-29 Thread Darin Adler
On Mar 29, 2010, at 1:10 PM, Eric Seidel wrote: http://trac.webkit.org/changeset/38411 mentions the GCC bug I was referring to. I've never seen the Radar so I don't know what it was about exactly. I see where the confusion is coming from. The GCC bug is not the reason we have

Re: [webkit-dev] Crashing Workers Code?

2010-03-29 Thread Darin Adler
On Mar 29, 2010, at 5:14 PM, Dmitry Titov wrote: JSC workers are terminated by setting a 1-ms timeout. V8 workers terminate by throwing exception of a special kind and then checking for it in C++ code. There is precedent in JavaScriptCore for using a special exception to terminate code.

Re: [webkit-dev] Web developer documentation - working with Mozilla

2010-03-22 Thread Darin Adler
On Mar 22, 2010, at 7:26 AM, henry.haveri...@nokia.com wrote: If we did that, we should have some kind of in-line mark-up (like Doxygen or qdoc) for adding the descriptions and other fields, so we could repeatedly auto-generate the docs. If the markup isn’t too repetitive than I think it

Re: [webkit-dev] WebKit Icon license?

2010-03-19 Thread Darin Adler
On Mar 19, 2010, at 8:40 AM, Dimitri Glazkov wrote: Would you happen to know how WebKit icon is licensed? The icon currently on webkit.org has the icon for Apple’s Safari web browser in it. Because of that, Apple has provided no license to use the icon; we are continuing to use it with

Re: [webkit-dev] WebKit produces wrong result on autocomplete, after user uses back button

2010-03-16 Thread Darin Adler
Thanks for yourinterest in WebKit. Sending mail to this list is not the correct way to file a bug report. Please see http://webkit.org/quality/reporting.html, which describes how to do that. -- Darin ___ webkit-dev mailing list

Re: [webkit-dev] Invoking script from NPAPI plugin

2010-03-11 Thread Darin Adler
On Mar 10, 2010, at 10:36 PM, Ohayon, Gil wrote: Can you please give me a pointer in WebCore where to look for the bug, so I can start look into it myself. Sorry, I don’t understand. You should file a bug report first with an example showing the bug and steps to reproduce. Then we will have

Re: [webkit-dev] Invoking script from NPAPI plugin

2010-03-11 Thread Darin Adler
On Mar 11, 2010, at 9:48 AM, Ohayon, Gil wrote: Sure, I’ll file a bug. Lets have that discussion in the bug report. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] gdb 7.0 [Re: Questions regarding memory debugging]

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 8:47 AM, Evan Martin wrote: I guess this file should probably live in the WebCore tree somewhere. I hadn't gotten around to it because I wasn't sure where it belonged. If anyone has a good idea where it should go I'll commit it. In WebKitTools, either at the top level,

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 9, 2010, at 8:56 PM, Holger Freyther wrote: Now SharedBuffer is refcounted and can only leak if someone is holding a reference to it and this is where stuff gets tricky. Besides manually searching the tree and adding printf's all over has anyone found a better way of doing this?

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 10:06 AM, Greg Simon wrote: This would be a really great topic for the webkit meeting in April. At Palm we spend a significant amount of development time dealing with memory “growth” (not so much leaks). Google perf tools has worked very well for us on desktop as it

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 11:15 AM, Mike Marchywka wrote: I haven't looked at this code but is SharedBuffer thread safe etc? SharedBuffer uses RefCounted, an implementation that works only on a single thread, as opposed to the slower CrossThreadRefCounted. We can test your guess about the memory

Re: [webkit-dev] Questions regarding memory debugging

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 11:48 AM, Zoltan Herczeg wrote: I have a technique to capture ref/deref problems with gdb. When the object is created (inside the object constructor), I just put a write break point to the address of m_refCount: watch this-m_refCount in gdb. The backtrace can be

Re: [webkit-dev] what is sentencegranularity?

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 1:05 PM, Ojan Vafai wrote: The topic of sentence granularity selections came up in https://bugs.webkit.org/show_bug.cgi?id=33413. I'm trying to understand, moving forward, how to test the correct behavior for sentence granularity. As best I can tell, it's not a Mac

Re: [webkit-dev] Invoking script from NPAPI plugin

2010-03-10 Thread Darin Adler
On Mar 10, 2010, at 12:57 PM, Ohayon, Gil wrote: I have a NPAPI plugin which I wish to use to push updates into a web page. The plugin get’s updates from a remote process and generate JS code which is passed back to the web page using NPN_Invoke or NPN_Evaluate. My problem is that page is

Re: [webkit-dev] Proxy help

2010-03-04 Thread Darin Adler
Wrong list for this question. You could try webkit-gtk or webkit-help. http://webkit.org/contact.html http://lists.webkit.org/mailman/listinfo.cgi/webkit-gtk http://lists.webkit.org/mailman/listinfo.cgi/webkit-help -- Darin ___ webkit-dev mailing

Re: [webkit-dev] Mouse handling Bug ?

2010-03-04 Thread Darin Adler
This is the list for discussing development of WebKit, not for reporting bugs or asking for help getting WebKit working. How to report bugs: http://webkit.org/quality/reporting.html. Explanation of some mailing lists: http://webkit.org/contact.html. The webkit-gtk mailing list:

Re: [webkit-dev] rangeParent and rangeOffset of mouseEvent in Javascript

2010-03-02 Thread Darin Adler
This mailing list is for discussion of the development of WebKit, not help using WebKit. Please see http://webkit.org/contact.html. Your question is more appropriate for webkit-help. On Mar 1, 2010, at 5:45 PM, baizhenxuan wrote: in firefox, mouseEvent has property rangeParent and rangeOffset

Re: [webkit-dev] Question on FormData interface and implementation

2010-02-25 Thread Darin Adler
On Feb 25, 2010, at 4:11 PM, Jian Li wrote: I like option 3 since it seems to be the one to involve far less changes. However, people who read the code really need to get a good understanding of differences between FormData and DOMFormData. Lets start with this, and later if we think of

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Darin Adler
On Feb 23, 2010, at 8:08 AM, Ariya Hidayat wrote: When the test is run, the browser loads both files, takes snapshots, and does a pixel comparison. Thus font differences between platforms become less of an issue. Isn't it our existing pixel test infrastructure? Or do you mean something

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Darin Adler
On Feb 23, 2010, at 9:58 AM, Dirk Schulze wrote: But how do we write tests for box-shadows, gradients or patterns on a text (like in SVG)? Possibly with canvas. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org

Re: [webkit-dev] SmartDelete incorrect?

2010-02-23 Thread Darin Adler
On Feb 22, 2010, at 6:47 PM, Ojan Vafai wrote: As best I can tell, smart delete/paste were added for Mail at http://trac.webkit.org/changeset/7627. Until now, I've understood that the correct Mac platform text editing behavior is what TextEdit does. I’ll check with some folks here at Apple

Re: [webkit-dev] SmartDelete incorrect?

2010-02-23 Thread Darin Adler
On Feb 22, 2010, at 6:47 PM, Ojan Vafai wrote: From the test: Tests: Smart delete when deleting the first word on a line. Expected Results: The first word and the space following the first word should be deleted. That is the correct result. But you only get smart deletion you use double

Re: [webkit-dev] Increasing the number of cross-platform/port expected results

2010-02-23 Thread Darin Adler
On Feb 23, 2010, at 11:06 AM, Andras Becsi wrote: I like this concept of reftests because it seems easier to maintain and scales better on multiple ports than the current form of testing. A reftest-style test seems like a good alternative to a pure text test. It can handle testing a lot more

Re: [webkit-dev] focus property of node

2010-02-16 Thread Darin Adler
On Feb 12, 2010, at 9:59 PM, jyotigoyal wrote: I am new to webkit. I need to set that property of a node which makes a node focusable. which is that property ? how do I access this property of node to find whether it is focussed or not. This is a mailing list for development of WebKit, not

<    2   3   4   5   6   7   8   9   10   11   >