Re: [webkit-dev] JSC: Callback functions returning exception, what should be the JSValueRef return?

2009-08-11 Thread Darin Adler
The design is that the return value is ignored. In theory, you can safely return anything, even a garbage pointer. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] resolve-ChangeLogs now seems to be broken the same was prepare-ChangeLog was before

2009-08-10 Thread Darin Adler
On Aug 10, 2009, at 10:53 AM, Peter Kasting wrote: Try changing the last line of canonicalRelativePath() from: return File::Spec->abs2rel($absolutePath); to return File::Spec->abs2rel($absolutePath, Cwd::getcwd()); That seems to have fixed the problem. -- Darin ___

Re: [webkit-dev] Using JavaScriptCore in Win32

2009-08-10 Thread Darin Adler
On Aug 10, 2009, at 10:44 AM, Brian Barnes wrote: JSBase.h includes stdbool.h, which is where this error comes from. I need JSBase to compile scripts, unless I'm mistaken here. The the os-win32 directory is not intended for use from clients using JavaScriptCore, and it shouldn't be in your

[webkit-dev] resolve-ChangeLogs now seems to be broken the same was prepare-ChangeLog was before

2009-08-10 Thread Darin Adler
$ resolve-ChangeLogs WebCore/ChangeLog svn: warning: '../../../../Volumes/Home/darin/Safari/OpenSource/ WebCore/ChangeLog' is not a working copy WARNING: ../../../../Volumes/Home/darin/Safari/OpenSource/WebCore/ ChangeLog is not in a conflicted state. Anyone know who broke this? -- Darin

Re: [webkit-dev] Using JavaScriptCore in Win32

2009-08-10 Thread Darin Adler
On Aug 10, 2009, at 8:27 AM, Brian Barnes wrote: I'm attempting to use JSC in my win32 port of my application, and am running into a number of problems. I suspect they all stem from the fact that there must be some #defines I need to properly set before compiling the headers or some other

Re: [webkit-dev] scroll areas of 's

2009-08-04 Thread Darin Adler
On Aug 4, 2009, at 2:57 PM, Chris Fleizach wrote: How do the scroll areas that encompass text areas fit into the render tree? I need to turn that scroll area into an accessible object, but when I look at the render tree i don't see anything that would indicate there is a renderer associat

Re: [webkit-dev] SLL_Pop list is not checked for NULL

2009-08-03 Thread Darin Adler
On Aug 3, 2009, at 5:00 AM, Luka Napotnik wrote: In JavaScriptCore/wtf/FastMalloc.cpp:696 The list should be checked for NULL. No, that’s incorrect. The code is fine as it is. There’s only one caller and that caller guarantees that neither list nor *list is 0. Is there some reason you thi

Re: [webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Darin Adler
On Aug 2, 2009, at 2:05 AM, Adam Barth wrote: In any case: https://bugs.webkit.org/show_bug.cgi?id=27931 I'll have a patch shortly. Please let me know if there are other call sites you'd like changed. Thanks! Once you pointed out this was not due to a recent change, I had resolved to

[webkit-dev] JavaScript bindings changed to call scriptExecutionContext virtual function?

2009-08-02 Thread Darin Adler
I noticed that many JavaScript binding implementations are now calling the virtual function scriptExecutionContext on DOM nodes. This should never be done! That's a virtual function, so it's not as fast as calling document(). The virtual Node::scriptExecutionContext() function should be mad

Re: [webkit-dev] document()->frame()->script()->globalObject()

2009-07-24 Thread Darin Adler
On Jul 24, 2009, at 11:05 AM, Adam Barth wrote: Do you have specific areas you're concerned about that we can be on the lookout for? I tried to think this through, but only had a few minutes free: A minor concern is that Frame has a constellation of helper classes to help keep it simple, i

[webkit-dev] Proposal about integer types used in WebKit

2009-07-24 Thread Darin Adler
Hi folks. The WebKit project assumes the LP64 approach to 64-bit. Roughly speaking, that means that: - int is a signed 32-bit integer - unsigned is an unsigned 32-bit integer - long long is a signed 64-bit integer - unsigned long long is an unsigned 64-bit integer And long an

Re: [webkit-dev] document()->frame()->script()->globalObject()

2009-07-24 Thread Darin Adler
On Jul 23, 2009, at 5:56 PM, Eric Seidel wrote: It sounds like you agree with me, that the Document should have a way to get to the JSDOMGlobalObject w/o having to go through the Frame. Am I understanding correctly? Yes, Maciej is saying that the document could point to the JSDOMWindow, w

Re: [webkit-dev] exposing the value of Accept-Language via window.navigation.acceptLanguage ?

2009-07-23 Thread Darin Adler
On Jul 22, 2009, at 10:36 PM, Darin Fisher wrote: Firefox and Chrome send very similar A-L headers. Given FF's marketshare, I'm surprised you observed compat problems with doing the same. Was that a recent observation? Can you provide more details about the issues you observed? I’m not fa

Re: [webkit-dev] HasStandardGetOwnPropertySlot

2009-07-22 Thread Darin Adler
On Jul 22, 2009, at 5:35 PM, Eric Seidel wrote: What is HasStandardGetOwnPropertySlot adding? Is it testable? It’s an optimization. If it’s set, then the JavaScript engine won’t even call getOwnPropertySlot, saving the overhead of a virtual function call. If it’s not set, then the engine

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
On Jul 20, 2009, at 2:50 PM, Peter Kasting wrote: my ($newdir) = @_; my $before = Cwd::getcwd(); chdir $newdir; my $after = Cwd::getcwd(); That seems like it ought to work a lot better. Yes, it does. Hooray! -- Darin ___ webkit-dev mailing lis

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
On Jul 20, 2009, at 2:40 PM, Peter Kasting wrote: It looks from here like the chdir call is causing curdir() to report the non-symbolic-link form of things. If that's true, it seems like this workaround would work: Makes sense. ... my ($newdir) = @_; my $before = File::Spec->rel2abs( Fil

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
On Jul 20, 2009, at 2:17 PM, Peter Kasting wrote: In the meantime, I've tried and failed to recreate Darin's problem locally, so I'm at the mercy of other people to report that they're having this problem. The key here is that "/Users/darin" is a symbolic link to "/Volumes/ Home/darin" — y

Re: [webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
On Jul 20, 2009, at 1:38 PM, Peter Kasting wrote: On Mon, Jul 20, 2009 at 1:28 PM, Darin Adler wrote: svn: Path '../..' ends in '..', which is unsupported for this operation This warning was caused by a change of mine that I checked in a fix for at noon on Friday.

[webkit-dev] svn-create-patch acting oddly lately

2009-07-20 Thread Darin Adler
My patches look like this now: $ svn-create-patch svn: Path '../..' ends in '..', which is unsupported for this operation Index: ../../../../../Users/darin/Safari/OpenSource/WebKit/mac/WebView/ WebHTMLView.mm === --- ../../../../..

Re: [webkit-dev] ExecState::thisObject()

2009-07-13 Thread Darin Adler
On Jul 13, 2009, at 2:36 PM, Maciej Stachowiak wrote: Don't you need an ExecState to report exceptions, including the uncatchable out-of-memory exception? Or does that work differently now? It works differently now. A JSGlobalData is all you need to report exceptions. -- Darin

Re: [webkit-dev] Patch process - let's make it better

2009-07-11 Thread Darin Adler
On Jul 10, 2009, at 4:23 PM, Maciej Stachowiak wrote: Perhaps we should make update-webkit (or some new wrapper type tool) run resolve-ChangeLogs automatically. Dave Kilzer had the same idea when he created resolve-ChangeLogs, so update-webkit does run resolve-ChangeLogs automatically. See

Re: [webkit-dev] Coding convention of constants

2009-07-09 Thread Darin Adler
On Jul 8, 2009, at 9:08 PM, KwangYul Seo wrote: I found another style which starts with "k". [4] platform/chromium/PopupMenuChromium.cpp static const int kMaxVisibleRows = 20; static const int kMaxHeight = 500; static const int kBorderSize = 1; static const TimeStamp kTypeAheadTimeoutMs = 1000

Re: [webkit-dev] Changes to prepare-ChangeLog

2009-07-09 Thread Darin Adler
On Jul 9, 2009, at 1:47 AM, Maciej Stachowiak wrote: (the /b/ URL is a redirect): I'm like most everything suggested in this thread. But I'm a little sad that these new shorter URLs are redirects. I really like to copy URLs out of the address field, so I’d want the legacy show_bug.cgi one

Re: [webkit-dev] Executing stand alone Javascipt without HTML

2009-07-09 Thread Darin Adler
This mailing list is for discussing the development of WebKit. For help in using WebKit, please post to . -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Detecting a finished paint via JavaScript

2009-07-08 Thread Darin Adler
On Jul 8, 2009, at 10:45 AM, RDC wrote: I would like it for benchmarking page rendering times OK. Hyatt may have some thoughts on this. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cg

Re: [webkit-dev] Detecting a finished paint via JavaScript

2009-07-08 Thread Darin Adler
On Jul 8, 2009, at 10:18 AM, RDC wrote: Is this something that is achievable in the current code? Or is a comparable feature planned? It's not, and I don’t know of any plans to add this. Would you be willing elaborate on why you want this? -- Darin _

Re: [webkit-dev] Inheritance in IDL files/JS bindings

2009-07-06 Thread Darin Adler
On Jul 6, 2009, at 2:52 PM, Drew Wilson wrote: BTW, I noticed that the CustomToJS IDL attribute in HTMLCollection.idl is not implemented - instead, there's just a big hard-coded list of classes in CodeGeneratorJS.pm::UsesManualToJSImplementation() that corresponds to that functionality.

Re: [webkit-dev] [Feature request] Bugzilla: default unassignee emails to per component.

2009-07-06 Thread Darin Adler
On Jul 6, 2009, at 12:59 PM, tonikitoo (Antonio Gomes) wrote: Now, for every bug filed there is a default assignee (webkit-unassig...@lists.webkit.org ). In order to make possible for developers to follow bug activities of a specific component. My proposal is the existence of default assigne

Re: [webkit-dev] Logo usage

2009-07-06 Thread Darin Adler
On Jul 1, 2009, at 4:04 AM, Gustavo Noronha wrote: I would like to know what are the usage terms for the WebKit logo - the one with compass in the box. Because this logo includes a copy of the Safari logo in it, it’s really not OK to use it outside webkit.org. Even in webkit.org itself it

Re: [webkit-dev] EXPORT_JS changeset

2009-07-06 Thread Darin Adler
On Jul 1, 2009, at 6:23 AM, Jack Wootton wrote: I'm interested in using the JavaScriptCore, however I'm working with an old revision of WebKit - I'm unsure of exactly what version it is, but the most recent entry in the changelog file in the JavaScriptCore was on the 2007-10-03. As a grou

Re: [webkit-dev] Help for Folder support for bookmark

2009-07-06 Thread Darin Adler
This is not a question about WebKit development, and is not on topic for this mailing list. This is not a general programming help list nor a general browser- development help list. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Darin Adler
On Jul 3, 2009, at 12:04 PM, Jeremy Orlow wrote: Nothing lists out the modified functions like in your ChangeLog, but I guess that's just not something people commonly need. I often search for old relevant changes by searching for function names. At least once a week for the last 5 years.

Re: [webkit-dev] ChangeLog

2009-07-03 Thread Darin Adler
On Jul 3, 2009, at 10:44 AM, Jeremy Orlow wrote: I agree that the ChangeLog really is duplicate information [...] The WebKit project change log was inspired by GNU project change logs: . I don’t like ChangeLog specifically. My

Re: [webkit-dev] NPAPI

2009-06-25 Thread Darin Adler
On Jun 25, 2009, at 6:44 AM, Jack Wootton wrote: 1. Is there a way to get the browser to load NPAPI plugins without an object or embed tag first having been parsed? No. 2. Using the Browse side of the NPAPI, is there a way to get a handle to WebView? No. Netscape plug-ins are intended to

Re: [webkit-dev] Getting global object from a webkit context throws a warning

2009-06-25 Thread Darin Adler
On Jun 25, 2009, at 2:14 AM, Sebastian Linke wrote: But before I go on, I would like to know why I get this warnings: $ LANG=C gcc test.c -o test $(pkg-config --cflags --libs webkit-1.0) test.c: In function 'get_forms': test.c:23: warning: assignment makes pointer from integer without a cast

Re: [webkit-dev] Question about Constructors in WebKit JS Bindings

2009-06-23 Thread Darin Adler
On Jun 23, 2009, at 11:50 AM, Adam Barth wrote: Is there a good way to tell if something is a constructor versus a function? Leading capital letter may be a good rule to start with. I don't think we have plans to add functions that start with a capital letter or constructors that do not.

Re: [webkit-dev] Question about Constructors in WebKit JS Bindings

2009-06-23 Thread Darin Adler
On Jun 23, 2009, at 10:41 AM, Maciej Stachowiak wrote: On Jun 22, 2009, at 11:58 PM, Adam Barth wrote: I don't really know how to solve this problem except by writing tests. However, tests don't really help when introducing new kinds of objects (e.g., workers, database transactions). Perh

Re: [webkit-dev] NPAPI plugin does not load under Safari (Cocoa related?)

2009-06-22 Thread Darin Adler
On Jun 22, 2009, at 7:55 AM, Eddy Bruël wrote: It looks like the NSPrincipalClass should be set to the name of the 'main' class in my plugin. That’s not needed for Netscape plug-ins. There’s a separate kind of plug-in called a WebKit plug-in that requires NSPrincipalClass. To figure out w

[webkit-dev] Changing our IDL syntax to get closer to WebIDL

2009-06-21 Thread Darin Adler
The IDL file format we use to generate our bindings has some things in common with WebIDL and many differences. There are extended attributes we use that exist in WebIDL but with a different name. As a first step in making our IDL syntax be as close to the WebIDL standard as possible, I’d l

[webkit-dev] New approach for DOM attributes that reflect content attributes

2009-06-21 Thread Darin Adler
There are many attributes in the DOM that are simply covers for getting and setting HTML or SVG attributes. The HTML 5 draft calls this reflection of content attributes. Currently we do this by writing getter and setter functions. For example, see the placeholder and useMap attributes of HT

Re: [webkit-dev] script to assist converting pixel tests to dumpastext tests

2009-06-17 Thread Darin Adler
On Jun 16, 2009, at 6:16 PM, Ryosuke Niwa wrote: I've been converting a bunch of pixel tests to dumpAsText tests. Thanks for telling us about your script. These are "layout tests", not "pixel tests". While it's true that the tests dump the render tree as text and when run in the --pixel mod

Re: [webkit-dev] How to find a WebKit Nightly corresponding roughly to particular Safari version

2009-06-15 Thread Darin Adler
On Jun 15, 2009, at 9:03 AM, Thomas Jaggi wrote: Thanks for your help. If I got that right, 38725 would correspond to Safari 3.2.1 (http://trac.webkit.org/changeset/38725). Using the 'official' detection script with 38707 (the last version before the non-existing 38725) I'm told "Your WebKi

Re: [webkit-dev] DOM building in Webkit

2009-06-12 Thread Darin Adler
On Jun 11, 2009, at 1:15 PM, Meryl Silverburgh wrote: Does Webkit build DOM element for things like 'comment' in the html document? and does it build DOM element for text with only non visible characters (e.g. "\n", " " , "\t")? These are questions you can answer yourself by writing a littl

Re: [webkit-dev] Identifying Views / Windows inside

2009-06-05 Thread Darin Adler
On Jun 5, 2009, at 1:41 AM, Jack Wootton wrote: 1. Does it have to be static? No. This is not a JavaScriptCore or WebKit question but a C language question. The keyword "static" makes the function have internal linkage. You can read up on the topic in any advanced C programming referenc

Re: [webkit-dev] cti_op_call_ArityCheck question

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 1:50 PM, Toshiyasu Morita wrote: I don't understand this code in JITStubs::cti_op_call_arityCheck(): ASSERT(argCount != newCodeBlock->m_numParameters); It's ensuring that the argument count does not equal the number of parameters expected by the newCodeBlock. I could u

Re: [webkit-dev] Question about CSS in Webkit

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 1:19 PM, Nathan Summer wrote: My question is if the CSS information stored Twice? onces are in the internal data structure built after parsing the CSS and other is in RenderStyle? The CSS stores the style rules. The RenderStyle stores the actual style chosen for each el

Re: [webkit-dev] Automatically generated -expected.txt is missing editing delegate

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 12:41 PM, Ryosuke Niwa wrote: it seems like run-webkit-tests doesn't generate editing delegate. Is it platform specific problem (I'm trying to do this on Windows)? Yes, that's not implemented on Windows yet. -- Darin ___ we

Re: [webkit-dev] Coding style

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 11:28 AM, David Levin wrote: I've thought rule of the rule as this "Control clauses (including any preceeding comments) that are one physical line should not use braces". So something like if (test) { myFunction(reallyLongParam1, reallyLongParam2, ...

Re: [webkit-dev] How to disable webkit image loading

2009-06-04 Thread Darin Adler
On Jun 4, 2009, at 9:40 AM, James Howlett wrote: Is there any configuration/setting in the code which can dynamically enable/disable image loading? If yes, can you please tell me how to do that in the code? Sure. [[webView preferences] setLoadsImagesAutomatically:NO] You didn’t speci

[webkit-dev] Does anyone know why http/tests/appcache/fallback.html is failing?

2009-06-02 Thread Darin Adler
This test is failing on all the Mac buildbots. --- layout-test-results/http/tests/appcache/fallback-expected.txt 2009-06-02 20:27:35.0 -0700 +++ layout-test-results/http/tests/appcache/fallback-actual.txt 2009-06-02 20:27:35.0 -0700 @@ -2,5 +2,6 @@ Should say SUCCESS: -SUC

Re: [webkit-dev] JSObjectMakeFunction question

2009-06-01 Thread Darin Adler
On Jun 1, 2009, at 8:29 AM, Jack Wootton wrote: It seems some casting is required for this though? Yes, conversion to JSObjectRef is needed, although you don’t have to do any casting. You can call JSValueToObject to turn the value into an object, making the appropriate object wrapper for

Re: [webkit-dev] How to interrupt Webkit Dump Render Tree output

2009-05-31 Thread Darin Adler
Coordinates in DumpRenderTree output are relative to the containing block, not absolute. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] Asynchronous JavaScript method support

2009-05-29 Thread Darin Adler
On May 29, 2009, at 1:46 AM, Jack Wootton wrote: Does WebKit allow for asynchronous methods / functions to be added to the JavaScript environment? There’s no clear definition for “asynchronous functions” so I can’t really answer that question. There are many JavaScript functions that do w

Re: [webkit-dev] bug? // FIXME:

2009-05-28 Thread Darin Adler
On May 28, 2009, at 9:49 AM, Jack Wootton wrote: JSStaticFunction JS_staticFuncs[1] = { {funcName, functionCallback, kJSPropertyAttributeNone} }; There’s your mistake. To quote the documentation for JSClassDefinition. â...@field staticFunctions A JSStaticFunction

Re: [webkit-dev] bug? // FIXME:

2009-05-28 Thread Darin Adler
On May 28, 2009, at 9:24 AM, Jack Wootton wrote: In the file JavaScriptCore/API/JSClassRef.cpp, in the constructor for OpaqueJSClass. there is a comment // FIXME: That hasn’t been in the source code for over a year . You are working with an old ver

Re: [webkit-dev] JSClassCreate & JSObjectSetProperty question

2009-05-28 Thread Darin Adler
On May 28, 2009, at 1:59 AM, Jack Wootton wrote: I understand the first part of your answer, but what i can't find it how to specify which C functions should be"bound" to the JavaScript functions. So for example, I add a new attribute to the window object named "foo", and I add a method to foo

Re: [webkit-dev] Need help/Suggestions to understand the framework of webkit

2009-05-27 Thread Darin Adler
On May 27, 2009, at 7:19 PM, Feng Qian wrote: webkit.org has documentations of setting up build and debug environment using XCode on Mac. And using Visual Studio on Windows too. The instructions start here . -- Darin

Re: [webkit-dev] testing question for code that calls abstract methods (like ChromeClient)

2009-05-27 Thread Darin Adler
On May 27, 2009, at 4:11 PM, John Gregg wrote: What's a good strategy for testing WebKit code that calls out to the ChromeClient interface or some other abstract interface? I can't find anything obvious in the codebase-- is there any way to mock out those calls for unit tests? Typically w

Re: [webkit-dev] JSClassCreate & JSObjectSetProperty question

2009-05-27 Thread Darin Adler
On May 27, 2009, at 8:34 AM, Jack Wootton wrote: I'm using JSObjectSetProperty. [...] I successfully have the execution context to use, the window JSObjectRef, property name, attributes and use NULL for exception (all these parameters make sense to me). However I'm unsure about the purpos

Re: [webkit-dev] SharedWorkers alternate design

2009-05-26 Thread Darin Adler
On May 26, 2009, at 10:16 AM, Drew Wilson wrote: OK, I've got two strong votes for the interface + static factory approach. Any objections from the rest of the WebKit team? If I don't hear any counter proposals, I'll do that. I think it's unpleasant to pay run-time cost for a compile-time

Re: [webkit-dev] JavaScriptCore API use

2009-05-26 Thread Darin Adler
On May 26, 2009, at 9:09 AM, Jack Wootton wrote: OK. To confirm, I need to obtain the Window JSObjectRef since any custom objects I wish to add are themselves attributes of the "window" object and so must be added accordingly? Yes. The most common way to make a named object visible to JavaScri

Re: [webkit-dev] JavaScriptCor API use

2009-05-26 Thread Darin Adler
On May 26, 2009, at 8:59 AM, Jack Wootton wrote: Thank you for taking the time to respond. I am using the S60 port of WebKit. So the platform is Symbian. OK. For that port I don’t know the answer. Perhaps someone familiar with that platform would know. Inside WebCore, to convert the JSDOM

Re: [webkit-dev] JavaScriptCor API use

2009-05-26 Thread Darin Adler
On May 26, 2009, at 8:32 AM, Jack Wootton wrote: 1. I'm attempting to use the JavaScriptCore API to add new JSObjects to the JavaScript environment. In order to use the API I include "JavaScriptCore.h". However in doing so, JSStringRefCF.h contains errors. The system include CoreFoundation/Co

Re: [webkit-dev] Browser issue with multiple tabulators

2009-05-22 Thread Darin Adler
I believe HTML 5’s sessionStorage is intended to resolve this issue. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mailman/listinfo.cgi/webkit-dev

Re: [webkit-dev] SharedWorkers alternate design

2009-05-22 Thread Darin Adler
No substantive comment, but a small style comment. On May 21, 2009, at 4:20 PM, Drew Wilson wrote: // Static factory method for getting the correct repository implementation for a given browser static public SharedWorkerRepository* getRepository(); Generally WebKit does not use the verb

Re: [webkit-dev] Webkit JavaScript question

2009-05-22 Thread Darin Adler
Some of the rationale is in this blog post too . For example: “We also think we can get a lot more speedups out of the JIT through techniques such as type specialization, better register allocation and liveness analysis. [...] by

Re: [webkit-dev] policyBaseURL and mainDocumentURL

2009-05-21 Thread Darin Adler
On May 20, 2009, at 11:22 PM, Adam Barth wrote: I'm trying to sort out all the security / privacy URLs we have, and I'm a bit puzzled by ResourceRequestBase::mainDocumentURL and Document::policyBaseURL. They both seem connected to third-party cookie blocking. Are they the same? I believ

Re: [webkit-dev] How to add a attribute for "object" tag and can be modified by JavaScript

2009-05-21 Thread Darin Adler
On May 21, 2009, at 7:12 AM, naixuan guan wrote: when I open the HTML page like follow: OBJECT> alert(document.StormPlayer.src); the warning message will show "undefined". why? Because not every HTML attribute has a corresponding JavaScript property. But alert(document.getElementById(

Re: [webkit-dev] Memory Management of Webkit on MacOS

2009-05-20 Thread Darin Adler
On May 20, 2009, at 9:33 AM, Lucius Fox wrote: Sorry. I meant does Webkit on MacOS X uses 'reference counted or garbage collected' memory management? Both. For Objective-C objects it uses whatever mode of memory management the host application chooses. This is also how Mac OS X system fram

Re: [webkit-dev] Bus Error on AtomicString.cpp

2009-05-19 Thread Darin Adler
On May 19, 2009, at 11:37 AM, Zongheng Zhou wrote: My question is, where does the alignment happen that guarantee 'characters' is aligned by 4-byte? It doesn’t. I know it must happen at somewhere, but just can't find it. Nope. Many, if not most, processors can support this optimization e

Re: [webkit-dev] [43842] trunk/WebCore

2009-05-19 Thread Darin Adler
On May 18, 2009, at 8:41 PM, Adam Roben wrote: We do something like this for Node::isSVGElement and Node::isWMLElement already, so there is precedent. But there are alternatives that don't require making styleForRenderer virtual. For example, styleForRenderer could be changed to *call* a

Re: [webkit-dev] KJS::JSObject question

2009-05-17 Thread Darin Adler
On May 15, 2009, at 7:35 AM, Jack Wootton wrote: 4. Create the context: JSGlobalContextRef context = JSGlobalContextCreate(globalObjectClass); You will only do this if you’re using JavaScript outside of a web page. If you want to do this in conjunction with WebKit you’ll need to get the c

Re: [webkit-dev] How to set breakpoints in JavaScript Engine of WebKit on MacOS

2009-05-15 Thread Darin Adler
On May 15, 2009, at 10:50 PM, Meryl Silverburgh wrote: I am able to download and compile both WebCore project and JavaScriptCore project using XCode on Macos. I have created a custom executable (pointing to /Application/Safari.app) in my WebCore project. The browser is launched and I can set br

Re: [webkit-dev] Memory Management of Webkit on MacOS

2009-05-15 Thread Darin Adler
The WebKit framework on Mac OS X supports either mode, reference counted or garbage collected, depending on the mode of the application it’s linked to. -- Darin ___ webkit-dev mailing list webkit-dev@lists.webkit.org http://lists.webkit.org/mai

Re: [webkit-dev] JSObjectCallAsFunctionCallback question

2009-05-14 Thread Darin Adler
On May 14, 2009, at 7:53 PM, Xiong wrote: So,can we add a member for the "function object" to store the method name[here is "getValues"] in theoretical ? Yes, in theory you could do that. Although that’s not the typical pattern. And this also like the "JSObjectRef object" variable in the

Re: [webkit-dev] JSObjectCallAsFunctionCallback question

2009-05-14 Thread Darin Adler
On May 14, 2009, at 7:03 PM, Xiong wrote: 1what is the purpose of the "JSObjectRef function" variable? In my case, we never use. It’s fine to not use this if you don’t need to. In JavaScript, functions are objects. Like other objects they can have properties. This argument is passed t

Re: [webkit-dev] KJS::JSObject question

2009-05-14 Thread Darin Adler
On May 14, 2009, at 8:03 AM, Jack Wootton wrote: My question: I do not understand how JSObject can be used to allow for the JavaScript syntax of : myNewJSObject.someObject.hello(). My first comment is that you should not be using JSObject directly. The right way to do this is to use the C-

Re: [webkit-dev] How to access formatted Java script Console message ?

2009-05-14 Thread Darin Adler
On May 14, 2009, at 8:48 AM, Gopal Raghavan wrote: Any idea why only the first argument is passed to client ? It’s a bug. There’s an internal Apple report of this in the Mac OS X public API that ChromeClient is used for: -webView:addMessageToConsole: passes console.log's first argu

Re: [webkit-dev] Using WebKit renderer to produce PDF output

2009-05-13 Thread Darin Adler
On May 13, 2009, at 2:41 PM, Ben Harper wrote: Unfortunately the platform is Windows. Regarding the method that you're describing - I assume the PDF generation is handled by CoreGraphics? Yes. -- Darin ___ webkit-dev mailing list webkit-dev@

Re: [webkit-dev] Using WebKit renderer to produce PDF output

2009-05-13 Thread Darin Adler
On May 13, 2009, at 2:11 PM, Ben Harper wrote: I need to produce a tool that can generate PDFs from HTML. The best solution I can think of is to use WebKit's layout engine, and plug my own PDF generator in as a renderer backend. I don't want to reinvent the wheel though - so I'm asking here

Re: [webkit-dev] squirrelfish-bytecode

2009-05-13 Thread Darin Adler
On May 13, 2009, at 9:09 AM, Meryl Silverburgh wrote: You mention native code. Under what situation will squirrelfish generate native code? I thought this is how v8 works, but not squirrelfish. Squirrelfish parse JS files and generate its internal bytecode and its VM will execute the byteco

Re: [webkit-dev] Webkit capture web page content API

2009-05-13 Thread Darin Adler
On May 13, 2009, at 8:59 AM, Lucius Fox wrote: But if Webkit is not involved. That means it can not capture the web content which is not within the visible area (e.g. a page is long and it has scroll bar)? To capture more than what’s currently visible you can use these NSView methods with

Re: [webkit-dev] Webkit capture web page content API

2009-05-13 Thread Darin Adler
On May 13, 2009, at 12:26 AM, Lucius Fox wrote: Does Webkit have an api which captures web page content? for example in Safari 4.0 beta, the history/bookmark shows an image of the web content of each history/bookmark entry. Can you please tell me which api in webkit that Safari 4.0 is usin

Re: [webkit-dev] Mapping Results between Layout-tests and Webkit-Supported Features

2009-05-08 Thread Darin Adler
On May 7, 2009, at 11:24 PM, g_siddu wrote: I am running webkit-layout tests on the Gtk Platfrom and with the tests being run i am trying to map them with those of the features provided by the webkit(http://trac.webkit.org/wiki/SpecSupport). There’s no real way to map a directory onto a fea

Re: [webkit-dev] PageGroups (and the localStorage being stored in it)

2009-05-08 Thread Darin Adler
On May 7, 2009, at 8:49 PM, Jeremy Orlow wrote: One more question: are there any use cases where setGroupName could occur after window.localStorage() had been called? I don’t know. I don’t think it’s something we can support. It’s possible we can change setGroupName to have no effect once a

Re: [webkit-dev] PageGroups (and the localStorage being stored in it)

2009-05-07 Thread Darin Adler
On May 7, 2009, at 4:56 PM, Jeremy Orlow wrote: I'm continuing to work on https://bugs.webkit.org/show_bug.cgi?id=25376 and noticed that the map of origins to localStorageAreas is owned by the PageGroup class. I'm having a bit of trouble understanding what exactly page groups are used for.

Re: [webkit-dev] MessagePorts and garbage collection

2009-05-07 Thread Darin Adler
We consider the current JavaScriptCore protected set to be something deprecated that we’d like to eliminate. We have been steadily decreasing the number of uses of it. All other things being equal, I think it would be good to keep the new mechanism separate. -- Darin __

Re: [webkit-dev] How can I listen for a page load complete event

2009-05-05 Thread Darin Adler
On May 4, 2009, at 11:32 PM, Meryl Silverburgh wrote: Thank you. If implementating the 'didFinishLoadForFrame' method is to listen for browser finishing loading everything, then some please in webkit code must call the didFinishLoadForFrame' to tell the delegate that page load is done, righ

Re: [webkit-dev] Proposal for a new way to handle porting #ifdefs

2009-05-05 Thread Darin Adler
On May 4, 2009, at 7:45 PM, George Staikos wrote: 1) In some cases some things apply to more than one OS so we have: #if OS(x) || OS(y) || OS(z) ... I think we should use: #if OS(x,y,z) How? Macros don’t have overloading with the same macro but different numbers of parameters. 3) I'm not s

Re: [webkit-dev] when can I treat a JSValueRef as a JSObjectRef?

2009-05-04 Thread Darin Adler
On May 4, 2009, at 10:53 AM, Patrick Mueller wrote: The docs I was reading were in fact the Apple docs I believe the document you cited is automatically generated from the comments in the JavaScriptCore headers. So if we improve the documentation comments in the headers in the WebKit open

Re: [webkit-dev] when can I treat a JSValueRef as a JSObjectRef?

2009-05-04 Thread Darin Adler
On May 4, 2009, at 10:17 AM, Patrick Mueller wrote: Since JSValueRef and JSObjectRef are typedef's to the same OpaqueJSValue structure (pointer) It’s easy to get the wrong idea about this by looking at the implementation. These two typedefs use the same structure, but they use const in a

Re: [webkit-dev] Plugins with no MIME type

2009-05-03 Thread Darin Adler
On May 3, 2009, at 12:30 AM, Loukas Kalenderidis wrote: I'm just starting out writing a WebKit plugin which will intercept HTTP requests and responses and manipulate them in various ways. I'm a bit unsure as to how to go about getting this sort of plugin to load, as it doesn't handle a spec

Re: [webkit-dev] How can I listen for a page load complete event

2009-04-30 Thread Darin Adler
On Apr 30, 2009, at 10:55 AM, Meryl Silverburgh wrote: I am trying to do that in C++ on MacOS. And when page load complete, I meant the browser finish loading everything (all js, images, css). Implement a frame load delegate, and implement the - webView:didFinishLoadForFrame: method. There’s

Re: [webkit-dev] How can I listen for a page load complete event

2009-04-29 Thread Darin Adler
On Apr 29, 2009, at 10:00 AM, Meryl Silverburgh wrote: Can you please tell me how can I listen for a page load complete event programmatically? What platform? What programming language? Could you give a little more context on who you are and what you’re working on? In HTML with JavaScript

Re: [webkit-dev] TestShell for WebKit rendering engine

2009-04-29 Thread Darin Adler
On Apr 29, 2009, at 9:25 AM, Lucius Fox wrote: Is there a TestShell for WebKit rendering engine on MacOS? i.e. just a window with a text field to enter URL and then it uses WebKit to load and render the page? I think the WebKit Gtk has something like that. Is there an equivalent of that on MacO

Re: [webkit-dev] Where is the code for "operator loading"?

2009-04-29 Thread Darin Adler
On Apr 29, 2009, at 2:53 AM, Nitin wrote: One question to ask Please don’t quote a large message that is not relevant to your message. That’s bad manners. Please don’t reply to an existing message thread to ask a question. Also not polite. Where is the code for operator loading like "=

Re: [webkit-dev] ASYNC attribute for

2009-04-28 Thread Darin Adler
Bug 20710: WebKit should support defer and async on script elements https://bugs.webkit.org/show_bug.cgi?id=20710 If someone wants to see this feature in WebKit, it’s be great to get started on it and see what parts of it are trickiest. Making interesting test cases that cover not only the fe

Re: [webkit-dev] drag'n'drop file uploads

2009-04-22 Thread Darin Adler
On Apr 22, 2009, at 3:47 AM, Philip Orr wrote: Does anyone have any pointers on drag and drop files from the finder directly into a web page or section of a web page. I've got examples in Firefox for this but sadly lacking in WebKit knowledge. Maybe if you pointed to the examples “in Firefo

Re: [webkit-dev] WebKit Layout test failures on Windows

2009-04-21 Thread Darin Adler
On Apr 21, 2009, at 7:05 AM, Kulanthaivel wrote: If these are font problems then please suggest me how to get these fonts to pass the layout tests in Windows. The easiest way I can think of to get the fonts is to get them from a Mac, if you have one. They’re all fonts included with Mac OS X

Re: [webkit-dev] content-disposition, utf-8 and webkit

2009-04-12 Thread Darin Adler
On Apr 12, 2009, at 7:08 PM, Andre-John Mas wrote: I am using the Webkit nightlies on MacOS X, and I noticed that the following header doesn't seem to give the expected results: content-disposition: inline; filename*="utf-8''%E8%92%99%E7%89%B9%E5%88%A9%E5%B0%94.vcf" In Firefox it provides

<    5   6   7   8   9   10   11   12   13   >