Re: [webkit-dev] HasStandardGetOwnPropertySlot

2009-07-22 Thread Darin Adler
On Jul 22, 2009, at 5:35 PM, Eric Seidel wrote: What is HasStandardGetOwnPropertySlot adding? Is it testable? It’s an optimization. If it’s set, then the JavaScript engine won’t even call getOwnPropertySlot, saving the overhead of a virtual function call. If it’s not set, then the engine

Re: [webkit-dev] HasStandardGetOwnPropertySlot

2009-07-22 Thread Eric Seidel
Never mind. I've looked at the source, and understand enough to see that that looks like a bad idea. Autogen'd constructors seem to always assume that the ConstructorTable will be non-empty, and thus they need to have a custom getOwnPropertySlot. So I'll leave the autogen'd code for now. It doe

Re: [webkit-dev] HasStandardGetOwnPropertySlot

2009-07-22 Thread David Levin
On Wed, Jul 22, 2009 at 5:35 PM, Eric Seidel wrote: > Now from the right email address. > > On Wed, Jul 22, 2009 at 5:34 PM, Eric Seidel wrote: > > http://trac.webkit.org/changeset/45938 added DOMConstructorObject, but > > did not change most constructors (the autogen'd ones). > > > > > > I'm now

Re: [webkit-dev] HasStandardGetOwnPropertySlot

2009-07-22 Thread Eric Seidel
Now from the right email address. On Wed, Jul 22, 2009 at 5:34 PM, Eric Seidel wrote: > http://trac.webkit.org/changeset/45938 added DOMConstructorObject, but > did not change most constructors (the autogen'd ones). > > > I'm now removing the autogen'd createStructure and making all > constructors