[webstack-discuss] Code review request for CR 6893031

2009-10-29 Thread Nick Kew
On 29 Oct 2009, at 21:58, Basant Kukreja wrote: > Hi, > Please review and provide your comments for following CR. > > CR 6893031 : mod_sed consumes too much memory when used inside > reverse proxy and line sizes are very long > > WebRev URL: http://cr.opensolaris.org/~basantk/6893031/webrev/

[webstack-discuss] Tomcat improvements and fixes - code review

2009-10-29 Thread Brian Overstreet
On Thursday October 29 2009 03:14:28 Petr Sumbera wrote: > Brian Overstreet napsal(a): > > On Thursday 22 October 2009 07:04:54 Petr Sumbera wrote: > >> Brian Overstreet wrote: > >>> On Friday October 9 2009 06:25:40 Petr Sumbera wrote: > Hi, > > can somebody please review following

[webstack-discuss] review mod_fcgid-2.3.4 (cr 6875538)

2009-10-29 Thread rahul
> rahul wrote: >> I have updated the below directory with a patch to avoid problems in >> config.apxs.log, Please see if this is ok. >> >> | >> Hi, >> | >> Can I please get this reviewed ? (updating mod_fcgid to latest) >> | >> http://cr.opensolaris.org/~vrthra/mod_fcgid-2.3.4/ >> > > Hi Rah

[webstack-discuss] how to debug stuck httpd MPM setting on b125

2009-10-29 Thread Seema Alevoor
Does it happen only when server_type is set to prefork ? Try resetting server_type to worker and check if /etc/apache2/2.2/envvars gets updated. Regards, Seema. On 10/29/09 16:52, Jeff Trawick wrote: > The worker MPM is getting started even though server_type is set to > prefork. > > $ svcs a

[webstack-discuss] review mod_fcgid-2.3.4 (cr 6875538)

2009-10-29 Thread rahul
> usr/src/cmd/apache2/modules/apxs-xml2enc.ksh93: > usr/src/cmd/apache2/modules/apxs-proxy-html.ksh93 : > Can you use APACHE_USR_PREFIX instead of /usr/apache2/2.2 ? Since all other modules use the same /usr/apache2/2.2, I would like to do it as a part of another bug for correcting build

[webstack-discuss] review mod_fcgid-2.3.4 (cr 6875538)

2009-10-29 Thread Seema Alevoor
usr/src/cmd/apache2/modules/apxs-xml2enc.ksh93: usr/src/cmd/apache2/modules/apxs-proxy-html.ksh93 : Can you use APACHE_USR_PREFIX instead of /usr/apache2/2.2 ? usr/src/pkgdefs/SUNWapch22m-xml2enc/copyright : usr/src/pkgdefs/SUNWapch22r-xml2enc/copyright : Need to change this to

[webstack-discuss] Code review request for CR 6893031

2009-10-29 Thread Basant Kukreja
On Thu, Oct 29, 2009 at 11:06:14PM +, Nick Kew wrote: >> >> WebRev URL: http://cr.opensolaris.org/~basantk/6893031/webrev/ > > That looks identical to your recent upstream fix. > > Assuming it is, +1. Yes, it is. Thanks, Basant.

[webstack-discuss] misc php bug fixes for build 127

2009-10-29 Thread Basant Kukreja
Changes looks good to me. Regards, Basant. On Thu, Oct 29, 2009 at 02:25:32PM -0700, Sriram Natarajan wrote: > thanks basant. Please find the updated webrev which incorporates your > feedback > > http://cr.opensolaris.org/~sn123202/b127/webrev/ > > > - Sriram > > Basant Kukreja wrote: >> 2 smal

[webstack-discuss] Code review request for CR 6893031

2009-10-29 Thread Basant Kukreja
Hi, Please review and provide your comments for following CR. CR 6893031 : mod_sed consumes too much memory when used inside reverse proxy and line sizes are very long WebRev URL: http://cr.opensolaris.org/~basantk/6893031/webrev/ Code changes are part of apache bug https://issues.apache.or

[webstack-discuss] Draft case for collectd integration within OpenSolaris

2009-10-29 Thread Amit Gupta
be built and we then >> pick and choose which plugins get bundled using the package prototype. >> >> I will send out an updated spec soon. >> >> Praveen >> ___ >> >> >> webstack-discuss mailing lis

[webstack-discuss] misc php bug fixes for build 127

2009-10-29 Thread Sriram Natarajan
thanks basant. Please find the updated webrev which incorporates your feedback http://cr.opensolaris.org/~sn123202/b127/webrev/ - Sriram Basant Kukreja wrote: > 2 small changes. > 1. In php_6818228.patch.patch, since off_t is defined as long (when > _FILE_OFFSET_BITS=32) so we should probably

[webstack-discuss] misc php bug fixes for build 127

2009-10-29 Thread Basant Kukreja
2 small changes. 1. In php_6818228.patch.patch, since off_t is defined as long (when _FILE_OFFSET_BITS=32) so we should probably use "long" instead of "int". 2. In nanosleep patch php_6893909.patch.patch, we can use LDFLAGS to tell configure to include "-lrt" LDFLAGS="-lrt" ./configure ... Reg

[webstack-discuss] review mod_fcgid-2.3.4 (cr 6875538)

2009-10-29 Thread Seema Alevoor
Looks fine. -- Seema. On 10/27/09 16:39, rahul wrote: > I have updated the below directory with a patch to avoid problems in > config.apxs.log, Please see if this is ok. > > | >> Hi, > | >> Can I please get this reviewed ? (updating mod_fcgid to latest) > | >> http://cr.opensolaris.org/~vrth

[webstack-discuss] misc php bug fixes for build 127

2009-10-29 Thread Sriram Natarajan
Hi I would like to integrate the bug fixes for following issues within build 127. can some one kindly look into this webrev report and let me know your thoughts.. 6660998 include snmp support within php 6818228 [nvb110] zlib functions are not working on sparc 6825797 php engine dumps core withi

[webstack-discuss] Tomcat improvements and fixes - code review

2009-10-29 Thread Petr Sumbera
Brian Overstreet napsal(a): > On Thursday 22 October 2009 07:04:54 Petr Sumbera wrote: >> Brian Overstreet wrote: >>> On Friday October 9 2009 06:25:40 Petr Sumbera wrote: Hi, can somebody please review following changes to Solaris Nevada Tomcat? 6864292 [nvb119] some JSP a

[webstack-discuss] how to debug stuck httpd MPM setting on b125

2009-10-29 Thread Jeff Trawick
Seema Alevoor wrote: > Does it happen only when server_type is set to prefork ? > > Try resetting server_type to worker and check if > /etc/apache2/2.2/envvars gets updated. oops, I found the problem: apachectl set HTTPD to httpd.worker instead of just httpd I'll assume that I did this to mysel

[webstack-discuss] how to debug stuck httpd MPM setting on b125

2009-10-29 Thread Jeff Trawick
The worker MPM is getting started even though server_type is set to prefork. $ svcs apache22 STATE STIMEFMRI disabled7:19:29 svc:/network/http:apache22 $ ps -ef | grep httpd $ svccfg -s apache22 listprop httpd/enable_64bit httpd/enable_64bit boolean false $ svccfg -s apache2