[webstack-discuss] Code Review Request for CR 6903263

2009-12-04 Thread Jyri Virkki
Brian Overstreet wrote: > > Not that I am aware of from looking at the mailing list, source code > repository, or the bug tracker. However, I believe they will be contributed > back to the upstream community when Amit returns from vacation. As the author, probably best to wait for Amit to do it

[webstack-discuss] Code Review Request for CR 6903263

2009-12-04 Thread Brian Overstreet
On Friday 04 December 2009 13:42:05 Jyri Virkki wrote: > On Dec 4, 2009, at 12:28 PM, Brian Overstreet wrote: > >> The dirs are supposed to be in sorted order, so add the dir where it > >> goes alphabetically, not at the end. > > > > Parts of the list are in alpabetical order, but other parts are >

[webstack-discuss] Code Review Request for CR 6903263

2009-12-04 Thread Jyri Virkki
On Dec 4, 2009, at 12:28 PM, Brian Overstreet wrote: >> >> The dirs are supposed to be in sorted order, so add the dir where it >> goes alphabetically, not at the end. > Parts of the list are in alpabetical order, but other parts are > not. I've > added collectd4 to the first section of the lis

[webstack-discuss] Code Review Request for CR 6903263

2009-12-04 Thread Brian Overstreet
On Friday 04 December 2009 01:05:01 Jyri Virkki wrote: Thanks for looking at this Jyri. The webrev has been updated based on your feedback. I also updated the usr/src/Targetdirs file in this new webrev because not all directories were listed in that file. > On Dec 4, 2009, at 12:05 AM, Brian O

[webstack-discuss] Code Review Request for CR 6903263

2009-12-04 Thread Jyri Virkki
On Dec 4, 2009, at 12:05 AM, Brian Overstreet wrote: > Please review and provide comments for > > CR 6903263: Integrate collectd 4.8.1 into SFW > > WebRev URL: http://cr.opensolaris.org/~overstre/6903263/webrev/ usr/src/lib/Makefile The dirs are supposed to be in sorted order, so add the dir wh

[webstack-discuss] Code Review Request for CR 6903263

2009-12-04 Thread Brian Overstreet
Please review and provide comments for CR 6903263: Integrate collectd 4.8.1 into SFW WebRev URL: http://cr.opensolaris.org/~overstre/6903263/webrev/ Thanks, Brian