[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-18 Thread Seema Alevoor
usr/src/cmd/mysql-5-0/Makefile.sfw : I don't think there is a need to explicitly include "/usr/include/openssl" in the CFLAGS/CXXFLAGS. --with-openssl-includes should suffice. Anyway, it isn't a major issue. So, changes look fine to me. -- Seema. On 03/18/09 11:57, sunanda menon wrote: > Up

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-18 Thread sunanda menon
Updated webrevs posted at http://cr.opensolaris.org/~sunandam/6808952/ Thanks Sunanda Seema Alevoor wrote: > usr/src/cmd/mysql-5-0/Makefile.sfw : > * Use $(CCBITS64) instead of "-m64" > * CXX64FLAGS already includes "-m64" . So, there is no need to add > this flag again to CXXFLAGS. > >

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-18 Thread Amanda Waite
Looks good to me. Amanda sunanda menon wrote: > Updated webrevs posted at http://cr.opensolaris.org/~sunandam/6808952/ > > Thanks Sunanda > > Seema Alevoor wrote: >> usr/src/cmd/mysql-5-0/Makefile.sfw : >> * Use $(CCBITS64) instead of "-m64" >> * CXX64FLAGS already includes "-m64" . So, t

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-16 Thread sunanda menon
Seema, I'll update the changes and send the webrev sometime later .Tied up in other things right now ,so this needs to wait :-) Thanks for the comments ,though . -- Sunanda Seema Alevoor wrote: > usr/src/cmd/mysql-5-0/Makefile.sfw : > * Use $(CCBITS64) instead of "-m64" > * CXX64FLAGS a

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-16 Thread Seema Alevoor
usr/src/cmd/mysql-5-0/Makefile.sfw : * Use $(CCBITS64) instead of "-m64" * CXX64FLAGS already includes "-m64" . So, there is no need to add this flag again to CXXFLAGS. -- Seema. On 03/12/09 17:17, sunanda menon wrote: > Hi , > Please do a Code Review request for the upgrade of

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread sunanda menon
Hi , Please do a Code Review request for the upgrade of MySQL from 5.0.67 to 5.0.77 (CR 6808952) at http://cr.opensolaris.org/~sunandam/6808952/ Thanks Sunanda

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Amanda Waite
Hi Sunanda, usr/src/cmd/mysql-5-0/METADATA - Can you add a NAME field as per http://wikis.sun.com/display/SFWNotes/Package+writing+guidelines usr/src/cmd/mysql-5-0/Makefile.sfw - You can get Version numbers and Program names from the METADATA file. These are available as $(COMPONENT_NAME:sh

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Amanda Waite
Jeff Trawick wrote: > Amanda Waite wrote: >> Jeff Trawick wrote: >>> sunanda menon wrote: Hi , Please do a Code Review request for the upgrade of MySQL from 5.0.67 to 5.0.77 (CR 6808952) at http://cr.opensolaris.org/~sunandam/6808952/ >>> it looks okay to me, though it wou

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Amanda Waite
Jeff Trawick wrote: > sunanda menon wrote: >> Hi , >> Please do a Code Review request for the upgrade of MySQL from 5.0.67 >> to 5.0.77 (CR 6808952) >> at http://cr.opensolaris.org/~sunandam/6808952/ >> > it looks okay to me, though it would be good for somebody more > familiar with packaging to

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Jeff Trawick
Amanda Waite wrote: > Jeff Trawick wrote: >> sunanda menon wrote: >>> Hi , >>> Please do a Code Review request for the upgrade of MySQL from 5.0.67 >>> to 5.0.77 (CR 6808952) >>> at http://cr.opensolaris.org/~sunandam/6808952/ >>> >> it looks okay to me, though it would be good for somebody more

[webstack-discuss] Code Review request for Upgrade of MySQL to 5.0.77

2009-03-12 Thread Jeff Trawick
sunanda menon wrote: > Hi , > Please do a Code Review request for the upgrade of MySQL from 5.0.67 > to 5.0.77 (CR 6808952) > at http://cr.opensolaris.org/~sunandam/6808952/ > it looks okay to me, though it would be good for somebody more familiar with packaging to have a look as well ;)