Re: WICKET-40 Parameters of nice URL's pages with 'sensitive' characters

2007-05-05 Thread Jean-Baptiste Quenot
* Al Maw: > Yes, needs fixing. Am looking into this right now. Any ETA? Otherwise I'll just commit the patch, and we'll see what happens when it's being tested by more people. Unit tests should be good enough, is there some corner cases that are not handled? -- Jean-Baptiste Quenot aka

Re: VOTE: EmptyPanel

2007-05-05 Thread Jean-Baptiste Quenot
* Jonathan Locke: > > > so i propose a vote to add this. i'm +1. +1 I have one in every project. It is particularly useful for a reusable modal dialog that is defined in the page, and replaced/shown in various forms. -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/j

Re: VOTE: EmptyPanel

2007-05-05 Thread Xavier Hanin
On 5/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: You're right about that. EmptyPanel is better, and it should probably be final. Yes, I think EmptyPanel has the merit of being more obvious in its intent, and less error prone. Xavier Eelco On 5/5/07, Igor Vaynberg <[EMAIL PROTECTED]> wro

Re: VOTE: EmptyPanel

2007-05-05 Thread Eelco Hillenius
You're right about that. EmptyPanel is better, and it should probably be final. Eelco On 5/5/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: will that really make things better? if you misname the markup file you will now get component not found rather then markup not found. -igor On 5/5/07, Ma

Re: VOTE: EmptyPanel

2007-05-05 Thread Igor Vaynberg
will that really make things better? if you misname the markup file you will now get component not found rather then markup not found. -igor On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: How about giving Panel.java an accompanying Panel.html file? That would obviate the need of addin

Re: VOTE: EmptyPanel

2007-05-05 Thread Eelco Hillenius
That's actually not a bad idea. Xavier, you think you would have found that/ is it as obvious? Eelco On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding EmptyPanel, and anyone subclassing Pane

Re: VOTE: EmptyPanel

2007-05-05 Thread Martijn Dashorst
How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding EmptyPanel, and anyone subclassing Panel would override it by supplying their own markup. Martijn On 5/5/07, Martijn Dashorst <[EMAIL PROTECTED]> wrote: +1, another class I can remove from our pro

Re: VOTE: EmptyPanel

2007-05-05 Thread Martijn Dashorst
+1, another class I can remove from our project :) On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: > > Yeah. I actually think I proposed something like this, or at least > +1-ed one at more than a year ago. You'll have to

Re: VOTE: EmptyPanel

2007-05-05 Thread Johan Compagner
its a bit redundent api but because of the naming i guess its is fine to have. johan On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: > > Yeah. I actually think I proposed something like this, or at least > +1-ed one at

Re: isFirstAttach() convenience method

2007-05-05 Thread Johan Compagner
I am against this method If you want that do it your self. its simple MyPage extends WebPage { private boole firstAttached = false; onAttach() { if (firstAttached) // do something firstAttached = true } } johan On 5/4/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: Although I do stil

Re: IUnversionedBehaviorListener

2007-05-05 Thread Matej Knopp
Yeah, I removed ~ a week ago. It was of no use since we have version merging for 1.3. -Matej On 5/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: I think Matej removed the concept of unversioned behavior listeners as it was flawed. Eelco On 5/5/07, Juergen Donnerstag <[EMAIL PROTECTED]> wrot

Re: VOTE: EmptyPanel

2007-05-05 Thread Xavier Hanin
+1 This is something I add to figure out how to do myself with a WebMarkupContainer, would have been easier with what you're proposing. Xavier On 5/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: +1 Eelco On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: > > > so i propose a vote to add

Re: IUnversionedBehaviorListener

2007-05-05 Thread Eelco Hillenius
I think Matej removed the concept of unversioned behavior listeners as it was flawed. Eelco On 5/5/07, Juergen Donnerstag <[EMAIL PROTECTED]> wrote: May be it is too early, but I have a strange problem. I'm currently playing with backporting some MarkupParser functionality which makes it is mo

Re: [VOTE] Propose Wicket for Graduation

2007-05-05 Thread Jean-Baptiste Quenot
[x] Yes, propose Wicket for Graduation [ ] No, Wicket is not ready to graduate -- Jean-Baptiste Quenot aka John Banana Qwerty http://caraldi.com/jbq/

Re: VOTE: EmptyPanel

2007-05-05 Thread Eelco Hillenius
+1 Eelco On 5/5/07, Jonathan Locke <[EMAIL PROTECTED]> wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: > > Yeah. I actually think I proposed something like this, or at least > +1-ed one at more than a year ago. You'll have to dig in the archives > to find out why oth