Re: [VOTE] disable line-precise error reporting by default

2007-07-06 Thread Jonathan Locke
[ x ] disable this feature by default, put instructions on how to enable it into component-not-found related exception messages [ ] leave it enabled by default i like the idea of a debug deployment mode. if we get into profiles, i'd prefer it be kept in code and not introduce any kind of dat

Re: [VOTE] disable line-precise error reporting by default

2007-07-06 Thread Juergen Donnerstag
[x] disable this feature by default, put instructions on how to enable it Juergen

Re: SmartLinkLabel - why final?

2007-07-06 Thread Juergen Donnerstag
any patch is welcome. Please open a jira issue, upload the patch and I'm happy to look at it. Thanks. Juergen On 7/6/07, Gerolf Seitz <[EMAIL PROTECTED]> wrote: since juergen donnerstag is the author of this class, this question is probably directed towards him, but all opinions are welcome, as

SmartLinkLabel - why final?

2007-07-06 Thread Gerolf Seitz
since juergen donnerstag is the author of this class, this question is probably directed towards him, but all opinions are welcome, as always. i wanted to provide an encrypted version of the SmartLinkLabel but since it's marked as final i would have to copy/paste the existing code and modify it a

Re: FileUploadField closing input streams behind my back

2007-07-06 Thread Eelco Hillenius
> Anyway, Al, what's your take on this? Do I have to have one? ;-) I've fixed the bug I was having, haven't had time to compare the two divergent branches since, sorry. I meant Noel's remarks, specifically: "So you do have an old version of the FileCleaner, albeit prior to enhancements that h

Re: [VOTE] disable line-precise error reporting by default

2007-07-06 Thread Igor Vaynberg
On 7/6/07, Igor Vaynberg <[EMAIL PROTECTED]> wrote: [x] disable this feature by default, put instructions on how to enable it into component-not-found related exception messages [ ] leave it enabled by default -igor

Re: [VOTE] disable line-precise error reporting by default

2007-07-06 Thread Al Maw
Igor Vaynberg wrote: [x] disable this feature by default, put instructions on how to enable it into component-not-found related exception messages [ ] leave it enabled by default Debug performance without this option is sufficiently close to production (this would being it within the same orde

Re: Nonsensical default validation messages

2007-07-06 Thread Igor Vaynberg
On 7/6/07, Al Maw <[EMAIL PROTECTED]> wrote: The current default validation messages in Application.properties make no logical sense. At the moment, if you put in a value that is larger than a NumberValidator maximum it says: "5 must be smaller than 3" Which it can't be, not even for very sm

Re: FileUploadField closing input streams behind my back

2007-07-06 Thread Al Maw
Eelco Hillenius wrote: On 7/6/07, Johan Compagner <[EMAIL PROTECTED]> wrote: and if i remember correctly, back then it looked if the FileUpload project was really in suspend stage. there wasn't much happening on it, so i am talking abou the time we added it to the core of wicket Yeah, that'

Nonsensical default validation messages

2007-07-06 Thread Al Maw
The current default validation messages in Application.properties make no logical sense. At the moment, if you put in a value that is larger than a NumberValidator maximum it says: "5 must be smaller than 3" Which it can't be, not even for very small values of 5. To fix this, we need to d

Re: [VOTE] disable line-precise error reporting by default

2007-07-06 Thread Eelco Hillenius
[ x ] disable this feature by default, put instructions on how to enable it into component-not-found related exception messages [ ] leave it enabled by default I've argued before that if it were up to me, deployment would be our default. Lost that argument and that is fine, but I feel that debug

[VOTE] disable line-precise error reporting by default

2007-07-06 Thread Igor Vaynberg
the new error reporting feature, that one that throws two exceptions per component, is really making development not enjoyable. it slows down request processing significantly and might give noobs the wrong impression. it is valuable information for noobs, but imho after using wicket for a week you

Re: FileUploadField closing input streams behind my back

2007-07-06 Thread Eelco Hillenius
On 7/6/07, Johan Compagner <[EMAIL PROTECTED]> wrote: and if i remember correctly, back then it looked if the FileUpload project was really in suspend stage. there wasn't much happening on it, so i am talking abou the time we added it to the core of wicket Yeah, that's one of the reasons why we

Re: IComponentInheritedModel & IWrapModel just to get the component in model

2007-07-06 Thread Johan Compagner
make your own base model public abstract class ComponentAssignModel implements IWrapModel, IComponentAssignedModel { private Component component; /** * @see org.apache.wicket.model.IWrapModel#getWrappedModel() */ public IModel getWrappedModel() { return this; }

Re: FileUploadField closing input streams behind my back

2007-07-06 Thread Johan Compagner
and if i remember correctly, back then it looked if the FileUpload project was really in suspend stage. there wasn't much happening on it, so i am talking abou the time we added it to the core of wicket johan On 7/5/07, Eelco Hillenius <[EMAIL PROTECTED]> wrote: > I understand "we just took wh