Re: VOTE: EmptyPanel

2007-05-19 Thread Eelco Hillenius
On 5/19/07, Sean Sullivan [EMAIL PROTECTED] wrote: What was the result of this vote? Is EmptyPanel going to be added to Wicket 1.3? Just added. Eelco

Re: VOTE: EmptyPanel

2007-05-18 Thread Sean Sullivan
What was the result of this vote? Is EmptyPanel going to be added to Wicket 1.3? On 5/4/07, Jonathan Locke [EMAIL PROTECTED] wrote: so i propose a vote to add this. i'm +1.

Re: VOTE: EmptyPanel

2007-05-05 Thread Eelco Hillenius
+1 Eelco On 5/5/07, Jonathan Locke [EMAIL PROTECTED] wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: Yeah. I actually think I proposed something like this, or at least +1-ed one at more than a year ago. You'll have to dig in the archives to find out why other

Re: VOTE: EmptyPanel

2007-05-05 Thread Martijn Dashorst
+1, another class I can remove from our project :) On 5/5/07, Jonathan Locke [EMAIL PROTECTED] wrote: so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: Yeah. I actually think I proposed something like this, or at least +1-ed one at more than a year ago. You'll have to dig

Re: VOTE: EmptyPanel

2007-05-05 Thread Martijn Dashorst
How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding EmptyPanel, and anyone subclassing Panel would override it by supplying their own markup. Martijn On 5/5/07, Martijn Dashorst [EMAIL PROTECTED] wrote: +1, another class I can remove from our

Re: VOTE: EmptyPanel

2007-05-05 Thread Eelco Hillenius
That's actually not a bad idea. Xavier, you think you would have found that/ is it as obvious? Eelco On 5/5/07, Martijn Dashorst [EMAIL PROTECTED] wrote: How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding EmptyPanel, and anyone subclassing Panel

Re: VOTE: EmptyPanel

2007-05-05 Thread Igor Vaynberg
will that really make things better? if you misname the markup file you will now get component not found rather then markup not found. -igor On 5/5/07, Martijn Dashorst [EMAIL PROTECTED] wrote: How about giving Panel.java an accompanying Panel.html file? That would obviate the need of adding

Re: VOTE: EmptyPanel

2007-05-05 Thread Eelco Hillenius
You're right about that. EmptyPanel is better, and it should probably be final. Eelco On 5/5/07, Igor Vaynberg [EMAIL PROTECTED] wrote: will that really make things better? if you misname the markup file you will now get component not found rather then markup not found. -igor On 5/5/07,

Re: VOTE: EmptyPanel

2007-05-05 Thread Xavier Hanin
On 5/5/07, Eelco Hillenius [EMAIL PROTECTED] wrote: You're right about that. EmptyPanel is better, and it should probably be final. Yes, I think EmptyPanel has the merit of being more obvious in its intent, and less error prone. Xavier Eelco On 5/5/07, Igor Vaynberg [EMAIL PROTECTED] wrote:

Re: VOTE: EmptyPanel

2007-05-05 Thread Jean-Baptiste Quenot
* Jonathan Locke: so i propose a vote to add this. i'm +1. +1 I have one in every project. It is particularly useful for a reusable modal dialog that is defined in the page, and replaced/shown in various forms. -- Jean-Baptiste Quenot aka John Banana Qwerty

VOTE: EmptyPanel

2007-05-04 Thread Jonathan Locke
so i propose a vote to add this. i'm +1. Eelco Hillenius wrote: Yeah. I actually think I proposed something like this, or at least +1-ed one at more than a year ago. You'll have to dig in the archives to find out why other people didn't agree back then, but I still think it's much