Review: Needs Fixing
Diff comments:
> === modified file 'src/logic/map_objects/immovable.cc'
> --- src/logic/map_objects/immovable.cc2016-11-03 07:20:57 +
> +++ src/logic/map_objects/immovable.cc2016-11-03 07:36:43 +
> @@ -339,6 +339,7 @@
>
> Immovable::Immovable(cons
The proposal to merge lp:~widelands-dev/widelands/oars_appdata into
lp:widelands has been updated.
Commit Message changed to:
Added age ratings to Appdata https://odrs.gnome.org/oars and validator call to
utils/uppdate_appdata.py. Fixed localization format for long description.
For more detail
Review: Resubmit
Thanks for the review - could you please check again for me?
I have added the validator to utils/uppdate_appdata.py now, so I can't forget
to validate again.
It's now throwing a warning "Found invalid tag: 'content_rating'", but I guess
that's because the format is new and the
This feels a bit messy. The scale of an animation must now be publicly knowable
on the outside for doing math on it, though it feels like it should be a purely
internal information. Can this not be internalized somehow by changing the
animations interface?
Also, if you want bigger images to lo
Continuous integration builds have changed state:
Travis build 1603. State: errored. Details:
https://travis-ci.org/widelands/widelands/builds/175565469.
Appveyor build 1441. State: failed. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_casern_wor
Thanks for the answers earlier. Wares- and WorkerQueues now have a common
interface so they can be used interchangeable. Note that the code is not really
tested yet.
Both are using the same gui class for display, list on the first tab. Support
for priorities on the graphical worker queues is dis
Review: Needs Fixing
LBTM. This is invalid XML, you have multiple root tags. The
has to be a child of .
You can use the appstream package of your distribution to validate appstream
files. E.g:
appstreamcli validate debian/widelands.appdata.xml
It throws a lot of errors, even before your chan
Continuous integration builds have changed state:
Travis build 1601. State: passed. Details:
https://travis-ci.org/widelands/widelands/builds/175510561.
Appveyor build 1439. State: success. Details:
https://ci.appveyor.com/project/widelands-dev/widelands/build/_widelands_dev_widelands_animation_
It could be coded a bit more elegantly(see my comments), but apart from that it
LGTM. However, I did not test it because I dont know a straight forward way to
get a warehous with 500+ workers.
Diff comments:
> === modified file 'src/logic/map_objects/tribes/warehouse.cc'
> --- src/logic/map_obj
The proposal to merge lp:~widelands-dev/widelands/fsmenu_fullscreen_2_about
into lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_2_about/+merge/309754
--
Your team Widelands Developers
Review: Approve
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/fsmenu_fullscreen_2_about/+merge/309754
Your team Widelands Developers is subscribed to branch
lp:~widelands-dev/widelands/fsmenu_fullscreen_2_about.
___
Mailing li
This looks very promising!
--
https://code.launchpad.net/~widelands-dev/widelands/animation_scaling/+merge/310718
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/animation_scaling into lp:widelands.
_
GunChleoc has proposed merging lp:~widelands-dev/widelands/animation_scaling
into lp:widelands.
Commit message:
Implemented scaling for animations. Bigger idle textures for Barbarian
warehouse and shipyard.
Requested reviews:
Widelands Developers (widelands-dev)
For more details, see:
https:
Btw, is the C++ system applied for Widelands using garbage collection? I looked
through some code in defaultai.cc and didn't find any free-memory operations so
far, e.g. after local list creations.
--
https://code.launchpad.net/~7010622-q/widelands/topple-seafaring-1/+merge/310436
Your team Wide
I tested my proposed logic on a "one-world" island and it turned out the
expedition found portspaces in secondary access although it doesn't per-se
perform secondary island circling. This is because the map is a torus and the
ship is reflected only onto the island again under various angles and
The proposal to merge lp:~widelands-dev/widelands/sphinx-buildings into
lp:widelands has been updated.
Status: Needs review => Merged
For more details, see:
https://code.launchpad.net/~widelands-dev/widelands/sphinx-buildings/+merge/308704
--
Your team Widelands Developers is requested to r
I need this for other branches, so I'm gonna merge.
@bunnybot merge
--
https://code.launchpad.net/~widelands-dev/widelands/sphinx-buildings/+merge/308704
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/sphinx-buildings into lp:widelands.
_
The proposal to merge lp:~widelands-dev/widelands/bug-1638394-render-road into
lp:widelands has been updated.
Commit Message changed to:
Fix a crash with rendering roads in previously visible areas:
If the owner of the starting field of the road is not visible, the owner of the
end field of the
Janosch Peters has proposed merging
lp:~widelands-dev/widelands/bug-1638394-render-road into lp:widelands.
Requested reviews:
Widelands Developers (widelands-dev)
Related bugs:
Bug #1638394 in widelands: "Crash on rendering roads"
https://bugs.launchpad.net/widelands/+bug/1638394
For more
19 matches
Mail list logo
