Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/improve-restool into lp:widelands

2016-03-18 Thread GunChleoc
Thanks for the fix! :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/improve-restool/+merge/289305 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/improve-restool. ___ Mailing list: https://l

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-editor into lp:widelands

2016-03-19 Thread GunChleoc
Thanks! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-editor/+merge/289494 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1395278-editor. ___ Mailing list: https://launchpad.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_DBG_window into lp:widelands

2016-03-19 Thread GunChleoc
Review: Approve I'm done - I prettied things up a bit. I noticed that the information on the bottom just keeps expanding rather than being replaces. Is this on purpose? If it is on purpose, please feel free to merge. Otherwise, please fix. -- https://code.launchpad.net/~widelands-dev/widelands

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-network-io-wui into lp:widelands

2016-03-19 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1395278-network-io-wui into lp:widelands. Commit message: Refactored remaining member variables. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1395278 in widelands: "Consolidate naming of m

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/memleaks-and-uninit-vars into lp:widelands

2016-03-19 Thread GunChleoc
Review: Approve LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/memleaks-and-uninit-vars/+merge/289561 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/memleaks-and-uninit-vars. ___ Mailing list: https:

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/show-ship-names into lp:widelands

2016-03-19 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/show-ship-names into lp:widelands. Commit message: Added census/statistics strings to ships and ship construction. Ship states are now an enum class. Requested reviews: Widelands Developers (widelands-dev) For more details, see

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-scripting into lp:widelands

2016-03-19 Thread GunChleoc
Thanks for the review :) AppVeyor fails a lot on the downloads - the service is quite new, and I guess they're still working out the kinks. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1395278-scripting/+merge/288975 Your team Widelands Developers is subscribed to

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands-website/fix-installation into lp:widelands-website

2016-03-19 Thread GunChleoc
Yes, I was unable to find current repositories for everything. Our only solution for this is to get the update to Django 1.8 working. -- https://code.launchpad.net/~widelands-dev/widelands-website/fix-installation/+merge/286797 Your team Widelands Developers is subscribed to branch lp:widelands-w

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/memleaks-and-uninit-vars into lp:widelands

2016-03-19 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/memleaks-and-uninit-vars/+merge/289561 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/memleaks-and-uninit-vars. ___ Mailing list: https://launchp

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1252625-statistics-window-update into lp:widelands

2016-03-19 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1252625-statistics-window-update into lp:widelands. Commit message: Plot areas now update their data less often. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1252625 in widelands: "Ge

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-network-io-wui into lp:widelands

2016-03-19 Thread GunChleoc
Thanks! @bunnybot merge Diff comments: > === modified file 'src/io/filesystem/layered_filesystem.cc' > --- src/io/filesystem/layered_filesystem.cc 2016-02-18 18:27:52 + > +++ src/io/filesystem/layered_filesystem.cc 2016-03-19 10:27:47 + > @@ -89,7 +89,7 @@ >

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_DBG_window into lp:widelands

2016-03-19 Thread GunChleoc
Sounds good to me then - I can take care of 1. when you're finished with reworking the info. -- https://code.launchpad.net/~widelands-dev/widelands/ship_DBG_window/+merge/289110 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ship_DBG_window. _

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-editor into lp:widelands

2016-03-19 Thread GunChleoc
I think we should go through all the clang warnings on Travis sometime and fix. Added replies to your comments. Diff comments: > > === modified file 'src/editor/tools/editor_increase_height_tool.h' > --- src/editor/tools/editor_increase_height_tool.h2016-01-28 05:24:34 > + > +++ src/ed

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_DBG_window into lp:widelands

2016-03-19 Thread GunChleoc
OK, let's merge this then :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/ship_DBG_window/+merge/289110 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/ship_DBG_window. ___ Mailing list: htt

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-graphic into lp:widelands

2016-03-19 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1395278-graphic into lp:widelands. Commit message: Refactored member variables in src/graphic. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1395278 in widelands: "Consolidate naming of m

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1395278-editor into lp:widelands

2016-03-20 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1395278-editor into lp:widelands. Commit message: Refactored member variable names in src/editor. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1395278 in widelands: "Consolidate naming of m

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/watchwindow-fixes into lp:widelands

2016-03-20 Thread GunChleoc
Review: Approve LGTM :) I think it would also be great when a new location is added, that the window activates that new location. It doesn't do that in trunk either though, so it's up to you if you want to work on this in this branch. -- https://code.launchpad.net/~widelands-dev/widelands/watc

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/new_workarea_pics into lp:widelands

2016-03-20 Thread GunChleoc
Review: Approve @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/new_workarea_pics/+merge/289578 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/new_workarea_pics. ___ Mailing list: https://laun

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/watchwindow-fixes into lp:widelands

2016-03-20 Thread GunChleoc
New changes still LGTM - Happy :) -- https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/watchwindow-fixes. ___ Mailing list: https://lau

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/watchwindow-fixes into lp:widelands

2016-03-20 Thread GunChleoc
> I am still missing some comments about the basic > workings of this (very sepcial) window. and I have some questions: > > * why is uint8_t as index, a plain unsigned int would not make a difference? Old code. We actually think that using int is even better than unsigned int, because it prevent

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands

2016-03-20 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands. Commit message: Fixed the hopping in the Island Hopping scenario. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1540813 in widelands: "Island Ho

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/watchwindow-fixes into lp:widelands

2016-03-20 Thread GunChleoc
Cool, thanks for testing and fixing! Travis went through as well. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/watchwindow-fixes/+merge/289573 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/watchwindow-fixes.

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1422347-no-scenario-replays into lp:widelands

2016-03-20 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1422347-no-scenario-replays into lp:widelands. Commit message: Stop writing replays for scenarios. Fixed "Scenario" localization for loadgame. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands

2016-03-20 Thread GunChleoc
On my machine, I couldn't get it to hop at all without the blank spaces. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1540813-island-hoppi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/show-ship-names into lp:widelands

2016-03-20 Thread GunChleoc
I agree the labels could be improved. I don't like "Transport mode" - too techy. For "Unloading", I used to have "Building Port", but I didn't like that either, because as soon as the wares and builder are unloaded, the ship goes into transport mode while the port is building - how about "Found

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands

2016-03-20 Thread GunChleoc
The rest of the script was running fine. The fix happened by accident. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/bug-1540813-island-hopping

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/show-ship-names into lp:widelands

2016-03-21 Thread GunChleoc
I like "Expedition Landing" :D I would like an -ing form for the transport as well for consistency - just "Transporting" sounds a bit weird to me though, and the dictionary agrees that I need to specify what is being transported. How about plain old "Shipping"? That can be used as an intransiti

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/show-ship-names into lp:widelands

2016-03-21 Thread GunChleoc
Done :) Is this ready to merge now? -- https://code.launchpad.net/~widelands-dev/widelands/show-ship-names/+merge/289562 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/show-ship-names into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/show-ship-names into lp:widelands

2016-03-21 Thread GunChleoc
8-) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/show-ship-names/+merge/289562 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/show-ship-names. ___ Mailing list: https://launchpad.net/~widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1559729-lost_portspace into lp:widelands

2016-03-21 Thread GunChleoc
Actually, it's not my code - you are much more familiar with it than I am, Tibor. We somehow have to remember the original port spaces that were there during map creation or maybe have been added later through a scenario script, so we can reenable them once the space gets freed up again. -- htt

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1559729-lost_portspace into lp:widelands

2016-03-22 Thread GunChleoc
Glad you found the bug! I think we can differentiate in the write function whether we are in a game or in the editor: if (!is_a(Game, &egbase)) { // cleanup } This way, we would still have the cleanup for the editor. -- https://code.launchpad.net/~widelands-dev/widelands/bug-15

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1559729-lost_portspace into lp:widelands

2016-03-22 Thread GunChleoc
I think this is ready for merging now :) It would still be nice to have the blue building plot symbols around a possible port space, but that's another bug. @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1559729-lost_portspace/+merge/289626 Your team Widelands Develo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands

2016-03-22 Thread GunChleoc
Review: Disapprove I can't reproduce the original bug any more, so I'm setting this to invalid/rejected. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1540813

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands

2016-03-22 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/bug-1540813-island-hopping into lp:widelands has been updated. Status: Needs review => Rejected For more details, see: https://code.launchpad.net/~widelands-dev/widelands/bug-1540813-island-hopping/+merge/289579 -- Your team Widelands Develo

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-22 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/lua-driven-help into lp:widelands. Commit message: The contents of the Tribal Encyclopedia / Editor Help are now defined in Lua files. Removed Readme/Authors/License buttons from in-game/in-editor menu. Requested reviews: Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-23 Thread GunChleoc
Review: Abstain I have streamlined the code a bit, that shouldn't change the semantics. Code looks clean, and soldiers seem to be retreating properly. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830 Your team Widelands Developers is subscribed to branch lp:~wide

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-23 Thread GunChleoc
Review: Approve OK, let's wait for somebody else to come in and do some more testing - you have my approval for the code (my "Abstain" was a misclick). -- https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830 Your team Widelands Developers is subscribed to branch lp:~wid

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1252625-statistics-window-update into lp:widelands

2016-03-23 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1252625-statistics-window-update/+merge/289569 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1252625-statistics-window-update. ___ Maili

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1422347-no-scenario-replays into lp:widelands

2016-03-23 Thread GunChleoc
Thanks! I'd still like somebody to test, to make sure that I haven't missed anything. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1422347-no-scenario-replays/+merge/289582 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1422347-no-scenario-re

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-23 Thread GunChleoc
Thanks! When you have some time, could you have a look at the "About" branch too? It has already been tested. I am thinking of creating a new text domain for the editor help, I might still do that in the other branch. -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/about into lp:widelands

2016-03-24 Thread GunChleoc
Review: Resubmit I have reworked the hotkey listings to reduce the translation efforts and also added a new textdomain for the editor - this will help translators to prioritize and also cleans up the mess where some of the editor helptexts were in widelands and others in txts.. -- https://code

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/infotool_stuck_painting into lp:widelands

2016-03-25 Thread GunChleoc
I actually think that you fixed a really annoying bug here! Code LGTM, I'll do some testing. -- https://code.launchpad.net/~widelands-dev/widelands/infotool_stuck_painting/+merge/290076 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/infoto

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-25 Thread GunChleoc
I did get some segfaults while developing this branch, but I thought I had sqashed them all. This one looks completely different though. Since your crash won't reproduce anymore, do you think that this branch is good to go now? -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-h

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/infotool_stuck_painting into lp:widelands

2016-03-25 Thread GunChleoc
Review: Approve Tested and working :) Once Travis comes through, this can go in. -- https://code.launchpad.net/~widelands-dev/widelands/infotool_stuck_painting/+merge/290076 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/infotool_stuck_painting.

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-25 Thread GunChleoc
I am done proofreading. I also made sure that all the maps will load in a singleplayer game without errors. The Nile has lost its suggested teams - is that on purpose? Next time, please use bzr mv to rename directories, this is very hard to diff. There might be more that I have missed. I am al

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-25 Thread GunChleoc
> I got different segfaults... so i think it's not related not this branch. On > the other side i had no trouble with other programs, so i think it's not my > computer which causes such segfaults. Annoying was that the segfaults are > irreproducable, sometimes there was no segfault. Because there i

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-25 Thread GunChleoc
> This is really strange i restarted widelands about 25 times without any > crash until my last post. So the first crashes i encountered was kind of > "luck" :-D Is there a possibility to have a bashscript to make automatic > tests? Not easily - first, we would need to add a test to the test s

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-25 Thread GunChleoc
Thanks! Yes, it would be better if the localization tags were written - it's not triviel though. Time for a wishlist bug? -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-25 Thread GunChleoc
Review: Approve Looking good :) -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps. ___ Mailing list: https://launchpad.net/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/infotool_stuck_painting into lp:widelands

2016-03-25 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/infotool_stuck_painting/+merge/290076 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/infotool_stuck_painting. ___ Mailing list: https://launchpad

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_fixes into lp:widelands

2016-03-25 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/scrollbar_fixes into lp:widelands. Commit message: Various scrollbar-related fixes: - Improved buttons for short scrollbars - Fixed height of language list in options. - Fixed width of MapDetails in Mapselect and missing pixel in Map

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/draw_rect_missing_pixel into lp:widelands

2016-03-25 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/draw_rect_missing_pixel into lp:widelands. Commit message: Added missing pixel on the bottom right corner in the draw_rect program. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1540827 into lp:widelands

2016-03-26 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1540827 into lp:widelands. Commit message: Fixed bug with establishing smuggling routes in the Smugglers scenario. Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1540827 in widelands: "Smug

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-27 Thread GunChleoc
You didn't work on the scenarios in this branch, so no need to worry about them here. The only scenario still untested is Trident of Fire - tree growth could be compared in single player mode (= without the scenario scripts). The scenario scripts themselves need to be tested in multiplayer mode

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/about into lp:widelands

2016-03-27 Thread GunChleoc
Thanks for testing again - should be all fixed now. I also moved the Tribal Encyclopedia button to the right, as discussed in the other merge request. > Works :-) The only thing is F1 hotkey, which triggers the tribal encyclopedia > during gameplay and Trees/terrains in editor and not a general

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/draw_rect_missing_pixel into lp:widelands

2016-03-28 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/draw_rect_missing_pixel/+merge/290141 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/draw_rect_missing_pixel. ___ Mailing list: https://launchpad

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1540827 into lp:widelands

2016-03-28 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1540827/+merge/290164 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1540827. ___ Mailing list: https://launchpad.net/~widelands-dev Post

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_fixes into lp:widelands

2016-03-28 Thread GunChleoc
Yes, this is what I meant by "We still need to do something about The Nile, but I'd rather do that in a separate branch, so we won't lose the test case here." ;) There are 2 possible solution: 1. Get the new font renderer working, so we can have a big multilinetextarea for pretty much everythi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1562071-rendering_issues into lp:widelands

2016-03-28 Thread GunChleoc
Review: Approve LGTM :) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1562071-rendering_issues/+merge/290183 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1562071-rendering_issues. ___ Mailing list

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-28 Thread GunChleoc
The problem is triggered in the line std::unique_ptr table(lua_->run_script(entry.script_path)); and the crash happens somewhere in eris. I have no idea why. I tried all kinds of things, and I'm out of ideas. -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/2897

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1556218-escape-characters into lp:widelands

2016-03-28 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/bug-1556218-escape-characters into lp:widelands. Commit message: Replaced "\\< ... \\>" with "< ... >" Requested reviews: Widelands Developers (widelands-dev) Related bugs: Bug #1556218 in wideland

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/options_spinbox_cleanups into lp:widelands

2016-03-28 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/options_spinbox_cleanups into lp:widelands. Commit message: Options and Spinbox cleanups: - Reversed semantics of "Do not zip" checkbox. - More intelligent handling of units in spinboxes. Requested reviews: Widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-28 Thread GunChleoc
Yes, we could try that. Good idea :) -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___ Mailing list: https://laun

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-03-28 Thread GunChleoc
OK, updating eris doesn't help - the bug is somewhere else. -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___ Mai

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1562071-rendering_issues into lp:widelands

2016-03-28 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1562071-rendering_issues/+merge/290183 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1562071-rendering_issues. ___ Mailing list: https:/

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-28 Thread GunChleoc
I agree, let's merge this. This will give us a higher chance that somebody will encounter any bugs. I also tested Trident of Fire, which is working fine :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscri

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/options_spinbox_cleanups into lp:widelands

2016-03-28 Thread GunChleoc
Thanks! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/options_spinbox_cleanups/+merge/290192 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/options_spinbox_cleanups. ___ Mailing list: https:

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1556218-escape-characters into lp:widelands

2016-03-28 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1556218-escape-characters/+merge/290191 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1556218-escape-characters. ___ Mailing list: https

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/scrollbar_fixes into lp:widelands

2016-03-28 Thread GunChleoc
Yes, the issue is not new. Thanks for the review :) @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/scrollbar_fixes/+merge/290133 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/scrollbar_fixes into lp:widelands. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-28 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps. ___ Mailing list: https://launchpad.net/~widelands-dev Po

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_actionconfirm into lp:widelands

2016-03-29 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/fix_actionconfirm into lp:widelands. Commit message: Consistent ActionConfirm with improved messages. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-29 Thread GunChleoc
I had double-checked and didn't see any saveloading of the old value - I might have missed something thoug, or it might be a bug that it's not there. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830 Your team Widelands Developers is subscribed to branch lp:~widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/fix_actionconfirm into lp:widelands

2016-03-29 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/fix_actionconfirm/+merge/290280 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/fix_actionconfirm. ___ Mailing list: https://launchpad.net/~widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-29 Thread GunChleoc
I know - can you double-check if ivar3 is saved as well while you're dealing with this? -- https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1554552. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-29 Thread GunChleoc
Everything should be UTF-8, so we can use curly quotes etc. The culprit is probably Archipelago_Sea. -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-29 Thread GunChleoc
Next try @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps. ___ Mailing list: https://launchpad.net/~widela

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/string-fixes into lp:widelands

2016-03-30 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/string-fixes into lp:widelands. Commit message: Various string fixes: - Fixed overlap with slider labels in statistics windows - Improved/fixed TRANSLATORS comments - Tweaked ship transport strings. - Fixed missing localization markers

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-30 Thread GunChleoc
Review: Needs Fixing LGTM - this messes up the testsuite though. So, we need to test map loading, especially for scenarios. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-155

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_overlap into lp:widelands

2016-03-30 Thread GunChleoc
LGTM - will do some testing. I was also thinking of something else that we might do: When a ship has delivered its wares to a port, it will sit there until it gets new orders. This will probably block the portdock for other ships trying to reach the same port? We might test for that and let any

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/spidercloth_menu_icon into lp:widelands

2016-03-30 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/spidercloth_menu_icon into lp:widelands has been updated. Description changed to: Desaturated and a tiny bit of bluish hue. Discussed in the forum: https://wl.widelands.org/forum/topic/1953/ For more details, see: https://code.launchpad.net/~wi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/spidercloth_menu_icon into lp:widelands

2016-03-30 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/spidercloth_menu_icon into lp:widelands. Commit message: Differentiated the Spidercloth menu icon from the Cloth menu icon Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_overlap into lp:widelands

2016-03-30 Thread GunChleoc
I have randomized the idle length a bit, because ships would get stuck on top of each other repeatedly when there a lot of them going in the same direction. Also used game.logic_rand() to avoid desyncs. I double-checked the codebase any everything seems fine - I expect the usages of rand() in th

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_overlap into lp:widelands

2016-03-30 Thread GunChleoc
P.S. I am not sure that my decision to do this only in transport mode is correct - I wanted to give priority to scouting. -- https://code.launchpad.net/~widelands-dev/widelands/ship_overlap/+merge/290363 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-de

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-30 Thread GunChleoc
The test scenario probably has a bob packet - we need the bob packets for the critters, so we can't just exclude them from the map loading code in general. We might be safe killing the packet in the test suite though - it should not affect normal map loading, because those should only have critt

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/escaping-fixes into lp:widelands

2016-03-30 Thread GunChleoc
Review: Approve LGTM :) As soon as Travis comes through this can go in. -- https://code.launchpad.net/~widelands-dev/widelands/escaping-fixes/+merge/290410 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/escaping-fixes. ___

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_overlap into lp:widelands

2016-03-30 Thread GunChleoc
> Transport mode - ship in scouting mode does not use movepath, because there is > no path to follow. I believe. But no big deal. OK, I removed the check then - no need to test for something that's always true. > Random idle time - I did a test with ships in a bunch and also with static > idle t

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/escaping-fixes into lp:widelands

2016-03-31 Thread GunChleoc
@bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/escaping-fixes/+merge/290410 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/escaping-fixes. ___ Mailing list: https://launchpad.net/~widelands-de

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/ship_overlap into lp:widelands

2016-03-31 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/ship_overlap into lp:widelands has been updated. Status: Needs review => Approved For more details, see: https://code.launchpad.net/~widelands-dev/widelands/ship_overlap/+merge/290363 -- Your team Widelands Developers is requested to review

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-31 Thread GunChleoc
> Where does this ALTGR+SHIFT+n - apostroph comes from? It comes from your guideline to use proper typography in UI strings that I introduced 2 years ago. I am generating the characters with LibreOffice, so there is no reason why they shouldn't be a legal typographical apostrophe or closing quo

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-31 Thread GunChleoc
I found it in MapObjectPacket - case MapObject::HeaderWorker. We didn't have any compatibility code for soldiers in Build18, so this is new. We obviously don't want compatibility code where we don't need it, but we also want to be able to load old maps, which I now fear might have soldiers in th

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/revised_maps into lp:widelands

2016-03-31 Thread GunChleoc
I agree that the warnings are annoying, but I don't know how to fix them - there are no obvious encoding errors. -- https://code.launchpad.net/~widelands-dev/widelands/revised_maps/+merge/289704 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/revised_maps. __

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-31 Thread GunChleoc
Exactly something like this. -- https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1554552. ___ Mailing list: https://launchpad.net/~widel

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/bug-1554552 into lp:widelands

2016-03-31 Thread GunChleoc
Excellent! @bunnybot merge -- https://code.launchpad.net/~widelands-dev/widelands/bug-1554552/+merge/289830 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1554552. ___ Mailing list: https://launchpad.net/~widela

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/luatable-stack-fix into lp:widelands

2016-03-31 Thread GunChleoc
You just made my day :) Another thing I would need for that branch (and also for the new font renderer) is a code review of https://code.launchpad.net/~widelands-dev/widelands/about/+merge/288697 - it has already been tested. Do you have time for this? @bunnybot merge -- https://code.launchpa

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/lua-driven-help into lp:widelands

2016-04-01 Thread GunChleoc
Thanks! I have merged the fix now. Is this ready to go in? -- https://code.launchpad.net/~widelands-dev/widelands/lua-driven-help/+merge/289782 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/lua-driven-help. ___ Mai

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-01 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands has been updated. Status: Needs review => Work in progress For more details, see: https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 -- Your team Widelands Develope

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-01 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 Don't review thi

Re: [Widelands-dev] [Merge] lp:~widelands-dev/widelands/luatable-stack-fix into lp:widelands

2016-04-01 Thread GunChleoc
Don't apologize, shit happens ;) -- https://code.launchpad.net/~widelands-dev/widelands/luatable-stack-fix/+merge/290650 Your team Widelands Developers is requested to review the proposed merge of lp:~widelands-dev/widelands/luatable-stack-fix into lp:widelands. _

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-01 Thread GunChleoc
GunChleoc has proposed merging lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands. Requested reviews: Widelands Developers (widelands-dev) For more details, see: https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+merge/290697 Don't review thi

[Widelands-dev] [Merge] lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands

2016-04-01 Thread GunChleoc
The proposal to merge lp:~widelands-dev/widelands/travis-clang-warnings into lp:widelands has been updated. Commit Message changed to: Fixed some compiler warnings flagged up by clang in Travis. For more details, see: https://code.launchpad.net/~widelands-dev/widelands/travis-clang-warnings/+me

<    8   9   10   11   12   13   14   15   16   17   >