gerritbot added a comment.
Change 473197 merged by jenkins-bot:
[integration/config@master] Migrate Wikibase client/repo to Docker + cleanup
https://gerrit.wikimedia.org/r/473197TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/em
gerritbot added a comment.
Change 470798 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] build: prepend Wikibase client/repo settings
https://gerrit.wikimedia.org/r/470798TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/p
gerritbot added a comment.
Change 473197 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Migrate Wikibase client/repo to Docker + cleanup
https://gerrit.wikimedia.org/r/473197TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabr
gerritbot added a comment.
Change 470798 had a related patch set uploaded (by Hashar; owner: Hashar):
[mediawiki/extensions/Wikibase@master] build: prepend Wikibase client/repo settings
https://gerrit.wikimedia.org/r/470798TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps:
Addshore added a comment.
There is no good way to inject configuration files before extensions get loaded.
We could make mediawiki add a comment before it starts loading the extensions that it is installed with to the file?
Then in our jenkins job we could split split the file at that point and s
gerritbot added a comment.
Change 470791 merged by jenkins-bot:
[integration/config@master] Wikibase client/repo copy LocalSettings.php
https://gerrit.wikimedia.org/r/470791TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpr
hashar added a comment.
I fixed the Docker jobs so they capture LocalSettings.php AFTER build/jenkins/mw-apply-wb-settings.sh has been run. For the repo variant the tail of the file looks like:
...
wfLoadExtension( 'Elastica' );
wfLoadExtension( 'GeoData' );
require_once "$IP/extensions/Wikibase/W
gerritbot added a comment.
Change 470791 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Wikibase client/repo copy LocalSettings.php
https://gerrit.wikimedia.org/r/470791TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricato
gerritbot added a comment.
Change 470604 merged by jenkins-bot:
[integration/config@master] Remove Wikibase sqlite client jobs
https://gerrit.wikimedia.org/r/470604TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences
gerritbot added a comment.
Change 470605 merged by jenkins-bot:
[integration/config@master] Wikibase nodepool jobs with php7
https://gerrit.wikimedia.org/r/470605TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/T
gerritbot added a comment.
Change 470605 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Wikibase nodepool jobs with php7
https://gerrit.wikimedia.org/r/470605TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia
gerritbot added a comment.
Change 470604 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Remove Wikibase sqlite client jobs
https://gerrit.wikimedia.org/r/470604TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimed
gerritbot added a comment.
Change 470598 merged by jenkins-bot:
[integration/config@master] Fix phpunit --verbose for Wikibase jobs
https://gerrit.wikimedia.org/r/470598TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer
gerritbot added a comment.
Change 470598 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Fix phpunit --verbose for Wikibase jobs
https://gerrit.wikimedia.org/r/470598TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wi
gerritbot added a comment.
Change 470594 merged by jenkins-bot:
[integration/config@master] Make Wikibase client/repo phpunit tests verbose
https://gerrit.wikimedia.org/r/470594TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/ema
gerritbot added a comment.
Change 470594 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Make Wikibase client/repo phpunit tests verbose
https://gerrit.wikimedia.org/r/470594TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabri
gerritbot added a comment.
Change 470060 merged by jenkins-bot:
[integration/config@master] Wikibase client/repo tests with Quibble
https://gerrit.wikimedia.org/r/470060TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailprefer
hashar added a comment.
(we have a nodejs app in integration/junitdiff.git which might help to compare the junit results)TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: hasharCc: Agabi10, gerritbot, hashar, P
hashar added a comment.
I have crafted two jobs that use quibble to run commands.
They should have the proper dependencies injected (I have triggered them manually and filled EXT_DEPENDENCIES myself).
https://integration.wikimedia.org/ci/job/wikibase-client-docker/3/consoleFull
https://integratio
gerritbot added a comment.
Change 470060 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Wikibase client/repo tests with Quibble
https://gerrit.wikimedia.org/r/470060TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wi
Addshore added a comment.
And then just run the group WikibaseClient, which is doable in Quibble with something like --commands 'php tests/phpunit/phpunit.php --group WikibaseClient'.
This is different to not loading repo / not loading client.
The config var currently has to be set, using @group e
hashar added a comment.
The point of having "client" job is to have tests from group WikibaseClient run AND no repo part of Wikibase enabled. Is this what could be somehow set up in quibble jobs?
We can surely create a dedicated job for that purpose. I guess the job would use the extensions:
Wik
WMDE-leszek added a comment.
Thanks @hashar for looking into this.
A quick question checking that I understood what you wrote right.
All tests from the client job are run.
The point of having "client" job is to have tests from group WikibaseClient run AND no repo part of Wikibase enabled. Is this
Addshore added a comment.
In T188717#4541189, @Addshore wrote:
In T188717#4541180, @Legoktm wrote:
Well the goal of this ticket is to get rid of all the special casing for Wikibase :)
I think we always want to run our tests with just client loaded, Quibble could provide a way to inject some set
gerritbot added a comment.
Change 467675 merged by jenkins-bot:
[integration/config@master] Remove obsolete Wikibase settings
https://gerrit.wikimedia.org/r/467675TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/
gerritbot added a comment.
Change 467675 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Remove obsolete Wikibase settings
https://gerrit.wikimedia.org/r/467675TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedi
hashar added a comment.
Ok sorry for the confusion.
Meanwhile, I have Quibble running Wikibase PHPUnit tests just fine with:
ZUUL_PROJECT=mediawiki/extensions/Wikibase quibble --run=phpunit
Thought there are 200 skipped tests for Database less tests, related to lack of CLDR/CirrusSearch/and 79 s
Addshore added a comment.
In T188717#4669782, @hashar wrote:
In T188717#4541201, @Addshore wrote:
Is there a ticket to link to for this split yet?
I guess that is T88258: Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration
No, the extensions & entry point
Addshore added a comment.
In T188717#4541195, @WMDE-leszek wrote:
I guess it is kind of going to be solved once we've managed to split WikibaseClient off WikibaseRepo, and making it fully stand-alone extension, or so. The work on making WikibaseRepo and WikibaseClient use extension.json is related
WMDE-leszek added a comment.
I guess it is kind of going to be solved once we've managed to split WikibaseClient off WikibaseRepo, and making it fully stand-alone extension, or so. The work on making WikibaseRepo and WikibaseClient use extension.json is related to this I guess.TASK DETAILhttps://ph
Addshore added a comment.
In T188717#4541180, @Legoktm wrote:
Well the goal of this ticket is to get rid of all the special casing for Wikibase :)
I think we always want to run our tests with just client loaded, Quibble could provide a way to inject some settings before running the tests?
Anothe
Legoktm added a comment.
Well the goal of this ticket is to get rid of all the special casing for Wikibase :)TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: LegoktmCc: Addshore, WMDE-leszek, Legoktm, Aklapper
WMDE-leszek added a comment.
Isn't it that quibble job runs repo and client enabled variant only? We still should have a job that has only client enabled (Wikipedia scenario). Whether done using quibble or not, is a technical detail (if done via quibble, might be worth considering excluding duplica
Addshore added a comment.
In T188717#4541170, @Legoktm wrote:
Given that Wikibase is now running the quibble jobs, I think we should just drop the old mwext-repo/client jobs. If sqlite testing is still wanted, we could add the generic quibble job that runs sqlite.
They still run different differ
Legoktm added a comment.
Given that Wikibase is now running the quibble jobs, I think we should just drop the old mwext-repo/client jobs. If sqlite testing is still wanted, we could add the generic quibble job that runs sqlite.TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShtt
Addshore added a comment.
I gave this task a bit of love as the description was out of date, although the task itself is still relevant.TASK DETAILhttps://phabricator.wikimedia.org/T188717EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: AddshoreCc: Addshore, WM
36 matches
Mail list logo
