Ricordisamoa added a comment.
In https://phabricator.wikimedia.org/T69122#1701960, @daniel wrote:
> - DOMTestUtils would be "born deprecated". We don't want to encourage more
> usages of it, we really want it to go away and be replaced with something
> better
DOMTestUtils is not in good
daniel added a comment.
Quick update on my take on this: If DOMTestUtils::assertTagSimple() implements
a subset of PHPUnit's assertTag(), and doesn't (contrary to my earlier
understanding) invent yet another way to specify tag matches, I'm not
//fundamentally// opposed to using it. However, I'
daniel added a comment.
Moved to "needs discussion", since it's unclear what assertTag() should be
replaced with. I don't think the proposed DOMTestUtils::assertTagSimple() is a
good approach.
TASK DETAIL
https://phabricator.wikimedia.org/T69122
EMAIL PREFERENCES
JanZerebecki added a comment.
I agree I'm against any regexp that tries to parse HTML or XML. We should never
do that.
I dislike the assertTag matchers syntax and prefer CSS. Because more people
know CSS. (Even more than XPath which I would otherwise prefer). Also it is
more expressive than
JanZerebecki added a comment.
Copying from https://gerrit.wikimedia.org/r/#/c/234291/ :
Daniel Kinzler:
> I'd prefer something that is less ad-hoc than this. Perhaps we could use
> Symfony's CSS selector implementation
> http://symfony.com/doc/current/components/css_selector.html (and skip the
gerritbot added a comment.
Change 237372 merged by jenkins-bot:
Replace some very simple asserttag with assertContains
https://gerrit.wikimedia.org/r/237372
TASK DETAIL
https://phabricator.wikimedia.org/T69122
EMAIL PREFERENCES
gerritbot added a comment.
Change 237372 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Replace some very simple asserttag with assertContains
https://gerrit.wikimedia.org/r/237372
TASK DETAIL
https://phabricator.wikimedia.org/T69122
EMAIL PREFERENCES
