[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2023-08-19 Thread Daimona
Daimona added a subtask: T142120: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to extension registration. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2023-07-13 Thread Daimona
Daimona added a comment. Note that the presence of this hook makes it quite difficult to have a standard PHPUnit setup (T227900 , T90875 ), because we need to fully initialize MediaWiki in order to run the

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2023-07-13 Thread Daimona
Daimona removed parent tasks: T227900: Phase out usage of tests/phpunit/suite.xml, T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2023-07-13 Thread Daimona
Daimona added a parent task: T227900: Phase out usage of tests/phpunit/suite.xml. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Daimona Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper,

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2023-03-16 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, Astuthiodit_1,

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2023-03-16 Thread gerritbot
gerritbot added a comment. Change 761894 **abandoned** by Kosta Harlan: [mediawiki/extensions/DonationInterface@master] [WIP] Remove UnitTestsList hook Reason: https://gerrit.wikimedia.org/r/761894 TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-02-11 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: gerritbot Cc: Krinkle, cscott, kostajh, Jdforrester-WMF, Aklapper, Fernandobacasegua34, 786, Suran38,

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-02-11 Thread gerritbot
gerritbot added a comment. Change 761894 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan): [mediawiki/extensions/DonationInterface@master] [WIP] Remove UnitTestsList hook https://gerrit.wikimedia.org/r/761894 TASK DETAIL

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-02-11 Thread kostajh
kostajh added a comment. In T298509#7640564 , @cscott wrote: > In T298509#7633961 , @kostajh wrote: > >> `composer phpunit:unit` will run unit (not integration) tests for core and

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-21 Thread cscott
cscott added a comment. In any case, apart from my general griping, this is the actual issue: In T298509#7609799 , @cscott wrote: > I don't know how DonationInterface and Wikibase are using this hook, but Parsoid's use is pretty

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-21 Thread cscott
cscott added a comment. In T298509#7633961 , @kostajh wrote: > `composer phpunit:unit` will run unit (not integration) tests for core and all skins/extensions, regardless of whether they're enabled, but those tests don't rely on

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-19 Thread kostajh
kostajh added a comment. In T298509#7633606 , @Krinkle wrote: > In T298509#7609799 , @cscott wrote: > >> In my personal opinion, rMW1d7221d066c0

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-19 Thread Krinkle
Krinkle added a comment. In T298509#7609799 , @cscott wrote: > In my personal opinion, rMW1d7221d066c0 was a mistake: as a MediaWiki developer I have just

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-10 Thread cscott
cscott added a comment. I don't know how DonationInterface and Wikibase are using this hook, but Parsoid's use is pretty subtle and not obviously easily replaced: Parsoid is *both* a library *and* and extension, and we need to be able to squirrel away Parsoid's "standalone" tests (run by

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-10 Thread kostajh
kostajh added a project: Platform Engineering. kostajh added a comment. Tagging #platform_engineering in case they have opinions on this. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-04 Thread Maintenance_bot
Maintenance_bot added a project: Wikidata. Restricted Application added a project: wdwb-tech. TASK DETAIL https://phabricator.wikimedia.org/T298509 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Maintenance_bot Cc: kostajh, Jdforrester-WMF,

[Wikidata-bugs] [Maniphest] T298509: Deprecate UnitTestsListHook

2022-01-04 Thread kostajh
kostajh created this task. kostajh added projects: MediaWiki-Core-Tests, Technical-Debt, User-kostajh, MediaWiki-extensions-DonationInterface, MediaWiki-extensions-WikibaseRepository, MediaWiki-extensions-WikibaseClient, Parsoid. Restricted Application added a subscriber: Aklapper. TASK