Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread MZMcBride
Ashar Voultoiz wrote: > On 06/12/10 05:56, MZMcBride wrote: >> I filed bug 26259, "MediaWiki bloated with test suites": >> https://bugzilla.wikimedia.org/show_bug.cgi?id=26259 >> >> RobLa asked me to send an e-mail to wikitech-l about this bug. It's my view >> that checking out MediaWiki from SVN

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Petr Kadlec
On 6 December 2010 08:47, Ashar Voultoiz wrote: >  - I want to be able to commit a bug fix + associated tests in one > revision without having to fetch the whole phase3 tree. You don’t have to. Subversion supports (since 1.5?) sparse checkouts

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Niklas Laxström
On 6 December 2010 08:11, Q wrote: > I think better time would be spent decoupling all the languages.  Out > the 57 megs for an svn export, 41 is the languages directory. Distribute > the Big $foo, where $foo is some reasonable number of major languages, > and offer the rest as a seperate dl. Thi

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread MZMcBride
Niklas Laxström wrote: > Besides, it feels silly to talk about this, while we simultaneously > talk about including some of the most common extensions in the name of > providing feature complete MediaWiki straight from the box--which is a > goal I agree with. I wouldn't say it's silly. If a very l

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Niklas Laxström
On 6 December 2010 12:08, Petr Kadlec wrote: > On 6 December 2010 08:47, Ashar Voultoiz wrote: >>  - I want to be able to commit a bug fix + associated tests in one >> revision without having to fetch the whole phase3 tree. > > You don’t have to. Subversion supports (since 1.5?) sparse checkouts

Re: [Wikitech-l] Code review and making it to 1.17

2010-12-06 Thread Roan Kattouw
2010/12/6 Tim Starling : > Presumably you mean that we would create REL1_17 now, as a copy from > trunk, then run make-wmf-branch in January, which would copy from > REL1_17 to 1.17wmf1, to be deployed shortly after. Then we would tag > for release of 1.17 beta 1 some time after that. > That's the

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Markus Glaser
Hi all, concerning the selenium part of the tests, I suggest to treat functional tests and regression tests differently: * The framework and test runner should remain in maintenance/tests, since it provides a testing infrastructure for MW * We are working on a MediaWiki smoke test which makes su

[Wikitech-l] Improving the skinning system

2010-12-06 Thread Daniel Friesen
I've been chipping away at our skins system lately, there's a lot we can improve to improve the skins system. Right now there's a lot of it that doesn't work so nicely for an ecosystem promoting the creation of a wide variety of skins. - footerlinks is duplicated across skins and is hardcoded (I

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Soxred93
On Dec 6, 2010, at 5:12 AM, Niklas Laxström wrote: > On 6 December 2010 08:11, Q wrote: >> I think better time would be spent decoupling all the languages. Out >> the 57 megs for an svn export, 41 is the languages directory. Distribute >> the Big $foo, where $foo is some reasonable number of ma

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Huib Laurens
Hi! MediaWiki is famous because its almost supported in all languages that's something other wiki software don't have, lets not try to remove that. So I think the main bundle should be mediawiki with *all* languages. But a other option is to add a second download option where people can download

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Platonides
Niklas Laxström wrote: > This suggestion seems to come up from time to time. I feel it is > unrealistic. First of all we can't remove them from svn, since they > have to be there. We could remove them from the tarballs, but please, > last time I checked the tarball was hardly over 12 megs. Even wit

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Soxred93
It probably would not be too hard to make an extension to do just that. Just modify ExtensionDistributor. -X! On Dec 6, 2010, at 10:02 AM, Platonides wrote: > Niklas Laxström wrote: >> This suggestion seems to come up from time to time. I feel it is >> unrealistic. First of all we can't remov

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Chad
On Mon, Dec 6, 2010 at 10:02 AM, Platonides wrote: > Niklas Laxström wrote: >> This suggestion seems to come up from time to time. I feel it is >> unrealistic. First of all we can't remove them from svn, since they >> have to be there. We could remove them from the tarballs, but please, >> last ti

Re: [Wikitech-l] Improving the skinning system

2010-12-06 Thread Trevor Parscal
On 12/6/10 3:18 AM, Daniel Friesen wrote: > It's not part of distribution, but the new installer's ability to point > out extensions and allow you to install them from the installer was > pointed out. However generally each skin doesn't have it's own set of > configuration (vector does, but general

Re: [Wikitech-l] Making usability part of the development process

2010-12-06 Thread Trevor Parscal
Have you considered using something like say XSL? If a skin was a combination of a set of CSS/JS/image files plus an XSL file which took XML data (which would be the page content and various user interface elements) then you could avoid using a whole new template system. PHP 5 has an XSL 1.0 li

Re: [Wikitech-l] Improving the skinning system

2010-12-06 Thread Daniel Friesen
On 10-12-06 07:48 AM, Trevor Parscal wrote: > On 12/6/10 3:18 AM, Daniel Friesen wrote: > >> It's not part of distribution, but the new installer's ability to point >> out extensions and allow you to install them from the installer was >> pointed out. However generally each skin doesn't have it

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Mark A. Hershberger
MZMcBride writes: > Even if we could say that most users downloading from SVN are > interested in development, I don't see how that extends to saying that > test suites are required for development. You've lost me. If a developer breaks a test, ze[1] should fix it. As the tests cover more and m

Re: [Wikitech-l] Making usability part of the development process

2010-12-06 Thread Daniel Friesen
PHP -> XSL doesn't quite feel like much of an improvement in terms of cutting down on the verbose redundant code boilerplate required to insert something. ie: doesn't look much better than text("title") ?>, as opposed to {$title|escape:html}. And I'm not sure how XSL handles html vs. text, we ha

Re: [Wikitech-l] Making usability part of the development process

2010-12-06 Thread Trevor Parscal
Fair enough, but when I've pushed for using PHP as a template language, even with a clever wrapper that would make injected data escaped by default (so unescaping was obvious and could be more easily scrutinized for XSS) I have been met with about equal resistance. The state of things is that u

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Ashar Voultoiz
On 06/12/10 09:07, MZMcBride wrote: > The maintenance directory has maintenance tools in it. I don't think test > suites fall within the category of "maintenance." Like large artwork files, > these seem to be "development" tools that shouldn't be downloaded with every > phase3 checkout. On the sec

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Niklas Laxström
On 6 December 2010 17:02, Platonides wrote: > Niklas Laxström wrote: > A few days ago the issue came up where I was talking with an end user > who was complaining about MediaWiki being too large (in the server, not > in the tarball) compared to other apps like wordpress. > I think there's a use ca

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Platonides
Niklas Laxström wrote: > On 6 December 2010 17:02, Platonides wrote: >> Niklas Laxström wrote: >> A few days ago the issue came up where I was talking with an end user >> who was complaining about MediaWiki being too large (in the server, not >> in the tarball) compared to other apps like wordpress

Re: [Wikitech-l] Improving the skinning system

2010-12-06 Thread Rob Lanphier
On Mon, Dec 6, 2010 at 3:18 AM, Daniel Friesen wrote: > I've been chipping away at our skins system lately, there's a lot we can > improve to improve the skins system. > Right now there's a lot of it that doesn't work so nicely for an > ecosystem promoting the creation of a wide variety of skins.

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread MZMcBride
Mark A. Hershberger wrote: > MZMcBride writes: >> Even if we could say that most users downloading from SVN are >> interested in development, I don't see how that extends to saying that >> test suites are required for development. You've lost me. > > If a developer breaks a test, ze[1] should fix

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Victor Vasiliev
I strongly disagree with removing tests from the /trunk/phase3 directory. They should be there, though they may be thrown out on the release. Maybe introduce a "production" branch where the phase3 is mirrored without development stuff? --vvv ___ Wikitec

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Chad
On Mon, Dec 6, 2010 at 10:08 PM, Victor Vasiliev wrote: > I strongly disagree with removing tests from the /trunk/phase3 > directory. They should be there, though they may be thrown out on the > release. Maybe introduce a "production" branch where the phase3 is > mirrored without development stuff

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Dmitriy Sintsov
* Chad [Mon, 6 Dec 2010 22:11:19 -0500]: > On Mon, Dec 6, 2010 at 10:08 PM, Victor Vasiliev > wrote: > > I strongly disagree with removing tests from the /trunk/phase3 > > directory. They should be there, though they may be thrown out on the > > release. Maybe introduce a "production" branch whe

Re: [Wikitech-l] Making usability part of the development process

2010-12-06 Thread Dmitriy Sintsov
* Daniel Friesen [Mon, 06 Dec 2010 08:13:04 -0800]: > PHP -> XSL doesn't quite feel like much of an improvement in terms of > cutting down on the verbose redundant code boilerplate required to > insert something. > ie: doesn't look much better than $this->text("title") ?>, as opposed to {$title

Re: [Wikitech-l] Removing test suites from trunk

2010-12-06 Thread Dmitriy Sintsov
* Huib Laurens [Mon, 6 Dec 2010 12:46:53 +0100]: > Hi! > > MediaWiki is famous because its almost supported in all languages that's > something other wiki software don't have, lets not try to remove that. > So I > think the main bundle should be mediawiki with *all* languages. > Preservation of m

Re: [Wikitech-l] Improving the skinning system

2010-12-06 Thread Dmitriy Sintsov
* Daniel Friesen [Mon, 06 Dec 2010 03:18:44 -0800]: > I've been chipping away at our skins system lately, there's a lot we can > improve to improve the skins system. > Right now there's a lot of it that doesn't work so nicely for an > ecosystem promoting the creation of a wide variety of skins.

Re: [Wikitech-l] Improving the skinning system

2010-12-06 Thread Daniel Friesen
On 10-12-06 10:46 PM, Dmitriy Sintsov wrote: > * Daniel Friesen [Mon, 06 Dec 2010 03:18:44 > -0800]: > >> I've been chipping away at our skins system lately, there's a lot we >> > can > >> improve to improve the skins system. >> Right now there's a lot of it that doesn't work so nicely for an >> e

Re: [Wikitech-l] Making usability part of the development process

2010-12-06 Thread Daniel Friesen
skin->tooltipAndAccesskey( 'search-go' ); ?> /> One thing our skin system "does" have is an extensive linker and system for building tooltips and accesskeys for things using our i18n system. And calls to the message system from skins are all over the place: tagline, jumpto, and basically ever