[MediaWiki-CodeReview] [MediaWiki r86764]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86764. Old Status: fixme New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r86764. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86764#c18108 Commit summary: Embrace comment with () only when really

[MediaWiki-CodeReview] [MediaWiki r89134]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r89134. Old Status: fixme New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r89134. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89134#c18109 Commit summary: Add back space between size and comment i

[MediaWiki-CodeReview] [MediaWiki r86827]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86827. Old Status: fixme New Status: reverted User "Brion VIBBER" also posted a comment on MediaWiki.r86827. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86827#c18110 Commit summary: Followup r86764: don't parse the comment.

[MediaWiki-CodeReview] [MediaWiki r90101]: New comment added

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" posted a comment on MediaWiki.r90101. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90101#c18111 Commit summary: Revert r86764, r89134, r86827 -- added a second opaque boolean parameter to Linker::commentBlock() which appeared to mostly just turn it into Lin

[MediaWiki-CodeReview] [MediaWiki r80409]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r80409. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80409#c0 Commit summary: Make Special:WhatLinksHere set the related title so that the skin can display page tabs in it.

[MediaWiki-CodeReview] [MediaWiki r90082]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r90082. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90082#c0 Commit summary: Localisation updates for core and extension messages from translatewiki.net (2011-06-14 20:30:00 UTC) _

[MediaWiki-CodeReview] [MediaWiki r86736]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86736. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r86736. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86736#c18112 Commit summary: Implemented param tracking for hook users, feels

[MediaWiki-CodeReview] [MediaWiki r80434]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r80434. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80434#c0 Commit summary: Make it so that editintro's included using the editintro url parameter, don't show sections. Its quite counter-intu

[MediaWiki-CodeReview] [MediaWiki r90019]: New comment added

2011-06-14 Thread MediaWiki Mail
User "^demon" posted a comment on MediaWiki.r90019. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90019#c18113 Commit summary: remove show/hide from search results Comment: Please [[Manual:Coding_conventions#PHP_pitfalls|don't use empty]] for something like this. If you haven'

[MediaWiki-CodeReview] [MediaWiki r86735]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86735. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86735. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86735#c18114 Commit summary: Followup to r86312 Reedy: that rev is breaki

[MediaWiki-CodeReview] [MediaWiki r80818]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r80818. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80818#c0 Commit summary: Replace the repeated prologues to set mOptions, clearState(), setOutputType(), setTitle() with startExternalParse()

[MediaWiki-CodeReview] [MediaWiki r86312]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86312. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86312. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86312#c18115 Commit summary: Followup rr86304 We need a title object for p

[MediaWiki-CodeReview] [MediaWiki r80828]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r80828. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80828#c0 Commit summary: Accept being passed a null Title to startExternalParse(), at the callers responsibility. Added a note about getUserS

[MediaWiki-CodeReview] [MediaWiki r81574]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r81574. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81574#c0 Commit summary: followup r13884 add CASCADE so that if the tables are created a second time, errors aren't given.

[MediaWiki-CodeReview] [MediaWiki r84894]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84894. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84894#c0 Commit summary: Followup r81928, make proper use of $this->output instead of echo. ___ MediaWi

[MediaWiki-CodeReview] [MediaWiki r81928]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r81928. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81928#c0 Commit summary: Add a new maintenance script to reset the user_token of all users if you think someone got ahold of your user table.

[MediaWiki-CodeReview] [MediaWiki r86734]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86734. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86734. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86734#c18116 Commit summary: Cleanup next/prev links on special:search. Rem

[MediaWiki-CodeReview] [MediaWiki r83041]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83041. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83041#c0 Commit summary: generic and specific parameters separated in help output Play with array_diff_key to output Maintenance class parameters s

[MediaWiki-CodeReview] [MediaWiki r83418]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83418. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83418#c0 Commit summary: r82867 converted $wgCaches into a class instance. Update the parsertests. This faking is needed to avoid Table 'unittest_ob

[MediaWiki-CodeReview] [MediaWiki r82870]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r82870. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82870#c0 Commit summary: Make Cite properly register to any parser instead of just $wgParser. Makes CiteParserTests work with r82867 code.

[MediaWiki-CodeReview] [MediaWiki r83147]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83147. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83147#c0 Commit summary: * When CACHE_ANYTHING is requested, return the cached instance, don't construct a new object for each use. * In MemcachedS

[MediaWiki-CodeReview] [MediaWiki r86722]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86722. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r86722. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86722#c18117 Commit summary: Added DBError::getContentMessage() to factorise c

[MediaWiki-CodeReview] [MediaWiki r86714]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86714. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86714. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86714#c18118 Commit summary: Allow extensions to customize the search forms

[MediaWiki-CodeReview] [MediaWiki r89598]: New comment added

2011-06-14 Thread MediaWiki Mail
User "Tim Starling" posted a comment on MediaWiki.r89598. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89598#c18119 Commit summary: ; Comment: Please try to write more informative commit messages. ___ MediaWiki-CodeReview mailing li

[MediaWiki-CodeReview] [MediaWiki r83140]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83140. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83140#c0 Commit summary: * Rewrote ObjectCache.php to conform to the modern coding style, and to be less convoluted about how CACHE_ANYTHING

[MediaWiki-CodeReview] [MediaWiki r83376]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83376. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83376#c0 Commit summary: (follow-up: r83371) Fix variable name typo. $this to $loginForm. ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r83371]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83371. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83371#c0 Commit summary: Fix and Enhance: 1. Fix - previously unresolved possible return value (ABORTED) added to switch 2. Allows a message t

[MediaWiki-CodeReview] [MediaWiki r86705]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86705. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86705. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86705#c18120 Commit summary: * Remove manual query building in search mysql

[MediaWiki-CodeReview] [MediaWiki r84393]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84393. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84393#c0 Commit summary: Follow up r84175 ___ MediaWiki-CodeReview mailing list mediawiki-coderev...@li

[MediaWiki-CodeReview] [MediaWiki r84175]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84175. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84175#c0 Commit summary: Enable preprocessDump.php to work without a db. Using the new hook added in r84173 _

[MediaWiki-CodeReview] [MediaWiki r84815]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84815. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84815#c0 Commit summary: Restore calls to SpecialPage::outputHeader(), no longer called since the rewrite to subclass SpecialPage

[MediaWiki-CodeReview] [MediaWiki r84555]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84555. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84555#c0 Commit summary: findhooks.php: also check for Hooks::run, not just wfRunHooks. Hooks class has existed since r80435 but IIRC nothing in co

[MediaWiki-CodeReview] [MediaWiki r86697]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86697. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86697. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86697#c18121 Commit summary: (bug 26603) Followup r82232: fix double-escapi

[MediaWiki-CodeReview] [MediaWiki r82232]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r82232. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82232#c0 Commit summary: (bug 26603) returnto parameter in login link not escaped when viewed on Special:Userlogout __

[MediaWiki-CodeReview] [MediaWiki r85030]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85030. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85030#c0 Commit summary: Move duplicated Site class into own class in Maintenance.php, include in 2 users _

[MediaWiki-CodeReview] [MediaWiki r86623]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86623. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86623. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86623#c18122 Commit summary: (bug 28643) Merge Serbian language variant con

[MediaWiki-CodeReview] [MediaWiki r89272]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89272. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89272#c0 Commit summary: Remove some unused variables, add/improve some documentation ___ MediaWiki-Cod

[MediaWiki-CodeReview] [MediaWiki r86622]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86622. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86622. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86622#c18123 Commit summary: (bug 22209, bug 22574) Make indent, bullet lis

[MediaWiki-CodeReview] [MediaWiki r86567]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86567. Old Status: new New Status: fixme User "Brion VIBBER" also posted a comment on MediaWiki.r86567. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86567#c18124 Commit summary: Remove the JPEG/TIFF specific metadata code fr

[MediaWiki-CodeReview] [MediaWiki r86574]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86574. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r86574. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86574#c18125 Commit summary: Tweak wfDl() so it actually works properly in 5.3

[MediaWiki-CodeReview] [MediaWiki r86547]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r86547. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86547#c0 Commit summary: 1.17: MFT r82413, r83529, r83545, r83874, r85544, r86065, r86346, r86477 ___ M

[MediaWiki-CodeReview] [MediaWiki r83529]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83529. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83529#c0 Commit summary: Make updateCollation.php a bit less murderous for WMF databases: * Don't run a COUNT(*) query on what's potentially t

[MediaWiki-CodeReview] [MediaWiki r86534]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Brion VIBBER" changed the status of MediaWiki.r86534. Old Status: new New Status: ok User "Brion VIBBER" also posted a comment on MediaWiki.r86534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86534#c18126 Commit summary: (bug 23816) Add tracking category for any page wi

[MediaWiki-CodeReview] [MediaWiki r81031]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r81031. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81031#c0 Commit summary: Improvement on r81030, pass on table aliasing to database code, and also table prefixing

[MediaWiki-CodeReview] [MediaWiki r84377]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84377. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84377#c0 Commit summary: Fix another usage of empty ___ MediaWiki-CodeReview mailing list mediawiki-cod

[MediaWiki-CodeReview] [MediaWiki r84359]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84359. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84359#c0 Commit summary: set threadaction to be PARAM_REQUIRED, don't do it explicitally, using empty (bleugh) Add blank description for "op

[MediaWiki-CodeReview] [MediaWiki r84376]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84376. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84376#c0 Commit summary: Fix r84359 with partial revert Didn't add empty() back in, used !count LQT seems to have crappy error handling, no? Also

[MediaWiki-CodeReview] [MediaWiki r84364]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84364. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84364#c0 Commit summary: Followup r84361, numerical keys ftw ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r84361]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84361. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84361#c0 Commit summary: * (bug 27469) label implicit groups in list=allusers&auprop=groups/list=users&usprop=groups ___

[MediaWiki-CodeReview] [MediaWiki r86200]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r86200. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86200#c0 Commit summary: Remove some unused variables/globals Fix another unreachable statement ___ Me

[MediaWiki-CodeReview] [MediaWiki r87202]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87202. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87202#c0 Commit summary: Move special classes into special folder ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87006]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87006. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87006#c0 Commit summary: Remove whitespace, unneeded globals, and swap and/or for &&/|| ___ Media

[MediaWiki-CodeReview] [MediaWiki r87456]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87456. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87456#c0 Commit summary: Fleshed out function level documentation ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r87570]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87570. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87570#c0 Commit summary: Bye bye config directory ___ MediaWiki-CodeReview mailing list mediawiki-coder

[MediaWiki-CodeReview] [MediaWiki r87579]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87579. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87579#c0 Commit summary: Kill some more long deprecated unused functions Add more @deprecated since where appropriate

[MediaWiki-CodeReview] [MediaWiki r80988]: New comment added

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r80988. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80988#c18127 Commit summary: HTMLForm: All section headers and footers. Added an optional second $section parameter to addHeaderText and addFooterText. Comment: $section = $

[MediaWiki-CodeReview] [MediaWiki r87810]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87810. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87810#c0 Commit summary: (follow-up r8) per CR - use SpecialPage::getTitleFor instead. ___ Med

[MediaWiki-CodeReview] [MediaWiki r87871]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87871. Old Status: deferred New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87871#c0 Commit summary: Follow-up to r8 - Linker::link() needs to be called as a non-static method __

[MediaWiki-CodeReview] [MediaWiki r87777]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r8. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/8#c0 Commit summary: (follow-up r87593 / bug 28875) Replace calls to makeKnownLink with Linker::link since makeKnownLink was killed in 1.

[MediaWiki-CodeReview] [MediaWiki r87088]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87088. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87088#c0 Commit summary: Whitespace cleanup Remove unused variables Remove some API wheel reinventing ___

[MediaWiki-CodeReview] [MediaWiki r85350]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85350. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85350#c0 Commit summary: Fix double credits, don't define multiple times ___ MediaWiki-CodeReview maili

[MediaWiki-CodeReview] [MediaWiki r85441]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85441. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85441#c0 Commit summary: * (bug 28433) Duplicator extension throwing errors when running latest version of MediaWiki _

[MediaWiki-CodeReview] [MediaWiki r87598]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87598. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87598#c0 Commit summary: Kill $wgExtraRandompageSQL Rewrote extension using them to subclass SpecialRandompage ___

[MediaWiki-CodeReview] [MediaWiki r80989]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r80989. Old Status: new New Status: ok User "Aaron Schulz" also posted a comment on MediaWiki.r80989. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80989#c18128 Commit summary: Uploads that throw a warning (UploadFromStash) a

[MediaWiki-CodeReview] [MediaWiki r87309]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r87309. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87309#c0 Commit summary: Initial contribution of auditcode ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r88731]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r88731. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88731#c0 Commit summary: Fix from Bug #29095 “Change Bugzilla link URL structure” [A] simple enough change to the URL to fix links such as

[MediaWiki-CodeReview] [MediaWiki r89578]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89578. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89578#c0 Commit summary: Fix svn props for r89577 ___ MediaWiki-CodeReview mailing list mediawiki-coder

[MediaWiki-CodeReview] [MediaWiki r89629]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r89629. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89629#c0 Commit summary: Keywords in /etc/ldap/ldap.conf and /etc/ldap.conf aren't case sensitive, ensure we parse in a case insensitive way.

[MediaWiki-CodeReview] [MediaWiki r81027]: New comment added

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r81027. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81027#c18129 Commit summary: * Replaced $wgMessageCache by MessageCache::singleton(); since we only use one instance of this class (as for ParserCache, LinkCache) * MessageCac

[MediaWiki-CodeReview] [MediaWiki r90102]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r90102. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90102#c0 Commit summary: Using true instead of calling isMainPage() again. (Follow-up r90099 CR, Poke r87212)

[MediaWiki-CodeReview] [MediaWiki r81027]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81027. Old Status: new New Status: ok User "Aaron Schulz" also posted a comment on MediaWiki.r81027. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81027#c18130 Commit summary: * Replaced $wgMessageCache by MessageCache::singl

[MediaWiki-CodeReview] [MediaWiki r81103]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81103. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81103#c0 Commit summary: (bug 26929) Introduced the edittools-upload message, which will be inserted under the upload form instead of edittoo

[MediaWiki-CodeReview] [MediaWiki r81254]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81254. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81254#c0 Commit summary: Remove a bunch of useless $wgOuts. Just pass them like we should. Also make them protected so people don't cal

[MediaWiki-CodeReview] [MediaWiki r81255]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81255. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81255#c0 Commit summary: Stupid references, stupid PHP. I blame Nikerabbit (fixing r81254) ___ Me

[MediaWiki-CodeReview] [MediaWiki r81364]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81364. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81364#c0 Commit summary: followup r81318 & r81312 so that FIXME and revert can live (somewhat) happily __

[MediaWiki-CodeReview] [MediaWiki r81373]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81373. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81373#c0 Commit summary: follow up r81363 and fix Bug#27099 ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r81408]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81408. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81408#c0 Commit summary: Add a maintenance script to fix double redirects (and corresponding edit summary messages). Still lacks some feature

[MediaWiki-CodeReview] [MediaWiki r82369]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r82369. Old Status: ok New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82369#c0 Commit summary: Fix wrong static calls ___ MediaWiki-CodeReview mailing list mediawiki-co

[MediaWiki-CodeReview] [MediaWiki r83665]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r83665. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83665#c0 Commit summary: Makes MediaWikiProvide methods static Follow up and revert r82369 which used dynamic calls __

[MediaWiki-CodeReview] [MediaWiki r85332]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r85332. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85332#c0 Commit summary: Fix fatal in SpecialCite introduced in the Context rewrite. Reported on r85302 CR, but not sure which exact revision actu

[MediaWiki-CodeReview] [MediaWiki r81147]: New comment added

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" posted a comment on MediaWiki.r81147. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81147#c18131 Commit summary: Fixed bug - skin is passed to the page through ResourceLoaderConfigVars now since it's not page specific, so the MakeGlobalVariableScripts hook th

[MediaWiki-CodeReview] [MediaWiki r81499]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81499. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81499#c0 Commit summary: Use the right query parameter. ___ MediaWiki-CodeReview mailing list med

[MediaWiki-CodeReview] [MediaWiki r81527]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81527. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81527#c0 Commit summary: Allow parameter to be passed with an array in the first parameter (as other wfMsg*() functions) ___

[MediaWiki-CodeReview] [MediaWiki r81266]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r81266. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81266#c0 Commit summary: (bug 26857) Fatal error during installation enabling 'Vector' extension (or any extension, really). The reason we're

[MediaWiki-CodeReview] [MediaWiki r84868]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "^demon" changed the status of MediaWiki.r84868. Old Status: new New Status: reverted Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84868#c0 Commit summary: Use $updater->addNewExtension ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r81544]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81544. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81544#c0 Commit summary: Currently, we do not send last-modified headers for the RC if patrolling is in use, since that messes with the way w

[MediaWiki-CodeReview] [MediaWiki r81569]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81569. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81569#c0 Commit summary: Followup comment to r81507. The api is using a legacy langlinks method no modern skin uses. Deprecating this and giv

Re: [Wikitech-l] background shell process control and exit status

2011-06-14 Thread Michael Dale
On 06/14/2011 05:41 PM, Platonides wrote: > Do you want the command to be run asynchronously or not? > If you expect the status code to be returned by wfShellExec(), then the > process will obviously have finished and there's no need for the PID. > OTOH if you launch it as a background task, you w

[MediaWiki-CodeReview] [MediaWiki r81591]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81591. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81591#c0 Commit summary: * Changed all calls to wfMsgWikiHtml() in core * Now replacing parameter before parsing where possible * Used 'parsei

[MediaWiki-CodeReview] [MediaWiki r81601]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81601. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81601#c0 Commit summary: Files with a mime type that does not match the extension are now properly thumbnailed. Partial bug fix to bug 26661.

[MediaWiki-CodeReview] [MediaWiki r81604]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81604. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81604#c0 Commit summary: (bug 23315) Add new body classes to allow easier styling of special pages. Also eliminate some duplicate code introdu

[MediaWiki-CodeReview] [MediaWiki r81613]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81613. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81613#c0 Commit summary: Cleanup MimeMagic: Add public identifier to functions; kill error operator; Cleanup function documentation; Manual s

[MediaWiki-CodeReview] [MediaWiki r81631]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81631. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81631#c0 Commit summary: Simplify a bit by passing directly the value returned by doUnblock() to showForm() in case of error ___

[MediaWiki-CodeReview] [MediaWiki r81678]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81678. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81678#c0 Commit summary: Followup r81583, break some of the long lines and centralize the regex.

[MediaWiki-CodeReview] [MediaWiki r81711]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81711. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81711#c0 Commit summary: Add : to file-deleted-duplicate to force inline link display, as the file can exist on the shared repo. ___

[MediaWiki-CodeReview] [MediaWiki r81747]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81747. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81747#c0 Commit summary: We have OutputPage::showPermissionsErrorPage() for that ___ MediaWiki-Co

[MediaWiki-CodeReview] [MediaWiki r81795]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81795. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81795#c0 Commit summary: Allow several answers in QuestyCaptcha, per request at http://permalink.gmane.org/gmane.org.wikimedia.mediawiki/3676

[MediaWiki-CodeReview] [MediaWiki r81825]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81825. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81825#c0 Commit summary: Quick fix for PHP warnings in loop below ___ MediaWiki-CodeReview mailin

[MediaWiki-CodeReview] [MediaWiki r81889]: Revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r81889. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/81889#c0 Commit summary: Refactor userLinks into it's own method ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r86534]: New comment added, and revision status changed

2011-06-14 Thread MediaWiki Mail
User "Aaron Schulz" changed the status of MediaWiki.r86534. Old Status: ok New Status: fixme User "Aaron Schulz" also posted a comment on MediaWiki.r86534. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86534#c18132 Commit summary: (bug 23816) Add tracking category for any page

<    1   2   3   4   >