[MediaWiki-CodeReview] [MediaWiki r88362]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Nikerabbit changed the status of MediaWiki.r88362. Old Status: deferred New Status: fixme User Nikerabbit also posted a comment on MediaWiki.r88362. Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88362#c18747 Commit summary: some work on paging

[MediaWiki-CodeReview] [MediaWiki r90743]: New comment added

2011-06-26 Thread MediaWiki Mail
User SPQRobin posted a comment on MediaWiki.r90743. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90743#c18748 Commit summary: Directionality improvements as part of bug 6100 (under $wgBetterDirectionality): * Add CSS that should fix all LTR/LTR text on both LTR/RTL wikis, for

[MediaWiki-CodeReview] [MediaWiki r88622]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r88622. Old Status: new New Status: ok Full URL: https://secure.wikimedia.org/wikipedia/mediawiki/wiki/Special:Code/MediaWiki/88622#c0 Commit summary: Adding test suite for jquery.tabIndex.js, currently broken per: (bug 29048) jQuery.tabIndex:

[MediaWiki-CodeReview] [MediaWiki r68904]: New comment added

2011-06-26 Thread MediaWiki Mail
User TheDJ posted a comment on MediaWiki.r68904. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/68904#c18749 Commit summary: (bug 24212) Added MediaWiki:ImagePage.css which is also included on foreign client wikis. Comment: As far as I'm concerned, there are toggles: If you

[MediaWiki-CodeReview] [MediaWiki r90819]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Simetrical changed the status of MediaWiki.r90819. Old Status: new New Status: fixme User Simetrical also posted a comment on MediaWiki.r90819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18750 Commit summary: Made '^' (XOR) in recCheckCondition() act as a

[MediaWiki-CodeReview] [MediaWiki r90524]: New comment added

2011-06-26 Thread MediaWiki Mail
User Devayon posted a comment on MediaWiki.r90524. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90524#c18751 Commit summary: follow up to r90521 Comment: Hi, I get a database error if I go to index.php directly. Problem is solved (as in I get a proper redirect to main-page)

[Wikitech-l] WMF XML dump title case problem

2011-06-26 Thread Emmanuel Engelhart
Sorry, now correctly cross posted. Emmanuel Original Message Subject:WMF XML dump title case problem Date: Sun, 26 Jun 2011 17:07:19 +0200 From: Emmanuel Engelhart emman...@engelhart.org To: Mailing list for Wikimedia CH wikimediac...@lists.wikimedia.org,

Re: [Wikitech-l] WMF XML dump title case problem

2011-06-26 Thread MZMcBride
Emmanuel Engelhart wrote: Titles should be stored in the table page with a first letter uppercased. http://en.wikipedia.org/wiki/Wikipedia:Naming_conventions_%28technical_restric tions%29#Lower_case_first_letter Unfortunately, it seems that we have XML dumps (and consequently mwdumper

Re: [Wikitech-l] WMF XML dump title case problem

2011-06-26 Thread Steve Summit
Emmanuel Engelhart wrote: Titles should be stored in the table page with a first letter uppercased... Unfortunately, it seems that we have XML dumps (and consequently mwdumper generated SQL) containing titles with a first letter lowercased. For example: $wget

[MediaWiki-CodeReview] [MediaWiki r90835]: New comment added

2011-06-26 Thread MediaWiki Mail
User Nikerabbit posted a comment on MediaWiki.r90835. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90835#c18752 Commit summary: Unbreak multiple maintenance scripts Comment: Please backport, these are regressions in 1.17. ___

[MediaWiki-CodeReview] [MediaWiki r90524]: New comment added

2011-06-26 Thread MediaWiki Mail
User Jeroen De Dauw posted a comment on MediaWiki.r90524. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90524#c18753 Commit summary: follow up to r90521 Comment: You need to run the table update script at special smwadmin ___

[MediaWiki-CodeReview] [MediaWiki r82418]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Hashar changed the status of MediaWiki.r82418. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/82418#c0 Commit summary: re bug #25523: add mime.info and mime.types for *.dwg files so that when people add dwg to $wgFileExtensions, they can move

[MediaWiki-CodeReview] [MediaWiki r90524]: New comment added

2011-06-26 Thread MediaWiki Mail
User Devayon posted a comment on MediaWiki.r90524. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90524#c18754 Commit summary: follow up to r90521 Comment: oh, thanks :) ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90839]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r90839. Old Status: new New Status: ok User Reedy also posted a comment on MediaWiki.r90839. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90839#c18755 Commit summary: Followup r90775: Fix PHP Notice: Undefined index: deletedonly in

[MediaWiki-CodeReview] [MediaWiki r90819]: New comment added

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r90819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18756 Commit summary: Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, XOR silently ignored subconds beyond the first two. After r28805,

[MediaWiki-CodeReview] [MediaWiki r90304]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90304. Old Status: fixme New Status: new User Aaron Schulz also posted a comment on MediaWiki.r90304. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90304#c18757 Commit summary: Fix r90024: missing one PG sql file change

[MediaWiki-CodeReview] [MediaWiki r90835]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90835. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90835#c0 Commit summary: Unbreak multiple maintenance scripts ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r90827]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r90827. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90827#c0 Commit summary: userinfo for Guillaume Paumier ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90002]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r90002. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90002#c0 Commit summary: fix random link ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90826]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90826. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90826#c0 Commit summary: Fix comment in BacklinkCache::partition() + a typo Per cr on r84254 ___

[MediaWiki-CodeReview] [MediaWiki r84254]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84254. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84254#c0 Commit summary: documentation for BacklinkCache class - still need examples - could use peer review - no functional changes

[MediaWiki-CodeReview] [MediaWiki r83754]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r83754. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83754#c0 Commit summary: Update description how CentralNotice works to match the current landscape.

[MediaWiki-CodeReview] [MediaWiki r83731]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r83731. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83731#c0 Commit summary: removed .project file ( mistake in r83730 ) ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r86448]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Reedy changed the status of MediaWiki.r86448. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86448#c0 Commit summary: added licence ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90833]: New comment added

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r90833. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90833#c18758 Commit summary: Per http://translatewiki.net/wiki/Thread:Support/Unprotect get rid of term unprotect (hard to translate, not necessarily used to remove protection)

[MediaWiki-CodeReview] [MediaWiki r90839]: New comment added

2011-06-26 Thread MediaWiki Mail
User Duplicatebug posted a comment on MediaWiki.r90839. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90839#c18759 Commit summary: Followup r90775: Fix PHP Notice: Undefined index: deletedonly in /www/w/includes/specials/SpecialContributions.php on line 131 Comment: api

[MediaWiki-CodeReview] [MediaWiki r89566]: New comment added

2011-06-26 Thread MediaWiki Mail
User Duplicatebug posted a comment on MediaWiki.r89566. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89566#c18760 Commit summary: Followup r89564 Strip out the ?feed= functionality, update urls to point at the API! Comment: Using tt$wgUser/tt for ttuser/tt looks wrong,

[MediaWiki-CodeReview] [MediaWiki r80167]: New comment added

2011-06-26 Thread MediaWiki Mail
User Hashar posted a comment on MediaWiki.r80167. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/80167#c18761 Commit summary: Coerce mtimes to TS_UNIX before outputting them, and fix a wrong timestamp format in ResourceLoaderUserModule. This should fix bug 26704 Comment: This

[MediaWiki-CodeReview] [MediaWiki r90823]: New comment added

2011-06-26 Thread MediaWiki Mail
User Kaldari posted a comment on MediaWiki.r90823. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90823#c18762 Commit summary: mw.util.wikiUrlencode is not meant for encoding entire URLs, or if it is, its too agressive. For example, it encodes tildes, which will break some URLs.

[MediaWiki-CodeReview] [MediaWiki r90845]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r90845. Old Status: new New Status: fixme User Krinkle also posted a comment on MediaWiki.r90845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90845#c18765 Commit summary: Bug #29106: Patch from Michael M. to address JS legacy

[MediaWiki-CodeReview] [MediaWiki r90845]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r90845. Old Status: fixme New Status: resolved User Krinkle also posted a comment on MediaWiki.r90845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90845#c18766 Commit summary: Bug #29106: Patch from Michael M. to address JS legacy

[MediaWiki-CodeReview] [MediaWiki r90845]: New comment added

2011-06-26 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r90845. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90845#c18767 Commit summary: Bug #29106: Patch from Michael M. to address JS legacy globals in wikiEditor Comment: Fixed in r90850. ___

[MediaWiki-CodeReview] [MediaWiki r90239]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User MarkAHershberger changed the status of MediaWiki.r90239. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90239#c0 Commit summary: Fix Bug #28344 - “Links doesn't work inside collapsible toggles” Patch from mybugs.mail If a link is added

[MediaWiki-CodeReview] [MediaWiki r90851]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r90851. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90851#c0 Commit summary: Followup r90239: Move return till after the toggle is executed. ___

[MediaWiki-CodeReview] [MediaWiki r90239]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r90239. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90239#c0 Commit summary: Fix Bug #28344 - “Links doesn't work inside collapsible toggles” Patch from mybugs.mail If a link is added inside of a

[MediaWiki-CodeReview] [MediaWiki r87483]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r87483. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/87483#c0 Commit summary: * Fix for bug 28534: IE 6 content type detection again * Fix for bug 28639: user object instance cache pollution

[MediaWiki-CodeReview] [MediaWiki r89812]: New comment added

2011-06-26 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r89812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c18769 Commit summary: MFT r89278, r89452. Also had to grab r83360. Comment: Looks like the first part of r89278 wasn't applied here, intentional ?

[MediaWiki-CodeReview] [MediaWiki r89812]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89812. Old Status: new New Status: fixme Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c0 Commit summary: MFT r89278, r89452. Also had to grab r83360. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89813]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89813. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89813#c0 Commit summary: Followup r89812, RELEASE-NOTES ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90586]: New comment added

2011-06-26 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r90586. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90586#c18770 Commit summary: * MFT r90585 (i know it's late ... ready for 1.17.1 :D) * *this* is why i need testing pplz on oracle Comment: The revision in trunk isn't reviewed

[MediaWiki-CodeReview] [MediaWiki r90852]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r90852. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90852#c0 Commit summary: Localisation updates for ToolserverI18N messages from translatewiki.net (2011-06-26 19:34:00)

[MediaWiki-CodeReview] [MediaWiki r90843]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r90843. Old Status: new New Status: ok User Krinkle also posted a comment on MediaWiki.r90843. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90843#c18771 Commit summary: Update calls to deprecated User::isValidEmailAddr Fix

[MediaWiki-CodeReview] [MediaWiki r86364]: New comment added

2011-06-26 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r86364. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86364#c18772 Commit summary: Move User::isValidEmailAddr() to Sanitizer. Comment: Reedy fixed the deprecated uses of it in trunk in r90843. See also

[MediaWiki-CodeReview] [MediaWiki r88551]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r88551. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88551#c0 Commit summary: * (bug 26240) CodeReview's (partially absence of) query params suck (tracking) Make filtering by author/status work for

[MediaWiki-CodeReview] [MediaWiki r90819]: New comment added

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r90819. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90819#c18774 Commit summary: Made '^' (XOR) in recCheckCondition() act as a one-hot detector. Before r28805, XOR silently ignored subconds beyond the first two. After r28805,

[MediaWiki-CodeReview] [MediaWiki r83909]: New comment added

2011-06-26 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r83909. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/83909#c18775 Commit summary: Complete the trinity of blocking frontend interfaces by rewriting SpecialIpblocklist: * Move and rename to SpecialBlockList * Use an HTMLForm in GET

[MediaWiki-CodeReview] [MediaWiki r84251]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Happy-melon changed the status of MediaWiki.r84251. Old Status: fixme New Status: new User Happy-melon also posted a comment on MediaWiki.r84251. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84251#c18776 Commit summary: First forays into the swamp of the Block.php

[MediaWiki-CodeReview] [MediaWiki r90857]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90857. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90857#c0 Commit summary: Follow-up r84251 - isAllowed( 'right', 'or-another-right' ) was reverted.

[MediaWiki-CodeReview] [MediaWiki r90815]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90815. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90815#c0 Commit summary: (sort of bug 29586) Make the (next 200) links on categories link directly to the relevant section of the category.

[MediaWiki-CodeReview] [MediaWiki r90814]: New comment added

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r90814. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90814#c18778 Commit summary: (bug 8556) When using $wgRawHtml, don't show scary session_failure/possible attack warning when you try to edit categories. Categories

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-06-26 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18779 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r90840]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90840. Old Status: new New Status: deferred Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90840#c0 Commit summary: Twesk description message for consistency Register extension to Translatewiki

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18781 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-06-26 Thread MediaWiki Mail
User Krinkle posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18783 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-06-26 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18782 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r84475]: New comment added

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r84475. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c18784 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise $mAddress/$mUser, $mBy/$mByName,

[MediaWiki-CodeReview] [MediaWiki r90841]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90841. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90841#c0 Commit summary: Fix class name conflict with core ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r90803]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90803. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90803#c0 Commit summary: add tooltip-invert tooltip-namespace_association introduced by 90766 ___

[MediaWiki-CodeReview] [MediaWiki r84475]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84475. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84475#c0 Commit summary: Blame hashar for this giant commit; he teased me for making so many smaller ones earlier... :D * Internalise

[MediaWiki-CodeReview] [MediaWiki r84588]: New comment added

2011-06-26 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r84588. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84588#c18787 Commit summary: Try to untangle the autoblock time logic, which made very little sense and led to very old indefinite blocks triggering autoblocks with ipb_expiry

[MediaWiki-CodeReview] [MediaWiki r90860]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90860. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90860#c0 Commit summary: Follow-up r84588 CR ___ MediaWiki-CodeReview mailing list

[MediaWiki-CodeReview] [MediaWiki r84588]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r84588. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/84588#c0 Commit summary: Try to untangle the autoblock time logic, which made very little sense and led to very old indefinite blocks

[MediaWiki-CodeReview] [MediaWiki r86234]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Happy-melon changed the status of MediaWiki.r86234. Old Status: fixme New Status: new Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86234#c0 Commit summary: Update Skin.php to not call the now-separate Linker methods via $this-foo().

[MediaWiki-CodeReview] [MediaWiki r85951]: New comment added

2011-06-26 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r85951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85951#c18788 Commit summary: Implement user-is-blocked and wiki-is-read-only as exceptions. Comment: ''All'' of User.php smells, the bits associated with blocking particularly

[MediaWiki-CodeReview] [MediaWiki r85951]: New comment added

2011-06-26 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r85951. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85951#c18789 Commit summary: Implement user-is-blocked and wiki-is-read-only as exceptions. Comment: One step closer to the global-less code nirvana tt;)/tt

[MediaWiki-CodeReview] [MediaWiki r85872]: New comment added

2011-06-26 Thread MediaWiki Mail
User Happy-melon posted a comment on MediaWiki.r85872. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85872#c18790 Commit summary: Clean up some direct $db-query($sql) calls. Remove limit/offset parameters from Article::getContributors() as they weren't being used anywhere and

[MediaWiki-CodeReview] [MediaWiki r35826]: New comment added

2011-06-26 Thread MediaWiki Mail
User Solitarius posted a comment on MediaWiki.r35826. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/35826#c18791 Commit summary: Revert r35769. The star-shaped bullet isn't really ideal; it doesn't display properly in some browsers (overlaps with square bullet), and isn't

[MediaWiki-CodeReview] [MediaWiki r85872]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r85872. Old Status: fixme New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85872#c0 Commit summary: Clean up some direct $db-query($sql) calls. Remove limit/offset parameters from Article::getContributors() as they

[MediaWiki-CodeReview] [MediaWiki r85872]: New comment added

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz posted a comment on MediaWiki.r85872. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/85872#c18792 Commit summary: Clean up some direct $db-query($sql) calls. Remove limit/offset parameters from Article::getContributors() as they weren't being used anywhere and

[MediaWiki-CodeReview] [MediaWiki r90814]: New comment added

2011-06-26 Thread MediaWiki Mail
User Bawolff posted a comment on MediaWiki.r90814. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90814#c18793 Commit summary: (bug 8556) When using $wgRawHtml, don't show scary session_failure/possible attack warning when you try to edit categories. Categories automatically go

[MediaWiki-CodeReview] [MediaWiki r90865]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90865. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90865#c0 Commit summary: Follow-up r86234, and more parameter documentation. ___

[MediaWiki-CodeReview] [MediaWiki r86234]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r86234. Old Status: new New Status: resolved Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/86234#c0 Commit summary: Update Skin.php to not call the now-separate Linker methods via $this-foo().

[MediaWiki-CodeReview] [MediaWiki r90861]: Revision status changed

2011-06-26 Thread MediaWiki Mail
User Aaron Schulz changed the status of MediaWiki.r90861. Old Status: new New Status: ok Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90861#c0 Commit summary: Comment shuffling, also fixing r86347 CR. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r89812]: New comment added

2011-06-26 Thread MediaWiki Mail
User ^demon posted a comment on MediaWiki.r89812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c18794 Commit summary: MFT r89278, r89452. Also had to grab r83360. Comment: Do you mean the changes to HttpTest? Not necessary since the phpunit tests were dropped from

[Wikitech-l] Bugzilla Weekly Report

2011-06-26 Thread reporter
MediaWiki Bugzilla Report for June 20, 2011 - June 27, 2011 Status changes this week Bugs NEW : 247 Bugs ASSIGNED : 10 Bugs REOPENED : 37 Bugs RESOLVED

[MediaWiki-CodeReview] [MediaWiki r89812]: New comment added, and revision status changed

2011-06-26 Thread MediaWiki Mail
User Krinkle changed the status of MediaWiki.r89812. Old Status: fixme New Status: ok User Krinkle also posted a comment on MediaWiki.r89812. Full URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/89812#c18795 Commit summary: MFT r89278, r89452. Also had to grab r83360. Comment: Ah,