[MediaWiki-CodeReview] [MediaWiki r108719]: New comment added

2012-01-13 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r108719. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108719#c29445 Commit summary for MediaWiki.r108719: I18n #410: some hacky code for adding help links Santhosh.thottingal's comment: Forgot to add help.png?

[MediaWiki-CodeReview] [MediaWiki r108719]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108719. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108719#c29446 Commit summary for MediaWiki.r108719: I18n #410: some hacky code for adding help links Nikerabbit's comment: Yes. ___

[MediaWiki-CodeReview] [MediaWiki r108793]: New comment added

2012-01-13 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r108793. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108793#c29448 Commit summary for MediaWiki.r108793: Add image ping r108719 Santhosh.thottingal's comment: That makes two image directories - one under the extension root and

[MediaWiki-CodeReview] [MediaWiki r88633]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r88633 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88633#c29449 Old Status: resolved New Status: fixme Commit summary for MediaWiki.r88633: * In core: ** Added hooks for custom RC/newpages filters ** Added

[MediaWiki-CodeReview] [MediaWiki r108794]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r108794 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108794 Old status: new New status: ok Commit summary for MediaWiki.r108794: Fix broken indentation ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r108793]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108793. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108793#c29450 Commit summary for MediaWiki.r108793: Add image ping r108719 Nikerabbit's comment: Yup. The other images could be moved here.

Re: [Wikitech-l] Breaking backwards compatibility (Re: MediaWiki 1.18 learnings from a wiki admin extension writer)

2012-01-13 Thread Petr Bena
I think we should reconsider how we deal with backward compatibility, I am one of people who believe that software should be kept backward compatible as long as it's technically not causing troubles. It isn't hard for dev to flag a variable or function as deprecated for some reason and completely

[MediaWiki-CodeReview] [MediaWiki r108798]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108798 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108798 Old status: new New status: ok Commit summary for MediaWiki.r108798: a little bit of space between the arrow and the text ___

[MediaWiki-CodeReview] [MediaWiki r108800]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108800 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108800#c29451 Old Status: new New Status: ok Commit summary for MediaWiki.r108800: r88633: lazy-load 'customFilters' field in SpecialRecentChanges. Almost every

[MediaWiki-CodeReview] [MediaWiki r88633]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r88633 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88633 Old status: fixme New status: resolved Commit summary for MediaWiki.r88633: * In core: ** Added hooks for custom RC/newpages filters ** Added tables,fields,and

[MediaWiki-CodeReview] [MediaWiki r108403]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108403. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108403#c29452 Commit summary for MediaWiki.r108403: Cleanup the convertPLural method for Lithuanian(lt) Add phpunit test cases. Nikerabbit's comment: Commit says cleanup, but to me it

[MediaWiki-CodeReview] [MediaWiki r108343]: New comment added

2012-01-13 Thread MediaWiki Mail
Hashar posted a comment on MediaWiki.r108343. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343#c29453 Commit summary for MediaWiki.r108343: [mw.config] wgAction shouldn't use direct URL values * Fixes bug 25800 * Depends on r108342 Hashar's comment: Where / how to reproduce

[MediaWiki-CodeReview] [MediaWiki r108343]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108343. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343#c29454 Commit summary for MediaWiki.r108343: [mw.config] wgAction shouldn't use direct URL values * Fixes bug 25800 * Depends on r108342 Nikerabbit's comment: Some API calls.

[MediaWiki-CodeReview] [MediaWiki r108343]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108343. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343#c29455 Commit summary for MediaWiki.r108343: [mw.config] wgAction shouldn't use direct URL values * Fixes bug 25800 * Depends on r108342 Nikerabbit's comment:

[MediaWiki-CodeReview] [MediaWiki r108805]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108805 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108805 Old status: new New status: ok Commit summary for MediaWiki.r108805: Add help link to the main page of Special:Translate too. Followup r108804.

[MediaWiki-CodeReview] [MediaWiki r108804]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108804 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108804#c29456 Old Status: new New Status: ok Commit summary for MediaWiki.r108804: Add help links for special pages of Translate. CSS cleanup. Nikerabbit's

[MediaWiki-CodeReview] [MediaWiki r108403]: New comment added

2012-01-13 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r108403. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108403#c29457 Commit summary for MediaWiki.r108403: Cleanup the convertPLural method for Lithuanian(lt) Add phpunit test cases. Santhosh.thottingal's comment: Suppose one and

[MediaWiki-CodeReview] [MediaWiki r108403]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108403. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108403#c29458 Commit summary for MediaWiki.r108403: Cleanup the convertPLural method for Lithuanian(lt) Add phpunit test cases. Nikerabbit's comment: How about

[MediaWiki-CodeReview] [MediaWiki r108803]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108803 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108803 Old status: new New status: ok Commit summary for MediaWiki.r108803: Fix name and URL in extension credits. Could someone with more knowledge about the resource loader

[MediaWiki-CodeReview] [MediaWiki r108802]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108802 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108802 Old status: new New status: ok Commit summary for MediaWiki.r108802: Ugh. Removed the wrong message. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r108801]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108801 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108801 Old status: new New status: ok Commit summary for MediaWiki.r108801: Handle type:city(population) ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r108799]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108799 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108799 Old status: new New status: ok Commit summary for MediaWiki.r108799: Actually fix the loop problem this time. ___

[MediaWiki-CodeReview] [MediaWiki r108797]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108797 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108797 Old status: new New status: ok Commit summary for MediaWiki.r108797: Fix a nasty infinite loop. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r108795]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108795 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108795 Old status: new New status: resolved Commit summary for MediaWiki.r108795: Remove unneeded extra section. ___

[MediaWiki-CodeReview] [MediaWiki r108791]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108791 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108791 Old status: new New status: ok Commit summary for MediaWiki.r108791: * Distinguish does not exist from failure in FSFileBackend::doGetFileStat(). * Added clearstatcache()

[MediaWiki-CodeReview] [MediaWiki r108790]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108790 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108790 Old status: new New status: ok Commit summary for MediaWiki.r108790: Follow-up to r108577 - fixed name of magic file ___

[MediaWiki-CodeReview] [MediaWiki r108403]: New comment added

2012-01-13 Thread MediaWiki Mail
Santhosh.thottingal posted a comment on MediaWiki.r108403. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108403#c29459 Commit summary for MediaWiki.r108403: Cleanup the convertPLural method for Lithuanian(lt) Add phpunit test cases. Santhosh.thottingal's comment: ok, you are

[MediaWiki-CodeReview] [MediaWiki r108403]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108403. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108403#c29460 Commit summary for MediaWiki.r108403: Cleanup the convertPLural method for Lithuanian(lt) Add phpunit test cases. Nikerabbit's comment: We should probably get in touch with

[MediaWiki-CodeReview] [MediaWiki r107776]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
IAlex changed the status of MediaWiki.r107776 to new and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107776#c29461 Old Status: fixme New Status: new Commit summary for MediaWiki.r107776: * Display all errors in showForm() instead of only the first one * First do

[MediaWiki-CodeReview] [MediaWiki r108376]: Revision status changed

2012-01-13 Thread MediaWiki Mail
IAlex changed the status of MediaWiki.r108376 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108376 Old status: ok New status: resolved Commit summary for MediaWiki.r108376: Fix double-escaping in 108312 ___

[Wikitech-l] Mailing lists server migration today

2012-01-13 Thread Mark Bergsma
Hi, Today I will be migrating the mailing lists from a very old server (lily) in Amsterdam, to a new server (sodium) in our new Ashburn data center. Mailman will be upgraded to version 2.1.13 along the way. During the migration, mail will be delayed as all data will need to be transferred to

[Wikitech-l] Want student help with your MediaWiki project?

2012-01-13 Thread Sumana Harihareswara
I've arranged for MediaWiki to get some interns this spring. Four bright college students -- they already know web development and have had internships at Facebook, Google, and Microsoft -- need a mentor. https://www.mediawiki.org/wiki/UCOSP_Spring_2012 It's a bit like Google Summer of Code,

[MediaWiki-CodeReview] [MediaWiki r100274]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Jeroen De Dauw changed the status of MediaWiki.r100274 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/100274 Old status: fixme New status: new Commit summary for MediaWiki.r100274: created basic reminder email functionality ___

[MediaWiki-CodeReview] [MediaWiki r108719]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r108719 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108719 Old status: new New status: ok Commit summary for MediaWiki.r108719: I18n #410: some hacky code for adding help links

[MediaWiki-CodeReview] [MediaWiki r108614]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Santhosh.thottingal changed the status of MediaWiki.r108614 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108614 Old status: new New status: ok Commit summary for MediaWiki.r108614: Fix Uncaught TypeError: Cannot read property 'ttf' of undefined

[MediaWiki-CodeReview] [MediaWiki r108806]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108806 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108806#c29462 Old Status: new New Status: ok Commit summary for MediaWiki.r108806: Per Aaron, fix for r107776: correct count() check Nikerabbit's comment: ===

[MediaWiki-CodeReview] [MediaWiki r108807]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108807 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108807 Old status: new New status: ok Commit summary for MediaWiki.r108807: Fix for r108376: the whole string is already espcaed on output, no need to escape it twice

[MediaWiki-CodeReview] [MediaWiki r108808]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108808 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108808 Old status: new New status: ok Commit summary for MediaWiki.r108808: svn:eol-style native ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r108343]: New comment added

2012-01-13 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r108343. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108343#c29463 Commit summary for MediaWiki.r108343: [mw.config] wgAction shouldn't use direct URL values * Fixes bug 25800 * Depends on r108342 Krinkle's comment: See r108342 CR for

[MediaWiki-CodeReview] [MediaWiki r108342]: New comment added

2012-01-13 Thread MediaWiki Mail
Krinkle posted a comment on MediaWiki.r108342. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108342#c29464 Commit summary for MediaWiki.r108342: Implement MediaWiki::getPerformedAction() * Fixes: -- Bug 27930 - Ablity to get current action (The Right Way) Krinkle's comment: In

[MediaWiki-CodeReview] [MediaWiki r90286]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Krinkle changed the status of MediaWiki.r90286 to resolved and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/90286#c29465 Old Status: ok New Status: resolved Commit summary for MediaWiki.r90286: Swap else if for elseif Trimming trailing whitespace also Krinkle's

[Wikitech-l] CANCELED: Mailing lists server migration today

2012-01-13 Thread Mark Bergsma
On Jan 13, 2012, at 2:54 PM, Mark Bergsma wrote: Hi, Today I will be migrating the mailing lists from a very old server (lily) in Amsterdam, to a new server (sodium) in our new Ashburn data center. Mailman will be upgraded to version 2.1.13 along the way. ...and right after I sent this

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-13 Thread Krinkle
On Thu, Jan 12, 2012 at 5:57 PM, Chad innocentkil...@gmail.com wrote: On Thu, Jan 12, 2012 at 11:51 AM, Daniel Barrett d...@vistaprint.com wrote: Me: 8. Our MediaWiki:common.js stopped running on the login page. I realize this was a security fix; it just took me by surprise. Fixed by

[MediaWiki-CodeReview] [MediaWiki r107975]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107975 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107975 Old status: new New status: resolved Commit summary for MediaWiki.r107975: MFT r105341, t105853, r106780 ___

[MediaWiki-CodeReview] [MediaWiki r108274]: New comment added

2012-01-13 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r108274. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29466 Commit summary for MediaWiki.r108274: * Added WikiPage to RequestContext and related so that it can be shared to avoid creating a new object each time and thus avoiding database

[MediaWiki-CodeReview] [MediaWiki r108274]: New comment added

2012-01-13 Thread MediaWiki Mail
IAlex posted a comment on MediaWiki.r108274. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29467 Commit summary for MediaWiki.r108274: * Added WikiPage to RequestContext and related so that it can be shared to avoid creating a new object each time and thus avoiding database

[MediaWiki-CodeReview] [MediaWiki r108778]: New comment added

2012-01-13 Thread MediaWiki Mail
Rsterbin posted a comment on MediaWiki.r108778. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108778#c29468 Commit summary for MediaWiki.r108778: Added spam and abuse filtering: * NB: AbuseFilter setup tested with a simple filter using action=feedback. * AbuseFilter consequences

Re: [Wikitech-l] MediaWiki 1.18 learnings from a wiki admin extension writer

2012-01-13 Thread Victor Vasiliev
On Thu, Jan 12, 2012 at 5:39 PM, Chad innocentkil...@gmail.com wrote: 2.      The removal of Xml::hidden() caused one of our extensions to break.   I switched to Xml::input(..., array('type', 'hidden')) Xml::hidden() was removed entirely? There *is* Html::hidden() which should be

[MediaWiki-CodeReview] [MediaWiki r108295]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108295 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108295 Old status: new New status: ok Commit summary for MediaWiki.r108295: Comments: allow removing anonymous users from your ignore list. User::idFromName() returns null for

Re: [Wikitech-l] Breaking backwards compatibility (Re: MediaWiki 1.18 learnings from a wiki admin extension writer)

2012-01-13 Thread Daniel Barrett
Rob, thanks for your comprehensive and thoughtful reply. ... bug 31676 (the 32-stylesheet limit of IE, https://bugzilla.wikimedia.org/show_bug.cgi?id=31676) which IMHO is a very serious time-bomb waiting to explode. I hope it makes it into 1.19wmf deployment as planned. Is this all versions

Re: [Wikitech-l] proposed tech conference anti-harassment policy

2012-01-13 Thread Peter Youngmeister
Hi! So, I am pro this policy. It's clean, neat, and easy to understand. However, in some ways, I feel that while a policy like this is a(n) (unfortunately) necessary tool to prevent discrimination and harassment at tech events, I do not think that it is sufficient. Let me explain. In my mind,

[MediaWiki-CodeReview] [MediaWiki r108811]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108811 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108811 Old status: new New status: ok Commit summary for MediaWiki.r108811: Add 'api-error-emptypage'. ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r108777]: New comment added

2012-01-13 Thread MediaWiki Mail
Reedy posted a comment on MediaWiki.r108777. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108777#c29469 Commit summary for MediaWiki.r108777: Maintenance class-ify eval.php Reedy's comment: Hmm. Whenever I used it, I just always did global $wgUser; etc first...

[MediaWiki-CodeReview] [MediaWiki r108812]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108812 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108812#c29470 Old Status: new New Status: ok Commit summary for MediaWiki.r108812: Do the , SpamBlacklist, and AbuseFilter checks only when those are set up

[MediaWiki-CodeReview] [MediaWiki r108813]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108813 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108813 Old status: new New status: ok Commit summary for MediaWiki.r108813: Localise a likely error. Ping r108811. ___

[MediaWiki-CodeReview] [MediaWiki r108819]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108819. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108819#c29471 Commit summary for MediaWiki.r108819: Fixed dim handling, made it fall back to scale and type Nikerabbit's comment: Are these dimensions translatable?

[MediaWiki-CodeReview] [MediaWiki r108819]: New comment added

2012-01-13 Thread MediaWiki Mail
MaxSem posted a comment on MediaWiki.r108819. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108819#c29472 Commit summary for MediaWiki.r108819: Fixed dim handling, made it fall back to scale and type MaxSem's comment: This parser function reuses stuff intended for geohack, and

[MediaWiki-CodeReview] [MediaWiki r108657]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108657 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108657 Old status: new New status: ok Commit summary for MediaWiki.r108657: 1.18wmf1: Update ArticleFeedback to trunk state ___

[MediaWiki-CodeReview] [MediaWiki r108666]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108666 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108666 Old status: new New status: ok Commit summary for MediaWiki.r108666: 1.18wmf1: Updating to trunk state to pick up r108665 ___

[MediaWiki-CodeReview] [MediaWiki r108671]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108671 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108671 Old status: new New status: ok Commit summary for MediaWiki.r108671: Revert r108603, which was itself a revert of r107376, r107994. Before considering something unneeded,

[MediaWiki-CodeReview] [MediaWiki r108694]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108694 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108694 Old status: new New status: resolved Commit summary for MediaWiki.r108694: Load the Recaptcha class in a way that has some chance of even working

[MediaWiki-CodeReview] [MediaWiki r101140]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r101140 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/101140 Old status: new New status: resolved Commit summary for MediaWiki.r101140: Instead of displaying ugly API errors to unprivileged users, tell them to ask permission

[MediaWiki-CodeReview] [MediaWiki r108606]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108606 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108606 Old status: new New status: ok Commit summary for MediaWiki.r108606: Revert r108562 - going to introduce new message in next commit

[MediaWiki-CodeReview] [MediaWiki r107305]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r107305 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107305 Old status: new New status: ok Commit summary for MediaWiki.r107305: Rework ext.translate.quickedit.js from global functions into mw.translate Numerous JS fixes, like

[MediaWiki-CodeReview] [MediaWiki r107380]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107380 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107380 Old status: new New status: ok Commit summary for MediaWiki.r107380: Revert r106546 based on IAlex's CR comments. I've already updated Bug #30047 to let the submitter

[MediaWiki-CodeReview] [MediaWiki r108600]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108600 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108600 Old status: new New status: ok Commit summary for MediaWiki.r108600: Add some top padding to avoid text with large font size not touching the toolbar. Also make sure enough

[MediaWiki-CodeReview] [MediaWiki r107402]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107402 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107402 Old status: new New status: ok Commit summary for MediaWiki.r107402: [mediawiki.js] code quality and clean up * using local mw variable in file instead of reaching to

[MediaWiki-CodeReview] [MediaWiki r108029]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108029 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108029 Old status: deferred New status: ok Commit summary for MediaWiki.r108029: Updated to new version ___ MediaWiki-CodeReview

[MediaWiki-CodeReview] [MediaWiki r107405]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107405 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107405 Old status: new New status: ok Commit summary for MediaWiki.r107405: [mediawiki.js] use simple IIFE closure with object literal * Remove weird new () syntax. Simply use a

[MediaWiki-CodeReview] [MediaWiki r88118]: New comment added

2012-01-13 Thread MediaWiki Mail
Fomafix posted a comment on MediaWiki.r88118. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/88118#c29473 Commit summary for MediaWiki.r88118: Fix Bug 28979 — “remove some CSS for abbr and acronym tags” The abbr and acronym tags were whitelisted with bug 671, but there are

[MediaWiki-CodeReview] [MediaWiki r107422]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107422 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107422#c29474 Old Status: new New Status: ok Commit summary for MediaWiki.r107422: Use implode rather than a poor foreach equivalent. Follow up to r107415.

[MediaWiki-CodeReview] [MediaWiki r108738]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108738 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108738 Old status: new New status: ok Commit summary for MediaWiki.r108738: * fixed some i18n errors. ___ MediaWiki-CodeReview mailing

[MediaWiki-CodeReview] [MediaWiki r108660]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108660 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108660 Old status: new New status: ok Commit summary for MediaWiki.r108660: Get rid of pipe symbol in translatable page group ids. They cause too many problems, like bug 33666

[MediaWiki-CodeReview] [MediaWiki r108215]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108215 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108215 Old status: new New status: ok Commit summary for MediaWiki.r108215: Prevent #firstHeading overriding the language specific h1 height. Ref Bug 30809

[MediaWiki-CodeReview] [MediaWiki r102669]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r102669 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102669 Old status: deferred New status: ok Commit summary for MediaWiki.r102669: Adding Dutch messages and removing translations for local user groups

[MediaWiki-CodeReview] [MediaWiki r108809]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108809 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108809#c29475 Old Status: new New Status: ok Commit summary for MediaWiki.r108809: follow up to r100274 - plural use in js messages Siebrand's comment: Yay!

[MediaWiki-CodeReview] [MediaWiki r108810]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Siebrand changed the status of MediaWiki.r108810 to ok and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108810#c29476 Old Status: new New Status: ok Commit summary for MediaWiki.r108810: plural in js messages Siebrand's comment: More yay!

[MediaWiki-CodeReview] [MediaWiki r78453]: New comment added

2012-01-13 Thread MediaWiki Mail
Siebrand posted a comment on MediaWiki.r78453. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/78453#c29477 Commit summary for MediaWiki.r78453: Using $ replacement in message - fixes hacky thing done in r78405. Siebrand's comment: This is now available. See r108809 for example.

[MediaWiki-CodeReview] [MediaWiki r107775]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107775 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107775#c29478 Old Status: new New Status: fixme Commit summary for MediaWiki.r107775: improving testability under windows os Nikerabbit's comment: Typo?

[MediaWiki-CodeReview] [MediaWiki r107007]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107007 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107007 Old status: new New status: ok Commit summary for MediaWiki.r107007: Don't check badlogin attempts in memcached if we are not configured to show captchas on bad login.

[MediaWiki-CodeReview] [MediaWiki r107097]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r107097 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107097 Old status: new New status: ok Commit summary for MediaWiki.r107097: Fix issue with deleting security groups. ___

[MediaWiki-CodeReview] [MediaWiki r95787]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r95787 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/95787 Old status: new New status: resolved Commit summary for MediaWiki.r95787: RL2: Add hooks that ensure the database is updated when Gadget definition: pages are deleted

[MediaWiki-CodeReview] [MediaWiki r96010]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r96010 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/96010 Old status: new New status: ok Commit summary for MediaWiki.r96010: RL2: Refactor GadgetPageList resulting in less code duplication in GadgetHooks * Factor getRowForTitle()

[MediaWiki-CodeReview] [MediaWiki r97052]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r97052 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97052 Old status: new New status: ok Commit summary for MediaWiki.r97052: RL2: Followup to r96954 and r97005: add i18n messages for the validation stuff. The messages aren't very

[MediaWiki-CodeReview] [MediaWiki r97055]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r97055 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/97055 Old status: new New status: ok Commit summary for MediaWiki.r97055: RL2: Per CR on r96863, moved getCategoryTitle() to LocalGadgetRepo. Also turned it from a static method

[MediaWiki-CodeReview] [MediaWiki r98878]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r98878 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/98878 Old status: new New status: ok Commit summary for MediaWiki.r98878: [RL2] Followup r96837, prevent requests for nonexistent modules from polluting the gadget names cache by

[MediaWiki-CodeReview] [MediaWiki r108184]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108184. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108184#c29479 Commit summary for MediaWiki.r108184: ResourceLoader: Add an experimental option to move the main module loading queue (the bottom queue) from the bottom of the body up into

[MediaWiki-CodeReview] [MediaWiki r108812]: New comment added

2012-01-13 Thread MediaWiki Mail
Rsterbin posted a comment on MediaWiki.r108812. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108812#c29480 Commit summary for MediaWiki.r108812: Do the , SpamBlacklist, and AbuseFilter checks only when those are set up (followup to r108778) Rsterbin's comment: Yeah, that was

[MediaWiki-CodeReview] [MediaWiki r108184]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108184 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108184 Old status: new New status: resolved Commit summary for MediaWiki.r108184: ResourceLoader: Add an experimental option to move the main module loading queue (the

Re: [Wikitech-l] postgreSQL testing

2012-01-13 Thread Dan Nessett
On Thu, 12 Jan 2012 16:17:00 +0100, Antoine Musso wrote: Hello, I have added a new continuous integration job to check our postgres support. This is exactly the same job as MediaWiki-phpunit, only the database backend change. The link is:

[MediaWiki-CodeReview] [MediaWiki r107776]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107776 to resolved URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107776 Old status: new New status: resolved Commit summary for MediaWiki.r107776: * Display all errors in showForm() instead of only the first one * First do some checks

[MediaWiki-CodeReview] [MediaWiki r108274]: New comment added

2012-01-13 Thread MediaWiki Mail
Aaron Schulz posted a comment on MediaWiki.r108274. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108274#c29481 Commit summary for MediaWiki.r108274: * Added WikiPage to RequestContext and related so that it can be shared to avoid creating a new object each time and thus avoiding

[MediaWiki-CodeReview] [MediaWiki r107792]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Aaron Schulz changed the status of MediaWiki.r107792 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/107792 Old status: new New status: ok Commit summary for MediaWiki.r107792: MFT r107359: fix Adobe Illustrator SVGs presumably broken by a PHP upgrade

[MediaWiki-CodeReview] [MediaWiki r108827]: Revision status changed

2012-01-13 Thread MediaWiki Mail
GWicke changed the status of MediaWiki.r108827 to deferred URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108827 Old status: new New status: deferred Commit summary for MediaWiki.r108827: Template expansion now enabled and somewhat working, but template fetching still fails all the

[MediaWiki-CodeReview] [MediaWiki r108828]: Revision status changed

2012-01-13 Thread MediaWiki Mail
MaxSem changed the status of MediaWiki.r108828 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108828 Old status: new New status: ok Commit summary for MediaWiki.r108828: Remove punctuation from description message. ___

[MediaWiki-CodeReview] [MediaWiki r102575]: Revision status changed

2012-01-13 Thread MediaWiki Mail
MarkAHershberger changed the status of MediaWiki.r102575 to new URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/102575 Old status: fixme New status: new Commit summary for MediaWiki.r102575: Commit to fix bug 30513. ___

[MediaWiki-CodeReview] [MediaWiki r108822]: New comment added, and revision status changed

2012-01-13 Thread MediaWiki Mail
Nikerabbit changed the status of MediaWiki.r108822 to fixme and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108822#c29482 Old Status: new New Status: fixme Commit summary for MediaWiki.r108822: Return message instead of key. Nikerabbit's comment: Was this

[MediaWiki-CodeReview] [MediaWiki r108789]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Pgehres (WMF) changed the status of MediaWiki.r108789 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108789 Old status: new New status: ok Commit summary for MediaWiki.r108789: adding embargoed countries back ___

[MediaWiki-CodeReview] [MediaWiki r108783]: Revision status changed

2012-01-13 Thread MediaWiki Mail
Khorn (WMF) changed the status of MediaWiki.r108783 to ok URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108783 Old status: new New status: ok Commit summary for MediaWiki.r108783: tweak enets forms to be closer to others ___

[MediaWiki-CodeReview] [MediaWiki r108825]: New comment added

2012-01-13 Thread MediaWiki Mail
Nikerabbit posted a comment on MediaWiki.r108825. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/108825#c29483 Commit summary for MediaWiki.r108825: in preparation of concurrencyCheck extension, add concurrency check call to feedback dashboard response items, added method to load

  1   2   3   4   >