[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111350. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31192 Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item Wikinaut's comment: The usag

[Wikitech-l] 1.19 post-deployment bugs

2012-02-17 Thread Mark A. Hershberger
With this rollout, we've been watching the Village Pumps on various projects and trying to work with people who are active on the projects and, in the process, we've come up with some bugs that we'd like to get fixed before we deploy to Commons on Tuesday (see https://www.mediawiki.org/wiki/MediaW

[MediaWiki-CodeReview] [MediaWiki r106809]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r106809 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106809 Old status: fixme New status: new Commit summary for MediaWiki.r106809: Followup r106808 *(bug 28747) AntiSpoof should also check global accounts from CentralAuth TODO: Ne

[MediaWiki-CodeReview] [MediaWiki r111800]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Reedy" changed the status of MediaWiki.r111800 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111800 Old status: ok New status: fixme Commit summary for MediaWiki.r111800: Add both size *and* size difference on history page per bug 34449 _

[MediaWiki-CodeReview] [MediaWiki r111800]: New comment added

2012-02-17 Thread MediaWiki Mail
"PleaseStand" posted a comment on MediaWiki.r111800. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111800#c31191 Commit summary for MediaWiki.r111800: Add both size *and* size difference on history page per bug 34449 PleaseStand's comment: There is a single quote that should not be

[MediaWiki-CodeReview] [MediaWiki r106809]: New comment added

2012-02-17 Thread MediaWiki Mail
"RobLa-WMF" posted a comment on MediaWiki.r106809. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106809#c31190 Commit summary for MediaWiki.r106809: Followup r106808 *(bug 28747) AntiSpoof should also check global accounts from CentralAuth TODO: Need to do something with batchAntiSp

[MediaWiki-CodeReview] [MediaWiki r106809]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"RobLa-WMF" changed the status of MediaWiki.r106809 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/106809#c31189 Old Status: ok New Status: fixme Commit summary for MediaWiki.r106809: Followup r106808 *(bug 28747) AntiSpoof should also check global accoun

[MediaWiki-CodeReview] [Wikimedia r1266]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1266 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1266 Old status: new New status: deferred Commit summary for Wikimedia.r1266: Added select() to Db_Adapter_Abstract. ___ Media

[MediaWiki-CodeReview] [Wikimedia r1327]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1327 to "deferred" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1327 Old status: new New status: deferred Commit summary for Wikimedia.r1327: Added helper for testing: addOnUrlParametersForTesting() ___

[MediaWiki-CodeReview] [Wikimedia r1272]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1272 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1272 Old status: new New status: ok Commit summary for Wikimedia.r1272: civicrm_recurring_globalcollect updated to communicate with Global Collect.

[MediaWiki-CodeReview] [Wikimedia r1349]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1349 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1349 Old status: new New status: fixme Commit summary for Wikimedia.r1349: Added ability to send emails and log contributions. See r1212. ___

[MediaWiki-CodeReview] [Wikimedia r1349]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1349. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1349#c31188 Commit summary for Wikimedia.r1349: Added ability to send emails and log contributions. See r1212. Khorn (WMF)'s comment: Also: That's a pretty huge try block you've got ther

[MediaWiki-CodeReview] [Wikimedia r1349]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1349. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1349#c31187 Commit summary for Wikimedia.r1349: Added ability to send emails and log contributions. See r1212. Khorn (WMF)'s comment: There's a pretty good change this could explode fair

[MediaWiki-CodeReview] [Wikimedia r1348]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1348 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1348 Old status: new New status: ok Commit summary for Wikimedia.r1348: Removed debugging dump. See r1212. ___ MediaWiki-CodeReview

[Wikitech-l] Git + Gerrit is a toughy

2012-02-17 Thread Andrew Otto
Hi all! And here's another hi: Hi! This is my first post to this list, so here is a quick intro in case you missed the other ones. I'm Andrew Otto, an engineering on the new Analytics team. I'm working with David Schoonover (new hire as well), Fabian Kaelin, and Diederik van Liere. Right no

[MediaWiki-CodeReview] [Wikimedia r1335]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1335 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1335#c31186 Old Status: new New Status: ok Commit summary for Wikimedia.r1335: Added two parameters: date and process to control payments. Khorn (WMF)'s commen

[MediaWiki-CodeReview] [MediaWiki r111788]: New comment added

2012-02-17 Thread MediaWiki Mail
"MZMcBride" posted a comment on MediaWiki.r111788. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111788#c31185 Commit summary for MediaWiki.r111788: Followup r111777, fixed mixed indentation caused by copy/paste fail MZMcBride's comment: [[Manual:Coding conventions/PHP#Ternary opera

[MediaWiki-CodeReview] [Wikimedia r1345]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1345 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1345 Old status: new New status: ok Commit summary for Wikimedia.r1345: Added thank_you_civicrm_recurring_globalcollect(). See r1212. __

[MediaWiki-CodeReview] [Wikimedia r1339]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1339 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1339 Old status: new New status: ok Commit summary for Wikimedia.r1339: Only allowing monthly intervals to be processed at this time. See r1338. ___

[MediaWiki-CodeReview] [Wikimedia r1338]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1338. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1338#c31184 Commit summary for Wikimedia.r1338: Added _civicrm_recurring_globalcollect_get_payment_by_id(), _civicrm_recurring_globalcollect_get_next_sched_contribution_date(). Updated d

[MediaWiki-CodeReview] [Wikimedia r1338]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1338 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1338 Old status: new New status: fixme Commit summary for Wikimedia.r1338: Added _civicrm_recurring_globalcollect_get_payment_by_id(), _civicrm_recurring_globalcollect_get_n

[MediaWiki-CodeReview] [Wikimedia r1338]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1338. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1338#c31183 Commit summary for Wikimedia.r1338: Added _civicrm_recurring_globalcollect_get_payment_by_id(), _civicrm_recurring_globalcollect_get_next_sched_contribution_date(). Updated d

[MediaWiki-CodeReview] [Wikimedia r1338]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1338. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1338#c31182 Commit summary for Wikimedia.r1338: Added _civicrm_recurring_globalcollect_get_payment_by_id(), _civicrm_recurring_globalcollect_get_next_sched_contribution_date(). Updated d

[MediaWiki-CodeReview] [Wikimedia r1338]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1338. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1338#c31181 Commit summary for Wikimedia.r1338: Added _civicrm_recurring_globalcollect_get_payment_by_id(), _civicrm_recurring_globalcollect_get_next_sched_contribution_date(). Updated d

[MediaWiki-CodeReview] [Wikimedia r1337]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1337 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1337 Old status: new New status: ok Commit summary for Wikimedia.r1337: Added a retry field for how long to wait between failures. _

[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1336. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31180 Commit summary for Wikimedia.r1336: Added two methods to query the database for payments: _civicrm_recurring_globalcollect_get_next_sched_contribution() and _civicrm_recurrin

[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added

2012-02-17 Thread MediaWiki Mail
"Johnduhart" posted a comment on MediaWiki.r111350. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31179 Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item Johnduhart's comment: The

[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1336. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31178 Commit summary for Wikimedia.r1336: Added two methods to query the database for payments: _civicrm_recurring_globalcollect_get_next_sched_contribution() and _civicrm_recurrin

[MediaWiki-CodeReview] [Wikimedia r1336]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1336 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1336#c31177 Old Status: new New Status: fixme Commit summary for Wikimedia.r1336: Added two methods to query the database for payments: _civicrm_recurring_g

[MediaWiki-CodeReview] [MediaWiki r111803]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r111803 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111803 Old status: new New status: ok Commit summary for MediaWiki.r111803: follow-up to r111802, we dont need internal document.ready trigger since the entire js file is in

[MediaWiki-CodeReview] [MediaWiki r111802]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r111802 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111802 Old status: new New status: resolved Commit summary for MediaWiki.r111802: fix for bug 34466 - making sure mediawiki module isnt executed before the DOM is read

[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111350. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31176 Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item Wikinaut's comment: Source /

[MediaWiki-CodeReview] [MediaWiki r111588]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31175 Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an intran

[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added

2012-02-17 Thread MediaWiki Mail
"Awjrichards" posted a comment on MediaWiki.r111350. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31174 Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item Awjrichards's comment: Ah

[MediaWiki-CodeReview] [MediaWiki r111588]: New comment added

2012-02-17 Thread MediaWiki Mail
"Aaron Schulz" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31173 Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an in

[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111350. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31172 Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item Wikinaut's comment: [CORR] u

[MediaWiki-CodeReview] [MediaWiki r111788]: New comment added

2012-02-17 Thread MediaWiki Mail
"Preilly" posted a comment on MediaWiki.r111788. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111788#c31171 Commit summary for MediaWiki.r111788: Followup r111777, fixed mixed indentation caused by copy/paste fail Preilly's comment: Hmm, I guess it's a style thing if(){} else{} j

[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111350. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31170 Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters when rendering the channel item Wikinaut's comment: GlobalFu

[MediaWiki-CodeReview] [MediaWiki r111805]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Trevor Parscal" changed the status of MediaWiki.r111805 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111805 Old status: ok New status: resolved Commit summary for MediaWiki.r111805: MFT r111804 ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r111807]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Trevor Parscal" changed the status of MediaWiki.r111807 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111807 Old status: new New status: ok Commit summary for MediaWiki.r111807: MFT r111805 ___ MediaWiki-CodeReview mailing list m

[MediaWiki-CodeReview] [MediaWiki r111805]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Trevor Parscal" changed the status of MediaWiki.r111805 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111805 Old status: new New status: ok Commit summary for MediaWiki.r111805: MFT r111804 ___ MediaWiki-CodeReview mailing list m

[MediaWiki-CodeReview] [MediaWiki r111788]: New comment added

2012-02-17 Thread MediaWiki Mail
"Preilly" posted a comment on MediaWiki.r111788. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111788#c31169 Commit summary for MediaWiki.r111788: Followup r111777, fixed mixed indentation caused by copy/paste fail Preilly's comment: Also, are we supposed to use $_SERVER directly? O

[MediaWiki-CodeReview] [MediaWiki r111806]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Trevor Parscal" changed the status of MediaWiki.r111806 to "ok" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111806#c31168 Old Status: new New Status: ok Commit summary for MediaWiki.r111806: Follow-up r111804: Accidentally hides the non-collapsed stuff Trevor P

[MediaWiki-CodeReview] [MediaWiki r111804]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Trevor Parscal" changed the status of MediaWiki.r111804 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111804 Old status: fixme New status: resolved Commit summary for MediaWiki.r111804: Fix weird bug where CSS was not loaded yet, and it was assumed that it would. Rel

[MediaWiki-CodeReview] [MediaWiki r111788]: New comment added

2012-02-17 Thread MediaWiki Mail
"Awjrichards" posted a comment on MediaWiki.r111788. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111788#c31167 Commit summary for MediaWiki.r111788: Followup r111777, fixed mixed indentation caused by copy/paste fail Awjrichards's comment: I typically don't really like the ternary

[MediaWiki-CodeReview] [MediaWiki r111588]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Wikinaut" changed the status of MediaWiki.r111588 to "new" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588 Old status: fixme New status: new Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with no

[MediaWiki-CodeReview] [MediaWiki r111588]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31166 Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an intran

[MediaWiki-CodeReview] [MediaWiki r111588]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31165 Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an intran

[MediaWiki-CodeReview] [MediaWiki r111788]: New comment added

2012-02-17 Thread MediaWiki Mail
"Preilly" posted a comment on MediaWiki.r111788. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111788#c31164 Commit summary for MediaWiki.r111788: Followup r111777, fixed mixed indentation caused by copy/paste fail Preilly's comment: Just curious why not use a ternary operator? ___

[MediaWiki-CodeReview] [MediaWiki r111804]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Trevor Parscal" changed the status of MediaWiki.r111804 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111804#c31163 Old Status: new New Status: fixme Commit summary for MediaWiki.r111804: Fix weird bug where CSS was not loaded yet, and it was assumed th

[MediaWiki-CodeReview] [MediaWiki r111588]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31162 Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an intran

[MediaWiki-CodeReview] [MediaWiki r111777]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Preilly" changed the status of MediaWiki.r111777 to "resolved" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111777 Old status: new New status: resolved Commit summary for MediaWiki.r111777: Removed usage of wfGetIP() and now just fetching IP from [REMOTE_ADDR], followup r111689,

[MediaWiki-CodeReview] [MediaWiki r111588]: New comment added

2012-02-17 Thread MediaWiki Mail
"Wikinaut" posted a comment on MediaWiki.r111588. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111588#c31161 Commit summary for MediaWiki.r111588: important fix inside HttpFunctions.php. I noticed that when you call HttpRequest::factory with noProxy=true for example inside an intran

[MediaWiki-CodeReview] [MediaWiki r111769]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Preilly" changed the status of MediaWiki.r111769 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111769 Old status: new New status: ok Commit summary for MediaWiki.r111769: add tests for beta_opensearch.js these tests mostly cover highlighting of keywords in search results o

[MediaWiki-CodeReview] [Wikimedia r1334]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1334 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1334#c31160 Old Status: new New Status: fixme Commit summary for Wikimedia.r1334: Fixes #1246 - Added date and process parameters. Added validation method.

[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Wikinaut" changed the status of MediaWiki.r111350 to "new" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31159 Old Status: fixme New Status: new Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of characters w

[MediaWiki-CodeReview] [MediaWiki r111796]: New comment added

2012-02-17 Thread MediaWiki Mail
"Bsitu" posted a comment on MediaWiki.r111796. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111796#c31158 Commit summary for MediaWiki.r111796: fix for bug34431 - Disable the old toolbar if the new toolbar is enabled Bsitu's comment: Both toolbars are loaded via js, users would see

[MediaWiki-CodeReview] [MediaWiki r111797]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Aaron Schulz" changed the status of MediaWiki.r111797 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111797 Old status: new New status: ok Commit summary for MediaWiki.r111797: Use local context to get messages ___ MediaWiki-CodeR

[MediaWiki-CodeReview] [Wikimedia r1346]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1346 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1346#c31157 Old Status: new New Status: fixme Commit summary for Wikimedia.r1346: Added $effort_id as a parameter to _queue2civicrm_contribution_insert(). Se

[MediaWiki-CodeReview] [Wikimedia r1347]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1347 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1347 Old status: new New status: ok Commit summary for Wikimedia.r1347: Added dependencies. See r1212. ___ MediaWiki-CodeReview mail

[MediaWiki-CodeReview] [MediaWiki r111439]: New comment added

2012-02-17 Thread MediaWiki Mail
"Dantman" posted a comment on MediaWiki.r111439. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111439#c31156 Commit summary for MediaWiki.r111439: Introduce property: and itemprop: support for addMeta to add RDFa and Microdata to the . This is done in a way that can also be feature

[MediaWiki-CodeReview] [MediaWiki r111796]: New comment added

2012-02-17 Thread MediaWiki Mail
"Aaron Schulz" posted a comment on MediaWiki.r111796. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111796#c31155 Commit summary for MediaWiki.r111796: fix for bug34431 - Disable the old toolbar if the new toolbar is enabled Aaron Schulz's comment: If the new toolbar is loaded via J

[MediaWiki-CodeReview] [Wikimedia r1329]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1329 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1329#c31154 Old Status: new New Status: fixme Commit summary for Wikimedia.r1329: Putting in a hard coded fix for issue with selecting only one payment gatew

[MediaWiki-CodeReview] [Wikimedia r1287]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1287 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1287 Old status: new New status: fixme Commit summary for Wikimedia.r1287: Removed tabs from code. Fixed issues with civicrm_recurring_globalcollect_build_url(). Added local

[MediaWiki-CodeReview] [Wikimedia r1287]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1287. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1287#c31153 Commit summary for Wikimedia.r1287: Removed tabs from code. Fixed issues with civicrm_recurring_globalcollect_build_url(). Added localhost_test_url to settings. Khorn (WMF)'

[MediaWiki-CodeReview] [MediaWiki r111219]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111219 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111219 Old status: new New status: ok Commit summary for MediaWiki.r111219: Armour page titles in MD5 when putting information about AbuseFilter warnings in the session. Reso

[MediaWiki-CodeReview] [MediaWiki r111351]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111351 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111351 Old status: new New status: ok Commit summary for MediaWiki.r111351: follow-up r111350 . check if optional parameter isset and is_numeric, otherwise limit to the buil

[MediaWiki-CodeReview] [Wikimedia r1278]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1278 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1278 Old status: new New status: fixme Commit summary for Wikimedia.r1278: Code clean up. Disabling debugging and adding more logging for civicrm_recurring_globalcollect mod

[MediaWiki-CodeReview] [MediaWiki r111350]: New comment added, and revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111350 to "fixme" and commented it. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111350#c31152 Old Status: new New Status: fixme Commit summary for MediaWiki.r111350: fix for bug30377 : add a new parameter to limit the number of charac

[MediaWiki-CodeReview] [Wikimedia r1278]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1278. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1278#c31151 Commit summary for Wikimedia.r1278: Code clean up. Disabling debugging and adding more logging for civicrm_recurring_globalcollect module. Khorn (WMF)'s comment: WATCHDOG_EM

[MediaWiki-CodeReview] [pywikipedia r9905]: New comment added

2012-02-17 Thread MediaWiki Mail
"DrTrigon" posted a comment on pywikipedia.r9905. URL: http://www.mediawiki.org/wiki/Special:Code/pywikipedia/9905#c31150 Commit summary for pywikipedia.r9905: debugging '-debug' enabled for clean_sandbox DrTrigon's comment: I found nothing related to block, write or debug in 'config.py' (hope

[MediaWiki-CodeReview] [MediaWiki r111493]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111493 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111493 Old status: new New status: ok Commit summary for MediaWiki.r111493: r111471/r111472: Update ignore messages ___ MediaWiki-

[MediaWiki-CodeReview] [Wikimedia r1247]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" changed the status of Wikimedia.r1247 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1247 Old status: new New status: ok Commit summary for Wikimedia.r1247: Updating drush to take url as a parameter. Added setting fro Global Collect merchant ID. See r1212. __

[MediaWiki-CodeReview] [MediaWiki r111801]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111801 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111801 Old status: new New status: ok Commit summary for MediaWiki.r111801: MFT r111800 ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r111800]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111800 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111800 Old status: new New status: ok Commit summary for MediaWiki.r111800: Add both size *and* size difference on history page per bug 34449

[MediaWiki-CodeReview] [MediaWiki r111799]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111799 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111799 Old status: new New status: ok Commit summary for MediaWiki.r111799: MFT r111798 ___ MediaWiki-CodeReview mailing list medi

[MediaWiki-CodeReview] [MediaWiki r111798]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111798 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111798 Old status: new New status: ok Commit summary for MediaWiki.r111798: Revert r97042, causes bug 34432 ___ MediaWiki-CodeRevi

[MediaWiki-CodeReview] [MediaWiki r111354]: New comment added

2012-02-17 Thread MediaWiki Mail
"Awjrichards" posted a comment on MediaWiki.r111354. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111354#c31149 Commit summary for MediaWiki.r111354: getSkin is deprecated Awjrichards's comment: Rather than repeat: $linker = class_exists( 'DummyLinker' ) ? new DummyLinker : new

[MediaWiki-CodeReview] [MediaWiki r111359]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111359 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111359 Old status: new New status: ok Commit summary for MediaWiki.r111359: Remove code duplication ___ MediaWiki-CodeReview maili

[MediaWiki-CodeReview] [MediaWiki r111363]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111363 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111363 Old status: new New status: ok Commit summary for MediaWiki.r111363: Simpler this way, no BC code needed ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r111395]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111395 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111395 Old status: new New status: ok Commit summary for MediaWiki.r111395: Ping r111362 - remove rest of unneeded code ___ MediaW

[MediaWiki-CodeReview] [MediaWiki r111472]: New comment added

2012-02-17 Thread MediaWiki Mail
"Bsitu" posted a comment on MediaWiki.r111472. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111472#c31148 Commit summary for MediaWiki.r111472: bug 34090 - Added an additional column in the main feedback table to keep a count of the number of activities which have happened for each

[MediaWiki-CodeReview] [MediaWiki r111404]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111404 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111404 Old status: new New status: ok Commit summary for MediaWiki.r111404: Render real and tags insteaf of s ___ MediaWiki-Code

[MediaWiki-CodeReview] [MediaWiki r111428]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111428 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111428 Old status: new New status: ok Commit summary for MediaWiki.r111428: Fix ACW to work with new hook signature introduced in r111427

[MediaWiki-CodeReview] [MediaWiki r111427]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111427 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111427 Old status: new New status: ok Commit summary for MediaWiki.r111427: Port (with changes) r110866 to trunk. Reviewed by Brion before commit. ___

[MediaWiki-CodeReview] [MediaWiki r111435]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Raindrift" changed the status of MediaWiki.r111435 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111435 Old status: new New status: ok Commit summary for MediaWiki.r111435: Doc for r111434 ___ MediaWiki-CodeReview mailing list me

[MediaWiki-CodeReview] [MediaWiki r111465]: New comment added

2012-02-17 Thread MediaWiki Mail
"Awjrichards" posted a comment on MediaWiki.r111465. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111465#c31147 Commit summary for MediaWiki.r111465: Reduce global (ab)use Various code updates Trim trailing whitespace Awjrichards's comment: function trySubmit() { 72

[MediaWiki-CodeReview] [Wikimedia r1212]: New comment added

2012-02-17 Thread MediaWiki Mail
"Khorn (WMF)" posted a comment on Wikimedia.r1212. URL: http://www.mediawiki.org/wiki/Special:Code/Wikimedia/1212#c31146 Commit summary for Wikimedia.r1212: Adding module for Global Collect recurring payments. Khorn (WMF)'s comment: This is partially a style consideration, but I feel it's worth

[MediaWiki-CodeReview] [MediaWiki r111475]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111475 to "fixme" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111475 Old status: new New status: fixme Commit summary for MediaWiki.r111475: Updating english messages to use PLURAL for LastModified extension. See r99522.

[MediaWiki-CodeReview] [MediaWiki r111564]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Bsitu" changed the status of MediaWiki.r111564 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111564 Old status: new New status: ok Commit summary for MediaWiki.r111564: r111560: Update ignore messages ___ MediaWiki-CodeReview mai

[MediaWiki-CodeReview] [MediaWiki r111481]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111481 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111481 Old status: new New status: ok Commit summary for MediaWiki.r111481: display message language name in the users language, not the language of the message. correcting c

[MediaWiki-CodeReview] [MediaWiki r111515]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111515 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111515 Old status: new New status: ok Commit summary for MediaWiki.r111515: removed a wrong comment regarding PHP 5.3 function date_create_from_format, which is not suited to

[MediaWiki-CodeReview] [MediaWiki r111523]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111523 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111523 Old status: new New status: ok Commit summary for MediaWiki.r111523: Add resize: vertical; to the textarea's css so that browsers like firefox and chrome won't allow h

[MediaWiki-CodeReview] [MediaWiki r111536]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111536 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111536 Old status: new New status: ok Commit summary for MediaWiki.r111536: updated the link to tool, per b30863, used the attached fix by M. Movchin

[MediaWiki-CodeReview] [MediaWiki r111693]: New comment added

2012-02-17 Thread MediaWiki Mail
"Bsitu" posted a comment on MediaWiki.r111693. URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111693#c31145 Commit summary for MediaWiki.r111693: followup to -r111692 - wrap long line Bsitu's comment: I want to keep function arguments as aligned as possible so it's easier to read __

[MediaWiki-CodeReview] [MediaWiki r111555]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111555 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111555 Old status: new New status: ok Commit summary for MediaWiki.r111555: Updating change log ___ MediaWiki-CodeReview mailing l

[MediaWiki-CodeReview] [MediaWiki r111693]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Raindrift" changed the status of MediaWiki.r111693 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111693 Old status: deferred New status: ok Commit summary for MediaWiki.r111693: followup to -r111692 - wrap long line ___ MediaWiki

[MediaWiki-CodeReview] [MediaWiki r111598]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111598 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111598 Old status: new New status: ok Commit summary for MediaWiki.r111598: turning off native spellcheck for now ___ MediaWiki-Co

[MediaWiki-CodeReview] [MediaWiki r111692]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Raindrift" changed the status of MediaWiki.r111692 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111692 Old status: deferred New status: ok Commit summary for MediaWiki.r111692: Standardizing clickTracking event name for article creation workflow by introducing acwbucket &

[MediaWiki-CodeReview] [MediaWiki r111640]: Revision status changed

2012-02-17 Thread MediaWiki Mail
"Awjrichards" changed the status of MediaWiki.r111640 to "ok" URL: http://www.mediawiki.org/wiki/Special:Code/MediaWiki/111640 Old status: new New status: ok Commit summary for MediaWiki.r111640: Made 'register' functions static (required by BackupDumper) __

  1   2   3   4   >